Daniel Hilst
2b150830c9
genimage stops with "Failed to find usr/bin/dig in /install/netboot/ubuntu24.04.4/ppc64el/compute/rootimg" and returns 2, so packimage writes no initrd.gz and nodeset reports "Did you run genimage before running packimg?". The diskless compute node never boots. xCAT-server/share/xcat/netboot/ubuntu ships a package list for ppc64el on 20.04 and on 26.04 only. imgutils::get_profile_def_filename finds no ppc64el list for 22.04 or 24.04 and falls back to compute.pkglist, which installs no dig. mkinitrd copies usr/bin/dig into the initrd and find_rootimg_file calls xdie when the file is absent. The test reads the four ppc64el package lists the pipeline provisions and asserts each one installs dig, a kernel and nfs-common. It fails on 22.04 and 24.04 and passes on 20.04 and 26.04. Evidence: reg_linux_diskless_installation_flat on ubuntu-24-ppc64le-devel in xcat-core-devel-ubuntu-cd build 120, xcattest.log.20260911175800 on xcat25-mn. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test/unit
Unit tests. These run against the source tree only -- no xCAT installation, no running daemons, no management node.
They are executed on every pull request by the xcat_test GitHub Actions workflow,
which calls run_unit_tests() in github_action_xcat_test.pl:
prove -r xCAT-test/unit
You can run exactly the same thing from a clean checkout:
cd <xcat-core checkout>
prove -r xCAT-test/unit
What belongs here
A test belongs in unit/ when everything it needs is in the checkout: plugin and
library sources, kickstart/preseed/subiquity templates, postscripts, packaging
metadata. Such a test asserts on rendered output or module logic and reaches the
repository root through FindBin:
use FindBin;
use lib "$FindBin::Bin/../../perl-xCAT";
use lib "$FindBin::Bin/../../xCAT-server/lib/perl";
Because of those FindBin paths the tests only work from a source tree. The copy
installed under /opt/xcat/share/xcat/tools/autotest/unit is not a substitute --
../.. resolves to /opt/xcat/share/xcat/tools there and the tests die or silently
skip. The CI takes a copy of the checkout before the build for this reason; see
preserve_source_tree().
What does not belong here
Anything that needs an installed xCAT, a populated /install, a real service binary
or a live daemon. Those go in ../integration and run on
a management node through xcattest. Both suites run on every pull request -- the
workflow installs xCAT on the runner and then runs the ci_test cases against it --
so putting a test in integration/ does not cost it CI coverage. What differs is what
each suite is allowed to depend on, and that unit tests also run standalone from a
bare checkout with no xCAT at all.
Shell-script unit tests belong in ../bats
and run with BATS. Do not add Perl .t tests that grep shell source when the
behavior can be exercised by sourcing a shell library or script and shadowing the
external commands it calls.
The distinction matters because a test that needs an absent environment does not fail
-- it calls plan skip_all and reports as skipped. A handful of those in a suite of
several hundred assertions is easy to stop reading. Keeping the two kinds in separate
directories means a skip in unit/ is a real signal rather than routine noise.
Guarding on a source file, on the other hand, is fine and common here:
plan skip_all => "compute.subiquity.tmpl not found" unless -f $tmpl_path;
That guard never fires when the tree is intact.