xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-04 20:17:55 +00:00
Code Issues Releases Wiki Activity

test(xcatd): the purity check misses exited() mutating in place

Browse Source 
The subtest composed the two calls as exited(forked($pace,10),11), so exited()
only ever got forked()'s throwaway intermediate to mutate. An exited() that
wrote in place left $pace untouched and the assertion stayed green -- the
review that found this confirmed it by making exited() impure and watching the
file pass.

Check each on a state it was handed directly. Verified the other way round:
making exited() assign into its argument and return the same reference now
reddens both new assertions, where before it reddened nothing.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
This commit is contained in:
Daniel Hilst
2026-09-01 18:56:52 -03:00
parent 49e77398e4
commit 207ec20f83
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/xcatd_monitor_respawn.t
+18
View File
@@ -186,6 +186,24 @@ subtest 'the pacing functions are pure' => sub {
is_deeply( $pace, \%before, 'exited()/forked() leave the state they were given alone' );
isnt( $after, $pace, 'they return a new state rather than the same reference' );
is( due( $pace, 0 ), due( $pace, 0 ), 'due() is free of side effects' );
# Each of the two has to be checked on a state it was handed DIRECTLY. Composing them as
# exited(forked($pace,...)) only ever lets exited() mutate forked()'s throwaway
# intermediate, so an exited() that wrote in place would leave $pace untouched and the
# assertion above green.
my $only_forked = xCAT::RespawnUtils::policy( min_interval => 1, max_interval => 8 );
my %before_forked = %$only_forked;
my $forked_out = forked( $only_forked, 10 );
is_deeply( $only_forked, \%before_forked,
'forked() alone leaves the state it was given alone' );
isnt( $forked_out, $only_forked, 'forked() returns a new state' );
my $only_exited = xCAT::RespawnUtils::policy( min_interval => 1, max_interval => 8 );
my %before_exited = %$only_exited;
my $exited_out = exited( $only_exited, 5 );
is_deeply( $only_exited, \%before_exited,
'exited() alone leaves the state it was given alone' );
isnt( $exited_out, $only_exited, 'exited() returns a new state' );
};
# --- the window the reaper looks through ------------------------------------