xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-08-26 16:46:41 +00:00
Code Issues Releases Wiki Activity

fix(credentials): audit delegated certificate signing

Browse Source
This commit is contained in:
Vinícius Ferrão
2026-08-20 17:37:19 -03:00
parent 1f68e97f9e
commit bae92ffc47
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-server/lib/xcat/plugins/credentials.pm
+7
View File
@@ -96,6 +96,13 @@ sub process_request
$callback->({ error => ["Unable to sign certificate for $node"], errorcode => [1] });
return;
}
my $peer = $request->{'_xcat_clientip'}
? $request->{'_xcat_clientip'}->[0]
: $request->{'_xcat_clienthost'}
? $request->{'_xcat_clienthost'}->[0]
: $request->{'_xcat_clientfqdn'}->[0];
xCAT::MsgUtils->trace(0, 'I',
"credentials: signed certificate for $node requested by $peer");
$callback->({ data => [{ content => [$certificate], desc => ['x509cert'] }] });
return;
}
xCAT-test/unit/credentials_service_node.t
+11
View File
@@ -342,6 +342,7 @@ is( $error, 'The management node is not configured',
'missing site.master has a specific error' );
$xCAT::Table::servicenode = 'service-a';
@xCAT::MsgUtils::messages = ();
my @callback;
{
no warnings 'redefine';
@@ -374,6 +375,16 @@ is_deeply(
],
'authorized delegated request returns only the signed certificate'
);
is_deeply(
$xCAT::MsgUtils::messages[-1],
[
'xCAT::MsgUtils',
0,
'I',
'credentials: signed certificate for compute-01 requested by 192.0.2.21',
],
'successful delegated signing records the node and service node address'
);
@callback = ();
xCAT_plugin::credentials::process_request(