xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-10-20 14:45:41 +00:00
Code Issues Releases Wiki Activity

test(enablekdump): pin options that merely end in root=

Browse Source 
Add foo-root=bar and rd.foo.root=bar to the legacy migration fixture
and assert both survive intact. Against the word-boundary strip these
assertions fail with the tokens truncated to foo- and rd.foo.; the
existing second-run check keeps covering them through both executions.
This commit is contained in:
Vinícius Ferrão
2026-08-18 14:04:26 -03:00
parent 6b9891b6de
commit 5d3c40b5a2
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/enablekdump_per_node.t
+5 -1
View File
@@ -109,7 +109,7 @@ sub write_file {
# line, so leaving the legacy value behind would defeat the migration.
{
my $legacy = qq{KDUMP_COMMANDLINE=""\n}
. qq{KDUMP_COMMANDLINE_APPEND="root=nfs:10.0.0.1:/dumparea rd.neednet=1 rootflags=nofail"\n};
. qq{KDUMP_COMMANDLINE_APPEND="root=nfs:10.0.0.1:/dumparea rd.neednet=1 rootflags=nofail foo-root=bar rd.foo.root=bar"\n};
my $r = run_enablekdump(osver => 'rhels7.9', node => 'n07',
sysconfig => $legacy);
@@ -122,6 +122,10 @@ sub write_file {
'unrelated options on the legacy line are preserved');
like($append, qr{(?:^|\s)rootflags=nofail(?:\s|$)},
'rootflags= is not mistaken for a root= token');
like($append, qr{(?:^|\s)foo-root=bar(?:\s|$)},
'a root= suffix after a dash is not stripped');
like($append, qr{(?:^|\s)rd\.foo\.root=bar(?:\s|$)},
'a root= suffix after a dot is not stripped');
# Re-running against its own output must not stack another root=.
my $r2 = run_enablekdump(osver => 'rhels7.9', node => 'n07',