The aarch64 domain of the branch was measured on one host and guest pair, an
x86_64 hypervisor emulating aarch64. Three other pairs are not covered.
An aarch64 guest on an aarch64 hypervisor must be a kvm domain that takes the
host CPU, not a qemu domain pinned to cortex-a57. An aarch64 guest on a POWER
hypervisor must take neither the POWER CPU model, nor the pseries CPU topology,
nor the qemu-system-ppc64 emulator. A CPU mode from vm.othersettings must not
reach an emulated domain, because TCG has no host CPU.
The video assertion stated that the aarch64 virt machine has no virtio video
model. libvirt reports virtio for a riscv64 virt machine and not for an aarch64
one on the same host, and the aarch64 emulator there has no virtio-gpu device,
so the refusal came from that build and not from the machine type. The test now
expects the virtio model, as it does for riscv64.
The POWER controls now pass a hypervisor cputype, which is what builds the CPU
model and the topology element.
Ten of the new assertions fail on the unfixed tree.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Unit tests. These run against the source tree only -- no xCAT installation, no
running daemons, no management node.
They are executed on every pull request by the xcat_test GitHub Actions workflow,
which calls run_unit_tests() in github_action_xcat_test.pl:
prove -r xCAT-test/unit
You can run exactly the same thing from a clean checkout:
cd <xcat-core checkout>
prove -r xCAT-test/unit
What belongs here
A test belongs in unit/ when everything it needs is in the checkout: plugin and
library sources, kickstart/preseed/subiquity templates, postscripts, packaging
metadata. Such a test asserts on rendered output or module logic and reaches the
repository root through FindBin:
Because of those FindBin paths the tests only work from a source tree. The copy
installed under /opt/xcat/share/xcat/tools/autotest/unit is not a substitute --
../.. resolves to /opt/xcat/share/xcat/tools there and the tests die or silently
skip. The CI takes a copy of the checkout before the build for this reason; see
preserve_source_tree().
What does not belong here
Tests that build RPMs, create Linux namespaces or start service binaries belong
in ../native. They run explicitly on a suitable host,
outside the default unit suite.
Anything that needs an installed xCAT, a populated /install, a real service binary
or a live daemon. Those go in ../integration and run on
a management node through xcattest. Both suites run on every pull request -- the
workflow installs xCAT on the runner and then runs the ci_test cases against it --
so putting a test in integration/ does not cost it CI coverage. What differs is what
each suite is allowed to depend on, and that unit tests also run standalone from a
bare checkout with no xCAT at all.
Shell-script unit tests belong in ../bats
and run with BATS. Do not add Perl .t tests that grep shell source when the
behavior can be exercised by sourcing a shell library or script and shadowing the
external commands it calls.
The distinction matters because a test that needs an absent environment does not fail
-- it calls plan skip_all and reports as skipped. A handful of those in a suite of
several hundred assertions is easy to stop reading. Keeping the two kinds in separate
directories means a skip in unit/ is a real signal rather than routine noise.
Guarding on a source file, on the other hand, is fine and common here:
planskip_all=>"compute.subiquity.tmpl not found"unless-f$tmpl_path;
Daniel Hilst
1c91237cfc