2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-11-21 01:42:15 +00:00
Files
xcat-core/xCAT-test/bats
Daniel Hilst a5cd542a5d fix(xcat-core): configdhcpv6duid writes a DUID that the reservation does not hold
mypostscript assigned DHCP6DUID and did not export it, so configdhcpv6duid, which runs as a
child process, never saw mac.duid and wrote the firmware DUID-UUID. The script also rejected
ll, which makedhcp accepts and selects by default on ppc64le. It read the SMBIOS UUID before
the attribute, so a missing or nil UUID ended the script although a literal DUID needs none.
And it wrote no systemd-networkd configuration for a DUID that is not a DUID-UUID.

mypostscript now exports DHCP6DUID. The script reads the attribute first, builds the DUID-LL
from the first mac.mac address for ll and for an unset value on ppc64le, reads the UUID only
for firmware and canonical, and gives systemd-networkd the type of every DUID through
DUIDType and the rest through DUIDRawData.

postscript_dhcpv6_duid.bats fails without this change.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-11-06 17:32:00 -03:00
..

xCAT-test/bats

Shell-script unit tests live here and run with:

bats -r xCAT-test/bats

The GitHub Actions xcat_test workflow runs this command after the Perl .t unit tests. Use BATS for shell behavior that can be exercised from the source tree without an installed xCAT, a live management node, or real services.

Prefer sourcing an existing shell library or sourceable script and calling the function under test. Keep reusable install-template helpers in xCAT-server/share/xcat/install/scripts/scriptlib, and reusable postscript helpers in xCAT/postscripts/xcatlib.sh. Use scratch directories and shadowed commands so tests cannot write to the host.

Extraction helpers in helpers/shell_source.bash are only for legacy code that cannot safely be sourced yet. Do not add Perl .t tests that grep shell source when the behavior can be tested with BATS.

Postscript sandbox prerequisites

otherpkgs_upgrade_scope.bats and routeop.bats run complete postscripts in Linux filesystem and network namespaces. Their /etc writes stay inside test fixtures. They require Bubblewrap, Bash, GNU core utilities, grep, sed, and permission to create user namespaces. The CI workflow installs Bubblewrap and enables those namespaces.

routeop_linklocal.bats also needs iproute2 and kernel support for dummy network interfaces. It maps root and grants CAP_NET_ADMIN only inside a new user and network namespace. It runs as an ordinary user and changes real kernel routes only in that private network namespace.

Missing prerequisites fail these tests without stopping unrelated test files. Non-Linux hosts report a skip. Set TMPDIR to a writable, executable filesystem if the default temporary directory is mounted with noexec.

go_xcat_os_release.bats, go_xcat_activation.bats and the full-script cases in postscripts_apt_get.bats use the same namespace isolation. They require bats-core 1.4 or newer. OS detection also requires GNU awk for the legacy Red Hat release parser. Postscript cases require GNU diffutils.

networkmanager_postscript.bats renders complete installation postscripts in private namespaces. It requires Bubblewrap, bats-core 1.4 or newer, user namespaces and the xCAT Perl dependencies, including DBI and DBD::SQLite.

go_xcat_os_release.bats and go_xcat_el_repo_check.bats source the complete go-xcat script. OS detection uses mawk when available, otherwise the host AWK. The two legacy Red Hat version cases use GNU awk. CI installs both interpreters. Package-manager commands are test doubles, so these cases check selection, arguments and error handling, not repository availability or package installation.

Genesis startup

genesis_ib_modules.bats and genesis_secondary_dhcp.bats run the complete doxcat script in a private filesystem and network namespace. They replace external services and device commands, then check the boot interface and the IPv4 and IPv6 DHCP requests. They do not contact a DHCP server or a BMC.

The startup cases require Linux, bats-core 1.4 or newer, Bubblewrap, Bash, GNU core utilities, grep, sed, awk and permission to create user namespaces. Missing Linux prerequisites fail these cases. Non-Linux hosts skip them. The RPM prerequisite check requires rpmspec but does not use the sandbox. Run containers with an init process to reap children created by deliberate-fault tests.

Genesis sandbox prerequisites

genesis_bmcsetup_users.bats, genesis_getadapter.bats and genesis_discovery_uuid.bats run the complete checkout scripts with private filesystem, process, and network namespaces. They replace hardware and transport commands, not the scripts under test. The fixtures do not contact a BMC or transmit an adapter or discovery request.

These tests require Linux, bats-core 1.4 or newer, Bubblewrap, Bash, GNU core utilities, awk, grep, sed, and user namespace support. The adapter tests also require cmp from diffutils, and the discovery test requires gzip. The CI environment provides these dependencies. Missing prerequisites fail on Linux; non-Linux hosts report a skip. The temporary filesystem must allow executable files.

The BMC cases check LAN values, device and channel selection, write retries, configuration defaults, user selection, and vendor port commands. They assert the commands issued by the complete script. They do not verify that physical BMC firmware accepts those commands.

Boot artifact and repository checks

mknb_genesis_compression.bats, dhcp_http_port.bats and go_xcat_common_repository.bats require Linux, Bubblewrap and user namespaces. They execute checkout code in isolated filesystems without contacting services. Non-Linux hosts skip these cases; missing Linux prerequisites fail them. The compression cases also need xz, gzip and cpio. They run as an ordinary user so directory-permission failures can be exercised. Both lzma and xz selection paths build real images, and the decoder checks the LZMA format.