rinstall prints "Failed to run 'nodeset' against the node" while nodeset succeeds and reports no error. xCAT::Utils::runxcmd returns $::RUNCMD_RC, and xCAT::Utils::runcmd and the service helpers of every plugin inside the subrequest assign to that global, so the status of the last command of the subrequest becomes the status of the subrequest. makedhcp supplies that command: the ISC branch restarts dhcpd6 whenever /etc/dhcp/dhcpd6.conf is absent or foreign, which is every run of a cluster with no IPv6 network, and the restart fails because dhcpd6 has no subnet to serve. runxcmd_subrequest_errorcode.t holds the result of a subrequest to the errorcode of its responses. dhcp_isc_dhcp6_restart.t holds the restart of dhcpd6 to a run that serves an IPv6 network. The condition moves out of dhcp.pm into xCAT::DHCP::Backend::ISC unchanged, so that a test can read it. Against this tree the first test fails 3 of its 5 assertions and the second fails 1 of its 4. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| Black-box service tests | xCAT-test/blackboxtest/ |
python3 -m unittest discover -s tests, then blackboxtest run <conf> on a management node |
| Native host tests | xCAT-test/native/*.t, xCAT-test/native/*.bats |
Selected CI cases and explicit lab runs; see native/README.md |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
blackboxtest is the odd one out: its Python unit tests and blackboxtest validate run offline like the others, but its point is the third column --
asking a management node what a booting node asks (DHCP, DNS, TFTP, HTTP,
xcatd) and asserting on the answers. It talks to the services only as a client,
so it does not depend on which DHCP server answers or on the xCAT database.
See unit/README.md, bats/README.md and blackboxtest/README.md for the
detailed rules for each suite.