Daniel Hilst
e364172b99
The unit tests drive xCAT::RespawnUtils, which is where the pacing lives, but nothing connects that to the daemon. Replacing the respawn condition in xcatd's service loop with "if (0)" -- so a dead install monitor is never re-forked -- leaves the whole suite green. The behaviour the PR exists to deliver is unverified. That gap cannot be closed in a unit test: xcatd needs the database, SSL, the plugin tree and /var/run/xcat before it will start, which is why the pacing was extracted in the first place. It belongs in xCAT-test, where there is a running daemon to kill things in. Add a case that kills the install monitor and requires that a new one appears, that it reclaims xcatiport rather than merely existing, and that the SSL listener keeps its pid throughout -- surviving without a restart being the entire point. The process titles are matched anchored. An unanchored "pgrep -f xcatd: install monitor" also matches the running test's own command line, and the kill would then take out the test; that was observed on a live MN, not guessed. Two smaller test defects go with it. The fork test kept every pid it forked in @spawned and had its END block signal all of them, including ones it had already reaped -- verified as 3 of 3 -- so a recycled pid would take a signal meant for a process that no longer exists, and the suite runs as root in CI. Reaped pids now leave the list. And the tunables reach policy() straight from %ENV, where they can be empty or misspelt; assert that none of those shapes produces a Perl warning, since xcatd runs under use warnings and would put one in the daemon log on every start. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test/unit
Unit tests. These run against the source tree only -- no xCAT installation, no running daemons, no management node.
They are executed on every pull request by the xcat_test GitHub Actions workflow,
which calls run_unit_tests() in github_action_xcat_test.pl:
prove -r xCAT-test/unit
You can run exactly the same thing from a clean checkout:
cd <xcat-core checkout>
prove -r xCAT-test/unit
What belongs here
A test belongs in unit/ when everything it needs is in the checkout: plugin and
library sources, kickstart/preseed/subiquity templates, postscripts, packaging
metadata. Such a test asserts on rendered output or module logic and reaches the
repository root through FindBin:
use FindBin;
use lib "$FindBin::Bin/../../perl-xCAT";
use lib "$FindBin::Bin/../../xCAT-server/lib/perl";
Because of those FindBin paths the tests only work from a source tree. The copy
installed under /opt/xcat/share/xcat/tools/autotest/unit is not a substitute --
../.. resolves to /opt/xcat/share/xcat/tools there and the tests die or silently
skip. The CI takes a copy of the checkout before the build for this reason; see
preserve_source_tree().
What does not belong here
Anything that needs an installed xCAT, a populated /install, a real service binary
or a live daemon. Those go in ../integration and run on
a management node through xcattest. Both suites run on every pull request -- the
workflow installs xCAT on the runner and then runs the ci_test cases against it --
so putting a test in integration/ does not cost it CI coverage. What differs is what
each suite is allowed to depend on, and that unit tests also run standalone from a
bare checkout with no xCAT at all.
The distinction matters because a test that needs an absent environment does not fail
-- it calls plan skip_all and reports as skipped. A handful of those in a suite of
several hundred assertions is easy to stop reading. Keeping the two kinds in separate
directories means a skip in unit/ is a real signal rather than routine noise.
Guarding on a source file, on the other hand, is fine and common here:
plan skip_all => "compute.subiquity.tmpl not found" unless -f $tmpl_path;
That guard never fires when the tree is intact.