Daniel Hilst
d5d89ade6c
ubuntu_2604_pkglist.t matched regexes against Template.pm's `push @lines` literals, and ubuntu_subiquity_storage.t was source greps end to end. Both pass when the code is moved somewhere it never runs, and both break on a reformat that changes nothing: reordering two keys inside the efi-part stanza -- identical emitted config -- fails the old efi-part match. The apt config is now rendered by calling ubuntu_subiquity_apt_config and asserting on its output. Only the two collaborators that read the xCAT database are stubbed; the release branch is driven for real through the media directory the renderer parses, so 26.04, 24.04 and pre-Deb822 each render their own shape. The Release-index requirement is exercised against a real directory instead of matched as a shell fragment. The partitioning moves to ubuntu_subiquity_storage.t, which owns that topic and was asserting the same facts by grep. The script cannot run here -- it stops syslog and carries xCAT template markers -- so the block that writes the partition file is lifted out and executed with its one bracket test shadowed by a shell function, which bash resolves ahead of the builtin, leaving the script's own condition unmodified. The emitted curtin config is parsed into id => attributes, so the assertions survive reindentation and reordering. Both extractions BAIL_OUT if their anchors stop matching, and the partition-file redirect is asserted to have been pointed at the scratch tree twice before anything runs, so a rewrite that stops matching fails loudly instead of writing to /tmp. Verified by mutation: dropping grub_device, formatting the ESP ext4, moving its mount point, dropping the bios_grub flag, indenting the block off column 0, dropping Enabled: no, rendering a live cdrom source on 26.04, dropping the Check-Date waiver, dropping the offline fallback and dropping the Release requirement each redden the suite; the pure key reorder that broke the old assertion leaves it green. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test/unit
Unit tests. These run against the source tree only -- no xCAT installation, no running daemons, no management node.
They are executed on every pull request by the xcat_test GitHub Actions workflow,
which calls run_unit_tests() in github_action_xcat_test.pl:
prove -r xCAT-test/unit
You can run exactly the same thing from a clean checkout:
cd <xcat-core checkout>
prove -r xCAT-test/unit
What belongs here
A test belongs in unit/ when everything it needs is in the checkout: plugin and
library sources, kickstart/preseed/subiquity templates, postscripts, packaging
metadata. Such a test asserts on rendered output or module logic and reaches the
repository root through FindBin:
use FindBin;
use lib "$FindBin::Bin/../../perl-xCAT";
use lib "$FindBin::Bin/../../xCAT-server/lib/perl";
Because of those FindBin paths the tests only work from a source tree. The copy
installed under /opt/xcat/share/xcat/tools/autotest/unit is not a substitute --
../.. resolves to /opt/xcat/share/xcat/tools there and the tests die or silently
skip. The CI takes a copy of the checkout before the build for this reason; see
preserve_source_tree().
What does not belong here
Anything that needs an installed xCAT, a populated /install, a real service binary
or a live daemon. Those go in ../integration and run on
a management node through xcattest. Both suites run on every pull request -- the
workflow installs xCAT on the runner and then runs the ci_test cases against it --
so putting a test in integration/ does not cost it CI coverage. What differs is what
each suite is allowed to depend on, and that unit tests also run standalone from a
bare checkout with no xCAT at all.
The distinction matters because a test that needs an absent environment does not fail
-- it calls plan skip_all and reports as skipped. A handful of those in a suite of
several hundred assertions is easy to stop reading. Keeping the two kinds in separate
directories means a skip in unit/ is a real signal rather than routine noise.
Guarding on a source file, on the other hand, is fine and common here:
plan skip_all => "compute.subiquity.tmpl not found" unless -f $tmpl_path;
That guard never fires when the tree is intact.