Daniel Hilst
9585205ea8
The test shipped with the netplan support drove only the private write_netplan_* writers, so it could not see the branch selection that is the actual fix: deleting the netplan arm from configipv4 outright left all fourteen assertions green. Its one real-parser gate was vacuous as well -- `netplan generate --root-dir` reads <root>/etc/netplan, and the harness wrote the drop-ins flat into the scratch directory, so netplan parsed zero files and exited 0 for any content at all, including a key it rejects. Drive configipv4, configipv6 and delete_nic_config_files instead, and let the generate gate see the tree it is meant to validate. netplan, ifup and wait_for_ifstate are shadowed with shell functions, which bash resolves ahead of $PATH, so `netplan apply` is recorded rather than run and the suite cannot touch the host's network however it is invoked. Two assertions had pinned the behaviour that was wrong: that a VLAN file declares no ethernets: section -- which is exactly why netplan could not resolve its link: -- and that the default route reads "to: default", an alias netplan only understands from 0.103. The harness now also uses the sentinel configeth really sets rather than one of its own, so an unset MTU is exercised through the comparison the script performs instead of past it. Each assertion was checked by reverting the behaviour it describes: all nine reversions fail, including the one the previous test was blind to. On a runner with netplan present the generate gate fails with "unknown key 'MTU'" when nicextraparams are passed through unmapped. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test/unit
Unit tests. These run against the source tree only -- no xCAT installation, no running daemons, no management node.
They are executed on every pull request by the xcat_test GitHub Actions workflow,
which calls run_unit_tests() in github_action_xcat_test.pl:
prove -r xCAT-test/unit
You can run exactly the same thing from a clean checkout:
cd <xcat-core checkout>
prove -r xCAT-test/unit
What belongs here
A test belongs in unit/ when everything it needs is in the checkout: plugin and
library sources, kickstart/preseed/subiquity templates, postscripts, packaging
metadata. Such a test asserts on rendered output or module logic and reaches the
repository root through FindBin:
use FindBin;
use lib "$FindBin::Bin/../../perl-xCAT";
use lib "$FindBin::Bin/../../xCAT-server/lib/perl";
Because of those FindBin paths the tests only work from a source tree. The copy
installed under /opt/xcat/share/xcat/tools/autotest/unit is not a substitute --
../.. resolves to /opt/xcat/share/xcat/tools there and the tests die or silently
skip. The CI takes a copy of the checkout before the build for this reason; see
preserve_source_tree().
What does not belong here
Anything that needs an installed xCAT, a populated /install, a real service binary
or a live daemon. Those go in ../integration and run on
a management node through xcattest. Both suites run on every pull request -- the
workflow installs xCAT on the runner and then runs the ci_test cases against it --
so putting a test in integration/ does not cost it CI coverage. What differs is what
each suite is allowed to depend on, and that unit tests also run standalone from a
bare checkout with no xCAT at all.
The distinction matters because a test that needs an absent environment does not fail
-- it calls plan skip_all and reports as skipped. A handful of those in a suite of
several hundred assertions is easy to stop reading. Keeping the two kinds in separate
directories means a skip in unit/ is a real signal rather than routine noise.
Guarding on a source file, on the other hand, is fine and common here:
plan skip_all => "compute.subiquity.tmpl not found" unless -f $tmpl_path;
That guard never fires when the tree is intact.