2
0
mirror of https://opendev.org/x/pyghmi synced 2026-03-27 13:23:30 +00:00

Prevent overwrite of existing files.

Fetching new licence keys or diagnostic data should never
overrite existing content.

Change-Id: I41519dc59544165e244b39cef2f510eeb4c0f15f
This commit is contained in:
Jarrod Johnson
2020-01-31 10:20:48 -05:00
parent 9c0843443e
commit d93718e306

View File

@@ -1679,6 +1679,10 @@ class Command(object):
return self.oem.update_firmware(file, data, progress, bank)
def get_diagnostic_data(self, savefile, progress=None, autosuffix=False):
if os.path.exists(savefile) and not os.path.isdir(savefile):
raise exc.InvalidParameterValue(
'Not allowed to overwrite existing file: {0}'.format(
savefile))
return self.oem.get_diagnostic_data(savefile, progress, autosuffix)
def get_licenses(self):
@@ -1688,6 +1692,10 @@ class Command(object):
return self.oem.delete_license(name)
def save_licenses(self, directory):
if os.path.exists(directory) and not os.path.isdir(directory):
raise exc.InvalidParameterValue(
'Not allowed to overwrite existing file: {0}'.format(
directory))
return self.oem.save_licenses(directory)
def apply_license(self, filename, progress=None):