From d93718e306e617101ba3da982dad4166dd6a60bf Mon Sep 17 00:00:00 2001
From: Jarrod Johnson <jjohnson2@lenovo.com>
Date: Fri, 31 Jan 2020 10:20:48 -0500
Subject: [PATCH] Prevent overwrite of existing files.

Fetching new licence keys or diagnostic data should never
overrite existing content.

Change-Id: I41519dc59544165e244b39cef2f510eeb4c0f15f
---
 pyghmi/redfish/command.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/pyghmi/redfish/command.py b/pyghmi/redfish/command.py
index 48934253..094a457d 100644
--- a/pyghmi/redfish/command.py
+++ b/pyghmi/redfish/command.py
@@ -1679,6 +1679,10 @@ class Command(object):
         return self.oem.update_firmware(file, data, progress, bank)
 
     def get_diagnostic_data(self, savefile, progress=None, autosuffix=False):
+        if os.path.exists(savefile) and not os.path.isdir(savefile):
+            raise exc.InvalidParameterValue(
+                'Not allowed to overwrite existing file: {0}'.format(
+                    savefile))
         return self.oem.get_diagnostic_data(savefile, progress, autosuffix)
 
     def get_licenses(self):
@@ -1688,6 +1692,10 @@ class Command(object):
         return self.oem.delete_license(name)
 
     def save_licenses(self, directory):
+        if os.path.exists(directory) and not os.path.isdir(directory):
+            raise exc.InvalidParameterValue(
+                'Not allowed to overwrite existing file: {0}'.format(
+                    directory))
         return self.oem.save_licenses(directory)
 
     def apply_license(self, filename, progress=None):