mirror of
https://github.com/xcat2/xcat-dep.git
synced 2026-09-12 04:26:25 +00:00
Daniel Hilst
e75b56a405
Follow-up self-review hardening on top of the PR #62 review response: - finalize_xcat_dep now treats a missing ppc64le PEER repo (not just missing genesis rpms) as fatal instead of silently skipping the OS -- in the CD both arches build every EL, so a missing peer is an incomplete input that would otherwise leave the x86_64 repo without the ppc64 genesis and still exit 0. - cross_copy_genesis treats an empty SIGMD5 (unreadable rpm) as "cannot confirm identical" and refreshes, rather than risking a false up-to-date match when two unreadable rpms both return an empty digest. - rpm_version fails when a directory holds more than one distinct version of a package (a stale artifact not cleaned before the build) instead of silently returning the first sorted match, which a version pin could pass against while the stale rpm still ships. Both arches share a Version for genesis, so a normal x86_64+ppc64 pair is a single entry. t/mockbuild-all.t: +4 cases (30 total) -- missing-peer fatal, rpm_sigmd5 on a missing rpm, and rpm_version multi-version failure. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>