mirror of
https://github.com/xcat2/xcat-dep.git
synced 2026-09-12 04:26:25 +00:00
Daniel Hilst
6742e5f862
elilo/mockbuild.pl wget'd the upstream tarball over $source_path and then normalized it in place, rewriting the tracked source file. Parallel builds share that same source file, so builds running concurrently raced to fetch and rewrite it -- one build could read the file mid-rewrite and get a truncated archive, an intermittent "Normalized source archive still missing elilo top-level tree" failure. Because elilo is a required dep, one such flake failed the whole run. The tracked tarball is already normalized (elilo/ top-level), so use it read-only when normalized and only fetch upstream when it is absent or not yet normalized. This removes the in-place rewrite (hence the race) and the flaky sourceforge dependency, and is more reproducible. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>