mirror of
https://github.com/xcat2/xcat-dep.git
synced 2026-09-12 12:36:23 +00:00
Daniel Hilst
5bb9cfa2b2
A CD run died at compile time inside XCAT::BuildUtils because xcat-master-ub was missing File::Slurper: "Can't locate File/Slurper.pm in @INC", in the middle of a build. It was fixed by hand, so the next unprovisioned host fails the same way and the documented install line can drift from what the code actually loads. --install-deps installs this host's prerequisites and exits: the sbuild/schroot toolchain plus the modules. It then LOADS each module and fails naming any that is still missing, rather than trusting apt's exit code. That probe earned its place immediately: the first list named libipc-cmd-perl, which does not exist on Ubuntu -- IPC::Cmd is core there -- and apt failed the whole install over it. The package is gone from the list and the module is asserted by loading instead, with a test that pins both halves of that reasoning. The list and the command are pure functions in BuildUtils, so the decision is unit-tested and the side effect stays in the caller. Run on xcat-master-ub and xcat-master-ub-ppc: both report every module present. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>