mirror of
https://github.com/xcat2/xcat-dep.git
synced 2026-09-09 22:46:44 +00:00
Daniel Hilst
1e9ec56bdc
Two CD runs died at compile time inside XCAT::BuildUtils because a builder was missing a Perl module the script loads: perl-File-Slurper on xcat-master-ub and perl-IPC-Cmd on xcat-master-ppc. Both surfaced as "Can't locate ... in @INC" in the middle of a build, and both were fixed by hand -- so the next unprovisioned host fails the same way, and BUILD.md's install line can drift from what the code actually requires. --install-deps installs this host's prerequisites and exits: the toolchain plus the modules, through dnf or zypper as the host's ID dictates. It then LOADS each module and fails naming any that is still missing, rather than trusting the package manager's exit code -- a package that installs cleanly but leaves the module unusable is exactly the failure this exists to prevent. The list and the command are pure functions in MockBuildUtils, so the decision is unit-tested (package sets per family, the right installer non-interactively, and the probe reporting only what genuinely cannot be loaded); the side effect stays in the caller. Run on xcat-master and xcat-master-ppc: both report every module present. xcat-master-suse is unreachable and still needs it. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>