xCAT/xcat-dep
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-dep.git synced 2026-09-12 12:36:23 +00:00
Code Issues Projects Releases Wiki Activity

test(xcat-dep): capture a manifest pin drifting from its changelog

Browse Source 
The Ubuntu build fails at the end, after compiling every package:

  FATAL: manifest validation failed:
    [noble-amd64] grub2-xcat: built 2.12-2, manifest pins 2.12-1

debs-manifest.conf pins the exact deb version each package must produce, and that
version comes from the package's own debian/changelog. Bumping the changelog
without the pin costs a whole build to discover a one-line edit.

The test compares every non-glob pin with the first line of that package's
debian/changelog. Globbed pins are deliberate -- goconserver's revision is the CD
stamp and xcat-genesis-base is not versioned by xcat-dep -- and are skipped. It
fails on grub2-xcat today.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
This commit is contained in:
Daniel Hilst
2026-09-02 17:06:36 -03:00
committed by Vinícius Ferrão
parent 341f4650ab
commit 67ab6f1fad
1 changed files with 37 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
t/sbuild-all.t
+37
View File
@@ -646,4 +646,41 @@ STUB
}
}
# ---- every non-glob manifest pin must match the package's own debian/changelog --------------
# debs-manifest.conf pins the exact deb version each package must produce, and the version comes
# from that package's debian/changelog. Bumping the changelog without the pin does not fail the
# build -- it fails the manifest VALIDATION, at the end, after every package has been compiled:
# FATAL: manifest validation failed:
# [noble-amd64] grub2-xcat: built 2.12-2, manifest pins 2.12-1
# which is a whole build's worth of time to learn about a one-line edit. grub2-xcat drifted exactly
# that way when the riscv64 UEFI image was added. Globbed pins are deliberate (goconserver's
# revision is the CD stamp; xcat-genesis-base is not versioned by xcat-dep) and are skipped.
{
my $root = "$FindBin::Bin/..";
my %dir_of = (
'ipmitool-xcat' => 'ipmitool',
'conserver-xcat' => 'conserver',
'syslinux-xcat' => 'syslinux',
'grub2-xcat' => 'grub2-xcat',
'elilo-xcat' => 'elilo',
'xnba-undi' => 'xnba',
);
my %manifest = read_manifest("$root/debs-manifest.conf");
my %seen;
for my $section (sort keys %manifest) {
for my $pkg (sort keys %{ $manifest{$section} }) {
my $pin = $manifest{$section}{$pkg};
next if !defined $pin || $pin =~ /[*?]/;
my $dir = $dir_of{$pkg} or next;
my $cl = "$root/$dir/debian/changelog";
next unless -f $cl;
open my $fh, '<', $cl or next;
my $first = <$fh>; close $fh;
my ($ver) = $first =~ /^\S+\s+\(([^)]+)\)/;
next if $seen{"$pkg=$pin=$ver"}++;
is($pin, $ver, "manifest pin $pkg=$pin matches $dir/debian/changelog");
}
}
}
done_testing;