2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-11-21 01:42:15 +00:00
Files
xcat-core/xCAT-test/unit/profile_customization.t
T
Daniel Hilst 9c311c8946 fix(xcat-core): Ubuntu diskless nodes cannot netboot over IPv6 only
The Ubuntu genimage enters dracut mode only when the rootimg holds
/usr/share/dracut or /usr/lib/dracut (netboot/ubuntu/genimage:791). Seven
netboot package lists hold no dracut, so genimage writes the legacy /init.
That /init waits for an "inet addr" line from ifconfig (genimage:1339) and
cuts XCATSERVER at the first colon (genimage:1348). Both steps are IPv4-only,
so an IPv6-only diskless node never boots. Ubuntu 26.04 diskless is the row
this blocks.

Add dracut and dracut-network to the 24.04 ppc64el list, its ppc64le copy,
and the five 26.04 netboot lists. Both packages are published for noble
(universe, 060+5-1ubuntu3) and resolute (main, 110-11) on amd64, ppc64el and
riscv64. dracut-network pulls iproute2 on resolute and iputils-arping on
noble, so no other entry is needed.

The new xCAT-test/unit/ubuntu_netboot_dracut_pkglists.t reads the seven lists
plus the working 24.04 x86_64 reference and asserts both entries.
profile_customization.t now expects dracut in the 26.04 riscv64 list.
Removing dracut from compute.ubuntu26.04.pkglist fails only that list's
assertion; the reference stays green.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-11-05 16:46:29 -03:00

155 lines
7.8 KiB
Perl

#!/usr/bin/env perl
use strict;
use warnings;
use FindBin;
use lib "$FindBin::Bin/../lib";
use lib "$FindBin::Bin/../../perl-xCAT", "$FindBin::Bin/../../xCAT-server/lib/perl";
use File::Copy qw(copy);
use File::Path qw(make_path);
use File::Slurper qw(read_binary write_binary);
use File::Temp qw(tempdir);
use Fcntl qw(S_IMODE);
use Test::More;
use XCAT::Test::File qw(repo_path);
my $prefix = shift @ARGV // repo_path('xCAT-server');
my $work = tempdir(CLEANUP => 1);
$ENV{XCATROOT} = $prefix;
$ENV{XCATCFG} = "SQLite:$work/db";
make_path("$work/db", "$work/install");
require xCAT::SvrUtils;
require xCAT::Postage;
require xCAT::Table;
my %packages = (
'install/compute' => ['@Minimal Install', qw(kernel chrony net-tools nfs-utils
openssh-server openssl rsync util-linux wget python3 tar bzip2
perl-interpreter grub2-efi-riscv64 efibootmgr)],
'netboot/compute' => ['@minimal-environment', qw(initscripts chrony kernel
net-tools nfs-utils openssh-server rsync tar util-linux wget python3 tar
bzip2 bc dracut dracut-network NetworkManager rsyslog hostname e2fsprogs
ethtool parted openssl openssh-clients bash vim-minimal rpm iputils
perl-interpreter)],
'netboot/service' => ['@minimal-environment', qw(chrony kernel net-tools
nfs-utils openssh-server rsync tar util-linux wget perl-DBD-MySQL
perl-DBD-Pg perl-lib python3 tar bzip2 bc dracut dracut-network rsyslog
hostname e2fsprogs ethtool parted openssl openssh-clients bash
vim-minimal rpm iputils)],
);
my @cases;
for my $family (['rh', 'rhels10'], ['rocky', 'rocky10']) {
my ($directory, $os) = @$family;
for my $profile (qw(compute service)) {
push @cases, map { ['install', $directory, $profile, $os, 'riscv64', $_] }
qw(tmpl pkglist);
push @cases, map { ['netboot', $directory, $profile, $os, 'riscv64', $_] }
qw(pkglist exlist postinstall);
}
push @cases, map { [$_, $directory, 'service', $os, 'riscv64', 'otherpkgs.pkglist'] }
qw(install netboot);
}
my $ubuntu_compute = [qw(openssh-server chrony gawk nfs-common snmpd)];
my $ubuntu_kvm = [qw(openssh-server ntp gawk nfs-common snmpd qemu-kvm
libvirt-bin bridge-utils libcap2-bin vlan tmux)];
for my $release (qw(20.04 22.04 24.04 26.04)) {
push @cases, ['install', 'ubuntu', 'compute', "ubuntu$release", 'aarch64',
'pkglist', "compute.ubuntu$release.pkglist", $ubuntu_compute];
}
for my $release (qw(12.04 14.04 16.04)) {
push @cases, ['install', 'ubuntu', 'kvm', "ubuntu$release", 'x86_64',
'pkglist', "kvm.ubuntu$release.pkglist", $ubuntu_kvm];
}
push @cases, ['install', 'ubuntu', 'compute', 'ubuntu26.04', 'riscv64',
'pkglist', 'compute.ubuntu26.04.riscv64.pkglist',
[qw(bash nfs-common openssl isc-dhcp-client libc-bin openssh-server
openssh-client wget vim rsync busybox-static gawk bind9-dnsutils chrony gpg)]];
for my $release (qw(24.04 26.04)) {
my @expected = qw(bash nfs-common openssl isc-dhcp-client libc-bin
linux-image-generic openssh-server openssh-client wget rsync
busybox-static gawk bind9-dnsutils tar gzip xz-utils cpio chrony);
push @expected, qw(util-linux-extra iproute2) if $release eq '24.04';
# genimage enters dracut mode only when the rootimg carries dracut. Every release
# needs it, because the legacy /init it falls back to is IPv4-only.
push @expected, qw(dracut dracut-network);
push @cases, ['netboot', 'ubuntu', 'compute', "ubuntu$release", 'riscv64',
'pkglist', "compute.ubuntu$release.riscv64.pkglist", \@expected];
}
for my $case (@cases) {
my ($kind, $directory, $profile, $os, $arch, $extension, $name, $expected_packages) = @$case;
my $base = "$prefix/share/xcat/$kind/$directory";
$name //= "$profile.$os.$arch.$extension";
$expected_packages //= $packages{"$kind/$profile"};
subtest "$kind/$directory/$name" => sub {
my $selected = $extension eq 'postinstall'
? xCAT::SvrUtils->get_postinstall_file_name($base, $profile, "$os.2", $arch)
: xCAT::SvrUtils::get_file_name($base, $extension, $profile, "$os.2", $arch);
is($selected, "$base/$name", 'retains the public profile filename');
ok(defined($selected) && -r $selected, 'selected asset is readable') or return;
my $mode = S_IMODE((stat($selected))[2]);
if ($extension eq 'postinstall') {
ok($mode & oct('100'), 'postinstall asset is executable by its owner');
} else {
is($mode & oct('111'), 0, 'data asset is not executable');
}
my $original = read_binary($selected);
my $custom = "$work/$name";
copy($selected, $custom) or die "copy $selected: $!";
is(read_binary($custom), $original, 'a custom copy contains the complete asset');
if ($extension eq 'otherpkgs.pkglist') {
is_deeply([xCAT::Postage::get_pkglist_records($selected)],
['xcat/xcat-core/xCATsn', 'xcat/xcat-dep/rh10/riscv64/goconserver'],
'the service node retains its architecture-specific packages');
}
if ($extension eq 'pkglist' && $expected_packages) {
is_deeply([xCAT::Postage::get_pkglist_records($selected)],
$expected_packages, 'retains package order and repeated entries');
}
};
}
my $site = xCAT::Table->new('site', -create => 1) or die 'Cannot create site table';
$site->setAttribs({key => 'installdir'}, {value => "$work/install"});
$site->close();
my $custom = "$work/install/custom/install/rocky";
make_path($custom);
my $name = 'compute.rocky10.riscv64';
copy("$prefix/share/xcat/install/rocky/$name.tmpl", "$custom/$name.tmpl") or die $!;
write_binary("$custom/$name.pkglist", "local-package\n");
my ($status, $error) = xCAT::SvrUtils->update_tables_with_templates(
'rocky10.2', 'riscv64', '/install/media', 'fixture');
is($status, 0, 'discovers the custom and shipped profiles') or diag($error);
my $images = xCAT::Table->new('linuximage') or die 'Cannot open linuximage table';
my $compute = $images->getAttribs({imagename => 'rocky10.2-riscv64-install-compute'}, 'template', 'pkglist');
is($compute->{template}, "$custom/$name.tmpl", 'image discovery prefers the custom template');
is($compute->{pkglist}, "$custom/$name.pkglist", 'image discovery prefers the custom package list');
is(xCAT::Postage::get_pkglist_tex($compute->{pkglist}), 'local-package',
'the selected custom package list reaches the package reader');
my $service = $images->getAttribs({imagename => 'rocky10.2-riscv64-install-service'}, 'template');
is($service->{template}, "$prefix/share/xcat/install/rocky/service.rocky10.riscv64.tmpl",
'a different profile still uses its shipped template');
$images->close();
my $rh_custom = "$work/install/custom/install/rh";
make_path($rh_custom);
my $rh_name = 'compute.rhels10.riscv64.tmpl';
my $shipped = read_binary("$prefix/share/xcat/install/rh/$rh_name");
write_binary("$rh_custom/$rh_name", $shipped . "\n# custom compute template\n");
($status, $error) = xCAT::SvrUtils->update_tables_with_templates(
'rhels10.2', 'riscv64', '/install/media', 'fixture');
is($status, 0, 'discovers the customized canonical profile and shipped alias') or diag($error);
$images = xCAT::Table->new('linuximage') or die 'Cannot open linuximage table';
$compute = $images->getAttribs({imagename => 'rhels10.2-riscv64-install-compute'}, 'template');
is($compute->{template}, "$rh_custom/$rh_name", 'image discovery selects the custom canonical profile');
$service = $images->getAttribs({imagename => 'rhels10.2-riscv64-install-service'}, 'template');
is($service->{template}, "$prefix/share/xcat/install/rh/service.rhels10.riscv64.tmpl",
'the service profile retains its shipped alias');
is(read_binary($service->{template}), $shipped,
'the shipped alias does not inherit the custom canonical profile');
$images->close();
done_testing();