Daniel Hilst
d8a01bcf15
The gating reg_linux_diskfull_installation_flat case cannot pass on Ubuntu: the compute node never reaches a booted, installed OS, and the case only ever reports "ssh: connect ... port 22: Connection refused". It is not one defect but a chain, each reachable only once the one before it is fixed. The installer never boots. Without boot=casper, casper never processes netboot=nfs -- it scans the local disks, finds no live media and panics "Unable to find a medium containing a live file system". nfsroot must also be a literal IP: casper mounts the live filesystem with klibc's nfsmount, which cannot resolve a hostname. And with the NFS root still mounted at end of install, systemd-shutdown blocks forever on an lvm/pvscan wedged in uninterruptible I/O on it, so the node never power-cycles into the disk it just installed. The installer has no usable DNS. A nameserver line in /etc/resolv.conf must hold an IP -- glibc's resolver discards a hostname written there -- so writing the xcatmaster name leaves the installer, and the in-target apt that inherits the file, hanging on archive.ubuntu.com. In-target apt cannot find its packages on classic-sources releases, because Subiquity renders the target sources.list from the install media alone. The node never leaves the installer. The boot flip to local disk goes through updateflag.awk, which needs gawk's |& /inet coprocess, but Ubuntu's /usr/bin/awk is mawk -- so the flip fails silently and the node reinstalls forever. And syncfiles runs inside the in-target chroot, asking the MN to scp files into a node that has no sshd yet, so it times out and the node reports failed on a good install. Cover each stage. All fail today. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test/unit
Unit tests. These run against the source tree only -- no xCAT installation, no running daemons, no management node.
They are executed on every pull request by the xcat_test GitHub Actions workflow,
which calls run_unit_tests() in github_action_xcat_test.pl:
prove -r xCAT-test/unit
You can run exactly the same thing from a clean checkout:
cd <xcat-core checkout>
prove -r xCAT-test/unit
What belongs here
A test belongs in unit/ when everything it needs is in the checkout: plugin and
library sources, kickstart/preseed/subiquity templates, postscripts, packaging
metadata. Such a test asserts on rendered output or module logic and reaches the
repository root through FindBin:
use FindBin;
use lib "$FindBin::Bin/../../perl-xCAT";
use lib "$FindBin::Bin/../../xCAT-server/lib/perl";
Because of those FindBin paths the tests only work from a source tree. The copy
installed under /opt/xcat/share/xcat/tools/autotest/unit is not a substitute --
../.. resolves to /opt/xcat/share/xcat/tools there and the tests die or silently
skip. The CI takes a copy of the checkout before the build for this reason; see
preserve_source_tree().
What does not belong here
Anything that needs an installed xCAT, a populated /install, a real service binary
or a live daemon. Those go in ../integration and run on
a management node through xcattest. Both suites run on every pull request -- the
workflow installs xCAT on the runner and then runs the ci_test cases against it --
so putting a test in integration/ does not cost it CI coverage. What differs is what
each suite is allowed to depend on, and that unit tests also run standalone from a
bare checkout with no xCAT at all.
The distinction matters because a test that needs an absent environment does not fail
-- it calls plan skip_all and reports as skipped. A handful of those in a suite of
several hundred assertions is easy to stop reading. Keeping the two kinds in separate
directories means a skip in unit/ is a real signal rather than routine noise.
Guarding on a source file, on the other hand, is fine and common here:
plan skip_all => "compute.subiquity.tmpl not found" unless -f $tmpl_path;
That guard never fires when the tree is intact.