2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-11-19 17:02:15 +00:00
Files
xcat-core/xCAT-test/lib/xCAT/Test/OS.pm
T
Daniel Hilst 837509f8cd fix(xcattest): a semicolon in a conf value truncates the chdef it builds
setup_env_by_configure_file built "chdef -t $type -o $name $attr=$value" and
runcmd passes that to bash. A value containing shell syntax was read as syntax.

vmothersetting separates its settings with a semicolon, so
"vmothersetting=cpumode:host-passthrough;firmware:efi-insecure" ended the chdef
at the semicolon. The node kept cpumode alone, mkvm defined the compute node
with no firmware, and it came up as a BIOS guest. A BIOS guest cannot network
boot over IPv6 and cannot load an EFI grub2, so the node took its DHCPv6 address
and never fetched a loader.

object_definition_command() and shell_quote() build the command with every value
quoted, and the chtab path for [Table_*] quotes its values the same way.

xCAT-test/unit/xcattest_object_quoting.t fails when the quoting is removed.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-28 12:13:02 -03:00

131 lines
3.7 KiB
Perl

package xCAT::Test::OS;
use strict;
use warnings;
#-----------------------------------------------------------------------------
=head1 NAME
xCAT::Test::OS - the operating system names xcattest matches a case against
=head1 DESCRIPTION
A test case declares the distributions it runs on in its C<os:> attribute, and xcattest compares
that list against the distribution it is running on. Both halves of the comparison live here, so a
distribution is named in one place and a unit test can call them.
=cut
#-----------------------------------------------------------------------------
#---
# =head3 linux_aliases
# Descriptions: the distributions a case's `os:Linux` stands for.
# Arguments: none
# Returns: the list of os names
#---
sub linux_aliases {
return qw(rhels sles ubuntu openeuler);
}
#---
# =head3 current_os
# Descriptions: the os name of the running system, in the spelling a case's `os:` attribute uses.
# Arguments: $root - a path prefix, for tests
# Returns: an os name, or undef
#---
sub current_os {
my ($root) = @_;
$root = '' unless defined $root;
if (-f "$root/etc/redhat-release") {
my $text = _slurp("$root/etc/redhat-release");
my ($major) = (defined($text) && $text =~ /(\d+)\.(\d*)/) ? ($1) : ('');
return "rhels$major";
}
return 'ubuntu' if -f "$root/etc/lsb-release";
if (-f "$root/etc/os-release") {
my $text = _slurp("$root/etc/os-release") // '';
return 'sles' if $text =~ /sles/;
if ($text =~ /^ID\s*=\s*"?openeuler"?\s*$/mi) {
my ($version) = $text =~ /^VERSION\s*=\s*"?([^"\n]+?)"?\s*$/mi;
my $release = _openeuler_release($version);
return defined($release) ? "openeuler$release" : 'openeuler';
}
return undef;
}
return 'sles' if -f "$root/etc/SuSE-release";
return 'aix';
}
#---
# =head3 _openeuler_release
# Descriptions: the release token openEuler's osimage names carry, from an os-release VERSION.
# Arguments: $version - the VERSION value of /etc/os-release
# Returns: a release token, or undef
#---
sub _openeuler_release {
my ($version) = @_;
return undef unless defined $version;
$version =~ s/^\s+|\s+$//g;
my ($release, $sp) = $version =~ /\A((?:20|22|24)\.03)(?:\s*\(LTS(?:-SP([1-9][0-9]*))?\))?\z/i
or return undef;
return $release . (defined($sp) ? "sp$sp" : '');
}
sub _slurp {
my ($path) = @_;
open my $fh, '<', $path or return undef;
local $/;
my $text = <$fh>;
close $fh;
return $text;
}
#-------------------------------------------------------
=head3 shell_quote
Descriptions: Quote a value so a shell passes it through unchanged.
Arguments: the value
Returns: the value in single quotes, with any single quote escaped
=cut
#-------------------------------------------------------
sub shell_quote
{
my ($value) = @_;
$value = '' unless defined $value;
$value =~ s/'/'\\''/g;
return "'" . $value . "'";
}
#-------------------------------------------------------
=head3 object_definition_command
Descriptions: The chdef command that defines one object from a conf section.
Attribute values are quoted, because a conf carries values a
shell would read as syntax: vmothersetting separates its
settings with a semicolon, which ends the command.
Arguments: the object type, the object name, a hash reference of attributes
Returns: the command
=cut
#-------------------------------------------------------
sub object_definition_command
{
my ($type, $name, $attrs) = @_;
my $cmd = "chdef -t $type -o $name";
foreach my $attr (sort keys %$attrs) {
$cmd .= " $attr=" . shell_quote($attrs->{$attr});
}
return $cmd;
}
1;