mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-11-19 17:02:15 +00:00
837509f8cd
setup_env_by_configure_file built "chdef -t $type -o $name $attr=$value" and runcmd passes that to bash. A value containing shell syntax was read as syntax. vmothersetting separates its settings with a semicolon, so "vmothersetting=cpumode:host-passthrough;firmware:efi-insecure" ended the chdef at the semicolon. The node kept cpumode alone, mkvm defined the compute node with no firmware, and it came up as a BIOS guest. A BIOS guest cannot network boot over IPv6 and cannot load an EFI grub2, so the node took its DHCPv6 address and never fetched a loader. object_definition_command() and shell_quote() build the command with every value quoted, and the chtab path for [Table_*] quotes its values the same way. xCAT-test/unit/xcattest_object_quoting.t fails when the quoting is removed. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>