The check that holds the whole security property of the split matched
`^allow (\w+) file_type:\w+ \w+;$` -- one unbraced permission and nothing
else. Every braced rule and every interface call passed it, so a grant of
filesystem-wide authority to xcat_t would not have been caught.
The pattern now reads both forms, and the named interfaces that grant the
same thing are asserted per domain: files_manage_all_files,
files_relabel_all_files, auth_manage_shadow, auth_relabel_shadow and
seutil_manage_file_contexts belong to xcat_image_t and not to xcat_t. One
check records what xcat_t does keep, and why.
Verified against the policy: a braced `allow xcat_t file_type:file { write
relabelto };` fails 1 check, and `files_relabel_all_files(xcat_t)` fails 2.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| Black-box service tests | xCAT-test/blackboxtest/ |
python3 -m unittest discover -s tests, then blackboxtest run <conf> on a management node |
| Native host tests | xCAT-test/native/*.t |
Explicit lab runs; see native/README.md |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
blackboxtest is the odd one out: its Python unit tests and blackboxtest validate run offline like the others, but its point is the third column --
asking a management node what a booting node asks (DHCP, DNS, TFTP, HTTP,
xcatd) and asserting on the answers. It talks to the services only as a client,
so it does not depend on which DHCP server answers or on the xCAT database.
See unit/README.md, bats/README.md and blackboxtest/README.md for the
detailed rules for each suite.