mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-21 16:39:30 +00:00
Daniel Hilst
69be7872f2
send_ddns_update signs the same packet on every attempt. Net::DNS appends the TSIG to the additional section, so the second attempt carries two TSIG records. named answers FORMERR to that message, which is neither NOTAUTH nor SERVFAIL, so the routine stops and reports FORMERR. The retry path can never be accepted. ddns_update_retry.t drives send_ddns_update with a resolver that answers FORMERR to a message with more than one TSIG record, as named does, and otherwise answers a scripted rcode. It asserts that every attempt carries exactly one TSIG record and the same update records, and that a retry answered NOERROR reports success. Both subtests fail before the fix. The header of each new test records that XCATROOT must name the tree under test, because xCAT::Table adds the installed /opt/xcat/lib/perl to @INC. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.