2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-11-20 09:22:17 +00:00
Files
xcat-core/xCAT-test/lib
Daniel Hilst 3fbf0b2a85 fix(xcat-test): a conf value is cut at its first semicolon
The value class of the conf parser held ':' and '/' and not ';', so
"othersettings=cpumode:host-passthrough;firmware:efi-secureboot" was read as
"cpumode:host-passthrough" and the rest was dropped with no warning. chtab
wrote the row with the first setting alone, and the node was defined without
the firmware it needs to boot over IPv6. The [Object_*] branch had the same
class and the same effect on vmothersetting.

The chtab command was also built by interpolation, with the row selector
unquoted, so a row name or a key carrying shell syntax would have ended the
command. chdef left its type and object name unquoted for the same reason.

parse_conf_assignment is now the one place the class is written, for both
section kinds. table_row_command builds the chtab command with every argument
quoted, the row selector among them, and object_definition_command quotes its
type and name.

xcattest_object_quoting.t asserts the argument list each command delivers, not
only its text, so a quoting change that splits an argument is caught. Removing
';' from the class fails the one check that names a semicolon value and leaves
the other fifteen passing.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-30 13:17:39 -03:00
..