The value class of the conf parser held ':' and '/' and not ';', so "othersettings=cpumode:host-passthrough;firmware:efi-secureboot" was read as "cpumode:host-passthrough" and the rest was dropped with no warning. chtab wrote the row with the first setting alone, and the node was defined without the firmware it needs to boot over IPv6. The [Object_*] branch had the same class and the same effect on vmothersetting. The chtab command was also built by interpolation, with the row selector unquoted, so a row name or a key carrying shell syntax would have ended the command. chdef left its type and object name unquoted for the same reason. parse_conf_assignment is now the one place the class is written, for both section kinds. table_row_command builds the chtab command with every argument quoted, the row selector among them, and object_definition_command quotes its type and name. xcattest_object_quoting.t asserts the argument list each command delivers, not only its text, so a quoting change that splits an argument is caught. Removing ';' from the class fails the one check that names a semicolon value and leaves the other fifteen passing. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| Black-box service tests | xCAT-test/blackboxtest/ |
python3 -m unittest discover -s tests, then blackboxtest run <conf> on a management node |
| Native host tests | xCAT-test/native/*.t, xCAT-test/native/*.bats |
Selected CI cases and explicit lab runs; see native/README.md |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
blackboxtest is the odd one out: its Python unit tests and blackboxtest validate run offline like the others, but its point is the third column --
asking a management node what a booting node asks (DHCP, DNS, TFTP, HTTP,
xcatd) and asserting on the answers. It talks to the services only as a client,
so it does not depend on which DHCP server answers or on the xCAT database.
See unit/README.md, bats/README.md and blackboxtest/README.md for the
detailed rules for each suite.