xcatroot writes the netplan of the booted system from the interface it found,
and it always wrote "dhcp4: true". An IPv6-only node has no DHCPv4 server, so it
reached its login prompt with no address: Ubuntu 24.04.5 reported
"[FAILED] Failed to start systemd-networkd-w... Wait for Network to be
Configured." and "[FAILED] Failed to start xcatpostinit.service", and the node
answered no ssh.
The address is already on the kernel command line, in the static form dracut
takes. xcat_static_ip6_fields reads it and the netplan carries the address, the
prefix and a default route through the gateway. A node whose command line holds
an IPv4 form keeps dhcp4, because the fields are read only from a bracketed
literal.
Captured by xCAT-test/bats/ipv6_xcatroot_netplan.bats. Reading the fields by
cutting on the first colon, which is what an IPv6 literal breaks, fails the
three parsing assertions and leaves the four refusals passing.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mknetboot gave an IPv6-only node ip=either6, which asks dracut for DHCPv6.
DHCPv6 assigns one address with a prefix length of 128 and carries no route, and
an xCAT provision network sends no router advertisement: radvd is not installed
and net.ipv6.conf.<nic>.forwarding is 0. The node came up with the address and
no way to reach the server, and the dracut hook reported
"Connecting to [2001:db8:147::1]:80... failed: Network is unreachable."
debian.pm now builds the static form from the address, gateway and prefix the
node already has in the database, the way sles.pm passes hostip and gateway to
linuxrc. either6 remains the answer when the address cannot be resolved.
Captured by xCAT-test/unit/dracut_static_ip6.t. Removing the prefix length from
the parameter fails four of its nine assertions and leaves the bracketing and
the refusal cases passing.
Measured on an IPv6-only Ubuntu 24.04 node: Kea records prefix_len=128 for its
lease, and dracut logged BOUND6 for eth0 before the fetch failed.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
grub2_kernel_commands read the image and not the architecture, so a ppc node
whose grub2 image carries linuxefi was given it. linuxefi loads an EFI binary
and a ppc loader is not one. The previous commit removed the architecture test
along with the defect it carried.
The command now needs both: the architecture whose loader is an EFI binary, and
an image that carries the command.
grub2_netboot_protocol.t covers the three architectures and caught this. Its
loader fixture now records the commands it carries, because the configuration
follows the image.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
grub2.pm chooses the kernel command from the architecture of the node, so every
x86 node is given linuxefi and initrdefi. Those two come from a downstream patch
and an image built from upstream grub carries neither.
These assertions fail without the fix that follows: the upstream image, the
missing image and the undefined image are all answered with linuxefi.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
format_host_port validates its host with format_uri_host, which refuses
'!myipfn!' because it is not a host name. The call returns undef, so a command
line built from it loses both the server and the port.
These assertions fail without the fix that follows: format_host_port and
format_uri_host return nothing for the placeholder, and the imgurl built from it
reads "imgurl=http:///install/..." for an IPv6 and an IPv4 facing address alike.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The search list added in the previous commit carried no config:type, and the
AutoYaST schema gives searchlist the LIST type, the way it gives it to
nameservers. xmllint against profile.rng of Leap 15.6 reports only "Element
profile failed to validate content", and YaST refuses the profile entirely, so
the node cannot install at all.
searchlist is now emitted as a typed list. Measured against
/usr/share/YaST2/schema/autoyast/rng/profile.rng on a live management node: the
generated profile fails to validate, the same profile with the attribute added
validates, and removing hostname as well changes nothing, so hostname was not
the element at fault.
Captured by xCAT-test/unit/autoyast_ipv6_network.t, which gained an assertion on
the attribute.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
_autoyast_network6 sets dhcp_hostname to false, because an IPv6-only node has no
DHCPv4 to take a hostname from, and it writes no hostname of its own. YaST then
has nothing to set: y2log of an installed node records Y2Network::Hostname with
@static=nil, @transient=nil and @dhcp_hostname=:none, and the node answers
"localhost". The two sibling builders in the same file write both keys.
The dns section now carries the node name and a search list of the node domain.
getNodeNetworkCfg6 already returns the name, so no new lookup is needed.
Captured by xCAT-test/unit/autoyast_ipv6_network.t. Without the two keys its
assertions 17 and 18 fail and the other 16 pass.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
pre.sle substitutes the install server for XCATNEXTSERVERHOOK in the media_url
that xCAT::Template writes for every install source. The substitution read
sed -e 's!XCATNEXTSERVERHOOK!'$nextserver'!', with the value unquoted, and
shopt -s nullglob is set earlier in the same script. An IPv6 server is bracketed,
so "[2001:db8::1]" is a glob that matches no file and the whole sed script word
is removed. sed then reads the profile as its script and writes nothing, so
/tmp/profile/modified.xml is empty. AutoYaST falls back to the unmodified profile
and stops on "Disk 'XCATPARTITIONHOOK' was not found", because the pre-script
also substitutes the install disk into that profile.
The substitution moves into substitute_nextserver, which quotes the value. An
IPv4 server was never affected, because it carries no bracket.
Captured by xCAT-test/bats/ipv6_pre_sle_nextserver.bats. With the quotes removed
again, assertions 9 and 10 fail and the IPv4 assertion 11 still passes.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
site.nameservers holds one list for the whole cluster, so an IPv6-only node takes the
IPv4 resolver of an IPv4 network when its own network names none. The AutoYaST profile
of a Leap 15.6 node carried <nameserver>192.168.156.1</nameserver> while the node had
no IPv4 address at all.
An unreachable server in resolv.conf is not a failure the node reports. Every lookup
waits for its timeout before the next server is tried.
The test adds a node whose configured resolvers are IPv4 only and asserts the section
carries none of them, and that the gateway stands in.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
post.sles.common reads MANAGEDADDRESSMODE and, for anything but static, removes the
interface configuration and writes a new one with BOOTPROTO=dhcp. managed_address_mode
returns site.managedaddressmode, which describes the cluster.
An IPv6-only node therefore has the static IPv6 configuration in its AutoYaST profile
rewritten to DHCP during the post phase, and comes up with a link-local address only.
The node has no IPv4 address to ask a DHCP server for, so the site attribute cannot
answer for it.
The test renders MANAGEDADDRESSMODE for three nodes with the site attribute set to
dhcp: an IPv6-only node, an IPv4 node and a dual-stack node. Only the IPv6-only node
is expected to differ, so the other two hold the site behaviour down.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
An Ubuntu diskless node brings its interface up from the dracut ip= parameter.
debian.pm appends ifname, netdev and BOOTIF and no ip= at all, and dracut configures
the interface it needs with DHCPv4 when the command line carries none. An IPv6-only
node therefore gets no address, cannot fetch imgurl and never mounts a root.
gen_net_boot_params already derives the interface in xCAT's own order and returns the
IPv4 spelling of the parameter. The test asserts the IPv6 spelling beside it for every
branch that names an interface, and asserts the IPv4 spelling is unchanged, because
anaconda.pm is its only caller today.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The assertions added with this test required Socket6 and IO::Socket::INET6 on every
RPM family, which contradicts xcat_server_inet6_optional_dependency.t and the reason
it records: every call site loads the modules with an eval and keeps working on IPv4,
so a hard dependency states a dependency the code does not have.
The measurement that prompted the test still holds, and it is narrower than it looked.
Both modules are absent on a Leap 15.6 management node because the openSUSE Minimal-VM
image sets solver.onlyRequires = true in /etc/zypp/zypp.conf, so zypper installs no
recommended package. dnf installs one, so EL and openEuler need no hard dependency.
The test now reads requires and recommends separately per family: openSUSE requires
both and recommends neither, EL and openEuler recommend both and require neither. The
deb control files are read per package, since perl-xCAT has carried a hard dependency
since before this rule. xcat_server_inet6_optional_dependency.t gains a pointer to the
openSUSE exception so the two files do not disagree in prose.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
pre.sle and pre.sles read the install server out of the kernel command line and put
it back into a URL. pre.sle substitutes it for XCATNEXTSERVERHOOK in the media_url of
every install source, and pre.sles substitutes it into #INSTALL_SOURCES_IN_PRE#.
The derivation cut the authority at the first colon. An IPv6 install server written
"autoyast=http://[2001:db8::1]:80/install/autoinst/node01" yielded "[2001", so the
media_url read "http://[2001:80/install/..." and YaST had no install source. A
portless IPv4 URL kept its path as well, and worked only because xCAT always writes
a port.
The test runs the derivation taken from each script against a command line of its
own, so a change to the derivation is measured here.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT::SLP, xCAT::IPMI, xCAT::Client, xCAT::NetworkUtils and the dhcp, nodestat and
credentials plugins reach IPv6 only through Socket6 and IO::Socket::INET6. Each one
loads them with eval { require ... }, so a missing module is not an error. The guard
variable stays false and the IPv6 branch is never taken.
No family declares the dependency. perl-generators reads a use statement, not a
require inside an eval, so the EL build derives no perl(Socket6) either, and
xCAT-server lists the two deb packages as Recommends, which apt 3.0 solver3 can drop.
The test asserts both specs require both modules on openSUSE, EL and openEuler, and
that both deb control files name them in Depends.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
AutoYaST keeps the network the installer used unless keep_install_network says
otherwise, and the sections _autoyast_network6 replaces set it true. The static
interface in the generated section was therefore ignored.
The test asserts the section sets keep_install_network to false.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
AutoYaST validated the generated profile and reported "Extra element networking
in interleave", then told the operator no profile could be retrieved. The
element is dhcp_resolv, which the schema of Leap 15.6 does not accept.
The test asserts the section has no dhcp_resolv and keeps dhcp_hostname, which
the schema does accept.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
sles.pm put only the net device on the command line, so linuxrc configured IPv4
by default. An IPv6-only node sent an IPv4 DHCPDISCOVER, which the management
node answered "no free leases".
The test covers the arguments for a node with a gateway and an IPv6 nameserver,
for one with neither, that an IPv4 nameserver is left out, and that a node with
no IPv6 configuration gets no arguments.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
addrangedetection keys the dynamic ranges on networks.net, which carries no
prefix length. addnet6 names a subnet "<net>/<prefix>" and looked the range up
under that, so the lookup missed every IPv6 subnet.
The test drives the lookup with both forms of the subnet and holds down that an
IPv4 subnet is unchanged.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
setup_env_by_configure_file built "chdef -t $type -o $name $attr=$value" and
runcmd passes that to bash. A value containing shell syntax was read as syntax.
vmothersetting separates its settings with a semicolon, so
"vmothersetting=cpumode:host-passthrough;firmware:efi-insecure" ended the chdef
at the semicolon. The node kept cpumode alone, mkvm defined the compute node
with no firmware, and it came up as a BIOS guest. A BIOS guest cannot network
boot over IPv6 and cannot load an EFI grub2, so the node took its DHCPv6 address
and never fetched a loader.
object_definition_command() and shell_quote() build the command with every value
quoted, and the chtab path for [Table_*] quotes its values the same way.
xCAT-test/unit/xcattest_object_quoting.t fails when the quoting is removed.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xcattest applies the [Object_*] sections of a conf by joining each attribute to
a chdef command and running it through bash. Nothing quoted the values, and a
conf carries values a shell reads as syntax.
The test builds the command for a vmothersetting that holds two settings and
asserts the semicolon stays inside one command, that every value is quoted, and
that bash passes the whole value through as one argument.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
dhcp6_bootfile_url_for_node builds the RFC 5970 option 59 URL for both DHCP
backends, and each backend already had its own assertions on it. Neither
compared them, so the two could drift apart and both files would stay green.
The new block renders the same node through kea_build_node_reservations6 and
through the ISC omshell session and asserts the URL is the same string, that Kea
marks it always-send, and that a node asking for xnba gets none from either
backend.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT.spec requires the file /usr/sbin/in.tftpd. Two openSUSE packages provide
it, and atftp has no IPv6 option at all.
The test asserts openSUSE asks for the tftp package by name and no longer leaves
a file dependency atftp can satisfy, and that EL keeps the file dependency it
resolves to tftp-server.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Template.pm built the media_url of each add-on product from the noderes
substitution, which writes the address of the management node as it stands. An
IPv6-only node was told to install from "http://2001:db8::1//install/...".
The test covers the IPv6-only URL on the default port and on a custom port, and
holds down that a node with IPv4 keeps the substitution.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
grub2.pm replaces !myipfn! with the facing address of the management node. The
placeholder stands in front of ":$httpport" in the install URLs, so an IPv6
address was substituted bare and the authority could not be read.
grub2_ipv6.t now exercises setstate with a kcmdline that carries the placeholder
inside an install URL. sles_install_url_ipv6.t asserts the substitution itself
against the real module, in both contexts: bracketed where a port follows, bare
where none does.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
sles.pm joined the install server and the port with a colon, so an IPv6
management node produced "install=http://2001:db8:156::1:80/install/...". That
authority cannot be split into an address and a port.
The test covers the diskful autoyast= and install= arguments, the statelite and
stateless imgurl=, and the authority helper the three share.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
dhcp.pm derived the DHCPv6 configuration file only inside the branch that
switches the DHCPv4 file to /etc/dhcp/dhcpd.conf. openSUSE ships /etc/dhcpd.conf,
so that branch never ran and the v6 file stayed undef.
The test asserts the v6 file for each layout ISC uses, that an AIX file yields
none, and that the module derives the v6 file from the v4 file it chose.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xcatd also fails to start on openSUSE, on Date::Parse, which xCAT-server ships in
xcatd.pm. The test named perl-xCAT alone, so that gap was not captured.
The expected capabilities are now a table keyed by spec, and xCAT-server is in
it. The set comes from comparing every perl() capability the EL build generates
against what a Leap 15.6 management node can resolve: of 88, only these five are
required and absent.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
perl-xCAT.spec carries no Requires and relies on the automatic Perl dependency
generator. EL has perl-generators and derives 99 perl() requires from the module
sources. openSUSE has none, so the built rpm requires only /bin/sh.
The test reads the Requires of perl-xCAT with rpmspec for openSUSE and for EL10.
On openSUSE it expects the four modules a Leap node does not otherwise carry. On
EL it expects none of them, because perl-generators derives them there.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
opensuse_pod2man_buildrequires.t called BAIL_OUT when rpmspec exited non-zero.
prove stops every remaining file on a bail-out, not only the one that called it,
so one unreadable spec would hide the result of the rest of the suite.
The close failure now dies, which fails that file alone.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
openSUSE ships DB_File in perl-core-DB_File. The spec asks for perl-DB_File on
every platform below EL10, so zypper refuses the transaction with "nothing
provides 'perl-DB_File' needed by the to be installed xCAT-server" and the
management node cannot install xCAT.
The test reads the Requires of xCAT-server with rpmspec for openSUSE, EL9 and
EL10. On openSUSE it expects the perl(DB_File) capability and no perl-DB_File
package name. The EL assertions hold the existing behaviour down: EL9 keeps the
hard package requirement, EL10 keeps none.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-buildkit, xCAT-client, xCAT-test and xCAT-vlan failed in %build with
"pod2man: command not found", and buildrpms.pl then refused to index a partial
repository, so there is no openSUSE core repo to install from at all.
An openSUSE build root installs only perl-base, which does not ship pod2man, and
xpod2man runs it. The four specs guarded "BuildRequires: perl-Pod-Html" with
"%if !0%{?suse_version}" and declared nothing in its place, so openSUSE had no
requirement that brings the tool in. They now require the full perl package there.
This is not an IPv6 defect. xCAT-vlan and xCAT-buildkit carry no change on this
branch and fail the same way, so the gap predates it; it is fixed here because it
stands between the branch and any openSUSE test.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Nothing asserted that the specs whose %build runs xpod2man declare something that
ships pod2man on openSUSE. The test reads the BuildRequires of each one for
openSUSE and for EL, so the EL side is held unchanged beside it.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
subiquity_boot_params now asks whether the node has an IPv4 address, and this
test's xCAT::NetworkUtils stub had no node_is_ipv6_only, so the extracted routine
died at the call and the file reported no plan rather than a failed assertion.
The stub answers that the node has an IPv4 address, which is what every case here
describes. The refusal itself is covered in debian_subiquity_boot_params.t.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The test never asked what subiquity_boot_params does for a node with no IPv4
address. The new cases assert that such a node is refused, that the message names
the node and the component without IPv6 support, and that a node which has an IPv4
address is unaffected.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
grub2_ipv6.t drove setstate with a command line that has no placeholder, so the
lookup that resolves it was never exercised. The new cases assert the placeholder
becomes the IPv6 facing address and that the IPv4-only lookup, which reports the
node unresolvable, is not used. The IPv4 case beside it holds that path unchanged.
An earlier version of the assertion counted IPv6 facing calls, which the tftpserver
lookup in the same run already makes, so it passed with the defect in place.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The setting accepted one value, efi, and nothing covered what a guest then asks of
Secure Boot. The test holds down which values the setting accepts, what each one
asks, and the guest XML each one produces, including that a guest which does not
ask for EFI gains no firmware element.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
post.xcat.rhels10 builds XCATSERVER with format_host_port and the other two copies
wrote "$MASTER_IP:3001". The test drives each script's own format_host_port and
asserts that no copy interpolates the address unbracketed.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
post.xcat.rhels10 brackets the management node address before it goes in a URL and
the other two copies did not, and nothing held the three to each other.
The test drives each script's own format_uri_host with one table, and asserts that
no download URL in them interpolates MASTER_IP unbracketed.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The DHCPv6 half of makedhcp had no test for the boot file, the DHCPv6 service or
the sysconfig file, so a node could be given its reserved address with nothing to
load and the suite stayed green.
The test drives the ISC path of makedhcp and asserts that every DHCPv6 host it
creates carries a bootfile-url naming the grub2 loader, that a node with
netboot=xnba gets none, that the DHCPv6 daemon is restarted, and that a missing
/etc/sysconfig/dhcpd6 is not reported as an error.
The harness now names the operating system instead of reading the host it runs
on. Both sysconfig branches depend on it, so without this the test exercised
whichever branch the build host happened to take, and the error assertion passed
with the defect in place. It also stubs restartservice, which the harness
previously let through to the services of the build host.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
sles.pm matched ipv6 nowhere in 2801 lines and the SUSE templates wrote
"<bootproto>dhcp</bootproto>" directly, so an IPv6-only SUSE node had no way to configure its
installer: DHCP cannot serve it, and SUSE has no static handoff on the kernel command line.
_autoyast_network6 builds the networking section of such a node, with a static interface, the
address of the node and a prefix length, which is what AutoYaST takes for IPv6 instead of a
netmask, and a default route carrying the IPv6 gateway.
The #YAST2NET6# directive chooses between that and the DHCP block the templates carried. An IPv4
node gets that block unchanged, which is why the existing #YAST2NET# was not used: its DHCP arm
renders something else, and leap15.6 is a gating cell. compute.leap15.tmpl and compute.sle15.tmpl
take the directive.
autoyast_ipv6_network.t covers the section. Emitting a netmask instead of a prefix length fails 2
of its 11 assertions. The IPv4 output of the directive was compared with the text it replaced and
is identical.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
root=nfs:, XCAT=, xcatd= and imgurl=http:// all separate the server from what follows with a
colon, so an IPv6 address in any of them cannot be told from the path or the port. Eight sites
built those values by interpolation, and a diskless, statelite or cloned node of any family took
a command line its initrd could not parse.
build_statelite_nfsroot_parameter brackets the server, which covers the NFS root of all three
netboot plugins at once. debian.pm and sles.pm now build the XCAT endpoint and the image URL
through xcatd_cmdline_address and format_host_port, as anaconda.pm already did for the install
path, and the mksysclone endpoint of anaconda.pm and sles.pm goes the same way.
destiny.pm had a third xcatd= site. The earlier change covered the two genesis branches and left
the legacy nbk branch interpolating the address.
nfs_root_options.t asserts the bracketed form, the IPv4 form and the mount options after a
bracketed address. Removing the brackets fails 2 of its 80 assertions and leaves the IPv4 and the
name cases passing.
zvm.pm carries the same pattern and is left alone: z/VM has no IPv6 netboot path to test it on.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
makedhcp builds a DUID-UUID from vpd.uuid and the reservation carries one identifier, but no
network manager derives that identifier in the byte order the firmware sends. NetworkManager has
no option for the SMBIOS UUID at all, and systemd-networkd's DUIDType=uuid uses the decoded
product UUID, which is the other order. So a node whose installed OS speaks DHCPv6 matched no
reservation and took a pool address.
configdhcpv6duid writes the identifier for whichever renderer the node has: the whole DUID for
NetworkManager, and the type by name with the sixteen bytes alone for systemd-networkd, which
composes the two. It is in the default postscript list for Linux, after remoteshell. AIX has
neither renderer and keeps its list.
A diskless or statelite node needs nothing: its address comes from the kernel command line and
configeth writes dhcp6: false, so its image sends no DHCPv6 request.
postscript_dhcpv6_duid.bats pins both forms to the literal the two Genesis images already use,
so the four copies of the byte swap cannot drift apart, and asserts the node fails loudly when
it has no renderer. postscript_dhcpv6_duid_registered.t holds the registration down: dropping it
fails 3 of its 7 assertions.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mknetboot excluded a statelite node from the static IPv6 address with no reason recorded, and
mksysclone had no IPv6 code at all. Both reach the same dracut networking as a diskless node, so
both asked DHCPv6 with the identifier their initrd generates. A reservation matches one
identifier, so the node took a pool address and no boot URL.
Statelite now takes the same path as diskless, and mksysclone renders the address beside the
Genesis kernel it boots.
anaconda_ipv6_statelite_sysclone.t drives both commands against a SQLite fixture. Restoring the
statelite guard fails one of its six assertions and removing the mksysclone block fails another,
while the diskless assertion survives both, so the gate did not move for diskless.
debian.pm records why the Ubuntu live filesystem is mounted over IPv4. The comment blamed casper,
which passes nfsroot= through untouched; klibc nfsmount is what cannot read an IPv6 server.
Measured on noble: "[2001:db8::1]:/export" and "2001:db8::1:/export" both answer "need a path",
while "192.0.2.1:/export" is accepted.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The static IPv6 boot path was gated on is_el10_os, which tests the basename against
rh|centos|alma|rocky|ol and the major version against 10 exactly. openEuler reaches the same
kickstart and dracut code through #KICKSTARTNET#, but the predicate answered 0 for it, so an
openEuler node fell to "dhcp --device=X --noipv4 --ipv6=dhcp". Its installer then sent the DUID
that NetworkManager generates, which matches no reservation, and the node took a pool address.
The same equality left a later EL release on the DHCPv6 path for no reason.
SvrUtils::uses_static_ipv6_boot names the capability instead of a version: openEuler of any
release, and EL from 10 upwards. The three gates in Template.pm and anaconda.pm read it, and the
variable that carried the answer is no longer called el10_ipv6_only. is_el10_os keeps its own
tests and its one remaining meaning.
anaconda_ipv6_rendering.t asserts the predicate per family. Removing the openEuler arm fails 2
of its 38 assertions and leaves 36 passing.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
configeth guarded the route with "[ a ] -a [ b ]", which is not a shell operator. bash reported
"[: too many arguments" and took the else path on every run, so /etc/sysconfig/network/routes
never received the IPv6 default route of a SUSE node and nothing said so.
The duplicate check behind that guard spelled the character class "[:space:]", which is a
bracket expression matching one of those six characters. It found no route already present, so
fixing the guard alone would have appended the route on every run of the postscript.
The two tests are now a valid shell condition and a correct class, and the logic moved into
add_suse_ipv6_default_route so it can be read without an installed node.
ipv6_configeth_suse_route.bats covers both faults separately. Restoring the operator fails 4 of
its 7 cases, one of which asserts that bash reports nothing on stderr; restoring the class fails
only the case that runs the postscript three times and expects one route.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
getzonesfornet in dhcp.pm rounded the prefix itself and passed the rounded value beside a
network that still carried its own. getIPv6PrefixLength prefers the embedded prefix, so the
rounded value was ignored and no reverse zone was written at all: dhcpd updated no PTR record
for a /62 or /126 network and reported nothing. The ddns.pm copy stripped the prefix first and
was unaffected, so the previous commit's claim that both copies were fixed was wrong.
The zones now come from xCAT::NetworkUtils::getIPv6ReverseZones, which both copies call. A
network whose prefix is not a multiple of 4 is covered by the zones of the next nibble -- a /62
by its four /64 zones -- which is what the IPv4 arm does with a /22. Rounding down to the /60
made xCAT answer for three networks it does not own.
kea_subnet_id_numeric.t only observes the encoding under the XS backend, and passed 6 of 6
under JSON::PP with the bug in place. It skips unless JSON->backend is the XS one, and the
workflow installs libjson-xs-perl so the backend is there.
dhcp6_boot_server now reports a substituted boot server, so an unresolvable tftpserver is not
silent, and the caller reports a warning that arrives with a server. The routine also moved
below grub2_node_loader, whose comment it had separated from it.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Both Genesis images built a DUID-UUID from the nil SMBIOS UUID. makedhcp refuses that UUID,
because nodeimport writes it to every PowerKVM node, and reserves the hardware address instead,
so the client sent an identifier no reservation held and the node took a pool address with no
boot file. genesis-duid and doxcat now keep the DUID-LL for it, which is what Kea reads the
hardware address out of.
getzonesfornet died on an IPv6 prefix that is not a multiple of 4, which took makedns and
makedhcp with it for a /62 or a /126 network. A reverse zone is delegated on a nibble, so the
prefix is rounded down and the enclosing zone is returned. Both copies of the routine are fixed.
The test suite needs socat and jq, and five bats files skipped without them, so the workflow
installs both. Template.pm drops the unused _is_el10, credentials.pm drops a repeated import,
and two comments that recorded bug history are cut to the fact the code cannot show.
Reverting any one fix fails named assertions: 1 of 8 and 1 of 3 bats cases for the two Genesis
images, and 4 of 30 in ddns_ipv6.t, which traps the abort so the file still reports.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
makedhcp reported a vpd.uuid that looks byte-swapped for duid=firmware and duid=canonical as
well as for a node with no duid attribute. Setting duid is the remedy the message names, so the
message could not be silenced except by a literal DUID. The check reads the version field, which
also reports a UUID that does not follow RFC 4122. It is now reported only for a node with no
duid attribute, and makedhcp.8 says so.
delnode removed only the lines of the family of the address it was given. A node whose address
changed from IPv4 to IPv6 kept its old A record, and makedhcp then wrote a DHCPv4 reservation
with a boot file for a node whose only address was IPv6. The family filter stays on the update
path, which is what keeps both records of a dual-stack node.
dhcp_dhcpv6_duid.t asserts that each duid value silences the report and that the default still
makes it. makehosts_dual_stack.t asserts a family change followed by a delete. Reverting either
fix fails exactly one assertion in each file.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
kea_subnet_id_numeric.t copied the dedupe-key expression into the test and asserted on the copy.
It never loaded xCAT::DHCP::Backend::Kea, so restoring the aliasing map in the module left the
test passing 4 of 4. It measured Perl, not the product.
The test now calls live_upsert_reservations through an injected control_agent_handler, as
dhcp_kea_renderer.t does, and asserts on the body that encode_config produces, which is what the
HTTP path sends. With the aliasing map restored, 3 of its 6 assertions fail and 3 pass.
xcattest also carries the value class for a [Table_*] line. It was [\w\.\-], so a value of
"2001:db8:176::" matched "2001" and the row was written with that value, and "/64" matched
nothing. The class is now the one [Object_*] already uses. A ';' is deliberately left out:
setup_env_by_configure_file builds a shell command from these values.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
makedhcp_dhcpv6_dual_stack_boot_server defined its network and went straight to
makedhcp <node>. A reservation only reaches a subnet that kea-dhcp6.conf already carries, so
makedhcp skipped the node with "Unable to find a Kea DHCPv6 subnet", exited 0, and the case
asserted an empty bootfile-url against the expected one. The run reported the case as failing
for the wrong reason, and an assertion on the exit status alone would have passed.
The case now runs makedhcp -n after makehosts, as makedhcp_dhcpv6_boot_intent does, and asserts
two things the earlier version could not tell apart: that the subnet is in the configuration, and
that the node has exactly one reservation. A skip now fails on the reservation count rather than
on the URL.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>