The DHCPv6 half of makedhcp had no test for the boot file, the DHCPv6 service or the sysconfig file, so a node could be given its reserved address with nothing to load and the suite stayed green. The test drives the ISC path of makedhcp and asserts that every DHCPv6 host it creates carries a bootfile-url naming the grub2 loader, that a node with netboot=xnba gets none, that the DHCPv6 daemon is restarted, and that a missing /etc/sysconfig/dhcpd6 is not reported as an error. The harness now names the operating system instead of reading the host it runs on. Both sysconfig branches depend on it, so without this the test exercised whichever branch the build host happened to take, and the error assertion passed with the defect in place. It also stubs restartservice, which the harness previously let through to the services of the build host. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| Black-box service tests | xCAT-test/blackboxtest/ |
python3 -m unittest discover -s tests, then blackboxtest run <conf> on a management node |
| Native host tests | xCAT-test/native/*.t, xCAT-test/native/*.bats |
Selected CI cases and explicit lab runs; see native/README.md |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
blackboxtest is the odd one out: its Python unit tests and blackboxtest validate run offline like the others, but its point is the third column --
asking a management node what a booting node asks (DHCP, DNS, TFTP, HTTP,
xcatd) and asserting on the answers. It talks to the services only as a client,
so it does not depend on which DHCP server answers or on the xCAT database.
See unit/README.md, bats/README.md and blackboxtest/README.md for the
detailed rules for each suite.