2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-11-20 17:32:15 +00:00
Commit Graph

876 Commits

Author SHA1 Message Date
Daniel Hilst 4b891e59d3 test(xcat-core): capture the drift the policy package does not repair
%posttrans relabels /install and nothing else, so a path under /opt/xcat
whose label was wrong before an upgrade stays wrong: rpm does not relabel a
directory that already exists. Measured on xcat163-mn-tmp-286, where
/opt/xcat/probe/subcmds/bin kept usr_t through the upgrade that fixed its
packaging, and only took bin_t once rpm created it.

xcat_selinux_package.t now asserts that %posttrans relabels /opt/xcat as
well. 1 of its 75 checks fails on this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-15 15:15:38 -03:00
Daniel Hilst e2bae62e61 test(xcat-core): capture the probe directory no package owns
/opt/xcat/probe/subcmds/bin is created by the %post of xCAT-probe, so no
package owns it. A directory a scriptlet creates takes the context of its
parent, usr_t, and not the bin_t that the policy gives /opt/.*/bin, and
nothing relabels it afterwards. Measured on xcat163-mn-tmp-286:

    restorecon -n -v -R /opt/xcat
    Would relabel /opt/xcat/probe/subcmds/bin from
      unconfined_u:object_r:usr_t:s0 to unconfined_u:object_r:bin_t:s0

It is the only path under /opt/xcat whose label does not match the policy.
The directory is in use: xcatprobe:263 drops a switchprobe symlink in it,
and xCAT-probe/debian/dirs already packages it on Debian.

xcat_probe_package_payload.t asserts that %install creates it, that %post
does not, and that the Debian package keeps it. 2 of its 4 checks fail on
this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-15 12:06:01 -03:00
Daniel Hilst 078f607448 feat(xcat-core): build the image in a domain of its own
The policy granted xcat_t everything the image build needs, so the domain
that listens on the xcatd port could also write and relabel a file of any
type. The rules were one per target type, 558 of them from the measured
denials, and 85 per cent of those repeated one of 58 permission patterns.

xcat.te now carries two domains. xcat_image_t is entered through
/opt/xcat/bin/genimage and the per-OS genimage program, from xcat_t and
from the administrator, and it holds the filesystem-wide manage and relabel
grants: the build creates an operating system tree, and the kernel cannot
tell a path inside that tree from the same type on the management node.
xcat_t keeps the daemon surface -- its sockets and ports, /install,
/tftpboot, /etc, the credentials, the service class for the units it
restarts -- and no grant over the file_type attribute.

The rules are Reference Policy interface calls where one exists:
domain_read_all_domains_state replaces 93 of them, dev_getattr_all_chr_files
31, files_read_etc_files, auth_read_shadow, seutil_read_config,
logging_send_syslog_msg, fs_mount_all_fs and corecmd_exec_bin the rest. The
module is 203 statements where the generated set was 806 rules.

packimage and liteimg are symlinks to xcatclientnnr, so their work runs in
the xcatd plugin and the tree authority stays in xcat_t with them. It can
move to xcat_image_t when the plugin execs a helper instead.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-15 02:28:20 -03:00
Daniel Hilst 52605e3959 test(xcat-core): capture the missing image-build domain
The image build creates an operating system tree, so it writes and relabels
files of every type the packages own. xcat_t holds that authority today, and
the same domain listens on the xcatd port.

xcat_selinux_package.t now asserts a second domain for the build: the
xcat_image_t declaration, its permissive line, the entrypoint, the
transition from xcat_t with the three inherited process permissions, the
role statements for system_r and unconfined_r, and the file contexts of the
two genimage programs. One check holds the security property of the split:
only xcat_image_t may manage or relabel every file type, and the daemon
domain gets no filesystem-wide grant.

9 of the 74 checks fail on this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-15 02:27:38 -03:00
Daniel Hilst 2f5a4dbd3a test(xcat-core): capture the empty candidate list of mysqlsetup
mysqlsetup -i reports

    comment the bind-address line failed: cannot read : No such file or
    directory

on every MySQL cluster, with no file named. Measured on xcat185-mn-tmp-84
through SN_setup_case, which then stops: the Kea configuration and the
service node install never happen.

@BIND_FILES is assigned by a top-level statement that sits below the main
flow's exit, so the statement never runs and the list is empty at run time.
$BIND_FILES[-1] is then undef. Each case in the test localizes the list, so
none of them read the value the script itself holds.

The test now asserts the list of the loaded script. 2 of its 15 checks fail
on this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 18:48:54 -03:00
Daniel Hilst d3739aa512 test(xcat-core): capture the labels the erase of xCAT-selinux leaves behind
Removing the package removes the module, so xcatd_exec_t and
xcat_client_exec_t leave the policy and each file that carried one becomes
unlabeled_t. Measured on xcat162-mn-tmp-286 after dnf remove:

    system_u:object_r:unlabeled_t:s0 /opt/xcat/sbin/xcatd
    system_u:object_r:unlabeled_t:s0 /opt/xcat/bin/xcatclient
    system_u:object_r:unlabeled_t:s0 /opt/xcat/bin/xcatclientnnr

restorecon -n reported all three as pending, and /install kept
public_content_t, which the stock policy does not define for it.

xcat_selinux_package.t asserts the %preun snapshot and the %postun relabel
that an erase needs, guarded for the erase only. 3 of its 64 checks fail on
this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 17:33:39 -03:00
Daniel Hilst 7b92b95034 test(xcat-core): capture the client exec that SELinux refuses
A client command run from unconfined_t fails under enforcing:

    /opt/xcat/bin/lsxcatd: /usr/bin/perl: bad interpreter: Permission denied

Measured on xcat162-mn-tmp-286, AlmaLinux 10.2, with the module loaded and
the entrypoints labelled. The same command returns 0 under setenforce 0.
The transition computes unconfined_u:unconfined_r:xcat_t, and the module
does not authorize unconfined_r for xcat_t, so the context is invalid and
the kernel refuses the exec. The permissive declaration does not help,
because an invalid context is not a permission check. The record is
SELINUX_ERR, op=security_compute_sid, which no AVC query finds.

xcat_selinux_package.t asserts the role statement, and check 49 of 60
fails on this commit. selinux_client_domain asserts that lsxcatd returns 0
and prints its version under enforcing, that seinfo reports xcat_t for
unconfined_r, and that the run leaves no invalid_context record.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 17:28:02 -03:00
Daniel Hilst 07b7041011 docs(xcat-core): two comments name the domain xcatd no longer runs in
The unit file and xcatd_service_direct_exec.t said that a direct ExecStart
keeps xcatd out of initrc_t and in unconfined_service_t. The entrypoint of
the xcat_t domain is the xcatd script, so a shell in ExecStart now costs the
domain, not the confinement.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:55:48 -03:00
Daniel Hilst 2efdce66b9 test(xcat-core): capture the missing xcat_t domain
xCAT ships no process domain. xcatd runs in unconfined_service_t, and a
client command runs in the domain of its caller, so no rule in the policy
module reaches either of them.

xcat_selinux_package.t now asserts the domain, the two entrypoint types,
the file contexts of the three entrypoints, the transition from systemd and
the transition from unconfined_t, and that no confined user domain gets a
transition. 9 of its 59 checks fail on this commit.

selinux_xcatd_domain asserts the live context of xcatd and its workers, and
the new selinux_client_domain case asserts the entrypoint labels and the
transition rules the loaded policy holds.

The two no-denial cases now count only the denials the kernel enforced,
because xcat_t is permissive and each access it needs is recorded. They also
pass --input-logs: on EL10 audit 4.0.3 ausearch reads the journal rather than
the file auditd.conf names, and answered "<no matches>" on a node whose log
held 1032 denials.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:52:43 -03:00
Daniel Hilst 8e9c1e2ab1 fix(xcat-core): mysqlsetup leaves /etc/my.cnf with the label of /tmp
mysqlsetup commented the bind-address line by writing the result to
/tmp/my.cnf and renaming it over the configuration file. A file created in
/tmp takes user_tmp_t, and a rename keeps the type of the file it moves, so
the management node was left with a MySQL configuration that mysqld is denied
read of. The denial survives the command and was seen in three rounds of the
SELinux campaign. The temporary path is also a fixed name in a world writable
directory, written as root.

comment_bind_address now reads the file, substitutes the line and writes the
result back through the same file. Truncating in place keeps the inode, which
is what carries the label, so no relabel is needed afterwards. The candidate
list moves to @BIND_FILES and the resolution order does not change: the
Ubuntu mariadb.conf.d file, then /etc/mysql/my.cnf, then /etc/my.cnf.

mysqlsetup_bind_address_label.t drives the sub against a scratch tree and
asserts the inode survives, that only a line starting with bind is commented,
and that no temporary file is left beside the target. With the rewrite put back
through a renamed file in /tmp, the inode check is the one check of the
thirteen that fails.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:33 -03:00
Daniel Hilst e35e2f8e19 test(xcat-core): the Genesis SELinux checks pass when the relabel fails
stage_genesis_payload() runs restorecon and discards its exit status, so a
relabel that fails returns 0 and the kernel keeps the context of the install
tree. mknb_genesis_selinux_context.t asserted that rc, so the test held the
defect in place. It now requires the failure to reach the caller, with the
kernel path and a message that names the relabel.

selinux_context.sh reads only the output of restorecon -F -n -v, so a non-zero
exit with no output reports GENESIS_SELINUX_OK.

The helper also builds genesis.kernel.<arch> from the architecture it was
given. With legacy Genesis, mknb ppc64le resolves share/xcat/netboot/genesis/
ppc64 and writes genesis.kernel.ppc64, so the helper fails on a kernel mknb
never staged. Three ppc64le cells run this case.

genesis_kernel_selinux_context.bats drives the helper with lsdef, mknb,
selinuxenabled and restorecon shadowed and XCATROOT in a scratch tree. Three of
its four checks fail without the fix that follows, and the fourth fails when the
OpenEmbedded branch is removed.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:21 -03:00
Daniel Hilst 16e20fbb52 fix(xcat-core): Genesis kernel keeps the install tree SELinux context
mknb stages the legacy Genesis kernel with cp -a, which implies --preserve=all
and copies the SELinux context of /opt/xcat/share/xcat/netboot/genesis with it.
On a management node with SELinux enabled the kernel then carries usr_t, while
the policy declares tftpdir_t for that path. Measured on an el9 management node,
restorecon -nvR /tftpboot names genesis.kernel.x86_64 and no other path, so it
is the one file xCAT mislabels under the TFTP root. Nothing in the netboot path
relabels it.

stage_genesis_payload now copies with --no-preserve=context,xattr, and runs
restorecon -F on the staged kernel when xCAT::Utils->isSELINUX reports SELinux
enabled. xattr goes with context because cp stores the context in the
security.selinux xattr, so --no-preserve=context alone still copies it. The
relabel corrects a kernel that an earlier xCAT staged, because a copy over an
existing file keeps that file's context. A failed relabel does not fail the
step.

mknb_genesis_staging.t reports SELinux as disabled, so its command counts stay
about the copies it tests.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:21 -03:00
Daniel Hilst ec2a48dec0 test(xcat-core): capture the SELinux context of the staged Genesis kernel
mknb stages the legacy Genesis kernel into the TFTP root with cp -a. The flag
implies --preserve=all, so the kernel arrives with the SELinux context of the
xCAT install tree and not the context the policy declares for that path.

The test drives stage_genesis_payload with a recording runner. It asserts that
the copy does not preserve the context, and that the staged kernel is relabelled
after the copy when SELinux is enabled. It fails on the current code: 4 of its
14 checks are red.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:20 -03:00
Daniel Hilst 3607c3f7bd test(xcat-core): capture the five measured rules the policy module omits
The xcat policy module carries four allow rules and xcat_selinux_package.t reads
only the spec and the file context list, so no test reads the module source. The
SELinux campaign measured five more accesses that the module does not grant:
httpd maps the per-node xnba boot config it serves, rsync reads /etc/shadow and
needs CAP_DAC_OVERRIDE to write it, and useradd and groupadd read the rootimg
/var/run symlink from an rpm scriptlet.

The test parses the allow rules of xcat.te into a permission set per source,
target and class, and asserts each access. It also asserts that no rule grants
kernel_t anything. Two such rules make an EL10 diskless node boot enforcing, and
they grant the pre-pivot domain execute on an unlabelled file, which on that
node is the whole root.

7 of the 43 checks fail on this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:20 -03:00
Daniel Hilst d53b723379 test(xcat-core): capture the missing xCAT SELinux policy package
xCAT ships no SELinux policy. On an enforcing management node, httpd
cannot read /install, which has no file context and is default_t, and
cannot read the /tftpboot files that xcat.conf serves. xcatws.cgi cannot
connect to xcatd.

xcat_selinux_package.t reads the xCAT-selinux spec, its file context list
and the xCAT-server and xCATsn specs. It checks the build and the
scriptlet macros, the /install labels, and the conditional Requires on
xCAT-selinux. 23 of its 31 checks fail on this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:20 -03:00
Daniel Hilst 61bc1dc1e9 test(xcat-core): capture the shell that starts xcatd
xcatd.service starts xcatd through /bin/sh to read /etc/profile.d/xcat.sh.
systemd runs that shell in initrc_t, so on an SELinux system xcatd runs in
initrc_t. That domain moves rsync, useradd, groupadd, hwclock and setfiles
into confined domains, which deny syncfiles, updatenode -F and genimage.

xcatd_service_direct_exec.t reads the [Service] section of the unit and
checks that ExecStart runs /usr/sbin/xcatd and that Environment= carries
XCATROOT, PATH and PERL_BADLANG. 11 of its 14 checks fail on this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:20 -03:00
Daniel Hilst d5a162cc11 test(xcat-core): measure what xcatconfig does to the SELinux policy of a node
xcatconfig turns SELinux off during an installation. It sets the running
system permissive and writes SELINUX=disabled into /etc/selinux/config. A
management node therefore loses the SELinux policy of the site, and only a
warning in the log reports it. Every CI cell that declares SELINUX=enforcing
ran its test cases permissive for this reason.

The test drives xCAT::SELinux->xcatconfig_action against a scratch root and
asserts that an enforcing node, a permissive node and a node with SELinux
already off all get an answer that asks for no change. It also asserts that
the call rewrites no file under that root.

10 of the 27 checks fail on this commit.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:20 -03:00
Daniel Hilst ba4824ef62 Merge pull request #7940 from VersatusHPC/fix/imgexport-destination
fix(imgport): write the imgexport bundle to its destination
2026-10-14 12:05:47 -03:00
Daniel Hilst bdd2a51efc Merge pull request #7945 from VersatusHPC/fix/imgimport-litefile-lookup
fix(imgport): quote the image column of the litefile lookup
2026-10-14 12:04:38 -03:00
Daniel Hilst c8a20a1ea2 Merge pull request #7950 from VersatusHPC/fix/kit-rhel-release
fix(kit): compare the RHEL release as a number
2026-10-14 11:53:59 -03:00
Daniel Hilst 25a3c8e55d Merge pull request #7947 from VersatusHPC/fix/table-setattribswhere-cache
fix(table): refresh the cache after a conditional update or rollback
2026-10-14 11:53:16 -03:00
Daniel Hilst 675c9f3dfd Merge pull request #7946 from VersatusHPC/fix/kit-lock
fix(kit): refuse a kit command while another process holds the kit lock
2026-10-14 11:51:23 -03:00
Daniel Hilst 5c0944854f Merge pull request #7944 from VersatusHPC/fix/imgimport-extra-destination
fix(imgport): copy an extra file into its destination directory
2026-10-14 11:49:02 -03:00
Daniel Hilst 2c2ce39795 Merge pull request #7943 from VersatusHPC/fix/table-dbworker-exception
fix(table): pass an exception of the DB worker to its caller
2026-10-14 11:48:20 -03:00
Daniel Hilst 2ae9abbaf8 Merge pull request #7936 from VersatusHPC/refactor/r26-genesis-reuse
refactor(genesis): share runtime helpers and build policy
2026-10-14 11:47:15 -03:00
Daniel Hilst b1fd47ae17 Merge pull request #7938 from VersatusHPC/fix/packimage-image-dir-glob
fix(packimage): refuse an image directory that the shell would split
2026-10-14 11:46:58 -03:00
Daniel Hilst 82a658ff23 Merge pull request #7917 from VersatusHPC/test/r26-package-artifacts
test(packaging): exercise package and repository behavior
2026-10-14 11:44:03 -03:00
Daniel Hilst f631faa68d Merge pull request #7911 from VersatusHPC/test/r26-genesis-hardware-isolation
test(genesis): isolate BMC and adapter script checks
2026-10-14 11:41:58 -03:00
Daniel Hilst 1dc9eebb76 Merge pull request #7915 from VersatusHPC/test/r26-image-network-behavior
test(provisioning): exercise image and network callers
2026-10-14 11:41:06 -03:00
Daniel Hilst 74ec6acdde Merge pull request #7900 from VersatusHPC/fix/x86-unstable-cases
fix(xcat-core): x86_64 CLI cases report failures the product does not have
2026-10-14 11:04:10 -03:00
Vinícius Ferrão 6147399387 test(kit): cover the RHEL release check of the kit commands
A kit command must run on RHEL 7, and must be refused on RHEL 8, 9, 10
and 11. The release check must leave SLES and Ubuntu alone.
2026-10-14 01:21:01 -03:00
Vinícius Ferrão 2d37c78b75 test(imgport): cover an extra file whose destination directory is missing
An extra file must go into its destination directory, which the import
creates with its missing parents. A file at the destination path, or at
a parent of it, must fail the import and stay as it was. A file name
with glob characters must stay literal. A failed backup of the previous
file must fail the import.
2026-10-14 00:46:41 -03:00
Vinícius Ferrão 3de07595b0 test(table): cover the cache after a rollback
A cached reader that saw an update before a rollback must see the
committed value after the rollback. This also holds when the rollback
goes through another table on the same handle, and after a table failed
to open on that handle.
2026-10-14 00:36:57 -03:00
Vinícius Ferrão fae54f7a07 test(table): cover the cache after a conditional update
A reader that built the cache of a table must see a conditional update
of setAttribsWhere at once.
2026-10-14 00:36:57 -03:00
Vinícius Ferrão ffd47c001f test(table): cover an exception of the DB worker
A table call that dies in the DB worker must die in its caller with the
same message. The DB worker must then serve the next request.
2026-10-14 00:36:47 -03:00
Vinícius Ferrão bc5da0fe88 test(imgport): cover the column quoting of the litefile lookup
When the configured database is MySQL, the litefile lookup of a
statelite import must quote the image column with backticks. An ALL
entry must still cover the same file of the image.
2026-10-14 00:35:54 -03:00
Vinícius Ferrão 9019944fab test(kit): cover the kit lock of a kit command
A kit command must hold the kit lock while it runs, and release it
after. It must refuse to run while another process holds the lock, also
in a process that ran a kit command before. A kit command that another
kit command runs must go on under the lock of that command.
2026-10-13 23:34:39 -03:00
Vinícius Ferrão 2a201ab62c test(genesis): prepare shared runtime library fixtures 2026-10-13 22:16:50 -03:00
Vinícius Ferrão af0781ad77 test(imgport): cover the destination of an imgexport bundle
A local imgexport must write the bundle to a relative or absolute
destination, to a directory, and to a path with a space, and to the
current working directory without a destination. A destination in a
missing directory must be reported before a bundle is written. A remote
export must copy the bundle to its destination on the remote host and
remove its local copy.
2026-10-13 11:40:16 -03:00
Vinícius Ferrão c177137afa test(packaging): keep failures local to each test file 2026-10-13 11:39:40 -03:00
Vinícius Ferrão c675b186fa test(packimage): cover an image directory with a space
packimage must refuse an image directory with a space, and leave the
directory or file that the first word of its path names. The previous
archive, the other formats and the image must stay.
2026-10-13 11:38:51 -03:00
Vinícius Ferrão 32ccf13fbe test(installer): exercise Genesis package transactions 2026-10-13 11:38:11 -03:00
Vinícius Ferrão dbbdcddcb2 test(packaging): query resolved RPM dependencies 2026-10-13 11:38:11 -03:00
Vinícius Ferrão 709bf6b678 test(provisioning): keep prerequisite failures local to each file 2026-10-13 11:38:10 -03:00
Vinícius Ferrão e7c7babce0 test(build): exercise release repository finalization 2026-10-13 11:38:10 -03:00
Vinícius Ferrão aebc350e1a test(probe): exercise the built RPM payload 2026-10-13 11:38:10 -03:00
Vinícius Ferrão 2d751ac847 test(el10): exercise media and RPM package policy 2026-10-13 11:38:09 -03:00
Vinícius Ferrão 14d0ac27da test(genimage): check driver selection after driver updates 2026-10-13 11:38:09 -03:00
Vinícius Ferrão a69404e749 test(network): execute rendered install postscripts 2026-10-13 11:37:35 -03:00
Vinícius Ferrão 7fd8c3681b test(nfs): exercise statelite installer boot parameters 2026-10-13 11:37:35 -03:00