xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-10-21 15:18:19 +00:00
Code Issues Releases Wiki Activity

test(packimage): cover an image directory with a space

Browse Source 
packimage must refuse an image directory with a space, and leave the
directory or file that the first word of its path names. The previous
archive, the other formats and the image must stay.
This commit is contained in:
Vinícius Ferrão
2026-10-13 11:38:51 -03:00
parent 1a71d9d33c
commit c675b186fa
1 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/packimage_atomic_archive.t
+24 -3
View File
@@ -60,11 +60,12 @@ our @LITEFILES;
my ($unsquashfs, $mksquashfs) = (tool('unsquashfs'), tool('mksquashfs'));
my $sequence = 0;
# The wrapper records what nodes would download while the pack runs, then runs or fails the real tool.
# The wrapper records what nodes would download while the pack runs, then runs or fails the real tool. $parent
# is the directory of the image directory.
sub image {
my ($method, $compress, $wrapped, $mode) = @_;
my ($method, $compress, $wrapped, $mode, $parent) = @_;
my $name = 'atomic-' . ++$sequence;
my $dest = "$fixture/images/$name";
my $dest = ($parent // "$fixture/images") . "/$name";
my $root = "$dest/rootimg";
make_path("$root/etc", "$root/opt/xcat", "$root/usr/bin", "$root/usr/lib/dracut/modules.d/97xcat", "$dest/bin");
write_text("$root/etc/shadow", "root:*:1:0:99999:7:::\n");
@@ -364,4 +365,24 @@ SCRIPT
is_deeply([ glob("$dest/.packimage-$host+*") ], [], "$label: no temporary file is left");
}
for my $kind (qw(directory file)) {
# The shell splits an image directory with a space, and the first word of its path names another path.
my $word = "$fixture/word-$kind";
if ($kind eq 'directory') {
make_path("$word/keep");
} else {
write_text($word, "file that the first word of the image directory names\n");
}
my ($name, $dest, $archive) = image('cpio', 'gzip', 'gzip', 'pass', "$word images");
make_path("$dest/rootimg/xcatpost");
write_text("$dest/rootimg/xcatpost/previous", "postscript of the previous pack\n");
my ($result, $errors) = packimage($dest, '-m', 'cpio', '-c', 'gzip', $name);
my $label = "image directory with a space after the path of a $kind";
like($errors, qr/Cannot pack the image in \Q$dest\E: its path has a space or a shell character/, "$label: the pack is refused");
ok($kind eq 'directory' ? -d "$word/keep" : -f $word, "$label: the $kind that the first word of the path names stays");
is(content($archive), "previous archive\n", "$label: the previous archive stays");
is(content("$dest/rootimg.previous"), "previous format\n", "$label: other formats stay");
is(content("$dest/rootimg/xcatpost/previous"), "postscript of the previous pack\n", "$label: the image stays as it was");
}
done_testing();