2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-04 20:17:55 +00:00

Merge pull request #7784 from VersatusHPC/fix/debian-html-form-dependency

fix(debian): declare HTML::Form runtime dependency
This commit is contained in:
Daniel Hilst
2026-08-31 11:42:04 -03:00
committed by GitHub
4 changed files with 22 additions and 5 deletions
+1 -1
View File
@@ -8,7 +8,7 @@ Homepage: https://xcat.org/
Package: perl-xcat
Architecture: all
Depends: ${perl:Depends}
Depends: ${perl:Depends}, libhtml-form-perl
Description: xCAT perl libraries
Provides perl xCAT libraries for core functionality. Required for all xCAT installations.
Includes xCAT::Table, xCAT::NodeRange, among others.
@@ -4,5 +4,5 @@ os:Linux
label:mn_only,ci_test,integration
cmd:prove -I/opt/xcat/lib/perl -I/opt/xcat/lib/perl/xCAT -r /opt/xcat/share/xcat/tools/autotest/integration
check:rc==0
check:output=~Files=3
check:output=~Files=4
end
+3 -3
View File
@@ -27,10 +27,10 @@ against it.
Note the `-I` flags: unlike the unit tests these run from the installed location, so
they pick up xCAT modules from `/opt/xcat/lib/perl` rather than from a source tree.
The case checks `rc==0` and `output=~Files=3`. The second assertion is there because
The case checks `rc==0` and `output=~Files=4`. The second assertion is there because
`prove` exits 0 both when tests pass and when they all skip, so `rc==0` alone would let
the case report green having run nothing. Matching `Files=3` proves `prove` actually
found all three files, which catches a packaging regression or a file being renamed
the case report green having run nothing. Matching `Files=4` proves `prove` actually
found all four files, which catches a packaging regression or a file being renamed
without the count being updated here. **Add to that number when you add a test.** A
missing directory is already caught by `rc==0` -- `prove -r` on a path that does not
exist exits 2.
@@ -0,0 +1,17 @@
#!/usr/bin/env perl
use strict;
use warnings;
use Test::More;
require_ok('HTML::Form');
my ($form) = HTML::Form->parse(
'<form method="post"><input name="user" value="admin"></form>',
'http://example.invalid/'
);
isa_ok($form, 'HTML::Form');
is($form->value('user'), 'admin', 'HTML form fields can be parsed');
done_testing();