xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-04 20:17:55 +00:00
Code Issues Releases Wiki Activity

test(ntp): the selector calls chrony available where makentp will not use it

Browse Source 
xCAT::NTP::Backend->available reports chrony as available when chronyd exists. makentp
configures chrony only when systemctl exists as well, and setupntp hands over to ntpd without
it. On a host with chronyd and no systemctl the selector answers chrony, makentp takes the ntpd
path anyway, and the admin is told nothing.

ntp_backend_selection.t drives available and choose with the command probe injected, so a case
can hold chronyd present and systemctl absent without depending on what the test host has
installed.

Six assertions fail: available reports chrony on chronyd alone, and choose neither downgrades
nor asks for an install.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
This commit is contained in:
Daniel Hilst
2026-09-03 14:40:07 -03:00
parent 670ea2df51
commit b3d6e1f9aa
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/ntp_backend_selection.t
+24
View File
@@ -69,4 +69,28 @@ $r = xCAT::NTP::Backend->choose(
is( $r->{name}, 'chrony', 'neither present keeps the preferred chrony' );
is( $r->{install}, 1, 'neither present flags install of the preferred daemon' );
# --- available: chrony needs systemd, not just chronyd -----------------------------------------
# makentp configures chrony only where systemctl is present, and setupntp hands over to ntpd
# without it. The selector has to call chrony usable on the same terms, or makentp silently takes
# the ntpd path for a backend the selector reported as available.
is( xCAT::NTP::Backend->available( 'chrony', commands => { chronyd => 1, systemctl => 1 } ), 1,
'chrony is available where chronyd and systemctl are both present' );
is( xCAT::NTP::Backend->available( 'chrony', commands => { chronyd => 1, systemctl => 0 } ), 0,
'chronyd without systemctl is not a usable chrony backend' );
is( xCAT::NTP::Backend->available( 'chrony', commands => { chronyd => 0, systemctl => 1 } ), 0,
'systemctl without chronyd is not a usable chrony backend either' );
is( xCAT::NTP::Backend->available( 'ntpd', commands => { ntpd => 1 } ), 1,
'ntpd needs only ntpd' );
$r = xCAT::NTP::Backend->choose(
requested => 'chrony', check_available => 1,
commands => { chronyd => 1, systemctl => 0, ntpd => 1 } );
is( $r->{name}, 'ntpd', 'chronyd without systemctl downgrades to the daemon that can be used' );
is( $r->{downgraded}, 'chrony', 'and the downgrade is reported rather than silent' );
$r = xCAT::NTP::Backend->choose(
requested => 'chrony', check_available => 1,
commands => { chronyd => 1, systemctl => 0, ntpd => 0 } );
is( $r->{install}, 1, 'chronyd without systemctl and no ntpd asks for an install' );
done_testing();