mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-11-20 01:12:18 +00:00
fix(xcat-core): the policy module omits five measured accesses
The xcat policy module granted httpd read of /tftpboot and let xcatws.cgi connect to the xcatd port. Five further accesses were measured denied on a management node and are not granted, so an enforcing node fails at them. httpd mmaps the per-node xnba boot config it serves out of /tftpboot. read_file_perms does not hold map, so the module now grants mmap_read_file_perms. Two sites recorded this denial three days apart, on xCAT 2.19.1 and 2.20. xdcp and "updatenode -F" copy /etc/shadow to the nodes and into a rootimg. rsync_export_all_ro holds that read and rsync_full_access does not grant it, because shadow_t is not in non_auth_file_type. rsync also writes a target it created at mode 0000, which needs CAP_DAC_OVERRIDE. Both rules are reached only where rsync runs in rsync_t, which needs a system-service caller. genimage installs packages into a rootimg with yum in a chroot, and useradd and groupadd read the rootimg /var/run symlink from the rpm scriptlets. The symlink carries public_content_t because the rootimg is under /install, and the base grant for that read names public_content_t nowhere. The module compiles at version 19 in the alma+epel-10-x86_64 mock root, and the five types reach the binary. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
This commit is contained in:
+25
-1
@@ -2,12 +2,36 @@ policy_module(xcat, 1.0.0)
|
||||
|
||||
gen_require(`
|
||||
type httpd_t, httpd_sys_script_t, tftpdir_t, ntop_port_t;
|
||||
type rsync_t, shadow_t;
|
||||
type useradd_t, groupadd_t, public_content_t;
|
||||
')
|
||||
|
||||
# httpd serves /tftpboot through the AliasMatch in xcat.conf. The stock policy lets only tftpd read tftpdir_t.
|
||||
# mmap_read_file_perms, not read_file_perms: httpd maps the per-node xnba boot config it serves.
|
||||
allow httpd_t tftpdir_t:dir list_dir_perms;
|
||||
allow httpd_t tftpdir_t:file read_file_perms;
|
||||
allow httpd_t tftpdir_t:file mmap_read_file_perms;
|
||||
allow httpd_t tftpdir_t:lnk_file read_lnk_file_perms;
|
||||
|
||||
# xcatws.cgi connects to xcatd on site.xcatdport, and the stock policy labels TCP 3001 ntop_port_t.
|
||||
allow httpd_sys_script_t ntop_port_t:tcp_socket name_connect;
|
||||
|
||||
# xdcp and "updatenode -F" copy /etc/shadow to the nodes and into a rootimg.
|
||||
# rsync_export_all_ro holds the read, and rsync_full_access does not grant it:
|
||||
# shadow_t is not in non_auth_file_type. These two rules are narrower than
|
||||
# either boolean. They are reached only where rsync runs in rsync_t, which
|
||||
# needs a system-service caller; xcatd is unconfined_service_t and does not
|
||||
# transition there.
|
||||
allow rsync_t shadow_t:file { getattr open read };
|
||||
|
||||
# rsync preserves the mode of /etc/shadow, so it writes a target it created at
|
||||
# mode 0000. As root that needs CAP_DAC_OVERRIDE. rsync_t already holds chown,
|
||||
# fowner, fsetid and dac_read_search; this is the write side of that set.
|
||||
allow rsync_t self:capability dac_override;
|
||||
|
||||
# genimage installs packages into a rootimg with yum in a chroot, and the rpm
|
||||
# scriptlets run useradd and groupadd. Both read the rootimg /var/run symlink
|
||||
# while they look for their lock file. It carries public_content_t because the
|
||||
# rootimg is under /install, and the base grant for that read is a list of
|
||||
# explicit per-type rules that public_content_t is in none of.
|
||||
allow useradd_t public_content_t:lnk_file read;
|
||||
allow groupadd_t public_content_t:lnk_file read;
|
||||
|
||||
Reference in New Issue
Block a user