mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-05-05 16:49:08 +00:00
Keep plugin bug label for XS crashes without $@
The else branch handles a rare case where XS libraries (Sys::Virt, Net::SNMP) crash without setting $@. This IS a plugin bug, so keep that label and the debug hint. Only the common case (die with $@) gets the clean passthrough.
This commit is contained in:
@@ -2091,7 +2091,8 @@ sub plugin_command {
|
||||
chomp(my $eval_err = $@);
|
||||
$error = "$modname: $eval_err";
|
||||
} else {
|
||||
$error = "$modname: unexpected error (pid $$, $$progname)";
|
||||
# XS libraries (Sys::Virt, Net::SNMP) can crash without setting $@
|
||||
$error = "$modname plugin bug (pid $$): died without setting an error. Run xcatd -f to debug";
|
||||
}
|
||||
if (scalar(@nodes)) {
|
||||
$error .= " [nodes: " . join(",", @nodes) . "]";
|
||||
|
||||
Reference in New Issue
Block a user