xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-10-21 15:18:19 +00:00
Code Issues Releases Wiki Activity

test(xcat-core): makedhcp writes always-send as a number for a proxyDHCP node

Browse Source 
makedhcp <node> adds the per-node classes to the loaded Kea config and
writes it back with encode_config. The proxyDHCP class sets always-send
to 1, and the renderer that turns the flag into a JSON boolean is not on
that path. Kea rejects the file ("unexpected integer, expecting
boolean"), so makedhcp fails for every node deferred to proxyDHCP.

The test syncs a proxyDHCP node, encodes the config and expects a JSON
boolean. It fails on this tree.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
This commit is contained in:
Daniel Hilst
2026-09-28 14:52:21 -03:00
parent 9aca68e64b
commit 8d40c54e03
1 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/dhcp_kea_plugin_intent.t
+28
View File
@@ -1692,4 +1692,32 @@ foreach my $case (@invalid_mac_cases) {
'and that class, which names no boot file, is not excluded from it' );
}
{
# makedhcp <node> writes the loaded config back through encode_config, not
# through the renderer. Kea rejects an option flag written as the number 1.
my %tables = (
noderes => DHCPKeaResTable->new( { win01 => { netboot => 'xnba' } } ),
mac => DHCPKeaResTable->new( { win01 => { mac => 'aa:bb:cc:dd:ee:0a' } } ),
chain => DHCPKeaResTable->new( { win01 => { currstate => 'install' } } ),
nodetype => DHCPKeaResTable->new( { win01 => { os => 'win2022' } } ),
);
no warnings 'redefine';
local *xCAT::Table::new = sub {
my ( $class, $name ) = @_;
return $tables{$name};
};
local *xCAT_plugin::dhcp::next_server_for_node = sub { return ( '192.0.2.1', '192.0.2.1' ); };
local *xCAT_plugin::dhcp::proxydhcp = sub { return 1; };
my $config = { Dhcp4 => { 'client-classes' => [] } };
xCAT_plugin::dhcp::kea_sync_node_client_classes( $config, ['win01'] );
my $written = JSON::decode_json( xCAT::DHCP::Backend::Kea->new()->encode_config($config) );
my ($deferral) = grep { $_->{name} eq 'xcat-proxydhcp-win01-aabbccddee0a' }
@{ $written->{Dhcp4}{'client-classes'} };
ok( $deferral, 'the proxyDHCP class is written by a makedhcp for one node' );
is( ref( $deferral ? $deferral->{'option-data'}[0]{'always-send'} : undef ), 'JSON::PP::Boolean',
'and its always-send flag is written as a boolean, which is what Kea parses' );
}
done_testing();