xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-10-20 22:55:40 +00:00
Code Issues Releases Wiki Activity

test(imgport): cover the image lock of a statelite import

Browse Source 
A statelite import must ask for the lock of its image directory. While
another command holds the lock, the import must fail, report the lock,
leave the tree in the bundle, and keep the image definition.
This commit is contained in:
Vinícius Ferrão
2026-10-13 23:10:23 -03:00
parent 9ecde2b838
commit 7c930bee9d
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/imgport_rootimg_checksum.t
+19 -1
View File
@@ -70,11 +70,12 @@ sub import_image {
write_text("$dest/initrd-stateless.gz", "published ramdisk\n");
write_text("$bundle/kernel", "kernel from the bundle\n");
write_text("$bundle/initrd-stateless.gz", "ramdisk from the bundle\n");
$prepare->($dest) if $prepare;
$prepare->($dest, $bundle) if $prepare;
@LOCKED = ();
my @errors;
my $checksum = delete $manifest{rootimgchecksum};
my $nodes = delete $manifest{nodes};
my $omit = delete $manifest{omit} || [];
my $name = "import-$sequence";
xCAT::Table->new('osimage', -create => 1)->setAttribs({ imagename => $name }, { osvers => 'rhels9.5', provmethod => 'netboot' });
my $data = {
@@ -85,6 +86,7 @@ sub import_image {
(defined $checksum ? (linuximage => { rootimgchecksum => $checksum }) : ()),
osimage => { imagename => $name, osvers => 'rhels9.6', osarch => 'x86_64', profile => 'compute', provmethod => 'netboot' },
};
delete @{$data}{@$omit};
my $placed = xCAT_plugin::imgport::place_image($data, $bundle, sub { push @errors, @{ $_[0]{error} || [] } }, $nodes);
return ($placed, join("\n", @errors), $dest, "$dest/$archive_name");
}
@@ -128,6 +130,22 @@ for my $archive_name (qw(rootimg.cpio.gz rootimg.tar.xz rootimg.sfs)) {
is(definition($dest), 'rhels9.5', 'the image definition stays while the image lock is held');
}
{
# A statelite bundle has a rootimgtree and no rootimg, and its import needs the image lock too.
local $HELD = 1;
my $tree;
my ($placed, $errors, $dest) = import_image('rootimg.cpio.gz', sub {
my (undef, $bundle) = @_;
$tree = "$bundle/rootimgtree.gz";
write_text($tree, "tree from the bundle\n");
}, rootimgtree => 'DEST/rootimgtree.gz', omit => [qw(rootimg kernel ramdisk)]);
ok(!$placed, 'a statelite import fails while another command holds the image lock');
like($errors, qr/failed to acquire lock/, 'the held image lock is reported for a statelite import');
is_deeply(\@LOCKED, ["$dest/rootimg"], 'a statelite import asks for the lock of its image directory');
ok(-e $tree, 'the tree stays in the bundle while the lock is held');
is(definition($dest), 'rhels9.5', 'the image definition stays while the lock of a statelite image is held');
}
{
my ($placed, $errors, $dest, $archive) = import_image('rootimg.cpio.gz', sub {
my ($dest) = @_;