xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-07-31 18:19:40 +00:00
Code Issues Releases Wiki Activity

fix(xnba): warn only when pxelinux is required

Browse Source 
Signed-off-by: Vinícius Ferrão <2031761+viniciusferrao@users.noreply.github.com>
This commit is contained in:
Vinícius Ferrão
2026-07-27 15:22:12 -03:00
parent 40f754d657
commit 42e8ef64cc
1 changed files with 23 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-server/lib/xcat/plugins/xnba.pm
+23 -15
View File
@@ -91,6 +91,14 @@ sub getstate {
}
}
sub _requires_pxelinux {
my $kern = shift;
return 0 unless ($kern and ref($kern) eq 'HASH');
my $kernel = $kern->{kernel} || '';
return ($kernel =~ /!/ or $kernel =~ /\.c32\z/ or $kernel =~ /memdisk\z/) ? 1 : 0;
}
my %efistubcache;
sub has_efistub {
my $kern = shift;
@@ -285,6 +293,7 @@ sub setstate {
close($pcfg);
_write_uefi_exit_script($bootloader_root, $node, $cref->{currstate});
} elsif ($kern and $kern->{kernel}) {
$::XNBA_pxelinux_required = 1 if (_requires_pxelinux($kern));
if ($kern->{kernel} =~ /!/) { #TODO: deprecate this, do stateless Xen like stateless ESXi
my $hypervisor;
my $kernel;
@@ -610,6 +619,7 @@ sub process_request {
$::XNBA_callback = shift;
my $sub_req = shift;
undef $::XNBA_addkcmdlinehandled; # clear out any previous value
undef $::XNBA_pxelinux_required;
my @args;
my @rnodes;
undef %failurenodes;
@@ -760,21 +770,6 @@ sub process_request {
}
}
#back to normal business
if (!-r "$globaltftpdir/xcat/pxelinux.0") {
if (-r $::XCATROOT . "/share/xcat/netboot/syslinux/pxelinux.0") {
copy($::XCATROOT . "/share/xcat/netboot/syslinux/pxelinux.0", "$globaltftpdir/xcat/pxelinux.0");
chmod(0644, "$globaltftpdir/xcat/pxelinux.0");
}
}
unless (-r "$globaltftpdir/xcat/pxelinux.0") {
# only legacy BIOS clients chain pxelinux, and not every distribution
# still ships syslinux, so warn instead of failing the whole request
$::XNBA_callback->({ warning => ["Unable to find pxelinux.0 from syslinux, legacy BIOS nodes that chain pxelinux will not boot until it is available"] });
}
my $inittime = 0;
if (exists($::XNBA_request->{inittime})) { $inittime = $::XNBA_request->{inittime}->[0]; }
if (!$inittime) { $inittime = 0; }
@@ -843,6 +838,19 @@ sub process_request {
}
}
}
if ($::XNBA_pxelinux_required) {
if (!-r "$globaltftpdir/xcat/pxelinux.0") {
if (-r $::XCATROOT . "/share/xcat/netboot/syslinux/pxelinux.0") {
copy($::XCATROOT . "/share/xcat/netboot/syslinux/pxelinux.0", "$globaltftpdir/xcat/pxelinux.0");
chmod(0644, "$globaltftpdir/xcat/pxelinux.0");
}
}
unless (-r "$globaltftpdir/xcat/pxelinux.0") {
$::XNBA_callback->({ warning => ["Unable to find pxelinux.0 from syslinux; nodes whose xNBA configuration chains pxelinux will not boot until it is available"] });
}
}
xCAT::MsgUtils->trace($verbose_on_off, "d", "xnba: Finish to handle configurations");
#dhcp stuff -- inittime is set when xcatd on sn is started