xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-05-17 19:57:18 +00:00
Code Issues Releases Wiki Activity

fix: accept RMCP message tag 0 from OpenBMC with session ID correlation

Browse Source 
OpenBMC-based BMCs return message tag 0 in RAKP2/RAKP4 instead of
echoing the tag from the request. xCAT rejected these as stale
responses and retried indefinitely until timeout.

Accept tag 0 but verify the remote console session ID in the response
matches our current sidm. This prevents stale retries from corrupting
session state while allowing OpenBMC responses through.

Applied to got_rmcp_response, got_rakp2, and got_rakp4.

Ref: #7511
This commit is contained in:
Vinícius Ferrão
2026-05-06 01:25:09 -03:00
parent cb2a6b3f3c
commit 2bcdc52f92
1 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-server/lib/perl/xCAT/IPMI.pm
+18 -6
View File
@@ -780,8 +780,12 @@ sub got_rmcp_response {
#we would ignore an RMCP+ open session response if we are not in an IPMI2 negotiation, so we have to have *some* state that isn't established for this to be kosher
return 9; #now's not the time for this response, ignore it
}
unless ($byte == $self->{rmcptag}) { #make sure this rmcp response is specifically the last one we sent.... we don't want to happily proceed with the risk a retry request blew up our temp session id without letting us know
return 9;
unless ($byte == $self->{rmcptag}) {
return 9 unless $byte == 0;
my @sid_check = @data[3..6];
unless (pack("C4", @sid_check) eq pack("C4", @{ $self->{sidm} })) {
return 9;
}
}
$byte = shift @data;
unless ($byte == 0x00) {
@@ -895,8 +899,12 @@ sub got_rakp4 {
unless ($self->{sessionestablishmentcontext} == STATE_EXPECTINGRAKP4) { #ignore rakp4 unless we are explicitly expecting RAKP4
return 9; #now's not the time for this response, ignore it
}
unless ($byte == $self->{rmcptag}) { #make sure this rmcp response is specifically the last one we sent.... we don't want to happily proceed with the risk a retry request blew up our temp session id without letting us know
return 9;
unless ($byte == $self->{rmcptag}) {
return 9 unless $byte == 0;
my @sid_check = @data[3..6];
unless (pack("C4", @sid_check) eq pack("C4", @{ $self->{sidm} })) {
return 9;
}
}
$byte = shift @data;
unless ($byte == 0x00) {
@@ -955,8 +963,12 @@ sub got_rakp2 {
#the reason being that if an old rakp1 retry actually made it and we were just too aggressive, then a previous rakp2 is invalidated and invalid session id or the integrity check value is bad
return 9; #now's not the time for this response, ignore it
}
unless ($byte == $self->{rmcptag}) { #make sure this rmcp response is specifically the last one we sent.... we don't want to happily proceed with the risk a retry request blew up our temp session id without letting us know
return 9;
unless ($byte == $self->{rmcptag}) {
return 9 unless $byte == 0;
my @sid_check = @data[3..6];
unless (pack("C4", @sid_check) eq pack("C4", @{ $self->{sidm} })) {
return 9;
}
}
$byte = shift @data;
unless ($byte == 0x00) {