xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-04 20:17:55 +00:00
Code Issues Releases Wiki Activity

fix(ppcmac): validate network addresses with isValidIp

Browse Source 
validate_ip accepted any all-zero address. Only the gateway may be all
zeros, which lpar_netboot uses when no router is needed.
This commit is contained in:
Vinícius Ferrão
2026-09-02 12:38:26 -03:00
parent b671879393
commit 28e019aa5c
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
perl-xCAT/xCAT/PPCmac.pm
+8 -5
View File
@@ -114,8 +114,7 @@ sub parse_args {
} else {
$server = xCAT::ServiceNodeUtils->getSNformattedhash($node, "xcat", "node", "primary");
foreach my $key (keys %$server) {
my $valid_ip = xCAT::NetworkUtils->validate_ip($key);
if ($valid_ip) {
unless (xCAT::NetworkUtils->isValidIp($key)) {
###################################################
# Service node is returned as hostname, Convert
# hostname to IP
@@ -224,9 +223,13 @@ sub parse_args {
if (scalar(@network) != 3) {
return (usage());
}
my $result = xCAT::NetworkUtils->validate_ip($opt{C}, $opt{G}, $opt{S});
if (@$result[0]) {
return (usage(@$result[1]));
foreach my $key (qw(C G S)) {
my $ip = $opt{$key};
# lpar_netboot accepts an all-zero gateway when no router is needed
next if $key eq 'G' and $ip eq '0.0.0.0';
next if xCAT::NetworkUtils->isValidIp($ip);
return (usage("Invalid IP address: $ip"));
}
}
} elsif ((exists($opt{S}) || exists($opt{G}) || exists($opt{C})) && !exists($opt{D})) {