xCAT/pyghmi
2
0
Fork 0
mirror of https://opendev.org/x/pyghmi synced 2026-03-29 06:13:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge "Stop spurious retry on incoming data"

Browse Source
This commit is contained in:
Jenkins
2015-10-21 19:14:03 +00:00
committed by Gerrit Code Review
parent 2a7d6f3662 cf351d1806
commit e96bd8f67c
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pyghmi/ipmi/console.py
View File

@@ -351,9 +351,15 @@ class Console(object):
self._sendpendingoutput()
if len(self.pendingoutput) > 0:
self._sendpendingoutput()
elif self.awaitingack: # session marked us as happy, but we are not
#this does mean that we will occasionally retry a packet
#sooner than retry suggests, but that's no big deal
elif ackseq != 0 and self.awaitingack:
# if an ack packet came in, but did not match what we
# expected, retry our payload now.
# the situation that was triggered was a senseless retry
# when data came in while we xmitted. In theory, a BMC
# should handle a retry correctly, but some do not, so
# try to mitigate by avoiding overeager retries
# occasional retry of a packet
# sooner than timeout suggests is evidently a big deal
self.send_payload(payload=self.lastpayload)
def main_loop(self):