xCAT/pyghmi
2
0
Fork 0
mirror of https://opendev.org/x/pyghmi synced 2026-08-28 17:46:44 +00:00
Code Issues Projects Releases Wiki Activity

Honor access=readonly for Lenovo config

Browse Source 
This will more properly alert user that
a setting cannot be manipulated.

Change-Id: Ied336b64512462cdf1cabd842091a544ba203cc9
This commit is contained in:
Jarrod Johnson
2021-08-12 11:25:14 -04:00
parent 1cd47f71b2
commit 611b8f3a21
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pyghmi/ipmi/oem/lenovo/config.py
+8 -4
View File
@@ -305,6 +305,10 @@ class LenovoFirmwareConfig(object):
readonly = setting.get('gray-if')
if readonly:
readonly = _convert_syntax(readonly)
else:
access = setting.get('access')
if access == 'readonly':
readonly = 'true'
possible = []
current = None
default = None
@@ -485,10 +489,6 @@ class LenovoFirmwareConfig(object):
for option in options.keys():
if options[option]['new_value'] is None:
continue
if options[option]['current'] == options[option]['new_value']:
continue
if options[option]['pending'] == options[option]['new_value']:
continue
if options[option]['readonly']:
errstr = '{0} is read only'.format(option)
if options[option]['readonly_why']:
@@ -496,6 +496,10 @@ class LenovoFirmwareConfig(object):
','.join(sorted(options[option]['readonly_why'])))
errstr += ea
raise pygexc.InvalidParameterValue(errstr)
if options[option]['current'] == options[option]['new_value']:
continue
if options[option]['pending'] == options[option]['new_value']:
continue
if isinstance(options[option]['new_value'], six.string_types):
# Coerce a simple string parameter to the expected list format
options[option]['new_value'] = [options[option]['new_value']]