Add batch support to nodeconfig

Particularly chatty output can make collate be unreasonable in
low quality terminals and links.  Throttle to about 4 times a second.

.gitignore

@@ -1,7 +1 @@
-*.pyc
-.*.
-confluent_client/man/man*
-.vscode
-.*.sw*
-.sw*
-.idea/*
+.idea

LICENSE

@@ -175,3 +175,28 @@
       of your accepting any such warranty or additional liability.
 
    END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

confluent_client/addattribs.py

@@ -1,24 +0,0 @@
-#!/usr/bin/python
-import os
-import sys
-path = os.path.dirname(os.path.realpath(__file__))
-try:
-    sys.path.remove(path)
-except Exception:
-    pass
-path = os.path.realpath(os.path.join(path, '..', 'confluent_server'))
-sys.path.append(path)
-
-import confluent.config.attributes as attr
-import shutil
-
-shutil.copyfile('doc/man/nodeattrib.ronn.tmpl', 'doc/man/nodeattrib.ronn')
-shutil.copyfile('doc/man/nodegroupattrib.ronn.tmpl', 'doc/man/nodegroupattrib.ronn')
-with open('doc/man/nodeattrib.ronn', 'a') as outf:
-    for field in sorted(attr.node):
-        outf.write('\n* `{0}`:\n  {1}\n'.format(field, attr.node[field]['description']))
-with open('doc/man/nodegroupattrib.ronn', 'a') as outf:
-    for field in sorted(attr.node):
-        outf.write('\n* `{0}`:\n  {1}\n'.format(field, attr.node[field]['description']))
-
-

confluent_client/bin/collate

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -35,16 +35,11 @@ import confluent.client
 argparser = optparse.OptionParser(usage="Usage: <other command> | %prog [options]")
 argparser.add_option('-a', '--abbreviate', action='store_true',
                      help='Attempt to use confluent server to shorten noderanges')
-argparser.add_option('-b', '--base',
-                     help='Use given node as reference for comparison when '
-                          'using -d, instead of using the most common result')
 argparser.add_option('-d', '--diff', action='store_true',
                      help='Show what differs between most common '
                           'output group and others')
 argparser.add_option('-w', '--watch', action='store_true',
                      help='Show intermediate results while running')
-argparser.add_option('-g', '--groupcount', action='store_true',
-                     help='Show count of output groups rather than the actual output')                     
 argparser.add_option('-s', '--skipcommon', action='store_true',
                      help='Do not print most common result, only non modal '
                           'groups, useful when combined with -d')
@@ -53,8 +48,6 @@ argparser.add_option('-c', '--count', action='store_true',
 argparser.add_option('-r', '--reverse', action='store_true',
                      help='Reverse sort order to show biggest output group '
                           'last')
-argparser.add_option('-l', '--log', action='store', type='string', dest='log',
-                     help='Log each output to file, using {node} as a placeholder for node.')
 (options, args) = argparser.parse_args()
 if sys.stdin.isatty():
     argparser.print_help()
@@ -70,10 +63,7 @@ else:
 def print_current():
     if options.diff:
         grouped.print_deviants(skipmodal=options.skipcommon, count=options.count,
-                          reverse=options.reverse, basenode=options.base)
-    elif options.groupcount:
-        grouped.generate_byoutput()
-        print(len(grouped.byoutput))
+                          reverse=options.reverse)
     else:
         grouped.print_all(skipmodal=options.skipcommon,
                                count=options.count,
@@ -88,18 +78,9 @@ while fullline:
     for line in fullline.split('\n'):
         if not line:
             continue
-        if ':' not in line:
+        if ': ' not in line:
             line = 'UNKNOWN: ' + line
-        if options.log:
-            node, output = line.split(':', 1)
-            output = output.lstrip()
-            currlog = options.log.format(node=node, nodename=node)
-            with open(currlog, mode='a')  as log:
-                log.write(output + '\n')
-            continue
-        node, output = line.split(':', 1)
-        output = output.lstrip()
-        grouped.add_line(node, output)
+        grouped.add_line(*line.split(': ', 1))
         if options.watch:
             if not holdoff:
                 holdoff = os.times()[4] + 0.250

confluent_client/bin/confetty

@@ -1,8 +1,8 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2014 IBM Corporation
-# Copyright 2015-2018 Lenovo
+# Copyright 2015-2016 Lenovo
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -49,7 +49,6 @@ import select
 import shlex
 import signal
 import socket
-import struct
 import sys
 import time
 try:
@@ -76,11 +75,6 @@ import confluent.termhandler as termhandler
 import confluent.tlvdata as tlvdata
 import confluent.client as client
 
-try:
-    unicode
-except NameError:
-    unicode = str
-
 conserversequence = '\x05c'  # ctrl-e, c
 clearpowermessage = False
 
@@ -94,15 +88,6 @@ except NameError:
 netserver = None
 laststate = {}
 
-try:
-    input = raw_input
-except NameError:
-    pass
-
-class BailOut(Exception):
-    def __init__(self, errorcode=0):
-        self.errorcode = errorcode
-
 
 def print_help():
     print("confetty provides a filesystem like interface to confluent.  "
@@ -204,9 +189,9 @@ def prompt():
     if os.environ.get('TERM', '') not in ('linux'):
         sys.stdout.write('\x1b]0;confetty: %s\x07' % target)
     try:
-        return input(target + ' -> ')
+        return raw_input(target + ' -> ')
     except KeyboardInterrupt:
-        print("")
+        print ""
         return ""
     except EOFError:  # ctrl-d
         print("exit")
@@ -292,8 +277,6 @@ def rcompleter(text, state):
 
 
 def parse_command(command):
-    if isinstance(command, list):
-        return command
     try:
         args = shlex.split(command, posix=True)
     except ValueError as ve:
@@ -306,11 +289,8 @@ currchildren = None
 
 
 def print_result(res):
-    global exitcode
     if 'errorcode' in res or 'error' in res:
-        print(res['error'])
-        if 'errorcode' in res:
-            exitcode |= res['errorcode']
+        print res['error']
         return
     if 'databynode' in res:
         print_result(res['databynode'])
@@ -323,9 +303,9 @@ def print_result(res):
             attrstr = '%s=%s' % (key, recurse_format(res[key]))
         elif not isinstance(res[key], dict):
             try:
-                print('{0}: {1}'.format(key, res[key]))
+                print '{0}: {1}'.format(key, res[key])
             except UnicodeEncodeError:
-                print('{0}: {1}'.format(key, repr(res[key])))
+                print '{0}: {1}'.format(key, repr(res[key]))
             continue
         elif 'value' in res[key] and res[key]['value'] is not None:
             attrstr = '%s="%s"' % (key, res[key]['value'])
@@ -338,7 +318,7 @@ def print_result(res):
         else:
             sys.stdout.write('{0}: '.format(key))
             if isinstance(res[key], str) or isinstance(res[key], unicode):
-                print(res[key])
+                print res[key]
             else:
                 print_result(res[key])
             continue
@@ -373,7 +353,7 @@ def do_command(command, server):
     if argv[0] == 'exit':
         if os.environ.get('TERM', '') not in ('linux'):
             sys.stdout.write('\x1b]0;\x07')
-        raise BailOut()
+        sys.exit(0)
     elif argv[0] in ('help', '?'):
         return print_help()
     elif argv[0] == 'cd':
@@ -437,10 +417,10 @@ def do_command(command, server):
         for res in session.read(targpath):
             if 'item' in res:  # a link relation
                 if type(res['item']) == dict:
-                    print(res['item']["href"])
+                    print res['item']["href"]
                 else:
                     for item in res['item']:
-                        print(item["href"])
+                        print item["href"]
             else:  # generic attributes to list
                 if 'error' in res:
                     sys.stderr.write(res['error'] + '\n')
@@ -454,10 +434,6 @@ def do_command(command, server):
         currconsole = targpath
         startrequest = {'operation': 'start', 'path': targpath,
                         'parameters': {}}
-        height, width = struct.unpack(
-            'hh', fcntl.ioctl(sys.stdout, termios.TIOCGWINSZ, b'....'))[:2]
-        startrequest['parameters']['width'] = width
-        startrequest['parameters']['height'] = height
         for param in argv[2:]:
             (parmkey, parmval) = param.split("=")
             startrequest['parameters'][parmkey] = parmval
@@ -502,8 +478,7 @@ def createresource(args):
         collection = targpath
     else:
         collection, _, resname = targpath.rpartition('/')
-        if 'name' not in keydata:
-            keydata['name'] = resname
+        keydata['name'] = resname
     makecall(session.create, (collection, keydata))
 
 
@@ -518,13 +493,6 @@ def makecall(callout, args):
             if 'errorcode' in response:
                 exitcode = response['errorcode']
             sys.stderr.write('Error: ' + response['error'] + '\n')
-        if 'databynode' in response:
-            lresponse = response['databynode']
-            for node in lresponse:
-                if 'errorcode' in lresponse[node]:
-                    exitcode = lresponse[node]['errorcode']
-                if 'error' in lresponse[node]:
-                    sys.stderr.write('{0}: Error - {1}\n'.format(node, lresponse[node]['error']))
 
 
 def clearvalues(resource, attribs):
@@ -607,20 +575,11 @@ def fullpath_target(currpath, forcepath=False):
         ntarget += '/'
     return ntarget
 
-def do_resize(a, b):
-    if not inconsole:
-        return
-    height, width = struct.unpack(
-        'hh', fcntl.ioctl(sys.stdout, termios.TIOCGWINSZ, b'....'))[:2]
-    tlvdata.send(session.connection, {'operation': 'resize', 'width': width,
-                                      'height': height})
-
 
 def startconsole(nodename):
     global inconsole
     global consolename
     global didconsole
-    signal.signal(signal.SIGWINCH, do_resize)
     didconsole = True
     consolename = nodename
     tty.setraw(sys.stdin.fileno())
@@ -639,12 +598,11 @@ def quitconfetty(code=0, fullexit=False, fixterm=True):
         if oldtcattr is not None:
             termios.tcsetattr(sys.stdin.fileno(), termios.TCSANOW, oldtcattr)
     # Request default color scheme, to undo potential weirdness of terminal
-    if sys.stdout.isatty():
-        sys.stdout.write('\x1b[m')
+    sys.stdout.write('\x1b[m')
     if fullexit:
-        if sys.stdout.isatty() and os.environ.get('TERM', '') not in ('linux'):
+        if os.environ.get('TERM', '') not in ('linux'):
             sys.stdout.write('\x1b]0;\x07')
-        raise BailOut(code)
+        sys.exit(code)
     else:
         tlvdata.send(session.connection, {'operation': 'stop',
                                           'path': currconsole})
@@ -663,28 +621,6 @@ def get_session_node(shellargs):
     return None
 
 
-def run_inline_command(path, arg, completion, **kwargs):
-    tlvdata.send(session.connection, {'operation': 'pause',
-                                              'path': currconsole})
-    buffdata = ''
-    while select.select((session.connection,), (), (), 0)[0]:
-        buffdata += consume_termdata(session.connection, bufferonly=True)
-    rc = session.simple_noderange_command(consolename, path, arg, **kwargs)
-    tlvdata.send(session.connection, {'operation': 'resume',
-                                      'path': currconsole})
-    sys.stdout.write(completion)
-    sys.stdout.flush()
-    if buffdata:
-        try:
-            sys.stdout.write(buffdata)
-        except UnicodeEncodeError:
-            sys.stdout.buffer.write(buffdata.encode('utf8'))
-        except IOError:  # Some times circumstances are bad
-                         # resort to byte at a time...
-            for d in buffdata:
-                sys.stdout.write(d)
-    return rc
-
 def conserver_command(filehandle, localcommand):
     # x - conserver has that as 'show baud', I am inclined to replace that with
     #     'request exclusive'
@@ -720,13 +656,13 @@ def conserver_command(filehandle, localcommand):
         localcommand = get_command_bytes(filehandle, localcommand, cmdlen)
 
         if localcommand[1] == 'o': # off
-            sys.stdout.write("powering off...")
-            sys.stdout.flush()
-            run_inline_command('/power/state', 'off', 'complete]')
+            print("powering off...")
+            session.simple_noderange_command(consolename, '/power/state', 'off')
+            print("complete]\r")
         elif localcommand[1] == 's':  # shutdown
-            sys.stdout.write("shutting down...")
-            sys.stdout.flush()
-            run_inline_command('/power/state', 'shutdown', 'complete]')
+            print("shutting down...")
+            session.simple_noderange_command(consolename, '/power/state', 'shutdown')
+            print("complete]\r")
         elif localcommand[1] == 'b': # boot
             cmdlen += 1
             localcommand = get_command_bytes(filehandle, localcommand, cmdlen)
@@ -737,46 +673,59 @@ def conserver_command(filehandle, localcommand):
                 bootmode = 'uefi'
                 bootdev = 'setup'
 
-                rc = run_inline_command('/boot/nextdevice', bootdev, '', bootmode=bootmode)
+                rc = session.simple_noderange_command(consolename, '/boot/nextdevice', bootdev, bootmode=bootmode)
 
                 if rc:
                     print("Error]\r")
                 else:
-                    rc = run_inline_command('/power/state', 'boot', 'complete]')
-                    if rc:
-                        print("Error]")
-
-            elif localcommand[2] == 'n':  # boot to network
-                sys.stdout.write("booting to network...")
-                sys.stdout.flush()
-                bootmode = 'uefi'
-                bootdev = 'network'
-                rc = run_inline_command('/boot/nextdevice', bootdev, '', bootmode=bootmode)
-                if rc:
-                    print("Error]\r")
-                else:
-                    rc = run_inline_command('/power/state', 'boot', 'complete]')
+                    rc = session.simple_noderange_command(consolename, '/power/state', 'boot')
                     if rc:
                         print("Error]\r")
+                    else:
+                        print("complete]\r")
+
+            elif localcommand[2] == 'n':  # boot to network
+                print("booting to network...")
+
+                bootmode = 'uefi'
+                bootdev = 'network'
+
+                rc = session.simple_noderange_command(consolename, '/boot/nextdevice', bootdev, bootmode=bootmode)
+
+                if rc:
+                    print("Error]\r")
+                else:
+                    rc = session.simple_noderange_command(consolename, '/power/state', 'boot')
+
+                    if rc:
+                        print("Error]\r")
+                    else:
+                        print("complete]\r")
+
             elif localcommand[2] == '\x0d':  # boot to default
                 print("booting to default...")
 
                 bootmode = 'uefi'
                 bootdev = 'default'
 
-                rc = run_inline_command('/boot/nextdevice', bootdev, '', bootmode=bootmode)
+                rc = session.simple_noderange_command(consolename, '/boot/nextdevice', bootdev, bootmode=bootmode)
 
                 if rc:
                     print("Error]\r")
                 else:
-                    rc = run_inline_command('/power/state', 'boot', 'complete]')
+                    rc = session.simple_noderange_command(consolename, '/power/state', 'boot')
+
                     if rc:
                         print("Error]\r")
+                    else:
+                        print("complete]\r")
+
             else:
                 print("Unknown boot state.]\r")
 
         else:
             print("Unknown power state.]\r")
+
         check_power_state()
     elif localcommand[0] == 'r':
         sys.stdout.write('\x1b7\x1b[999;999H\x1b[6n')
@@ -846,10 +795,6 @@ parser.add_option("-s", "--server", dest="netserver",
 parser.add_option("-c", "--control", dest="controlpath",
                   help="Path to offer terminal control",
                   metavar="PATH")
-parser.add_option(
-    '-m', '--mintime', default=0,
-    help='Minimum time to run or else pause for input (used to keep a '
-         'terminal from closing quickly on error)')
 opts, shellargs = parser.parse_args()
 
 username = None
@@ -874,10 +819,49 @@ def server_connect():
         passphrase = os.environ['CONFLUENT_PASSPHRASE']
         session.authenticate(username, passphrase)
     while not session.authenticated:
-        username = input("Name: ")
+        username = raw_input("Name: ")
         passphrase = getpass.getpass("Passphrase: ")
         session.authenticate(username, passphrase)
 
+
+try:
+    server_connect()
+except EOFError, KeyboardInterrupt:
+    sys.exit(0)
+except socket.gaierror:
+    sys.stderr.write('Could not connect to confluent\n')
+    sys.exit(1)
+# clear on start can help with readable of TUI, but it
+# can be annoying, so for now don't do it.
+# sys.stdout.write('\x1b[H\x1b[J')
+# sys.stdout.flush()
+
+if sys.stdout.isatty():
+    import readline
+
+    readline.parse_and_bind("tab: complete")
+    readline.parse_and_bind("set bell-style none")
+    dl = readline.get_completer_delims().replace('-', '')
+    readline.set_completer_delims(dl)
+    readline.set_completer(completer)
+
+doexit = False
+inconsole = False
+pendingcommand = ""
+session_node = get_session_node(shellargs)
+if session_node is not None:
+    consoleonly = True
+    do_command("start /nodes/%s/console/session" % session_node, netserver)
+    doexit = True
+elif shellargs:
+    command = " ".join(shellargs)
+    do_command(command, netserver)
+    quitconfetty(fullexit=True, fixterm=False)
+
+powerstate = None
+powertime = None
+
+
 def check_power_state():
     tlvdata.send(
         session.connection,
@@ -886,164 +870,86 @@ def check_power_state():
     return
 
 
-if sys.stdout.isatty():
-    import readline
-
-
-def main():
-    global inconsole
-    try:
-        server_connect()
-    except (EOFError, KeyboardInterrupt) as _:
-        raise BailOut(0)
-    except socket.gaierror:
-        sys.stderr.write('Could not connect to confluent\n')
-        raise BailOut(1)
-    # clear on start can help with readable of TUI, but it
-    # can be annoying, so for now don't do it.
-    # sys.stdout.write('\x1b[H\x1b[J')
-    # sys.stdout.flush()
-    global powerstate, powertime, clearpowermessage
-
-
-    if sys.stdout.isatty():
-
-        readline.parse_and_bind("tab: complete")
-        readline.parse_and_bind("set bell-style none")
-        dl = readline.get_completer_delims().replace('-', '')
-        readline.set_completer_delims(dl)
-        readline.set_completer(completer)
-
-    doexit = False
-    inconsole = False
-    pendingcommand = ""
-    session_node = get_session_node(shellargs)
-    if session_node is not None:
-        consoleonly = True
-        do_command("start /nodes/%s/console/session" % session_node, netserver)
-        doexit = True
-    elif shellargs:
-        do_command(shellargs, netserver)
-        quitconfetty(fullexit=True, fixterm=False)
-
-    powerstate = None
-    powertime = None
-
-    while inconsole or not doexit:
-        if inconsole:
-            try:
-                rdylist, _, _ = select.select(
-                    (sys.stdin, session.connection), (), (), 10)
-            except select.error:
-                rdylist = ()
-            for fh in rdylist:
-                if fh == session.connection:
-                    consume_termdata(fh)
-                else:
-                    try:
-                        myinput = fh.read()
-                        myinput = check_escape_seq(myinput, fh)
-                        if myinput:
-                            tlvdata.send(session.connection, myinput)
-                    except IOError:
-                        pass
-            if powerstate is None or powertime < time.time() - 10:  # Check powerstate every 10 seconds
-                powertime = time.time()
-                powerstate = True
-                check_power_state()
-        else:
-            currcommand = prompt()
-            try:
-                do_command(currcommand, netserver)
-            except socket.error:
+while inconsole or not doexit:
+    if inconsole:
+        try:
+            rdylist, _, _ = select.select(
+                (sys.stdin, session.connection), (), (), 10)
+        except select.error:
+            rdylist = ()
+        for fh in rdylist:
+            if fh == session.connection:
+                # this only should get called in the
+                # case of a console session
+                # each command should slurp up all relevant
+                # recv potential
+                #fh.read()
                 try:
-                    server_connect()
-                    do_command(currcommand, netserver)
-                except socket.error:
-                    doexit = True
-                    sys.stdout.write('Lost connection to server')
-    quitconfetty(fullexit=True)
-
-def consume_termdata(fh, bufferonly=False):
-    global clearpowermessage
-    try:
-        data = tlvdata.recv(fh)
-    except Exception:
-        data = None
-    if type(data) == dict:
-        updatestatus(data)
-        return ''
-    if data is not None:
-        data = client.stringify(data)
-        if clearpowermessage:
-            sys.stdout.write("\x1b[2J\x1b[;H")
-            clearpowermessage = False
-        if bufferonly:
-            return data
-        try:
-            sys.stdout.write(data)
-        except UnicodeEncodeError:
-            sys.stdout.buffer.write(data.encode('utf8'))
-        except IOError:  # Some times circumstances are bad
-                         # resort to byte at a time...
-            for d in data:
-                sys.stdout.write(d)
-        now = time.time()
-        if ('showtime' not in laststate or
-                                (now // 60) != laststate['showtime'] // 60):
-            # don't bother churning if minute does not change
-            laststate['showtime'] = now
-            updatestatus()
-        try:
-            sys.stdout.flush()
-        except Exception:
-            # EWOULDBLOCK causes this to raise, ignore
-            # this scenario comfortable that it
-            # will come out soon enough
-            pass
+                    data = tlvdata.recv(fh)
+                except Exception:
+                    data = None
+                if type(data) == dict:
+                    updatestatus(data)
+                    continue
+                if data is not None:
+                    if clearpowermessage:
+                        sys.stdout.write("\x1b[2J\x1b[;H")
+                        clearpowermessage = False
+                    try:
+                        sys.stdout.write(data)
+                    except IOError:  # Some times circumstances are bad
+                        # resort to byte at a time...
+                        for d in data:
+                            sys.stdout.write(d)
+                    now = time.time()
+                    if ('showtime' not in laststate or
+                            (now // 60) != laststate['showtime'] // 60):
+                        # don't bother churning if minute does not change
+                        laststate['showtime'] = now
+                        updatestatus()
+                    sys.stdout.flush()
+                else:
+                    deadline = 5
+                    connected = False
+                    while not connected and deadline > 0:
+                        try:
+                            server_connect()
+                            connected = True
+                        except (socket.gaierror, socket.error):
+                            pass
+                        if not connected:
+                            time.sleep(1)
+                            deadline -=1
+                    if connected:
+                        do_command(
+                            "start /nodes/%s/console/session skipreplay=True" % consolename,
+                            netserver)
+                    else:
+                        doexit = True
+                        inconsole = False
+                        sys.stdout.write("\r\n[remote disconnected]\r\n")
+                    break
+            else:
+                try:
+                    myinput = fh.read()
+                    myinput = check_escape_seq(myinput, fh)
+                    if myinput:
+                        tlvdata.send(session.connection, myinput)
+                except IOError:
+                    pass
+        if powerstate is None or powertime < time.time() - 10:  # Check powerstate every 10 seconds
+            powertime = time.time()
+            powerstate = True
+            check_power_state()
     else:
-        deadline = 5
-        connected = False
-        while not connected and deadline > 0:
+        currcommand = prompt()
+        try:
+            do_command(currcommand, netserver)
+        except socket.error:
             try:
                 server_connect()
-                connected = True
-            except Exception:
-                pass
-            if not connected:
-                time.sleep(1)
-                deadline -=1
-        if connected:
-            do_command(
-                "start /nodes/%s/console/session skipreplay=True" % consolename,
-                netserver)
-        else:
-            doexit = True
-            inconsole = False
-            sys.stdout.write("\r\n[remote disconnected]\r\n")
-    return ''
-
-if __name__ == '__main__':
-    errcode = 0
-    deadline = 0
-    if opts.mintime:
-        deadline = os.times()[4] + float(opts.mintime)
-    try:
-        main()
-    except BailOut as e:
-        errcode = e.errorcode
-    except Exception as e:
-        import traceback
-        excinfo = traceback.print_exc()
-        try:
-            quitconfetty()
-        except Exception:
-            pass
-        print(excinfo)
-    finally:
-        if deadline and os.times()[4] < deadline:
-            sys.stderr.write('[Exited early, hit enter to continue]')
-            sys.stdin.readline()
-        if errcode == 0:
-            errcode = exitcode
-        sys.exit(errcode)
+                do_command(currcommand, netserver)
+            except socket.error:
+                doexit = True
+                sys.stdout.write('Lost connection to server')
+quitconfetty(fullexit=True)

confluent_client/bin/confluent2ansible

@@ -1,71 +0,0 @@
-#!/usr/bin/python2
-import optparse
-import signal
-import sys
-import os
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-import confluent.sortutil as sortutil
-
-
-def lookupdata(data, key):
-    ret = data.get(key, {}).get('value', '')
-    if ret is None:
-        ret = ''
-    return ret
-
-def main():
-    argparser = optparse.OptionParser(
-    usage='''\n       %prog noderange -o ansible.hosts
-             \n ''')
-    argparser.add_option('-o', '--output',
-                         help='Ansible hosts file')
-    (options, args) = argparser.parse_args()
-    try:
-        noderange = args[0]
-    except IndexError:
-        argparser.print_help()
-        sys.exit(1)
-    if not options.output:
-        sys.stderr.write('Output file must be specified by -o\n')
-        sys.exit(1)
-    sess = client.Command()
-    databynode = {}
-    for res in sess.read('/noderange/{0}/attributes/all'.format(noderange)):
-        for node in res.get('databynode', {}):
-            if node not in databynode:
-                databynode[node] = {}
-            databynode[node].update(res['databynode'][node])
-    nodesbygroup = {}
-    with open(options.output, 'w') as importfile:
-        needempty = False
-        for node in sortutil.natural_sort(databynode):
-            data = databynode[node]
-            if not data.get('groups', []):
-                importfile.write(node + '\n')
-                needempty = True
-            for g in data.get('groups', []):
-                if g not in nodesbygroup:
-                    nodesbygroup[g] = set([node])
-                else:
-                    nodesbygroup[g].add(node)
-        if needempty:
-            importfile.write('\n')
-        for group in sortutil.natural_sort(nodesbygroup):
-            importfile.write('[{0}]\n'.format(group))
-            for node in sortutil.natural_sort(nodesbygroup[group]):
-                importfile.write('{0}\n'.format(node))
-            importfile.write('\n')
-
-
-if __name__ == '__main__':
-    main()

confluent_client/bin/confluent2hosts

@@ -1,212 +0,0 @@
-#!/usr/bin/python2
-import argparse
-import os
-import re
-import signal
-import sys
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-import confluent.client as client
-import confluent.sortutil as sortutil
-
-def partitionhostsline(line):
-    comment = ''
-    if '#' in line:
-        cmdidx = line.index('#')
-        comment = line[cmdidx:]
-        line = line[:cmdidx].strip()
-    if not line.strip():
-        return '', [], comment
-    ipaddr, names = line.split(None, 1)
-    names = names.split()
-    return ipaddr, names, comment
-
-class HostMerger(object):
-    def __init__(self):
-        self.byip = {}
-        self.byname = {}
-        self.byname6 = {}
-        self.sourcelines = []
-        self.targlines = []
-
-    def read_source(self, sourcefile):
-        with open(sourcefile, 'r') as hfile:
-            self.sourcelines = hfile.read().split('\n')
-        while not self.sourcelines[-1]:
-            self.sourcelines = self.sourcelines[:-1]
-        for x in range(len(self.sourcelines)):
-            line = self.sourcelines[x]
-            currip, names, comment = partitionhostsline(line)
-            if currip:
-                self.byip[currip] = x
-            byname = self.byname
-            if ':' in currip:
-                byname = self.byname6
-            for name in names:
-                byname[name] = x
-
-    def add_entry(self, ip, names):
-        targ = self.byname
-        if ':' in ip:
-            targ = self.byname6
-        line = '{:<39} {}'.format(ip, names)
-        x = len(self.sourcelines)
-        self.sourcelines.append(line)
-        for name in names.split():
-            if not name:
-                continue
-            targ[name] = x
-        self.byip[ip] = x
-
-
-    def read_target(self, targetfile):
-        if not os.path.exists(targetfile):
-            return
-        with open(targetfile, 'r') as hfile:
-            lines = hfile.read().split('\n')
-            while lines and not lines[-1]:
-                lines = lines[:-1]
-            for y in range(len(lines)):
-                line = lines[y]
-                currip, names, comment = partitionhostsline(line)
-                byname = self.byname
-                if ':' in currip:
-                    byname = self.byname6
-                if currip in self.byip:
-                    x = self.byip[currip]
-                    if self.sourcelines[x] is None:
-                        # have already consumed this entry
-                        continue
-                    self.targlines.append(self.sourcelines[x])
-                    self.sourcelines[x] = None
-                    continue
-                for name in names:
-                    if name in byname:
-                        x = byname[name]
-                        if self.sourcelines[x] is None:
-                            break
-                        self.targlines.append(self.sourcelines[x])
-                        self.sourcelines[x] = None
-                        break
-                else:
-                    self.targlines.append(line)
-
-    def write_out(self, targetfile):
-        while self.targlines and not self.targlines[-1]:
-            self.targlines = self.targlines[:-1]
-        while self.sourcelines and not self.sourcelines[-1]:
-            self.sourcelines = self.sourcelines[:-1]
-            if not self.sourcelines:
-                break
-        with open(targetfile, 'w') as hosts:
-            for line in self.targlines:
-                hosts.write(line + '\n')
-            for line in self.sourcelines:
-                if line is not None:
-                    hosts.write(line + '\n')
-
-def main():
-    ap = argparse.ArgumentParser(description="Create/amend /etc/hosts file for given noderange")
-    ap.add_argument('noderange', help='Noderange to generate/update /etc/hosts for')
-    ap.add_argument('-a', '--attrib', help='Pull ip addresses and hostnames from attribute database', action='store_true')
-    ap.add_argument('-i', '--ip', help='Expression to generate addresses (e.g. 172.16.1.{n1} or fd2b:246f:8a50::{n1:x})')
-    ap.add_argument('-n', '--name', help='Expression for name to add ({node}-compute, etc). If unspecified, "{node} {node}.{dns.domain}" will be used', action='append')
-    args = ap.parse_args()
-    c = client.Command()
-    if args.name:
-        names = ' '.join(args.name)
-    else:
-        names = '{node} {node}.{dns.domain}'
-    merger = HostMerger()
-    if not args.ip and not args.attrib:
-        sys.stderr.write('-a or -i is currently required\n')
-        sys.exit(1)
-    if args.attrib:
-        ip4bynode = {}
-        ip6bynode = {}
-        namesbynode = {}
-        domainsbynode = {}
-        for ent in c.read('/noderange/{0}/attributes/current'.format(args.noderange)):
-            ent = ent.get('databynode', {})
-            for node in ent:
-                for attrib in ent[node]:
-                    val = ent[node][attrib]
-                    if not isinstance(val, dict):
-                        continue
-                    val = val.get('value', None)
-                    if attrib == 'dns.domain':
-                        domainsbynode[node] = val
-                    if attrib.startswith('net.'):
-                        nameparts = attrib.split('.')
-                        if len(nameparts) == 2:
-                            currnet = None
-                        else:
-                            currnet = '.'.join(nameparts[1:-1])
-                        for currdict in (ip4bynode, ip6bynode, namesbynode):
-                            if node not in currdict:
-                                currdict[node] = {}
-                        if attrib.endswith('.ipv4_address') and val:
-                            ip4bynode[node][currnet] = val.split('/', 1)[0]
-                        elif attrib.endswith('.ipv6_address') and val:
-                            ip6bynode[node][currnet] = val.split('/', 1)[0]
-                        elif attrib.endswith('.hostname'):
-                            namesbynode[node][currnet] = re.split('\s+|,', val)
-        for node in ip4bynode:
-            mydomain = domainsbynode.get(node, None)
-            for ipdb in (ip4bynode, ip6bynode):
-                for currnet in ipdb[node]:
-                    if args.name:
-                        sys.stderr.write('Custom name and attribute addresses not currently supported together\n')
-                        sys.exit(1)
-                    else:
-                        names = list(namesbynode.get(node, {}).get(currnet, [node]))
-                        if mydomain:
-                            for name in names:
-                                if mydomain in names:
-                                    break
-                            else:
-                                for name in list(names):
-                                    names.append('{0}.{1}'.format(name, mydomain))
-                    names = ' '.join(names)
-                    merger.add_entry(ipdb[node][currnet], names)
-        merger.write_out('/etc/whatnowhosts')
-    else:
-        namesbynode = {}
-        ipbynode = {}
-        expurl = '/noderange/{0}/attributes/expression'.format(args.noderange)
-        expression = names
-        exitcode = 0
-        exitcode |= expand_expression(c, namesbynode, expurl, names)
-        exitcode |= expand_expression(c, ipbynode, expurl, args.ip)
-        if exitcode:
-            sys.exit(exitcode)
-        for node in ipbynode:
-            merger.add_entry(ipbynode[node], namesbynode[node])
-    if os.path.exists('/etc/hosts'):
-        merger.read_target('/etc/hosts')
-        os.rename('/etc/hosts', '/etc/hosts.confluentbkup')
-    merger.write_out('/etc/hosts')
-
-
-
-def expand_expression(c, namesbynode, expurl, expression):
-    exitcode = 0
-    for exp in c.create(expurl, {'expression': expression}):
-        if 'error' in exp:
-            sys.stderr.write(exp['error'] + '\n')
-            exitcode |= exp.get('errorcode', 1)
-        ex = exp.get('databynode', ())
-        for node in ex:
-            namesbynode[node] = ex[node]['value']
-    return exitcode
-
-
-if __name__ == '__main__':
-    main()

confluent_client/bin/confluent2lxca

@@ -1,76 +0,0 @@
-#!/usr/bin/python2
-import csv
-import optparse
-import signal
-import sys
-import os
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-import confluent.sortutil as sortutil
-
-headers = '# Type,Serial Number,Current IP,Current username,Current password,New password,Recovery password,Switch enable password,New IPv4,IPv4 Subnet mask,IPv4 Default gateway,IPv4 DNS1,IPv4 DNS2,New IPv6,IPv6 Prefix,IPv6 Default gateway,IPv6 DNS1,IPv6 DNS2,Domain,Host name,Display name,Rack,Lowest Rack Unit,Height,Force,Stored credentials ID,Managed authentication,Group Name'.split(',')
-
-def lookupdata(data, key):
-    ret = data.get(key, {}).get('value', '')
-    if ret is None:
-        ret = ''
-    return ret
-
-def main():
-    argparser = optparse.OptionParser(
-    usage='''\n       %prog noderange -o bulkimport.csv
-             \n ''')
-    argparser.add_option('-o', '--output',
-                         help='File to write for bulk import into xClarity Administrator')
-    (options, args) = argparser.parse_args()
-    try:
-        noderange = args[0]
-    except IndexError:
-        argparser.print_help()
-        sys.exit(1)
-    if not options.output:
-        sys.stderr.write('Output file must be specified by -o\n')
-        sys.exit(1)
-    if 'XCCUSER' not in os.environ or 'XCCPASS' not in os.environ:
-        sys.stderr.write('Must specify XCCUSER and XCCPASS in environment variables\n')
-        sys.exit(1)
-    xccuser = os.environ['XCCUSER']
-    xccpass = os.environ['XCCPASS']
-    sess = client.Command()
-    databynode = {}
-    for res in sess.read('/noderange/{0}/attributes/all'.format(noderange)):
-        for node in res.get('databynode', {}):
-            if node not in databynode:
-                databynode[node] = {}
-            databynode[node].update(res['databynode'][node])
-    for res in sess.read(
-            '/noderange/{0}/configuration/management_controller/net_interfaces/management'.format(
-                    noderange)):
-        for node in res.get('databynode', {}):
-            currip = res['databynode'][node].get('ipv4_address', {}).get(
-                'value', '')
-            if currip:
-                databynode[node]['hardwaremanagement.manager'] = {
-                    'value': currip.split('/', 1)[0]}
-    with open(options.output, 'w') as importfile:
-        bulkimport = csv.writer(importfile)
-        bulkimport.writerow(headers)
-        for node in sortutil.natural_sort(databynode):
-            data = databynode[node]
-            row = ['server', lookupdata(data, 'id.serial'), lookupdata(data, 'hardwaremanagement.manager'), xccuser, xccpass, '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', node, lookupdata(data, 'location.rack'), lookupdata(data, 'location.u'), '', '', '','', '']
-            bulkimport.writerow(row)
-
-
-
-
-if __name__ == '__main__':
-    main()

confluent_client/bin/confluent2xcat

@@ -1,103 +0,0 @@
-#!/usr/bin/python2
-import csv
-import optparse
-import signal
-import sys
-import os
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-import confluent.sortutil as sortutil
-
-
-def lookupdata(data, key):
-    ret = data.get(key, {}).get('value', '')
-    if ret is None:
-        ret = ''
-    return ret
-
-def main():
-    argparser = optparse.OptionParser(
-    usage='''\n       %prog noderange -o xcatnodes.def
-             \n ''')
-    argparser.add_option('-o', '--output',
-                         help='xCAT stanza file')
-    argparser.add_option('-m', '--macs',
-                         help='xCAT macs.csv to write')
-    (options, args) = argparser.parse_args()
-    try:
-        noderange = args[0]
-    except IndexError:
-        argparser.print_help()
-        sys.exit(1)
-    if not (options.output or options.macs):
-        sys.stderr.write('Output file must be specified by -o or -m\n')
-        sys.exit(1)
-    sess = client.Command()
-    databynode = {}
-    for res in sess.read('/noderange/{0}/attributes/all'.format(noderange)):
-        for node in res.get('databynode', {}):
-            if node not in databynode:
-                databynode[node] = {}
-            databynode[node].update(res['databynode'][node])
-    if options.output:
-        with open(options.output, 'w') as importfile:
-            for node in sortutil.natural_sort(databynode):
-                xcatattrs = collect_attribute_data(databynode, node)
-                importfile.write('{0}:\n'.format(node))
-                importfile.write('   objtype=node\n')
-                importfile.write('   arch=x86_64\n')
-                importfile.write('   netboot=xnba\n')
-                importfile.write('   mgt=ipmi\n')
-                for attr in xcatattrs:
-                    if xcatattrs[attr] is None:
-                        continue
-                    importfile.write('   {0}={1}\n'.format(attr,
-                                                           xcatattrs[attr]))
-                importfile.write('\n')
-    if options.macs:
-        with open(options.macs, 'w') as importfile:
-            macsv = csv.writer(importfile)
-            macsv.writerow(['#node', 'mac'])
-            for node in sortutil.natural_sort(databynode):
-                xcatattrs = collect_attribute_data(databynode, node)
-                macsv.writerow([node, xcatattrs['mac']])
-
-
-
-def collect_attribute_data(databynode, node):
-    data = databynode[node]
-    xcatattrs = {}
-    xcatattrs['groups'] = ','.join(data.get('groups', []))
-    xcatattrs['bmc'] = data.get('hardwaremanagement.manager', {}).get(
-        'value', None)
-    xcatattrs['mpa'] = data.get('enclosure.manager', {}).get(
-        'value', None)
-    xcatattrs['slotid'] = data.get('enclosure.bay', {}).get(
-        'value', None)
-    gotmac = False
-    for key in data:
-        if key.startswith('net.') and 'hwaddr' in key:
-            currmac = data[key].get('value', None)
-            if currmac:
-                if gotmac:
-                    sys.stderr.write(
-                        'Ignoring {0} and using only {1} for mac, '
-                        'multiple macs not supported by '
-                        'confluent2xcat\n'.format(key, gotmac))
-                    continue
-                gotmac = key
-                xcatattrs['mac'] = currmac
-    return xcatattrs
-
-
-if __name__ == '__main__':
-    main()

confluent_client/bin/dir2img

@@ -1,61 +1,19 @@
-#!/usr/bin/python
+#!/bin/sh
 # This will take a given directory and make a 'big floppy image'
 # out of it, suitable for nodemedia upload.
 
-import fcntl
-import glob
-import os
-import subprocess
-import sys
-
-def create_image(directory, image, label=None):
-    ents = 0
-    datasz = 512
-    for dir in os.walk(sys.argv[1]):
-        ents += 1
-        for filen in dir[2]:
-            ents += 1
-            filename = os.path.join(dir[0], filen)
-            currsz = os.path.getsize(filename)
-            # assuming up to 65k cluster
-            currsz = (currsz // 512 +1) * 512
-            datasz += currsz
-    datasz += ents * 32768
-    datasz = datasz // 4096 + 1
-    with open(image, 'wb') as imgfile:
-        imgfile.seek(datasz * 4096 - 1)
-        imgfile.write(b'\x00')
-    if label:
-        subprocess.check_call(['mformat', '-i', image, '-v', label,
-                               '-r', '16', '-d', '1', '-t', str(datasz),
-                               '-s', '4','-h', '2', '::'])
-    else:
-        subprocess.check_call(['mformat', '-i', image, '-r', '16', '-d', '1', '-t',
-                                str(datasz), '-s', '4','-h', '2', '::'])
-    # Some clustered filesystems will have the lock from mformat
-    # linger after close (mformat doesn't unlock)
-    # do a blocking wait for shared lock and then explicitly
-    # unlock between calls to mtools
-    with open(image, 'rb') as imgfile:
-        fcntl.flock(imgfile.fileno(), fcntl.LOCK_SH)
-        fcntl.flock(imgfile.fileno(), fcntl.LOCK_UN)
-    cpycmd = ['mcopy', '-i', image, '-s']
-    cpycmd.extend(glob.glob('{0}/*'.format(directory)))
-    cpycmd.append('::')
-    subprocess.check_call(cpycmd)
-    # though not necessary for us, make sure dir2img doesn't have a lingering
-    # flock from mcopy for any subsequent commands
-    with open(image, 'rb') as imgfile:
-        fcntl.flock(imgfile.fileno(), fcntl.LOCK_SH)
-        fcntl.flock(imgfile.fileno(), fcntl.LOCK_UN)
-
-
-if __name__ == '__main__':
-    if len(sys.argv) < 3:
-        sys.stderr.write("Usage: {0} <directory> <imagefile>".format(
-            sys.argv[0]))
-        sys.exit(1)
-    label = None
-    if len(sys.argv) > 3:
-        label = sys.argv[3]
-    create_image(sys.argv[1], sys.argv[2], label)
+if [ -z "$1" -o -z "$2" ]; then
+        echo "Usage: $0 <directory> <imagefile>"
+        exit 1
+fi
+# Get the needed payload side
+SIZE=$(du -sB 512 $1|awk '{print $1}')
+ENTRIES=$(find $1 |wc -l)
+# Also, each file and directory has overhead, pad size by 32kb per file,
+# which should be overkill but other values proved to be inadequate
+# A deeper understanding of VFAT would probably allow for more precise value
+SIZE=$((SIZE + ENTRIES * 64))
+dd if=/dev/zero of=$2 bs=512 count=$SIZE
+# Make a big single sided floppy with many many tracks, saves on complex math
+mformat -i $2 -d 1 -t $SIZE -s 1 -h 1 ::
+mcopy -i $2 -s $1/* ::

confluent_client/bin/nodeattrib

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -17,7 +17,6 @@
 
 __author__ = 'alin37'
 
-from getpass import getpass
 import optparse
 import os
 import signal
@@ -48,11 +47,6 @@ argparser.add_option('-e', '--environment', action='store_true',
                           'same name')
 argparser.add_option('-c', '--clear', action='store_true',
                      help='Clear attributes')
-argparser.add_option('-p', '--prompt', action='store_true',
-                     help='Prompt for attribute values interactively')
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Prompt if trying to set attributes on more '
-                          'than specified number of nodes')
 (options, args) = argparser.parse_args()
 
 
@@ -73,25 +67,12 @@ exitcode = 0
 nodetype="noderange"
 
 if len(args) > 1:
-    if "=" in args[1] or options.clear or options.environment or options.prompt:
+    if "=" in args[1] or options.clear or options.environment:
         if "=" in args[1] and options.clear:
             print("Can not clear and set at the same time!")
             argparser.print_help()
             sys.exit(1)
-        argassign = None
-        if options.prompt:
-            argassign = {}
-            for arg in args[1:]:
-                oneval = 1
-                twoval = 2
-                while oneval != twoval:
-                    oneval = getpass('Enter value for {0}: '.format(arg))
-                    twoval = getpass('Confirm value for {0}: '.format(arg))
-                    if oneval != twoval:
-                        print('Values did not match.')
-                argassign[arg] = twoval
-        session.stop_if_noderange_over(noderange, options.maxnodes)
-        exitcode=client.updateattrib(session,args,nodetype, noderange, options, argassign)
+        exitcode=client.updateattrib(session,args,nodetype, noderange, options)
     try:
         # setting user output to what the user inputs
         if args[1] == 'all':
@@ -105,10 +86,7 @@ if len(args) > 1:
             requestargs=args[1:]
     except:
         pass
-elif options.clear or options.environment or options.prompt:
-    sys.stderr.write('Attribute names required with specified options\n')
-    argparser.print_help()
-    exitcode = 400
+
 if exitcode != 0:
     sys.exit(exitcode)
 
@@ -133,6 +111,6 @@ else:
             sys.stderr.write(res['error'] + '\n')
             exitcode = 1
         else:
-            print(res['item']['href'].replace('/', ''))
+            print res['item']['href'].replace('/', '')
 
-sys.exit(exitcode)
+sys.exit(exitcode)

confluent_client/bin/nodebmcreset

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015-2017 Lenovo
@@ -32,8 +32,6 @@ if path.startswith('/opt'):
 import confluent.client as client
 
 argparser = optparse.OptionParser(usage="Usage: %prog <noderange>")
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Number of nodes to affect before prompting for confirmation')
 (options, args) = argparser.parse_args()
 try:
     noderange = args[0]
@@ -45,7 +43,7 @@ session = client.Command()
 exitcode = 0
 
 errorNodes = set([])
-session.stop_if_noderange_over(noderange, options.maxnodes)
+
 success = session.simple_noderange_command(noderange, 'configuration/management_controller/reset', 'reset', key='state', errnodes=errorNodes)   # = 0 if successful
 
 # Determine which nodes were successful and print them
@@ -53,14 +51,12 @@ success = session.simple_noderange_command(noderange, 'configuration/management_
 allNodes = set([])
 
 for node in session.read('/noderange/{0}/nodes/'.format(noderange)):
-    if 'error' in node and success != 0:
-        sys.exit(success)
     allNodes.add(node['item']['href'].replace("/", ""))
 
 goodNodes = allNodes - errorNodes
 
 for node in goodNodes:
-    print(node + ": BMC Reset Successful")
+    print node + ": BMC Reset Successful"
 
 
 sys.exit(success)

confluent_client/bin/nodeboot

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015 Lenovo
@@ -35,17 +35,10 @@ argparser = optparse.OptionParser()
 argparser.add_option('-b', '--bios', dest='biosmode',
                      action='store_true', default=False,
                      help='Request BIOS style boot (rather than UEFI)')
-argparser.add_option('-u', '--uefi', dest='uefimode',
-                     action='store_true', default=False,
-                     help='Request UEFI style boot (rather than BIOS)')
 argparser.add_option('-p', '--persist', dest='persist', action='store_true',
                      default=False,
                      help='Request the boot device be persistent rather than '
                           'one time')
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to boot, '
-                          'prompting if over the threshold')                        
 
 (options, args) = argparser.parse_args()
 
@@ -58,8 +51,8 @@ except IndexError:
     sys.exit(1)
 client.check_globbing(noderange)
 bootdev = None
-if len(args) > 1:
-    bootdev = args[1]
+if len(sys.argv) > 2:
+    bootdev = sys.argv[2]
     if bootdev in ('net', 'pxe'):
         bootdev = 'network'
 session = client.Command()
@@ -70,7 +63,6 @@ else:
     bootmode = 'uefi'
 
 errnodes = set([])
-session.stop_if_noderange_over(noderange, options.maxnodes)
 rc = session.simple_noderange_command(noderange, '/boot/nextdevice', bootdev,
                                      bootmode=bootmode,
                                      persistent=options.persist,

confluent_client/bin/nodeconfig

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -43,7 +43,7 @@ def bailout(msg, code=1):
     sys.exit(code)
 
 
-argparser = optparse.OptionParser(usage="Usage: %prog [options] <noderange> [setting|setting=value]")
+argparser = optparse.OptionParser()
 argparser.add_option('-c', '--comparedefault', dest='comparedefault',
                      action='store_true', default=False,
                      help='Compare given settings to default or list settings '
@@ -54,30 +54,10 @@ argparser.add_option('-d', '--detail', dest='detail',
                      action='store_true', default=False,
                      help='Provide verbose information as available, such as '
                           'help text and possible valid values')
-argparser.add_option('-e', '--extra', dest='extra',
-                     action='store_true', default=False,
-                     help='Access extra configuration.  Extra configuration is generally '
-                           'reserved for unpopular or redundant options that may be slow to '
-                           'read.  Notably the IMM category on Lenovo settings is considered '
-                           'to be extra configuration')
 argparser.add_option('-x', '--exclude', dest='exclude',
                      action='store_true', default=False,
                      help='Treat positional arguments as items to not '
                           'examine, compare, or restore default')
-argparser.add_option('-a', '--advanced', dest='advanced',
-                     action='store_true', default=False,
-                     help='Include advanced settings, which are normally not '
-                          'intended to be used without direction from the '
-                          'relevant server vendor.')
-argparser.add_option('-r', '--restoredefault', default=False,
-                     dest='restoredefault', metavar="COMPONENT",
-                     help='Restore the configuration of the node '
-                          'to factory default for given component. '
-                          'Currently only uefi is supported')
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to configure, '
-                          'prompting if over the threshold')
 (options, args) = argparser.parse_args()
 
 cfgpaths = {
@@ -108,9 +88,6 @@ setmode = None
 assignment = {}
 queryparms = {}
 printsys = []
-printbmc = []
-printextbmc = []
-printallbmc = False
 setsys = {}
 forceset = False
 needval = None
@@ -134,10 +111,9 @@ def _assign_value():
     assignment[key] = value
 
 
-def parse_config_line(arguments, single=False):
-    global setmode, printallbmc, forceset, key, value, needval, candidate, path, attrib
-    for pidx in range(0, len(arguments)):
-        param = arguments[pidx]
+def parse_config_line(arguments):
+    global setmode, forceset, key, value, needval, candidate, path, attrib
+    for param in arguments:
         if param == 'show':
             continue  # forgive muscle memory of pasu users
         if param == 'set':
@@ -146,20 +122,14 @@ def parse_config_line(arguments, single=False):
             continue
         if needval:
             key = needval
-            needval = None
-            if single:
-                value = ' '.join(arguments[pidx:])
-                _assign_value()
-                break
-            else:
-                value = param
+            value = param
             _assign_value()
             continue
         if '=' in param or param[-1] == ':' or forceset:
             if setmode is None:
                 setmode = True
             if setmode != True:
-                bailout('Cannot do set and query in same command: Query detected but "{0}" appears to be set'.format(param))
+                bailout('Cannot do set and query in same command')
             if '=' in param:
                 key, _, value = param.partition('=')
                 _assign_value()
@@ -171,10 +141,8 @@ def parse_config_line(arguments, single=False):
             if setmode is None:
                 setmode = False
             if setmode != False:
-                bailout('Cannot do set and query in same command: Set mode detected but "{0}" appears to be a query'.format(param))
+                bailout('Cannot do set and query in same command')
             if '.' not in param:
-                if param == 'bmc':
-                    printallbmc = True
                 matchedparms = False
                 for candidate in cfgpaths:
                     if candidate.startswith('{0}.'.format(param)):
@@ -190,19 +158,10 @@ def parse_config_line(arguments, single=False):
                                 del queryparms[path]
                             except KeyError:
                                 pass
-                if param.lower() == 'imm':
-                    printextbmc.append(param)
-                    options.extra = True
-                elif not matchedparms:
+                if not matchedparms:
                     printsys.append(param)
             elif param not in cfgpaths:
-                if param.startswith('bmc.'):
-                    printbmc.append(param.replace('bmc.', ''))
-                elif param.lower().startswith('imm'):
-                    options.extra = True
-                    printextbmc.append(param)
-                else:
-                    printsys.append(param)
+                printsys.append(param)
             else:
                 path, attrib = cfgpaths[param]
                 path = '/noderange/{0}/{1}'.format(noderange, path)
@@ -215,41 +174,13 @@ if options.batch:
     argfile = open(options.batch, 'r')
     argset = argfile.readline()
     while argset:
-        try:
-            argset = argset[:argset.index('#')]
-        except ValueError:
-            pass
-        argset = argset.strip()
-        if argset:
-            parse_config_line(shlex.split(argset), single=True)
+        parse_config_line(shlex.split(argset))
         argset = argfile.readline()
 else:
     parse_config_line(args[1:])
 session = client.Command()
 rcode = 0
-if options.restoredefault:
-    session.stop_if_noderange_over(noderange, options.maxnodes)
-    if options.restoredefault.lower() in (
-        'sys', 'system', 'uefi', 'bios'):
-        for fr in session.update(
-                '/noderange/{0}/configuration/system/clear'.format(noderange),
-                {'clear': True}):
-            rcode |= client.printerror(fr)
-        sys.exit(rcode)
-    elif options.restoredefault.lower() in (
-        'bmc', 'imm', 'xcc'):
-        for fr in session.update(
-                '/noderange/{0}/configuration/management_controller/clear'.format(noderange),
-                {'clear': True}):
-            rcode |= client.printerror(fr)
-        sys.exit(rcode)
-    else:
-        sys.stderr.write(
-            'Unrecognized component to restore defaults: {0}\n'.format(
-                options.restoredefault))
-        sys.exit(1)
 if setmode:
-    session.stop_if_noderange_over(noderange, options.maxnodes)
     if options.exclude:
         sys.stderr.write('Cannot use exclude and assign at the same time\n')
         sys.exit(1)
@@ -257,12 +188,8 @@ if setmode:
     attrnamebypath = {}
     for key in assignment:
         if key not in cfgpaths:
-            if key.startswith('bmc.'):
-                path = 'configuration/management_controller/extended/all'
-                attrib = key.replace('bmc.', '')
-            else:
-                path = 'configuration/system/all'
-                attrib = key
+            path = 'configuration/system/all'
+            attrib = key
         else:
             path, attrib = cfgpaths[key]
         if path not in updatebypath:
@@ -278,6 +205,7 @@ if setmode:
             rcode |= client.printerror(fr)
             for node in fr.get('databynode', []):
                 r = fr['databynode'][node]
+                rcode |= client.printerror(r, node)
                 if 'value' not in r:
                     continue
                 keyval = r['value']
@@ -289,25 +217,14 @@ else:
     for path in queryparms:
         if options.comparedefault:
             continue
-        rcode |= client.print_attrib_path(path, session, list(queryparms[path]),
+        rc = client.print_attrib_path(path, session, list(queryparms[path]),
                                       NullOpt(), queryparms[path])
-    if printsys == 'all' or printextbmc or printbmc or printallbmc:
-        if printbmc or not printextbmc:
-         rcode |= client.print_attrib_path(
-                        '/noderange/{0}/configuration/management_controller/extended/all'.format(noderange),
-                        session, printbmc, options, attrprefix='bmc.')
-        if options.extra:
-            rcode |= client.print_attrib_path(
-                    '/noderange/{0}/configuration/management_controller/extended/extra'.format(noderange),
-                    session, printextbmc, options)
+        if rc:
+            sys.exit(rc)
     if printsys or options.exclude:
         if printsys == 'all':
             printsys = []
-        if (options.comparedefault or printsys == []) and not options.advanced:
-            path = '/noderange/{0}/configuration/system/all'.format(noderange)
-        else:
-            path = '/noderange/{0}/configuration/system/advanced'.format(
-                noderange)
+        path = '/noderange/{0}/configuration/system/all'.format(noderange)
         rcode = client.print_attrib_path(path, session, printsys,
                                          options)
-sys.exit(rcode)
+sys.exit(rcode)

confluent_client/bin/nodeconsole

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015 Lenovo
@@ -17,15 +17,7 @@
 
 import optparse
 import os
-import subprocess
 import sys
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-import confluent.client as client
-import confluent.sortutil as sortutil
-import confluent.logreader as logreader
 
 confettypath = os.path.join(os.path.dirname(sys.argv[0]), 'confetty')
 argparser = optparse.OptionParser(
@@ -34,57 +26,9 @@ argparser = optparse.OptionParser(
            "ctrl-'e', then release ctrl, then 'c', then '?' for a full list. "
            "For example, ctrl-'e', then 'c', then '.' will exit the current "
            "console")
-argparser.add_option('-t', '--tile', action='store_true', default=False,
-                     help='Tile console windows in the terminal')
-argparser.add_option('-l', '--log', action='store_true', default=False,
-                     help='Enter log replay mode instead of showing a live console')
 (options, args) = argparser.parse_args()
 if len(args) != 1:
     argparser.print_help()
     sys.exit(1)
-if options.log:
-    logname = args[0]
-    if not os.path.exists(logname) and logname[0] != '/':
-        logname = os.path.join('/var/log/confluent/consoles', logname)
-    if not os.path.exists(logname):
-        sys.stderr.write('Unable to locate {0} on local system\n'.format(logname))
-        sys.exit(1)
-    logreader.replay_to_console(logname)
-    sys.exit(0)
-if options.tile:
-    null = open('/dev/null', 'w')
-    nodes = []
-    sess = client.Command()
-    for res in sess.read('/noderange/{0}/nodes/'.format(args[0])):
-        node = res.get('item', {}).get('href', '/').replace('/', '')
-        if not node:
-            sys.stderr.write(res.get('error', repr(res)) + '\n')
-            sys.exit(1)
-        nodes.append(node)
-    initial = True
-    pane = 0
-    sessname = 'nodeconsole_{0}'.format(os.getpid())
-    for node in sortutil.natural_sort(nodes):
-        panename = '{0}:{1}'.format(sessname, pane)
-        if initial:
-            initial = False
-            subprocess.call(
-                ['tmux', 'new-session', '-d', '-s',
-                 sessname, '-x', '800', '-y',
-                 '800', '{0} -m 5 start /nodes/{1}/console/session'.format(
-                    confettypath, node)])
-        else:
-            subprocess.call(['tmux', 'select-pane', '-t', sessname])
-            subprocess.call(['tmux', 'set-option', '-t', panename, 'pane-border-status', 'top'], stderr=null)
-            subprocess.call(
-                    ['tmux', 'split', '-h', '-t', sessname,
-                 '{0} -m 5 start /nodes/{1}/console/session'.format(
-                     confettypath, node)])
-            subprocess.call(['tmux', 'select-layout', '-t', sessname, 'tiled'], stdout=null)
-            pane += 1
-    subprocess.call(['tmux', 'select-pane', '-t', sessname])
-    subprocess.call(['tmux', 'set-option', '-t', panename, 'pane-border-status', 'top'], stderr=null)
-    os.execlp('tmux', 'tmux', 'attach', '-t', sessname)
-else:
-    os.execl(confettypath, confettypath, 'start',
-             '/nodes/{0}/console/session'.format(args[0]))
+os.execl(confettypath, confettypath, 'start',
+         '/nodes/{0}/console/session'.format(args[0]))

confluent_client/bin/nodedefine

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -55,4 +55,4 @@ for r in session.create('/noderange/', attribs):
         exitcode |= 1
     if 'created' in r:
         print('{0}: created'.format(r['created']))
-sys.exit(exitcode)
+sys.exit(exitcode)

confluent_client/bin/nodedeploy

@@ -1,159 +0,0 @@
-#!/usr/bin/python3
-
-
-import argparse
-import os
-import sys
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-import confluent.sortutil as sortutil
-
-def cleararm(nr, cli):
-    nodes = set([])
-    for rsp in cli.read('/noderange/{0}/attributes/current'.format(nr)):
-        for node in rsp.get('databynode', {}):
-            nodeinfo = rsp['databynode'][node]
-            for attr in nodeinfo:
-                if attr == 'deployment.apiarmed':
-                    curr = nodeinfo[attr].get('value', '')
-                    if curr == 'continuous':
-                        nodes.add(node)
-    noderange = nr
-    if nodes:
-        noderange += ',-({0})'.format(','.join(nodes))
-    for rsp in cli.update('/noderange/{0}/attributes/current'.format(noderange),
-                          {'deployment.apiarmed': ''}):
-        pass
-
-
-def armonce(nr, cli):
-    nodes = set([])
-    for rsp in cli.read('/noderange/{0}/attributes/current'.format(nr)):
-        for node in rsp.get('databynode', {}):
-            nodeinfo = rsp['databynode'][node]
-            for attr in nodeinfo:
-                if attr == 'deployment.apiarmed':
-                    curr = nodeinfo[attr].get('value', '')
-                    if curr == 'continuous':
-                        nodes.add(node)
-    noderange = nr
-    if nodes:
-        noderange += ',-({0})'.format(','.join(nodes))
-    for rsp in cli.update('/noderange/{0}/attributes/current'.format(noderange),
-                          {'deployment.apiarmed': 'once'}):
-        pass
-
-
-def setpending(nr, profile, cli):
-    args = {'deployment.pendingprofile': profile}
-    if not profile.startswith('genesis-'):
-        args['deployment.stagedprofile'] = ''
-        args['deployment.profile'] = ''
-    for rsp in cli.update('/noderange/{0}/attributes/current'.format(nr),
-                          args):
-        pass
-
-
-def clearpending(nr, cli):
-    for rsp in cli.update('/noderange/{0}/attributes/current'.format(nr),
-                          {'deployment.pendingprofile': ''}):
-        pass
-
-def main(args):
-    ap = argparse.ArgumentParser(description='Deploy OS to nodes')
-    ap.add_argument('-c', '--clear', help='Clear any pending deployment action', action='store_true')
-    ap.add_argument('-n', '--network', help='Initiate deployment over PXE/HTTP', action='store_true')
-    ap.add_argument('-p', '--prepareonly', help='Prepare only, skip any interaction with a BMC associated with this deployment action', action='store_true')
-    ap.add_argument('-m', '--maxnodes', help='Specifiy a maximum nodes to be deployed')
-    ap.add_argument('noderange', help='Set of nodes to deploy')
-    ap.add_argument('profile', nargs='?', help='Profile name to deploy')
-    args, extra = ap.parse_known_args(args)
-    if args.profile is None and len(extra) == 1:
-        args.profile = extra[0]
-        extra = extra[1:]
-    if args.profile and not args.network:
-        sys.stderr.write('-n is a required argument currently to perform an install, optionally with -p\n')
-        return 1
-    if not args.profile and args.network:
-        sys.stderr.write('Both noderange and a profile name are required arguments to request a network deployment\n')
-        return 1
-    if extra:
-        sys.stderr.write('Unrecognized arguments: ' + repr(extra) + '\n')
-    c = client.Command()
-    c.stop_if_noderange_over(args.noderange, args.maxnodes)
-    errnodes = set([])
-    if not args.clear and args.network and not args.prepareonly:
-        rc = c.simple_noderange_command(args.noderange, '/boot/nextdevice', 'network',
-                                        bootmode='uefi',
-                                        persistent=False,
-                                        errnodes=errnodes)
-        if errnodes:
-            sys.stderr.write(
-                'Unable to set boot device for following nodes: {0}\n'.format(
-                    ','.join(errnodes)))
-            return 1
-        rc |= c.simple_noderange_command(args.noderange, '/power/state', 'boot')
-    if args.clear:
-        cleararm(args.noderange, c)
-        clearpending(args.noderange, c)
-    elif args.profile:
-        profnames = []
-        for prof in c.read('/deployment/profiles/'):
-            profname = prof.get('item', {}).get('href', None)
-            if profname:
-                profname = profname.replace('/', '')
-                profnames.append(profname)
-                if profname == args.profile:
-                    break
-        else:
-            sys.stderr.write('The specified profile "{}" is not an available profile\n'.format(args.profile))
-            if profnames:
-                sys.stderr.write('The following profiles are available:\n')
-                for profname in profnames:
-                    sys.stderr.write('    ' + profname + '\n')
-            else:
-                sys.stderr.write('No deployment profiles available, try osdeploy fiimport or imgutil capture\n')
-            sys.exit(1)
-        armonce(args.noderange, c)
-        setpending(args.noderange, args.profile, c)
-    else:
-        databynode = {}
-        for r in c.read('/noderange/{0}/attributes/current'.format(args.noderange)):
-            dbn = r.get('databynode', {})
-            for node in dbn:
-                if node not in databynode:
-                    databynode[node] = {}
-                for attr in dbn[node]:
-                    if attr in ('deployment.pendingprofile', 'deployment.apiarmed', 'deployment.stagedprofile', 'deployment.profile'):
-                        databynode[node][attr] = dbn[node][attr].get('value', '')
-        for node in sortutil.natural_sort(databynode):
-            profile = databynode[node].get('deployment.pendingprofile', '')
-            if profile:
-                profile = 'pending: {}'.format(profile)
-            else:
-                profile = databynode[node].get('deployment.stagedprofile', '')
-                if profile:
-                    profile = 'staged: {}'.format(profile)
-                else:
-                    profile = databynode[node].get('deployment.profile', '')
-                    if profile:
-                        profile = 'completed: {}'.format(profile)
-                    else:
-                        profile= 'No profile pending or applied'
-            armed = databynode[node].get('deployment.apiarmed', '')
-            if armed in ('once', 'continuous'):
-                armed = ' (node authentication armed)'
-            else:
-                armed = ''
-            print('{0}: {1}{2}'.format(node, profile, armed))
-        sys.exit(0)
-    if args.network and not args.prepareonly:
-        return rc
-    return 0
-
-if __name__ == '__main__':
-    sys.exit(main(sys.argv[1:]))

confluent_client/bin/nodediscover

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -19,7 +19,6 @@ import csv
 import optparse
 import os
 import sys
-import time
 
 path = os.path.dirname(os.path.realpath(__file__))
 path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
@@ -27,51 +26,31 @@ if path.startswith('/opt'):
     sys.path.append(path)
 
 import confluent.client as client
-import confluent.sortutil as sortutil
 
-defcolumns = ['Node', 'Model', 'Serial', 'UUID', 'Mac Address', 'Type',
-              'Current IP Addresses']
-columnmapping = {
-    'Node': 'nodename',
-    'Model': 'modelnumber',
-    'Model Name': 'modelname',
-    'Serial': 'serialnumber',
-    'UUID': 'uuid',
-    'Type': 'types',
-    'Current IP Addresses': 'ipaddrs',
-    'IP': 'ipaddrs',
-    'Bay': 'bay',
-    'Mac Address': 'macs',
-    'Mac': 'macs',
-    'Switch': 'switch',
-    'Port': 'port',
-    'Advertised IP': 'otheripaddrs',
-    'Other IP': 'otheripaddrs',
-}
-#TODO: add chassis uuid
+tabformat = '{0:>15}|{1:>15}|{2:>15}|{3:>36}|{4:>17}|{5:>12}|{6:>48}'
+columns = ['Node', 'Model', 'Serial', 'UUID', 'Mac Address', 'Type',
+           'Current IP Addresses']
+delimit = ['-' * 15, '-' * 15, '-' * 15, '-' * 36, '-' * 17, '-' * 12,
+           '-' * 48]
 
 
-def print_disco(options, session, currmac, outhandler, columns):
+def dumpmacs(procinfo):
+    return ','.join(procinfo['macs']) # + procinfo.get('relatedmacs', []))
+
+
+def print_disco(options, session, currmac):
     procinfo = {}
     for tmpinfo in session.read('/discovery/by-mac/{0}'.format(currmac)):
 
         procinfo.update(tmpinfo)
-    if 'Switch' in columns or 'Port' in columns:
-        for tmpinfo in session.read(
-                '/networking/macs/by-mac/{0}'.format(currmac)):
-            if 'ports' in tmpinfo:
-                # The api sorts so that the most specific available value
-                # is last
-                procinfo.update(tmpinfo['ports'][-1])
-    record = []
-    for col in columns:
-        rawcol = columnmapping[col]
-        rawval = procinfo.get(rawcol, '')
-        if isinstance(rawval, list):
-            record.append(','.join(rawval))
-        else:
-            record.append(str(rawval))
-    outhandler.add_row(record)
+    record = [procinfo['nodename'], procinfo['modelnumber'],
+              procinfo['serialnumber'], procinfo['uuid'], dumpmacs(procinfo),
+              ','.join(procinfo['types']),
+              ','.join(sorted(procinfo['ipaddrs']))]
+    if options.csv:
+        csv.writer(sys.stdout).writerow(record)
+    else:
+        print(tabformat.format(*record))
 
 
 def process_header(header):
@@ -93,9 +72,7 @@ def process_header(header):
         elif datum in ('bmc', 'imm', 'xcc'):
             fields.append('hardwaremanagement.manager')
         elif datum in ('bmc gateway', 'xcc gateway', 'imm gateway'):
-            fields.append('net.bmc.ipv4_gateway')
-        elif datum in ('bmc_gateway', 'xcc_gateway', 'imm_gateway'):
-            fields.append('net.bmc.ipv4_gateway')
+            fields.append('net.bmc.gateway')
         elif datum in ('bmcuser', 'username', 'user'):
             fields.append('secret.hardwaremanagementuser')
         elif datum in ('bmcpass', 'password', 'pass'):
@@ -145,45 +122,24 @@ def datum_to_attrib(datum):
     del datum['node']
     return datum
 
-unique_fields = frozenset(['serial', 'mac', 'uuid'])
-
 def import_csv(options, session):
     nodedata = []
-    unique_data = {}
-    exitcode = 0
     with open(options.importfile, 'r') as datasrc:
         records = csv.reader(datasrc)
         fields = process_header(next(records))
-        for field in fields:
-            if field in unique_fields:
-                unique_data[field] = set([])
-        broken = False
         for record in records:
             currfields = list(fields)
             nodedatum = {}
             for datum in record:
-                currfield = currfields.pop(0)
-                if currfield in unique_fields:
-                    if datum in unique_data[currfield]:
-                        sys.stderr.write(
-                            "Import contains duplicate values "
-                            "({0} with value {1}\n".format(currfield, datum)
-                        )
-                        sys.exit(1)
-                    unique_data[currfield].add(datum)
-                nodedatum[currfield] = datum
+                nodedatum[currfields.pop(0)] = datum
             if not datum_complete(nodedatum):
                 sys.exit(1)
-            if not search_record(nodedatum, options, session) and not broken:
-                blocking_scan(session)
             if not search_record(nodedatum, options, session):
                 sys.stderr.write(
                     "Could not match the following data: " +
                     repr(nodedatum) + '\n')
-                broken = True
+                sys.exit(1)
             nodedata.append(nodedatum)
-    if broken:
-        sys.exit(1)
     for datum in nodedata:
         maclist = search_record(datum, options, session)
         datum = datum_to_attrib(datum)
@@ -191,7 +147,6 @@ def import_csv(options, session):
         for res in session.create('/nodes/', datum):
             if 'error' in res:
                 sys.stderr.write(res['error'] + '\n')
-                exitcode |= res.get('errorcode', 1)
                 continue
             elif 'created' in res:
                 print('Defined ' + res['created'])
@@ -202,39 +157,21 @@ def import_csv(options, session):
                                       {'node': nodename}):
                 if 'error' in res:
                     sys.stderr.write(res['error'] + '\n')
-                    exitcode |= res.get('errorcode', 1)
                     continue
                 elif 'assigned' in res:
                     print('Discovered ' + res['assigned'])
                 else:
                     print(repr(res))
-    if exitcode:
-        sys.exit(exitcode)
 
 
 def list_discovery(options, session):
-    orderby = None
-    if options.fields:
-        columns = []
-        for field in options.fields.split(','):
-            for cdt in columnmapping:
-                if cdt.lower().replace(
-                        ' ', '') == field.lower().replace(' ', ''):
-                    columns.append(cdt)
-    else:
-        columns = defcolumns
-    if options.order:
-        for field in columns:
-            if options.order.lower() == field.lower():
-                orderby = field
-    outhandler = client.Tabulator(columns)
-    for mac in list_matching_macs(options, session):
-        print_disco(options, session, mac, outhandler, columns)
     if options.csv:
-        outhandler.write_csv(sys.stdout, orderby)
+        csv.writer(sys.stdout).writerow(columns)
     else:
-        for row in outhandler.get_table(orderby):
-            print(row)
+        print(tabformat.format(*columns))
+        print(tabformat.format(*delimit))
+    for mac in list_matching_macs(options, session):
+        print_disco(options, session, mac)
 
 def clear_discovery(options, session):
     for mac in list_matching_macs(options, session):
@@ -244,12 +181,8 @@ def clear_discovery(options, session):
             else:
                 print(repr(res))
 
-def list_matching_macs(options, session, node=None, checknode=True):
+def list_matching_macs(options, session):
     path = '/discovery/'
-    if node:
-        path += 'by-node/{0}/'.format(node)
-    elif checknode and options.node:
-        path += 'by-node/{0}/'.format(options.node)
     if options.model:
         path += 'by-model/{0}/'.format(options.model)
     if options.serial:
@@ -270,52 +203,33 @@ def list_matching_macs(options, session, node=None, checknode=True):
         return [options.mac.replace(':', '-')]
     else:
         path += 'by-mac/'
-        ret = []
-        for x in session.read(path):
-            if 'item' in x and 'href' in x['item']:
-                ret.append(x['item']['href'])
-        return ret
+        return [x['item']['href'] for x in session.read(path)]
 
-def assign_discovery(options, session, needid=True):
+def assign_discovery(options, session):
     abort = False
     if options.importfile:
         return import_csv(options, session)
-    if not options.node:
-        sys.stderr.write("Node (-n) must be specified for assignment\n")
-        abort = True
-    if needid and not (options.serial or options.uuid or options.mac):
+    if not (options.serial or options.uuid or options.mac):
         sys.stderr.write(
             "UUID (-u), serial (-s), or ether address (-e) required for "
             "assignment\n")
         abort = True
+    if not options.node:
+        sys.stderr.write("Node (-n) must be specified for assignment\n")
+        abort = True
     if abort:
         sys.exit(1)
-    matches = list_matching_macs(options, session, None if needid else options.node, False)
-    if not matches:
-        # Do a rescan to catch missing requested data
-        blocking_scan(session)
-        matches = list_matching_macs(options, session, None if needid else options.node, False)
+    matches = list_matching_macs(options, session)
     if not matches:
         sys.stderr.write("No matching discovery candidates found\n")
         sys.exit(1)
-    exitcode = 0
     for res in session.update('/discovery/by-mac/{0}'.format(matches[0]),
                    {'node': options.node}):
         if 'assigned' in res:
             print('Assigned: {0}'.format(res['assigned']))
-        elif 'error' in res:
-            sys.stderr.write('Error: {0}\n'.format(res['error']))
-            exitcode |= res.get('errorcode', 1)
         else:
             print(repr(res))
-    if exitcode:
-        sys.exit(exitcode)
 
-def blocking_scan(session):
-    list(session.update('/discovery/rescan', {'rescan': 'start'}))
-    while(list(session.read('/discovery/rescan'))[0].get('scanning', False)):
-        time.sleep(0.5)
-    list(session.update('/networking/macs/rescan', {'rescan': 'start'}))
 
 
 def main():
@@ -352,13 +266,8 @@ def main():
     parser.add_option('-i', '--import', dest='importfile',
                       help='Import bulk assignment data from given CSV file',
                       metavar='IMPORT.CSV')
-    parser.add_option('-f', '--fields', dest='fields',
-                      help='Select fields for output',
-                      metavar='FIELDS')
-    parser.add_option('-o', '--order', dest='order',
-                      help='Order output by given field', metavar='ORDER')
     (options, args) = parser.parse_args()
-    if len(args) == 0 or args[0] not in ('list', 'assign', 'reassign', 'rescan', 'clear'):
+    if len(args) == 0 or args[0] not in ('list', 'assign', 'rescan', 'clear'):
         parser.print_help()
         sys.exit(1)
     session = client.Command()
@@ -368,12 +277,10 @@ def main():
         clear_discovery(options, session)
     if args[0] == 'assign':
         assign_discovery(options, session)
-    if args[0] == 'reassign':
-        assign_discovery(options, session, False)
     if args[0] == 'rescan':
-        blocking_scan(session)
-        print("Rescan complete")
+        list(session.update('/discovery/rescan', {'rescan': 'start'}))
+        print("Rescan initiated")
 
 
 if __name__ == '__main__':
-    main()
+    main()

confluent_client/bin/nodeeventlog

@@ -1,7 +1,7 @@
-#!/usr/bin/python2
+#!/usr/bin/python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
-# Copyright 2015-2019 Lenovo
+# Copyright 2015-2017 Lenovo
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -33,15 +33,10 @@ if path.startswith('/opt'):
 
 import confluent.client as client
 
-if sys.version_info[0] < 3:
-    sys.stdout = codecs.getwriter('utf8')(sys.stdout)
+sys.stdout = codecs.getwriter('utf8')(sys.stdout)
 
 argparser = optparse.OptionParser(
-    usage="Usage: %prog [options] <noderange> [clear]")
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to clear if clearing log, '
-                          'prompting if over the threshold')            
+    usage="Usage: %prog [options] noderange [clear]")
 (options, args) = argparser.parse_args()
 try:
     noderange = args[0]
@@ -50,11 +45,11 @@ except IndexError:
     sys.exit(1)
 client.check_globbing(noderange)
 deletemode = False
-if len(args) > 2:
+if len(sys.argv) > 3:
     argparser.print_help()
     sys.exit(1)
-if len(args) == 2:
-    if args[1] == 'clear':
+if len(sys.argv) == 3:
+    if sys.argv[2] == 'clear':
         deletemode = True
     else:
         argparser.print_help()
@@ -69,8 +64,6 @@ def format_event(evt):
         display = dt.strptime(evt['timestamp'], '%Y-%m-%dT%H:%M:%S')
         retparts.append(display.strftime('%m/%d/%Y %H:%M:%S'))
     dscparts = []
-    if evt.get('log_id', None):
-        retparts.append(evt['log_id'] + ':')
     if 'component_type' in evt and evt['component_type'] is not None:
         dscparts.append(evt['component_type'])
     if 'component' in evt and evt['component'] is not None:
@@ -84,15 +77,11 @@ def format_event(evt):
             pass
         dscparts.append(evttext)
     retparts.append(' - '.join(dscparts))
-    msg = evt.get('message')
-    if not msg:
-        msg = ''
-    return ' '.join(retparts) + msg
+    return ' '.join(retparts)
 
 
 if deletemode:
     func = session.delete
-    session.stop_if_noderange_over(noderange, options.maxnodes)
 else:
     func = session.read
 for rsp in func('/noderange/{0}/events/hardware/log'.format(noderange)):
@@ -109,4 +98,4 @@ for rsp in func('/noderange/{0}/events/hardware/log'.format(noderange)):
             if 'events' in thisdata:
                evtdata = thisdata['events']
                for evt in evtdata:
-                   print('{0}: {1}'.format(node, format_event(evt)))
+                   print '{0}: {1}'.format(node, format_event(evt))

confluent_client/bin/nodefirmware

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2016-2017 Lenovo
@@ -37,14 +37,14 @@ exitcode = 0
 
 
 def printfirm(node, prefix, data):
-    if 'model' in data and data['model']:
+    if 'model' in data:
         prefix += ' ' + data['model']
     builddesc = []
-    if 'build' in data and data['build']:
+    if 'build' in data:
         builddesc.append(data['build'])
-    if 'date' in data and data['date']:
+    if 'date' in data:
         builddesc.append(data['date'])
-    if 'version' in data and data['version']:
+    if 'version' in data:
         version = data['version']
         if builddesc:
             version += ' ({0})'.format(' '.join(builddesc))
@@ -55,14 +55,9 @@ def printfirm(node, prefix, data):
 components = ['all']
 
 argparser = optparse.OptionParser(
-    usage="Usage: "
-          "%prog <noderange> [list][update [--backup <file>]]|[<components>]")
+    usage="Usage: %prog <noderange> [update [--backup <file>]]|[<components>]")
 argparser.add_option('-b', '--backup', action='store_true',
                      help='Target a backup bank rather than primary')
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='When updating, prompt if more than the specified '
-                          'number of servers will be affected')
-             
 (options, args) = argparser.parse_args()
 upfile = None
 try:
@@ -71,15 +66,9 @@ try:
         if args[1] == 'update':
             upfile = args[2]
         else:
-            if args[1] == 'list':
-                comps = args[2:]
-            else:
-                comps = args[1:]
             components = []
-            for arg in comps:
+            for arg in args[1:]:
                 components += arg.split(',')
-            if not components:
-                components = ['all']
 
 except IndexError:
     argparser.print_help()
@@ -88,9 +77,9 @@ client.check_globbing(noderange)
 
 def get_update_progress(session, url):
     for res in session.read(url):
-        status = res.get('phase', 'error')
-        percent = res.get('progress', None)
-        detail = res.get('detail', repr(res)),
+        status = res['phase']
+        percent = res['progress']
+        detail = res['detail']
         if status == 'error':
             text = 'error!'
         else:
@@ -99,7 +88,6 @@ def get_update_progress(session, url):
 
 def update_firmware(session, filename):
     global exitcode
-    session.stop_if_noderange_over(noderange, options.maxnodes)
     output = sq.ScreenPrinter(noderange, session)
     nodeurls = {}
     filename = os.path.abspath(filename)
@@ -109,12 +97,6 @@ def update_firmware(session, filename):
     if options.backup:
         upargs['bank'] = 'backup'
     noderrs = {}
-    if session.unixdomain:
-        of = open(filename, 'rb')
-        try:
-            session.add_file(filename, of.fileno(), 'rb')
-        except Exception:
-            pass
     for res in session.create(resource, upargs):
         if 'created' not in res:
             for nodename in res.get('databynode', ()):
@@ -147,25 +129,22 @@ def update_firmware(session, filename):
 def show_firmware(session):
     global exitcode
     firmware_shown = False
-    nodes_matched = False
     for component in components:
         for res in session.read(
                 '/noderange/{0}/inventory/firmware/all/{1}'.format(
                     noderange, component)):
-            nodes_matched = True
             exitcode |= client.printerror(res)
             if 'databynode' not in res:
                 continue
             for node in res['databynode']:
+                exitcode |= client.printerror(res['databynode'][node], node)
                 if 'firmware' not in res['databynode'][node]:
                     continue
                 for inv in res['databynode'][node]['firmware']:
                     for prefix in inv:
                         firmware_shown = True
                         printfirm(node, prefix, inv[prefix])
-    if not nodes_matched:
-        sys.stderr.write('No matching nodes for noderange "{0}"\n'.format(noderange))
-    elif not firmware_shown and not exitcode:
+    if not firmware_shown:
         argparser.print_help()
 
 
@@ -177,4 +156,4 @@ try:
         update_firmware(session, upfile)
 except KeyboardInterrupt:
     print('')
-sys.exit(exitcode)
+sys.exit(exitcode)

confluent_client/bin/nodegroupattrib

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -17,7 +17,6 @@
 
 __author__ = 'alin37'
 
-from getpass import getpass
 import optparse
 import os
 import signal
@@ -36,9 +35,9 @@ import confluent.client as client
 
 argparser = optparse.OptionParser(
     usage='''\n       %prog [options]   \
-             \n       %prog [options] nodegroup [list of attributes|all]  \
+             \n       %prog [options] nodegroup [list of attributes]  \
              \n       %prog [options] nodegroup nodes=value1,value2   \
-             \n       %prog -e nodegroup <attribute names to set>  \
+             \n       %prog -e nodegroup <attribute names to set>  \             
              \n       %prog [options] nodegroup nodes=value1,value2
              \n ''')
 argparser.add_option('-b', '--blame', action='store_true',
@@ -48,8 +47,6 @@ argparser.add_option('-e', '--environment', action='store_true',
                           'same name')
 argparser.add_option('-c', '--clear', action='store_true',
                      help='Clear variables')
-argparser.add_option('-p', '--prompt', action='store_true',
-                     help='Prompt for attribute values interactively')
 (options, args) = argparser.parse_args()
 
 
@@ -75,19 +72,7 @@ if len(args) > 1:
         print("Can not clear and set at the same time!")
         argparser.print_help()
         sys.exit(1)
-    argassign = None
-    if options.prompt:
-        argassign = {}
-        for arg in args[1:]:
-            oneval = 1
-            twoval = 2
-            while oneval != twoval:
-                oneval = getpass('Enter value for {0}: '.format(arg))
-                twoval = getpass('Confirm value for {0}: '.format(arg))
-                if oneval != twoval:
-                    print('Values did not match.')
-            argassign[arg] = twoval
-    exitcode=client.updateattrib(session,args,nodetype, nodegroups, options, argassign)
+    exitcode=client.updateattrib(session,args,nodetype, nodegroups, options)
     try:
         # setting user output to what the user inputs
         if args[1] == 'all':
@@ -97,7 +82,7 @@ if len(args) > 1:
 
         requestargs=args[1:]
     except Exception as e:
-        print(str(e))
+        print str(e)
 
 if exitcode != 0:
     sys.exit(exitcode)
@@ -123,6 +108,6 @@ else:
             sys.stderr.write(res['error'] + '\n')
             exitcode = 1
         else:
-            print(res['item']['href'].replace('/', ''))
+            print res['item']['href'].replace('/', '')
 
-sys.exit(exitcode)
+sys.exit(exitcode)

confluent_client/bin/nodegroupdefine

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -45,15 +45,14 @@ except IndexError:
 client.check_globbing(noderange)
 session = client.Command()
 exitcode = 0
-for group in noderange.split(','):
-    attribs = {'name': group}
-    for arg in args[1:]:
-        key, val = arg.split('=', 1)
-        attribs[key] = val
-    for r in session.create('/nodegroups/', attribs):
-        if 'error' in r:
-            sys.stderr.write(r['error'] + '\n')
-            exitcode |= 1
-        if 'created' in r:
-            print('{0}: created'.format(r['created']))
-sys.exit(exitcode)
+attribs = {'name': noderange}
+for arg in args[1:]:
+    key, val = arg.split('=', 1)
+    attribs[key] = val
+for r in session.create('/nodegroups/', attribs):
+    if 'error' in r:
+        sys.stderr.write(r['error'] + '\n')
+        exitcode |= 1
+    if 'created' in r:
+        print('{0}: created'.format(r['created']))
+sys.exit(exitcode)

confluent_client/bin/nodegrouplist

@@ -1,62 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2015-2017 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-__author__ = 'jjohnson2,alin37,andywray'
-
-import optparse
-import os
-import signal
-import sys
-
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-
-def main():
-    argparser = optparse.OptionParser(
-    usage="Usage: %prog\n")
-    (options, args) = argparser.parse_args()
-    noderange=""
-    nodelist=""
-    nodelist = '/nodegroups/'
-    session = client.Command()
-    exitcode = 0
-    showtype='all'
-    requestargs=args[1:]
-    nodetype='noderange'
-    if len(args) > 0:
-        argparser.print_help()
-        sys.exit(1)
-    else:
-        for res in session.read(nodelist):
-            if 'error' in res:
-                sys.stderr.write(res['error'] + '\n')
-                exitcode = 1
-            else:
-                print(res['item']['href'].replace('/', ''))
-
-    sys.exit(exitcode)
-
-if __name__ == '__main__':
-    main()

confluent_client/bin/nodegroupremove

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -43,11 +43,10 @@ noderange = args[0]
 client.check_globbing(noderange)
 session = client.Command()
 exitcode = 0
-for group in noderange.split(','):
-    for r in session.delete('/nodegroups/{0}'.format(group)):
-        if 'error' in r:
-            sys.stderr.write(r['error'] + '\n')
-            exitcode |= 1
-        if 'deleted' in r:
-            print('{0}: deleted'.format(r['deleted']))
-sys.exit(exitcode)
+for r in session.delete('/nodegroups/{0}'.format(noderange)):
+    if 'error' in r:
+        sys.stderr.write(r['error'] + '\n')
+        exitcode |= 1
+    if 'deleted' in r:
+        print('{0}: deleted'.format(r['deleted']))
+sys.exit(exitcode)

confluent_client/bin/nodegrouprename

@@ -1,63 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2019 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-__author__ = 'jjohnson2,alin37,andywray'
-
-import optparse
-import os
-import signal
-import sys
-
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-
-def main():
-    argparser = optparse.OptionParser(
-    usage="Usage: %prog <group> <new group name>\n")
-    (options, args) = argparser.parse_args()
-    noderange=""
-    nodelist=""
-    nodelist = '/nodegroups/'
-    session = client.Command()
-    exitcode = 0
-    requestargs=args[1:]
-    nodetype='noderange'
-    if len(args) != 2:
-        argparser.print_help()
-        sys.exit(1)
-    else:
-        for res in session.update(
-            '/nodegroups/{0}/attributes/rename'.format(args[0]),
-            {'rename': args[1]}):
-            if 'error' in res:
-                sys.stderr.write(res['error'] + '\n')
-                exitcode = 1
-            else:
-                print('{0}: {1}'.format(res['oldname'], res['newname']))
-
-    sys.exit(exitcode)
-
-if __name__ == '__main__':
-    main()

confluent_client/bin/nodehealth

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015-2017 Lenovo
@@ -32,8 +32,7 @@ if path.startswith('/opt'):
 
 import confluent.client as client
 
-if sys.version_info[0] < 3:
-    sys.stdout = codecs.getwriter('utf8')(sys.stdout)
+sys.stdout = codecs.getwriter('utf8')(sys.stdout)
 
 argparser = optparse.OptionParser(usage="Usage: %prog <noderange>")
 (options, args) = argparser.parse_args()
@@ -45,14 +44,6 @@ except IndexError:
 client.check_globbing(noderange)
 
 
-codemappings = {
-    'ok': 0,
-    'warning': 1,
-    'critical': 2,
-    'failed': 2,
-    'unknown': 2,
-}
-
 def main():
     global session, exitcode, healthbynode, healthexplanations, health, node, sensor, explanation
     session = client.Command()
@@ -75,11 +66,9 @@ def main():
             if 'error' in health[node]:
                 sys.stderr.write('{0}: Error: {1}\n'.format(
                     node, health[node]['error']))
-                exitcode = 3
+                exitcode |= 1
             if 'health' in health[node]:
                 healthbynode[node] = health[node]['health']['value']
-                if codemappings[healthbynode[node]] > exitcode:
-                    exitcode = codemappings[healthbynode[node]]
             if 'sensors' in health[node]:
                 healthexplanations[node] = []
                 for sensor in health[node]['sensors']:
@@ -105,5 +94,5 @@ try:
     main()
 except KeyboardInterrupt:
     print('')
-sys.exit(exitcode)
+    sys.exit(0)
 

confluent_client/bin/nodeidentify

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015-2017 Lenovo
@@ -31,7 +31,7 @@ if path.startswith('/opt'):
 
 import confluent.client as client
 
-argparser = optparse.OptionParser(usage="Usage: %prog <noderange> [on|off|blink]")
+argparser = optparse.OptionParser(usage="Usage: %prog <noderange> [on|off]")
 (options, args) = argparser.parse_args()
 try:
     noderange = args[0]
@@ -42,6 +42,9 @@ client.check_globbing(noderange)
 identifystate = None
 if len(sys.argv) > 2:
     identifystate = sys.argv[2]
+else:
+    argparser.print_help()
+    sys.exit(1)
 session = client.Command()
 exitcode = 0
 sys.exit(

confluent_client/bin/nodeinventory

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2016-2017 Lenovo
@@ -34,8 +34,7 @@ if path.startswith('/opt'):
 
 import confluent.client as client
 
-if sys.version_info[0] < 3:
-    sys.stdout = codecs.getwriter('utf8')(sys.stdout)
+sys.stdout = codecs.getwriter('utf8')(sys.stdout)
 
 filters = []
 
@@ -51,20 +50,15 @@ def print_mem_info(node, prefix, meminfo):
     memdescfmt = '{0}GB PC'
     if meminfo['memory_type'] == 'DDR3 SDRAM':
         memdescfmt += '3-{1} '
-    elif 'DDR4' in meminfo['memory_type']:
+    elif meminfo['memory_type'] == 'DDR4 SDRAM':
         memdescfmt += '4-{1} '
-    elif 'DCPMM' in meminfo['memory_type']:
-        memdescfmt = '{0}GB {1} '
-        meminfo['module_type'] = 'DCPMM'
     else:
         print('{0}: {1}: Unrecognized Memory'.format(node, prefix))
         return
-    if meminfo.get('ecc', False):
+    if meminfo['ecc']:
         memdescfmt += 'ECC '
     capacity = meminfo['capacity_mb'] / 1024
-    modtype = meminfo.get('module_type', None)
-    if modtype:
-        memdescfmt += modtype
+    memdescfmt += meminfo['module_type']
     memdesc = memdescfmt.format(capacity, meminfo['speed'])
     print('{0}: {1} description: {2}'.format(node, prefix, memdesc))
     print('{0}: {1} manufacturer: {2}'.format(
@@ -72,11 +66,10 @@ def print_mem_info(node, prefix, meminfo):
     print('{0}: {1} model: {2}'.format(node, prefix, meminfo['model']))
     print('{0}: {1} serial number: {2}'.format(node, prefix,
                                                meminfo['serial']))
-    if 'manufacture_date' in meminfo:
-        print('{0}: {1} manufacture date: {2}'.format(node, prefix,
-                                                      meminfo['manufacture_date']))
-        print('{0}: {1} manufacture location: {2}'.format(
-            node, prefix, meminfo['manufacture_location']))
+    print('{0}: {1} manufacture date: {2}'.format(node, prefix,
+                                                  meminfo['manufacture_date']))
+    print('{0}: {1} manufacture location: {2}'.format(
+        node, prefix, meminfo['manufacture_location']))
 
 exitcode = 0
 
@@ -94,7 +87,6 @@ def printerror(res, node=None):
 
 
 url = '/noderange/{0}/inventory/hardware/all/all'
-usedprefixes = set([])
 
 argparser = optparse.OptionParser(
     usage="Usage: %prog <noderange> [serial|model|uuid|mac]")
@@ -137,11 +129,6 @@ try:
                 continue
             for inv in res['databynode'][node]['inventory']:
                 prefix = inv['name']
-                idx = 2
-                while (node, prefix) in usedprefixes:
-                    prefix = '{0} {1}'.format(inv['name'], idx)
-                    idx += 1
-                usedprefixes.add((node, prefix))
                 if not inv['present']:
                     if not filters:
                         if options.json:
@@ -149,7 +136,7 @@ try:
                                 databynode[node] = {}
                             databynode[node][prefix] = inv
                         else:
-                            print('{0}: {1}: Not Present'.format(node, prefix))
+                            print '{0}: {1}: Not Present'.format(node, prefix)
                     continue
                 info = inv['information']
                 info.pop('board_extra', None)

confluent_client/bin/nodelicense

@@ -1,151 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2019 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-import optparse
-import os
-import signal
-import sys
-import time
-
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-
-exitcode = 0
-
-argparser = optparse.OptionParser(
-    usage="Usage: "
-          "%prog <noderange> [list][install <license_filename>|save <directory>|delete <license_feature_name>]")
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to delete licenses from, '
-                          'prompting if over the threshold')                  
-(options, args) = argparser.parse_args()
-upfile = None
-downdir = None
-delete = False
-try:
-    noderange = args[0]
-    if len(args) > 1:
-        if args[1] == 'install':
-            upfile = args[2]
-        elif args[1] == 'save':
-            downdir = args[2]
-        elif args[1] == 'delete':
-            delete = args[2]
-        elif args[1] != 'list':
-            argparser.print_help()
-            sys.exit(1)        
-except IndexError:
-    argparser.print_help()
-    sys.exit(1)
-client.check_globbing(noderange)
-
-
-def install_license(session, filename):
-    global exitcode
-    resource = '/noderange/{0}/configuration/' \
-               'management_controller/licenses/'.format(noderange)
-    filename = os.path.abspath(filename)
-    instargs = {'filename': filename}
-    if session.unixdomain:
-        of = open(filename, 'rb')
-        try:
-            session.add_file(filename, of.fileno(), 'rb')
-        except Exception:
-            pass
-    for res in session.create(resource, instargs):
-        for node in res.get('databynode', []):
-            if 'error' in res['databynode'][node]:
-                sys.stderr.write('{0}: {1}\n'.format(
-                    node, res['databynode'][node]['error']))
-                sys.exit(res['databynode'][node].get('errorcode', 1))        
-    show_licenses(session)
-
-
-def save_licenses(session, dirname):
-    global exitcode
-    resource = '/noderange/{0}/configuration/' \
-               'management_controller/save_licenses'.format(noderange)
-    filename = os.path.abspath(dirname)
-    instargs = {'dirname': filename}
-    for res in session.create(resource, instargs):
-        for node in res.get('databynode', {}):
-            fname = res['databynode'][node].get('filename', None)
-            if fname:
-                print('{0}: Saved license to {1}'.format(node, fname))
-            elif 'error' in res['databynode'][node]:
-                sys.stderr.write('{0}: {1}\n'.format(node, res['databynode'][node]['error']))
-            else:
-                sys.stderr.write('{0}: {1}\n'.format(node, repr(res['databynode'][node])))
-
-
-def show_licenses(session):
-    global exitcode
-    for res in session.read(
-            '/noderange/{0}/configuration/management_controller/licenses/'
-            'all'.format(noderange)):
-        for node in res.get('databynode', {}):
-            for license in res['databynode'][node].get('License', []):
-                msg = '{0}: {1}'.format(node, license.get('feature',
-                                                          'Unknown'))
-                if license.get('state', 'Active') != 'Active':
-                    msg += ' ({0})'.format(license['state'])
-                print(msg)
-
-
-def delete_license(session, licname):
-    global exitcode
-    licstodel = []
-    for res in list(session.read(
-            '/noderange/{0}/configuration/management_controller/licenses/'
-            'all'.format(noderange))):
-        for node in res.get('databynode', {}):
-            for license in res['databynode'][node].get('License', []):
-                if license.get('feature', None) == licname:
-                    prefix = '/nodes/{0}/configuration/management_controller/licenses/'.format(node)
-                    for currlic in list(session.read(prefix)):
-                        currlic = currlic.get('item', {}).get('href', 'all')
-                        if currlic == 'all':
-                            continue
-                        currname = list(session.read(prefix + currlic))[0]
-                        currname = currname.get('License', [{}])[0].get('feature', None)
-                        if currname == licname:
-                            list(session.delete(prefix + currlic))
-    show_licenses(session)
-
-try:
-    session = client.Command()
-    if upfile:
-        install_license(session, upfile)
-    elif downdir:
-        save_licenses(session, downdir)
-    elif delete:
-        session.stop_if_noderange_over(noderange, options.maxnodes)
-        delete_license(session, delete)
-    else:
-        show_licenses(session)
-except KeyboardInterrupt:
-    print('')
-sys.exit(exitcode)

confluent_client/bin/nodelist

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015-2017 Lenovo
@@ -61,7 +61,7 @@ def main():
                 sys.stderr.write(res['error'] + '\n')
                 exitcode = 1
             else:
-                print(res['item']['href'].replace('/', ''))
+                print res['item']['href'].replace('/', '')
 
     sys.exit(exitcode)
 

confluent_client/bin/nodemedia

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2018 Lenovo
@@ -83,8 +83,7 @@ def list_media(noderange, media):
         for node in res.get('databynode', []):
             url = res['databynode'][node].get('url', None)
             name =  res['databynode'][node].get('name', None)
-            if (url and not url.startswith('file:') and
-                    not res['databynode'][node].get('secure', False)):
+            if url and not res['databynode'][node].get('secure', False):
                 name += ' (insecure)'
             if not name:
                 continue
@@ -111,12 +110,6 @@ def upload_media(noderange, media):
     resource = '/noderange/{0}/media/uploads/'.format(noderange)
     upargs = {'filename': filename}
     noderrs = {}
-    if session.unixdomain:
-        of = open(filename, 'rb')
-        try:
-            session.add_file(filename, of.fileno(), 'rb')
-        except Exception:
-            pass
     nodeurls = {}
     for res in session.create(resource, upargs):
         if 'created' not in res:
@@ -193,7 +186,5 @@ def main():
         argparser.print_help()
         sys.exit(1)
     handler(noderange, media)
-
 if __name__ == '__main__':
-    main()
-    sys.exit(exitcode)
+    main()

confluent_client/bin/nodeping

@@ -1,140 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2016-2017 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from collections import deque
-import optparse
-import os
-import select
-import signal
-import subprocess
-import sys
-
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-import confluent.sortutil as sortutil
-
-
-def run():
-
-    argparser = optparse.OptionParser(
-        usage="Usage: %prog [options] noderange")
-    argparser.add_option('-f', '-c', '--count', type='int', default=168,
-                         help='Number of commands to run at a time')
-    argparser.add_option('-s', '--substitutename',
-                         help='Use a different name other than the nodename for ping, with {}, it is the entire name evaluated as an expression, otherwise it is used as a suffix')
-    # among other things, FD_SETSIZE limits.  Besides, spawning too many
-    # processes can be unkind for the unaware on memory pressure and such...
-    (options, args) = argparser.parse_args()
-    if len(args) < 1:
-        argparser.print_help()
-        sys.exit(1)
-    client.check_globbing(args[0])
-    concurrentprocs = options.count
-    c = client.Command()
-
-    currprocs = 0
-    all = set([])
-    pipedesc = {}
-    pendingexecs = deque()
-    exitcode = 0
-
-    nodemap = {}
-    if options.substitutename:
-        subname = options.substitutename
-        if '{' not in subname:
-            subname = '{node}' + subname
-        for exp in c.create('/noderange/{0}/attributes/expression'.format(args[0]),
-                        {'expression': subname}):
-            if 'error' in exp:
-                sys.stderr.write(exp['error'] + '\n')
-                exitcode |= exp.get('errorcode', 1)
-            ex = exp.get('databynode', ())
-            for node in ex:
-                nodemap[node] = ex[node]['value']
-    for rsp in c.read('/noderange/{0}/nodes/'.format(args[0])):
-        if 'error' in rsp:
-            sys.stderr.write(rsp['error'] + '\n')
-            exitcode |= rsp.get('errorcode', 1)
-        if rsp.get('item', {}).get('href', None):
-            node = rsp['item']['href'][:-1]
-            pingnode = nodemap.get(node, node)
-            cmdv = ['ping', '-c', '1', '-W', '1', pingnode]
-            if currprocs < concurrentprocs:
-                currprocs += 1
-                run_cmdv(pingnode, cmdv, all, pipedesc)
-            else:
-                pendingexecs.append((pingnode, cmdv))
-    if not all or exitcode:
-        sys.exit(exitcode)
-    rdy, _, _ = select.select(all, [], [], 10)
-    while all:
-        pernodeout = {}
-        for r in rdy:
-            desc = pipedesc[r]
-            node = desc['node']
-            data = True
-            while data and select.select([r], [], [], 0)[0]:
-                data = r.readline()
-                if not data:
-                    pop = desc['popen']
-                    ret = pop.poll()
-                    if ret is not None:
-                        exitcode = exitcode | ret
-                        all.discard(r)
-                        r.close()
-                        if desc['type'] == 'stdout':
-                            if ret:
-                                print('{0}: no_ping'.format(node))
-                            else:
-                                print('{0}: ping'.format(node))
-                            if pendingexecs:
-                                node, cmdv = pendingexecs.popleft()
-                                run_cmdv(node, cmdv, all, pipedesc)
-        for node in sortutil.natural_sort(pernodeout):
-            for line in pernodeout[node]:
-                line = client.stringify(line)
-                if options.nonodeprefix:
-                    sys.stdout.write(line)
-                else:
-                    sys.stdout.write('{0}: {1}'.format(node, line))
-        sys.stdout.flush()
-        if all:
-            rdy, _, _ = select.select(all, [], [], 10)
-    sys.exit(exitcode)
-
-
-def run_cmdv(node, cmdv, all, pipedesc):
-    nopen = subprocess.Popen(
-        cmdv, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-    pipedesc[nopen.stdout] = {'node': node, 'popen': nopen,
-                              'type': 'stdout'}
-    pipedesc[nopen.stderr] = {'node': node, 'popen': nopen,
-                              'type': 'stderr'}
-    all.add(nopen.stdout)
-    all.add(nopen.stderr)
-
-
-if __name__ == '__main__':
-    run()

confluent_client/bin/nodepower

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015-2017 Lenovo
@@ -32,16 +32,11 @@ if path.startswith('/opt'):
 import confluent.client as client
 
 argparser = optparse.OptionParser(
-    usage="Usage: %prog [options] <noderange> "
-          "([status|on|off|shutdown|boot|reset|pdu_status|pdu_off|pdu_on])")
+    usage="Usage: %prog [options] noderange "
+          "([status|on|off|shutdown|boot|reset])")
 argparser.add_option('-p', '--showprevious', dest='previous',
                      action='store_true', default=False,
                      help='Show previous power state')
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to change power state, '
-                          'prompting if over the threshold')
-
 (options, args) = argparser.parse_args()
 try:
     noderange = args[0]
@@ -51,27 +46,22 @@ except IndexError:
 client.check_globbing(noderange)
 setstate = None
 if len(args) > 1:
-    setstate = args[1]
     if setstate == 'softoff':
         setstate = 'shutdown'
+    elif not args[1] in ('stat', 'state', 'status'):
+        setstate = args[1]
 
-if setstate not in (None, 'on', 'off', 'shutdown', 'boot', 'reset', 'pdu_status', 'pdu_stat', 'pdu_on', 'pdu_off', 'status', 'stat', 'state'):
+if setstate not in (None, 'on', 'off', 'shutdown', 'boot', 'reset'):
     argparser.print_help()
     sys.exit(1)
 session = client.Command()
 exitcode = 0
 session.add_precede_key('oldstate')
-powurl = 'state'
-if setstate and setstate.startswith('pdu_'):
-    setstate = setstate.replace('pdu_', '')
-    powurl = 'inlets/all'
-if setstate in ('status', 'state', 'stat'):
-    setstate = None
 
 if options.previous:
     # get previous states
     prev = {}
-    for rsp in session.read("/noderange/{0}/power/{1}".format(noderange, powurl)):
+    for rsp in session.read("/noderange/{0}/power/state".format(noderange)):
         # gets previous (current) states
 
         databynode = rsp["databynode"]
@@ -82,7 +72,4 @@ if options.previous:
     # add dictionary to session
     session.add_precede_dict(prev)
 
-def outhandler(node, res):
-    for k in res[node]:
-        client.cprint('{0}: {1}: {2}'.format(node, k.replace('inlet_', ''), res[node][k]))
-sys.exit(session.simple_noderange_command(noderange, '/power/{0}'.format(powurl), setstate, promptover=options.maxnodes, key='state', outhandler=outhandler))
+sys.exit(session.simple_noderange_command(noderange, '/power/state', setstate))

confluent_client/bin/noderemove

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2017 Lenovo
@@ -33,12 +33,8 @@ if path.startswith('/opt'):
 import confluent.client as client
 
 argparser = optparse.OptionParser(
-    usage='''\n       %prog <noderange>
+    usage='''\n       %prog noderange
              \n ''')
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to delete, '
-                          'prompting if over the threshold')      
 (options, args) = argparser.parse_args()
 if len(args) != 1:
     argparser.print_help()
@@ -47,11 +43,10 @@ noderange = args[0]
 client.check_globbing(noderange)
 session = client.Command()
 exitcode = 0
-session.stop_if_noderange_over(noderange, options.maxnodes)
 for r in session.delete('/noderange/{0}'.format(noderange)):
     if 'error' in r:
         sys.stderr.write(r['error'] + '\n')
         exitcode |= 1
     if 'deleted' in r:
         print('{0}: deleted'.format(r['deleted']))
-sys.exit(exitcode)
+sys.exit(exitcode)

confluent_client/bin/noderename

@@ -1,52 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2019 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-import optparse
-import os
-import signal
-import sys
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-
-argparser = optparse.OptionParser(usage="Usage: %prog <noderange> <newname>")
-(options, args) = argparser.parse_args()
-try:
-    noderange = args[0]
-except IndexError:
-    argparser.print_help()
-    sys.exit(1)
-client.check_globbing(noderange)
-identifystate = None
-if len(sys.argv) > 2:
-    newname = sys.argv[2]
-else:
-    argparser.print_help()
-    sys.exit(1)
-session = client.Command()
-exitcode = 0
-sys.exit(
-    session.simple_noderange_command(noderange, 'attributes/rename', newname))
-

confluent_client/bin/nodereseat

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015-2017 Lenovo
@@ -32,10 +32,6 @@ if path.startswith('/opt'):
 import confluent.client as client
 
 argparser = optparse.OptionParser(usage="Usage: %prog <noderange>")
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to reseat, '
-                          'prompting if over the threshold')   
 (options, args) = argparser.parse_args()
 try:
     noderange = args[0]
@@ -47,7 +43,7 @@ session = client.Command()
 exitcode = 0
 
 errorNodes = set([])
-session.stop_if_noderange_over(noderange, options.maxnodes)
+
 success = session.simple_noderange_command(noderange, 'power/reseat', 'reseat', key='reseat', errnodes=errorNodes)   # = 0 if successful
 
 # Determine which nodes were successful and print them
@@ -60,7 +56,7 @@ for node in session.read('/noderange/{0}/nodes/'.format(noderange)):
 goodNodes = allNodes - errorNodes
 
 for node in goodNodes:
-    print(node + ": Reseat successful")
+    print node + ": Reseat successful"
 
 
 sys.exit(success)

confluent_client/bin/nodersync

@@ -1,159 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2016-2017 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from collections import deque
-import optparse
-import os
-import select
-import shlex
-import signal
-import subprocess
-import sys
-
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-import confluent.screensqueeze as sq
-import confluent.sortutil as sortutil
-
-
-def run():
-    argparser = optparse.OptionParser(
-        usage="Usage: %prog <file/directorylist> <noderange>:<destination>",
-    )
-    argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to run rsync to, '
-                          'prompting if over the threshold')   
-    argparser.add_option('-f', '-c', '--count', type='int', default=168,
-                         help='Number of nodes to concurrently rsync')
-    # among other things, FD_SETSIZE limits.  Besides, spawning too many
-    # processes can be unkind for the unaware on memory pressure and such...
-    argparser.disable_interspersed_args()
-    (options, args) = argparser.parse_args()
-    if len(args) < 2 or ':' not in args[-1]:
-        argparser.print_help()
-        sys.exit(1)
-    concurrentprocs = options.count
-    noderange, targpath = args[-1].split(':', 1)
-    client.check_globbing(noderange)
-    c = client.Command()
-    cmdstr = ' '.join(args[:-1])
-    cmdstr = 'rsync -av --info=progress2 ' + cmdstr
-    cmdstr += ' {node}:' + targpath
-
-    currprocs = 0
-    all = set([])
-    pipedesc = {}
-    pendingexecs = deque()
-    exitcode = 0
-    c.stop_if_noderange_over(noderange, options.maxnodes)
-    for exp in c.create('/noderange/{0}/attributes/expression'.format(noderange),
-            {'expression': cmdstr}):
-        if 'error' in exp:
-            sys.stderr.write(exp['error'] + '\n')
-            exitcode |= exp.get('errorcode', 1)
-        ex = exp.get('databynode', ())
-        for node in ex:
-            cmd = ex[node]['value']
-            if not isinstance(cmd, bytes) and not isinstance(cmd, str):
-                cmd = cmd.encode('utf-8')
-            cmdv = shlex.split(cmd)
-            if currprocs < concurrentprocs:
-                currprocs += 1
-                run_cmdv(node, cmdv, all, pipedesc)
-            else:
-                pendingexecs.append((node, cmdv))
-    if not all or exitcode:
-        sys.exit(exitcode)
-    rdy, _, _ = select.select(all, [], [], 10)
-    nodeerrs = {}
-    pernodeout = {}
-    pernodefile = {}
-    output = sq.ScreenPrinter(noderange, c)
-
-    while all:
-        for r in rdy:
-            desc = pipedesc[r]
-            node = desc['node']
-            data = True
-            while data and select.select([r], [], [], 0)[0]:
-                data = r.read(1)
-                if data:
-                    if desc['type'] == 'stdout':
-                        if node not in pernodeout:
-                            pernodeout[node] = ''
-                        pernodeout[node] += client.stringify(data)
-                        if '\n' in pernodeout[node]:
-                            currout, pernodeout[node] = pernodeout[node].split('\n', 1)
-                            if currout:
-                                pernodefile[node] = os.path.basename(currout)
-                        if '\r' in pernodeout[node]:
-                            currout, pernodeout[node] = pernodeout[node].split('\r', 1)
-                            if currout:
-                                currout = currout.split()
-                                try:
-                                    currout = currout[1]
-                                    output.set_output(node, '{0}:{1}'.format(pernodefile[node], currout))
-                                except IndexError:
-                                    pernodefile = currout[0]
-                                    pass
-                    else:
-                        output.set_output(node, 'error!')
-                        if node not in nodeerrs:
-                            nodeerrs[node] = ''
-                        nodeerrs[node] += client.stringify(data)
-                else:
-                    pop = desc['popen']
-                    ret = pop.poll()
-                    if ret is not None:
-                        exitcode = exitcode | ret
-                        all.discard(r)
-                        r.close()
-                        if node not in nodeerrs:
-                            output.set_output(node, 'complete')
-                        if desc['type'] == 'stdout' and pendingexecs:
-                            node, cmdv = pendingexecs.popleft()
-                            run_cmdv(node, cmdv, all, pipedesc)
-        if all:
-            rdy, _, _ = select.select(all, [], [], 10)
-    for node in nodeerrs:
-        for line in nodeerrs[node].split('\n'):
-            sys.stderr.write('{0}: {1}\n'.format(node, line))
-    sys.exit(exitcode)
-
-
-def run_cmdv(node, cmdv, all, pipedesc):
-    nopen = subprocess.Popen(
-        cmdv, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-    pipedesc[nopen.stdout] = {'node': node, 'popen': nopen,
-                              'type': 'stdout'}
-    pipedesc[nopen.stderr] = {'node': node, 'popen': nopen,
-                              'type': 'stderr'}
-    all.add(nopen.stdout)
-    all.add(nopen.stderr)
-
-
-if __name__ == '__main__':
-    run()

confluent_client/bin/noderun

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2016-2017 Lenovo
@@ -35,24 +35,15 @@ if path.startswith('/opt'):
 
 import confluent.client as client
 import confluent.sortutil as sortutil
-devnull = None
 
 
 def run():
-    global devnull
-    devnull = open(os.devnull, 'rb')
     argparser = optparse.OptionParser(
-        usage="Usage: %prog [options] <noderange> <command expression>",
+        usage="Usage: %prog noderange commandexpression",
         epilog="Expressions are the same as in attributes, e.g. "
                "'ipmitool -H {hardwaremanagement.manager}' will be expanded.")
     argparser.add_option('-f', '-c', '--count', type='int', default=168,
                          help='Number of commands to run at a time')
-    argparser.add_option('-n', '--nonodeprefix', action='store_true',
-                         help='Do not prefix output with node names')
-    argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to run the command with, '
-                          'prompting if over the threshold')                           
     # among other things, FD_SETSIZE limits.  Besides, spawning too many
     # processes can be unkind for the unaware on memory pressure and such...
     argparser.disable_interspersed_args()
@@ -70,7 +61,7 @@ def run():
     pipedesc = {}
     pendingexecs = deque()
     exitcode = 0
-    c.stop_if_noderange_over(args[0], options.maxnodes)
+
     for exp in c.create('/noderange/{0}/attributes/expression'.format(args[0]),
                         {'expression': cmdstr}):
         if 'error' in exp:
@@ -78,9 +69,7 @@ def run():
             exitcode |= exp.get('errorcode', 1)
         ex = exp.get('databynode', ())
         for node in ex:
-            cmd = ex[node]['value']
-            if not isinstance(cmd, bytes) and not isinstance(cmd, str):
-                cmd = cmd.encode('utf-8')
+            cmd = ex[node]['value'].encode('utf-8')
             cmdv = shlex.split(cmd)
             if currprocs < concurrentprocs:
                 currprocs += 1
@@ -96,7 +85,7 @@ def run():
             desc = pipedesc[r]
             node = desc['node']
             data = True
-            while data and select.select([r], [], [], 0)[0]:
+            while data and select.select([r], [], [], 0):
                 data = r.readline()
                 if data:
                     if desc['type'] == 'stdout':
@@ -104,11 +93,7 @@ def run():
                             pernodeout[node] = []
                         pernodeout[node].append(data)
                     else:
-                        data = client.stringify(data)
-                        if options.nonodeprefix:
-                            sys.stderr.write(data)
-                        else:
-                            sys.stderr.write('{0}: {1}'.format(node, data))
+                        sys.stderr.write('{0}: {1}'.format(node, data))
                         sys.stderr.flush()
                 else:
                     pop = desc['popen']
@@ -122,11 +107,7 @@ def run():
                             run_cmdv(node, cmdv, all, pipedesc)
         for node in sortutil.natural_sort(pernodeout):
             for line in pernodeout[node]:
-                line = client.stringify(line)
-                if options.nonodeprefix:
-                    sys.stdout.write(line)
-                else:
-                    sys.stdout.write('{0}: {1}'.format(node, line))
+                sys.stdout.write('{0}: {1}'.format(node, line))
         sys.stdout.flush()
         if all:
             rdy, _, _ = select.select(all, [], [], 10)
@@ -134,14 +115,8 @@ def run():
 
 
 def run_cmdv(node, cmdv, all, pipedesc):
-    try:
-        nopen = subprocess.Popen(
-            cmdv, stdin=devnull, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-    except OSError as e:
-        if e.errno == 2:
-            sys.stderr.write('{0}: Unable to find local executable file "{1}"'.format(node, cmdv[0]))
-            return
-        raise
+    nopen = subprocess.Popen(
+        cmdv, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     pipedesc[nopen.stdout] = {'node': node, 'popen': nopen,
                               'type': 'stdout'}
     pipedesc[nopen.stderr] = {'node': node, 'popen': nopen,

confluent_client/bin/nodesensors

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015-2017 Lenovo
@@ -32,13 +32,6 @@ path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
 if path.startswith('/opt'):
     sys.path.append(path)
 
-
-class hybridcsv(csv.excel):
-    lineterminator = '\n'
-
-
-csv.register_dialect('hybrid', hybridcsv)
-
 import confluent.client as client
 
 sensorcollections = {
@@ -121,8 +114,7 @@ def sensorpass(showout=True, appendtime=False):
                         continue
                     for redundant_state in ('Non-Critical', 'Critical'):
                         try:
-                            if sensedata.get('states', False):
-                                sensedata['states'].remove(redundant_state)
+                            sensedata['states'].remove(redundant_state)
                         except ValueError:
                             pass
                     resultdata[node][sensedata['name']] = sensedata
@@ -140,12 +132,11 @@ def sensorpass(showout=True, appendtime=False):
                             showval = u' {0} '.format(sensedata['value'])
                         if sensedata['units'] not in (None, u''):
                             showval += sensedata['units']
-                        if sensedata.get('health', 'ok') != 'ok':
+                        if sensedata['health'] != 'ok':
                             datadescription = [sensedata['health']]
                         else:
                             datadescription = []
-                        if sensedata.get('states', False):
-                            datadescription.extend(sensedata['states'])
+                        datadescription.extend(sensedata['states'])
                         if datadescription:
                             if showval == '':
                                 showval += u' {0}'.format(
@@ -156,11 +147,8 @@ def sensorpass(showout=True, appendtime=False):
                         if appendtime:
                             showval += ' @' + time.strftime(
                                 '%Y-%m-%dT%H:%M:%S')
-                        printval = u'{0}: {1}:{2}'.format(
-                            node, sensedata['name'], showval)
-                        if not isinstance(printval, str):
-                            printval = printval.encode('utf-8')
-                        print(printval)
+                        print(u'{0}: {1}:{2}'.format(
+                            node, sensedata['name'], showval).encode('utf-8'))
                         sys.stdout.flush()
     return resultdata
 
@@ -168,7 +156,7 @@ def sensorpass(showout=True, appendtime=False):
 def format_csv(csvwriter, orderedsensors, resdata, showtime=True):
     for nodekey in resdata:
         if showtime:
-            if isinstance(showtime, int):
+            if showtime.is_integer():
                 rowdata = [time.strftime('%Y-%m-%dT%H:%M:%S'), nodekey]
             else:
                 rowdata = [time.strftime('%Y-%m-%dT%H:%M:%S.') +
@@ -195,7 +183,6 @@ def format_csv(csvwriter, orderedsensors, resdata, showtime=True):
             except KeyError:
                 rowdata.append('N/A')
         csvwriter.writerow(rowdata)
-        sys.stdout.flush()
 
 
 def main():
@@ -209,14 +196,10 @@ def main():
             orderedsensors.append(name)
         orderedsensors.sort()
         for name in orderedsensors:
-            headername = sensorheaders[name]
-            if (not isinstance(headername, str) and
-                    not isinstance(headername, bytes)):
-                headername = headername.encode('utf-8')
-            headernames.append(headername)
+            headernames.append(sensorheaders[name].encode('utf-8'))
     if options.csv:
         linebyline = False
-        csvwriter = csv.writer(sys.stdout, dialect='hybrid')
+        csvwriter = csv.writer(sys.stdout)
         if options.interval:
             csvwriter.writerow(['time', 'node'] + headernames)
         else:
@@ -237,7 +220,7 @@ def main():
                     sys.exit(exitcode)
             sleeptime = nextstart - os.times()[4]
             if sleeptime > 0:
-                time.sleep(sleeptime)
+                time.sleep(nextstart - os.times()[4])
     else:
         if options.csv:
             format_csv(csvwriter, orderedsensors, resdata, showtime=False)

confluent_client/bin/nodesetboot

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2015 Lenovo
@@ -32,7 +32,7 @@ if path.startswith('/opt'):
 import confluent.client as client
 
 argparser = optparse.OptionParser(
-    usage='Usage: %prog [options] <noderange> [default|cd|network|setup|hd|usb|floppy]')
+    usage='Usage: %prog [options] noderange [default|cd|network|setup|hd]')
 argparser.add_option('-b', '--bios', dest='biosmode',
                      action='store_true', default=False,
                      help='Request BIOS style boot (rather than UEFI)')
@@ -43,10 +43,7 @@ argparser.add_option('-p', '--persist', dest='persist', action='store_true',
 argparser.add_option('-u', '--uefi', dest='uefi', action='store_true',
                      default=True,
                      help='Request UEFI style boot (rather than BIOS)')
-argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to modify next boot device, '
-                          'prompting if over the threshold')                        
+
 (options, args) = argparser.parse_args()
 
 try:
@@ -56,8 +53,8 @@ except IndexError:
     argparser.print_help()
     sys.exit(1)
 bootdev = None
-if len(args) > 1:
-    bootdev = args[1]
+if len(sys.argv) > 2:
+    bootdev = sys.argv[2]
     if bootdev in ('net', 'pxe'):
         bootdev = 'network'
 session = client.Command()
@@ -66,7 +63,6 @@ if options.biosmode:
     bootmode = 'bios'
 else:
     bootmode = 'uefi'
-session.stop_if_noderange_over(noderange, options.maxnodes)
 sys.exit(session.simple_noderange_command(noderange, '/boot/nextdevice', bootdev,
                                      bootmode=bootmode,
-                                     persistent=options.persist))
+                                     persistent=options.persist))

confluent_client/bin/nodeshell

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2016-2017 Lenovo
@@ -34,31 +34,16 @@ if path.startswith('/opt'):
 
 import confluent.client as client
 import confluent.sortutil as sortutil
-devnull = None
+
 
 def run():
-    global devnull
-    devnull = open(os.devnull, 'rb')
+
     argparser = optparse.OptionParser(
-        usage="Usage: %prog [options] noderange commandexpression",
+        usage="Usage: %prog noderange commandexpression",
         epilog="Expressions are the same as in attributes, e.g. "
                "'ipmitool -H {hardwaremanagement.manager}' will be expanded.")
     argparser.add_option('-f', '-c', '--count', type='int', default=168,
                          help='Number of commands to run at a time')
-    argparser.add_option('-l', '--loginname', type='str',
-                         help='Username to use when connecting, defaults to current user.')
-    argparser.add_option('-n', '--nonodeprefix', action='store_true',
-                         help='Do not prefix output with node names')
-    argparser.add_option('-p', '--port', type='int', default=0,
-                         help='Specify a custom port for ssh')
-    argparser.add_option('-s', '--substitutename',
-                         help='Use a different name other than the nodename for ssh')
-    argparser.add_option('-x', '--noexpression', action='store_true',
-                         help='Suppress expression expansion of command')
-    argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to run remote ssh command to, '
-                          'prompting if over the threshold')
     # among other things, FD_SETSIZE limits.  Besides, spawning too many
     # processes can be unkind for the unaware on memory pressure and such...
     argparser.disable_interspersed_args()
@@ -77,53 +62,21 @@ def run():
     pendingexecs = deque()
     exitcode = 0
 
-    c.stop_if_noderange_over(args[0], options.maxnodes)
-    nodemap = {}
-    if options.substitutename:
-        subname = options.substitutename
-        if '{' not in subname:
-            subname = '{node}' + subname
-        for exp in c.create('/noderange/{0}/attributes/expression'.format(args[0]),
-                        {'expression': subname}):
-            if 'error' in exp:
-                sys.stderr.write(exp['error'] + '\n')
-                exitcode |= exp.get('errorcode', 1)
-            ex = exp.get('databynode', ())
-            for node in ex:
-                nodemap[node] = ex[node]['value']
-    cmdparms = []
-    if options.noexpression:
-        for res in c.read('/noderange/{0}/nodes/'.format(args[0])):
-            if 'error' in res:
-                sys.stderr.write(res['error'] + '\n')
-                exitcode |= res.get('errorcode', 1)
-                break
-            node = res['item']['href'][:-1]
-            cmdparms.append((node, cmdstr))
-    else:
-        for exp in c.create('/noderange/{0}/attributes/expression'.format(args[0]),
-                            {'expression': cmdstr}):
-            if 'error' in exp:
-                sys.stderr.write(exp['error'] + '\n')
-                exitcode |= exp.get('errorcode', 1)
-            ex = exp.get('databynode', ())
-            for node in ex:
-                cmdparms.append((node, ex[node]['value']))
-    for node, cmd in cmdparms:
-        sshnode = nodemap.get(node, node)
-        if not isinstance(cmd, str) and not isinstance(cmd, bytes):
-            cmd = cmd.encode('utf-8')
-        cmdv = ['ssh']
-        if options.port:
-            cmdv += ['-p', '{0}'.format(options.port)]
-        if options.loginname:
-            cmdv += ['-l', options.loginname]
-        cmdv += [sshnode, cmd]
-        if currprocs < concurrentprocs:
-            currprocs += 1
-            run_cmdv(node, cmdv, all, pipedesc)
-        else:
-            pendingexecs.append((node, cmdv))
+
+    for exp in c.create('/noderange/{0}/attributes/expression'.format(args[0]),
+                        {'expression': cmdstr}):
+        if 'error' in exp:
+            sys.stderr.write(exp['error'] + '\n')
+            exitcode |= exp.get('errorcode', 1)
+        ex = exp.get('databynode', ())
+        for node in ex:
+            cmd = ex[node]['value'].encode('utf-8')
+            cmdv = ['ssh', node, cmd]
+            if currprocs < concurrentprocs:
+                currprocs += 1
+                run_cmdv(node, cmdv, all, pipedesc)
+            else:
+                pendingexecs.append((node, cmdv))
     if not all or exitcode:
         sys.exit(exitcode)
     rdy, _, _ = select.select(all, [], [], 10)
@@ -141,11 +94,7 @@ def run():
                             pernodeout[node] = []
                         pernodeout[node].append(data)
                     else:
-                        data = client.stringify(data)
-                        if options.nonodeprefix:
-                            sys.stderr.write(data)
-                        else:
-                            sys.stderr.write('{0}: {1}'.format(node, data))
+                        sys.stderr.write('{0}: {1}'.format(node, data))
                         sys.stderr.flush()
                 else:
                     pop = desc['popen']
@@ -159,12 +108,7 @@ def run():
                             run_cmdv(node, cmdv, all, pipedesc)
         for node in sortutil.natural_sort(pernodeout):
             for line in pernodeout[node]:
-                line = client.stringify(line)
-                if options.nonodeprefix:
-                    sys.stdout.write(line)
-                else:
-                    line = line.lstrip('\x08')
-                    sys.stdout.write('{0}: {1}'.format(node, line))
+                sys.stdout.write('{0}: {1}'.format(node, line))
         sys.stdout.flush()
         if all:
             rdy, _, _ = select.select(all, [], [], 10)
@@ -173,7 +117,7 @@ def run():
 
 def run_cmdv(node, cmdv, all, pipedesc):
     nopen = subprocess.Popen(
-        cmdv, stdin=devnull, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+        cmdv, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     pipedesc[nopen.stdout] = {'node': node, 'popen': nopen,
                               'type': 'stdout'}
     pipedesc[nopen.stderr] = {'node': node, 'popen': nopen,

confluent_client/bin/nodestorage

@@ -1,250 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2018 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-import optparse
-import os
-import signal
-import sys
-
-try:
-    input = raw_input
-except NameError:
-    pass
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-exitcode = 0
-
-class OptParser(optparse.OptionParser):
-
-    def format_epilog(self, formatter):
-        return self.expand_prog_name(self.epilog)
-
-def mbtohuman(mb):
-    if mb > 1000000:
-        return '{0:.3f} TB'.format(mb/1000000.0)
-    if mb > 1000:
-        return '{0:.3f} GB'.format(mb/1000.0)
-    return '{0:.3f} MB'.format(mb)
-
-def showstorage(noderange, options, args):
-    global exitcode
-    session = client.Command()
-    disks = {}
-    arrays = {}
-    volumes = {}
-    scfg = session.read('/noderange/{0}/configuration/storage/all'.format(
-        noderange))
-    _print_cfg(scfg)
-
-
-def _print_cfg(scfg):
-    global exitcode
-    storagebynode = {}
-    for e in scfg:
-        if 'error' in e:
-            sys.stderr.write(e['error'] + '\n')
-            exitcode = e.get('errorcode', 1)
-        for node in e.get('databynode', {}):
-            curr = e['databynode'][node]
-            if 'error' in curr:
-                if 'no available drives' in curr['error']:
-                    curr['error'] += ' (drives must be in unconfigured state to be available, they must not be in jbod or online state)'
-                sys.stderr.write('{0}: {1}\n'.format(node, curr['error']))
-                exitcode = curr.get('errorcode', 1)
-                continue
-            if node not in storagebynode:
-                storagebynode[node] = {'disks': [], 'arrays': [],
-                                       'volumes': []}
-            storagebynode[node][curr['type'] + 's'].append(curr)
-    for node in storagebynode:
-        for disk in sorted(storagebynode[node]['disks'],
-                           key=lambda x: x['name']):
-            print('{0}: Disk {1} Description: {2}'.format(
-                node, disk['name'], disk['description']))
-            print('{0}: Disk {1} State: {2}'.format(node, disk['name'],
-                                                    disk['state']))
-            print('{0}: Disk {1} FRU: {2}'.format(node, disk['name'],
-                                                  disk['fru']))
-            print('{0}: Disk {1} Serial Number: {2}'.format(node, disk['name'],
-                                                            disk['serial']))
-            if disk['array']:
-                print('{0}: Disk {1} Array: {2}'.format(node, disk['name'],
-                                                        disk['array']))
-        for arr in storagebynode[node]['arrays']:
-            print('{0}: Array {1} Available Capacity: {2}'.format(
-                node, arr['id'], mbtohuman(arr['available'])))
-            print('{0}: Array {1} Total Capacity: {2}'.format(
-                node, arr['id'], mbtohuman(arr['capacity'])))
-            print('{0}: Array {1} RAID: {2}'.format(node, arr['id'],
-                                                    arr['raid']))
-            print('{0}: Array {1} Disks: {2}'.format(node, arr['id'], ','.join(
-                arr['disks'])))
-            print(
-                '{0}: Array {1} Volumes: {2}'.format(node, arr['id'], ','.join(
-                    arr['volumes'])))
-        for vol in storagebynode[node]['volumes']:
-            print('{0}: Volume {1}: Size: {2}'.format(node, vol['name'],
-                                                      mbtohuman(vol['size'])))
-            print('{0}: Volume {1}: State: {2}'.format(node, vol['name'],
-                                                       vol['state']))
-            print('{0}: Volume {1}: Array {2}'.format(node, vol['name'],
-                                                      vol['array']))
-
-
-def createstorage(noderange, options, args):
-    if options.raidlevel is None or options.disks is None:
-        sys.stderr.write('-r and -d are required arguments to create array\n')
-        sys.exit(1)
-    session = client.Command()
-    session.stop_if_noderange_over(noderange, options.maxnodes)
-    names = options.name
-    if names is None:
-        names = ''.join(args)
-    parms = {'disks': options.disks, 'raidlevel': options.raidlevel,
-             'name': names}
-    if options.size:
-        parms['size'] = options.size
-    if options.stripsizes:
-        parms['stripsizes'] = options.stripsizes
-    _print_cfg(session.create(
-            '/noderange/{0}/configuration/storage/volumes/{1}'.format(
-                noderange, names), parms))
-
-
-def deletestorage(noderange, options, args):
-    if options.name is None:
-        if len(args) == 1:
-            names = args[0]
-        else:
-            sys.stderr.write('-n is required to indicate volume(s) to delete\n')
-            sys.exit(1)
-    else:
-        names = options.name
-    session = client.Command()
-    session.stop_if_noderange_over(noderange, options.maxnodes)
-    for rsp in session.delete(
-            '/noderange/{0}/configuration/storage/volumes/{1}'.format(
-                noderange, names)):
-        if 'deleted' in rsp:
-            print('Deleted: {0}'.format(rsp['deleted']))
-        elif 'databynode' in rsp:
-            for node in rsp['databynode']:
-                if 'error' in rsp['databynode'][node]:
-                    sys.stderr.write('{0}: {1}\n'.format(
-                        node, rsp['databynode'][node]['error']))
-                else:
-                    sys.stderr.write('{0}: {1}\n'.format(
-                        node, repr(rsp['databynode'][node])))
-        else:
-            print(repr(rsp))
-
-
-def setdisk(noderange, options, args):
-    if options.disks is None:
-        if len(args):
-            names = args.pop(0)
-        else:
-            sys.stderr.write('-d is required to indicate disk to modify\n')
-            sys.exit(1)
-    else:
-        names = options.disks
-    if not len(args) or args[0] not in ('hotspare', 'jbod', 'unconfigured'):
-        sys.stderr.write('diskset requires valid state as argument (hotspare, jbod, unconfigured)\n')
-        sys.exit(1)
-    session = client.Command()
-    session.stop_if_noderange_over(noderange, options.maxnodes)
-    scfg = session.update('/noderange/{0}/configuration/storage/disks/{1}'.format(noderange, names), {'state': args[0]})
-    _print_cfg(scfg)
-
-funmap = {
-    'create': createstorage,
-    'show': showstorage,
-    'diskset': setdisk,
-    'delete': deletestorage,
-    'rm': deletestorage,
-}
-
-
-
-def main():
-    argparser = OptParser(
-        usage='Usage: %prog <noderange> [show|create|delete|diskset] [hotspare|jbod|unconfigured] [options]',
-        epilog='',
-    )
-    argparser.add_option('-r', '--raidlevel', type='int',
-                         help='RAID level to use when creating an array')
-    argparser.add_option('-d', '--disks', type='str',
-                         help='Comma separated list of disks to use, or the '
-                              'word "rest" to indicate use of all available '
-                              'disks')
-    argparser.add_option('-i', '--interactive', default=False, action='store_true',
-                         help='Confirm any potentially destructive changes interactively')
-    argparser.add_option('-s', '--size', type='str',
-                         help='Comma separated list of sizes to use when '
-                              'creating volumes.  The sizes may be absolute '
-                              'size (e.g. 16gb), percentage (10%) or the word '
-                              '"rest" to use remaining capacity, default '
-                              'behavior is to use all capacity to make a '
-                              'volume')
-    argparser.add_option('-n', '--name', type='str',
-                         help='Comma separated list of names to use when '
-                              'naming volumes, or selecting a volume for '
-                              'delete.  Default behavior is to use '
-                              'implementation provided default names.')
-    argparser.add_option('-z', '--stripsizes', type='str',
-                         help='Comma separated list of stripsizes to use when creating volumes. '
-                            'This value is in kilobytes.  The default behavior is to allow the '
-                            'storage controller to decide.')
-    argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to configure storage on, '
-                          'prompting if over the threshold') 
-    (options, args) = argparser.parse_args()
-    if len(args) == 1:
-        args.append('show')
-    try:
-        noderange = args[0]
-        operation = args[1]
-    except IndexError:
-        argparser.print_help()
-        sys.exit(1)
-    client.check_globbing(noderange)
-    try:
-        handler = funmap[operation]
-    except KeyError:
-        argparser.print_help()
-        sys.exit(1)
-    if options.interactive and operation != 'show':
-        showstorage(noderange, None, None)
-        sys.stdout.write('The above configuration will be changed by this action, do you wish to continue (y/N): ')
-        confirm = input()
-        if confirm and confirm.lower()[0] != 'y':
-            sys.stdout.write('Aborting\n')
-            sys.exit(1)
-    handler(noderange, options, args[2:])
-
-
-if __name__ == '__main__':
-    main()

confluent_client/bin/nodesupport

@@ -1,152 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2018 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-import optparse
-import os
-import signal
-import sys
-import time
-
-try:
-    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-except AttributeError:
-    pass
-path = os.path.dirname(os.path.realpath(__file__))
-path = os.path.realpath(os.path.join(path, '..', 'lib', 'python'))
-if path.startswith('/opt'):
-    sys.path.append(path)
-
-import confluent.client as client
-import confluent.screensqueeze as sq
-
-exitcode = 0
-
-
-def get_update_progress(session, url):
-    for res in session.read(url):
-        status = res['phase']
-        percent = res['progress']
-        detail = res['detail']
-        if status == 'error':
-            text = 'error!'
-        else:
-            text = '{0}: {1:3.0f}%'.format(status, percent)
-    return text, status, detail
-
-
-def printerror(res, node=None):
-    global exitcode
-    if 'errorcode' in res:
-        exitcode = res['errorcode']
-    if 'error' in res:
-        if node:
-            sys.stderr.write('{0}: {1}\n'.format(node, res['error']))
-        else:
-            sys.stderr.write('{0}\n'.format(res['error']))
-        if 'errorcode' not in res:
-            exitcode = 1
-    for node in res.get('databynode', ()):
-        printerror(res['databynode'][node], node)
-
-
-
-def download_servicedata(noderange, media, options):
-    global exitcode
-    session = client.Command()
-    output = sq.ScreenPrinter(noderange, session)
-    filename = os.path.abspath(media)
-    resource = '/noderange/{0}/support/servicedata/'.format(noderange)
-    upargs = {'filename': filename}
-    noderrs = {}
-    nodeurls = {}
-    session.stop_if_noderange_over(noderange, options.maxnodes)
-    for res in session.create(resource, upargs):
-        if 'created' not in res:
-            for nodename in res.get('databynode', ()):
-                output.set_output(nodename, 'error!')
-                noderrs[nodename] = res['databynode'][nodename].get(
-                    'error', 'Unknown Error')
-            continue
-        watchurl = res['created']
-        currnode = watchurl.split('/')[1]
-        nodeurls[currnode] = '/' + watchurl
-    while nodeurls:
-        for node in list(nodeurls):
-            progress, status, err = get_update_progress(
-                session, nodeurls[node])
-            if status == 'error':
-                exitcode = 1
-                noderrs[node] = err
-            if status in ('error', 'complete', 'pending'):
-                list(session.delete(nodeurls[node]))
-                del nodeurls[node]
-            output.set_output(node, progress)
-        time.sleep(2)
-    allerrnodes = ','.join(noderrs)
-    if noderrs:
-        sys.stderr.write(
-            'Nodes had errors retrieving service data ({0})!\n'.format(allerrnodes))
-    for node in noderrs:
-        sys.stderr.write('{0}: {1}\n'.format(node, noderrs[node]))
-
-funmap = {
-    'servicedata': download_servicedata,
-}
-
-
-class OptParser(optparse.OptionParser):
-
-    def format_epilog(self, formatter):
-        return self.expand_prog_name(self.epilog)
-
-def main():
-    argparser = OptParser(
-        usage="Usage: %prog <noderange> servicedata "
-              "<directory or filename>",
-        epilog='\nservicedata will save service data to the given '
-               'directory.  It is saved to the location on the relevant '
-               'management server (the confluent server if running remote, '
-               'and the collective.manager if in collective)\n'
-               '\n\nSee `man %prog` for more info.\n')
-    argparser.add_option('-m', '--maxnodes', type='int',
-                     help='Specify a maximum number of '
-                          'nodes to download diagnostic data from, '
-                          'prompting if over the threshold') 
-    (options, args) = argparser.parse_args()
-    media = None
-    try:
-        noderange = args[0]
-        operation = args[1]
-        arglength = 2
-        if operation == 'servicedata':
-            media = args[2]
-            arglength = 3
-        if len(args) > arglength:
-            argparser.print_help()
-            sys.exit(1)
-    except IndexError:
-        argparser.print_help()
-        sys.exit(1)
-    client.check_globbing(noderange)
-    try:
-        handler = funmap[operation]
-    except KeyError:
-        argparser.print_help()
-        sys.exit(1)
-    handler(noderange, media, options)
-if __name__ == '__main__':
-    main()

confluent_client/bin/stats

@@ -1,173 +0,0 @@
-#!/usr/bin/python2
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2019 Lenovo
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-import argparse
-import csv
-import fcntl
-import io
-import numpy as np
-
-import os
-import subprocess
-import sys
-
-try:
-    import sixel
-
-    class DumbWriter(sixel.SixelWriter):
-        def restore_position(self, output):
-            return
-except ImportError:
-    pass
-
-
-def plot(gui, output, plotdata, bins):
-    import matplotlib as mpl
-    if gui and mpl.get_backend() == 'agg':
-        sys.stderr.write('Error: No GUI backend available and -g specified!\n')
-    if not gui:
-        mpl.use('Agg')
-    import matplotlib.pyplot as plt
-    n, bins, patches = plt.hist(plotdata, bins)
-    plt.show()
-    if not gui:
-        if output:
-            tdata = output
-        else:
-            tdata = io.BytesIO()
-        plt.savefig(tdata)
-    if not gui and not output:
-        writer = DumbWriter()
-        writer.draw(tdata)
-    return n, bins
-
-def textplot(plotdata, bins):
-    n, bins = np.histogram(plotdata, bins)
-    labels = []
-    for bin in bins:
-        labels.append('{0:0.1f}'.format(bin))
-    width = 80
-    # Since this will be primarily piped into, hard to get 
-    # terminal width
-    labelwidth = 0
-    for lab in labels:
-        if len(lab) > labelwidth:
-            labelwidth = len(lab)
-    width -= (labelwidth) + 1
-    labelfmt = '{{0:>{0}s}}|'.format(labelwidth)
-    maxn = 0.0
-    for lgth in n:
-        if lgth > maxn:
-            maxn = float(lgth)
-    for i in range(len(n)):
-        print(labelfmt.format(labels[i]) + '=' * int(np.round((n[i]/maxn) * width)))
-    return n, bins
-
-histogram = False
-aparser = argparse.ArgumentParser(description='Quick access to common statistics')
-aparser.add_argument('-c', type=int, default=0, help='Column number to analyze (default is last column)')
-aparser.add_argument('-d', default=None, help='Value used to separate columns')
-aparser.add_argument('-x', default=False, action='store_true', help='Output histogram in sixel format')
-aparser.add_argument('-s', default=0, help='Number of header lines to skip before processing')
-aparser.add_argument('-g', default=False, action='store_true', help='Open histogram in separate graphical window')
-aparser.add_argument('-o', default=None, help='Output histogram to the specified filename in PNG format')
-aparser.add_argument('-t', default=False, action='store_true', help='Output a histogram in text format')
-aparser.add_argument('-v', default=False, action='store_true', help='Attempt to list nodes relevant to each histogram bar (requires -s, -o, or -t)')
-aparser.add_argument('-b', type=int, default=10, help='Number of bins to use in histogram (default is 10)')
-args = aparser.parse_args(sys.argv[1:])
-plotdata = []
-headlines = int(args.s)
-while headlines >= 0:
-    data = sys.stdin.readline()
-    headlines -= 1
-if args.d:
-    delimiter = args.d
-else:
-    if '\t' in data:
-        delimiter = '\t'
-    elif ' ' in data:
-        delimiter = ' '
-    elif ',' in data:
-        delimiter = ','
-    else:
-        delimiter = ' '  # handle single column
-data = list(csv.reader([data], delimiter=delimiter))[0]
-nodebydatum = {}
-idx = args.c - 1
-autoidx = False
-while data:
-    node = None
-    if ':' in data[0]:
-        node, data[0] = data[0].split(':', 1)
-    else:
-        node = data[0]
-    if idx == -1 and not autoidx:
-        while not autoidx:
-            try:
-                datum = float(data[idx])
-            except ValueError:
-                idx -= 1
-                continue
-            except IndexError:
-                sys.stderr.write('Unable to identify a numerical column\n')
-                sys.exit(1)
-            autoidx = True
-    else:
-        datum = float(data[idx])
-    if node:
-        if datum in nodebydatum:
-            nodebydatum[datum].add(node)
-        else:
-            nodebydatum[datum] = set([node])
-    plotdata.append(datum)
-    data = sys.stdin.readline()
-    data = list(csv.reader([data], delimiter=delimiter))[0]
-n = None
-if args.g or args.o or args.x:
-    n, bins = plot(args.g, args.o, plotdata, bins=args.b)
-if args.t:
-    n, bins = textplot(plotdata, bins=args.b)
-print('Samples: {5} Min: {3} Median: {0} Mean: {1} Max: {4} StandardDeviation: {2} Sum: {6}'.format(np.median(plotdata), np.mean(plotdata), np.std(plotdata), np.min(plotdata), np.max(plotdata), len(plotdata), np.sum(plotdata)))
-if args.v and n is not None and nodebydatum:
-    print('')
-    currbin = bins[0]
-    bins = bins[1:]
-    currbinmembers = []
-    for datum in sorted(nodebydatum):
-        if datum > bins[0]:
-           nextbin = None
-           endbin = bins[0]
-           while len(bins) and bins[0] < datum:
-                nextbin = bins[0]
-                bins = bins[1:]
-           if not nextbin:
-               nextbin = np.max(plotdata)
-           print('Entries between {0} and {1}'.format(currbin, endbin))
-           currbin = nextbin
-           print('-' * 80)
-           print(','.join(sorted(currbinmembers)))
-           print('')
-           print('')
-           currbinmembers = []
-        for node in nodebydatum[datum]:
-            currbinmembers.append(node)
-    if currbinmembers:
-       print('Entries between {0} and {1}'.format(currbin, np.max(plotdata)))
-       print('-' * 80)
-       print(','.join(sorted(currbinmembers)))
-       print('')
-       print('')

confluent_client/builddeb

@@ -1 +0,0 @@
-../confluent_server/builddeb

confluent_client/confluent/client.py

@@ -1,7 +1,7 @@
 # vim: tabstop=4 shiftwidth=4 softtabstop=4
 
 # Copyright 2014 IBM Corporation
-# Copyright 2015-2019 Lenovo
+# Copyright 2015-2018 Lenovo
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -15,13 +15,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-try:
-    import anydbm as dbm
-except ImportError:
-    import dbm
-import csv
+import anydbm as dbm
 import errno
-import fnmatch
 import hashlib
 import os
 import shlex
@@ -29,101 +24,20 @@ import socket
 import ssl
 import sys
 import confluent.tlvdata as tlvdata
-import confluent.sortutil as sortutil
 
 SO_PASSCRED = 16
 
 _attraliases = {
     'bmc': 'hardwaremanagement.manager',
     'bmcuser': 'secret.hardwaremanagementuser',
-    'switchuser': 'secret.hardwaremanagementuser',
     'bmcpass': 'secret.hardwaremanagementpassword',
-    'switchpass': 'secret.hardwaremanagementpassword',
 }
 
-try:
-    getinput = raw_input
-except NameError:
-    getinput = input
-
-
-class NestedDict(dict):
-    def __missing__(self, key):
-        value = self[key] = type(self)()
-        return value
-
-
-def stringify(instr):
-    # Normalize unicode and bytes to 'str', correcting for
-    # current python version
-    if isinstance(instr, bytes) and not isinstance(instr, str):
-        return instr.decode('utf-8')
-    elif not isinstance(instr, bytes) and not isinstance(instr, str):
-        return instr.encode('utf-8')
-    return instr
-
-class Tabulator(object):
-    def __init__(self, headers):
-        self.headers = headers
-        self.rows = []
-
-    def add_row(self, row):
-        self.rows.append(row)
-
-    def get_table(self, order=None):
-        i = 0
-        fmtstr = ''
-        separator = []
-        for head in self.headers:
-            if order and order == head:
-                order = i
-            neededlen = len(head)
-            for row in self.rows:
-                if len(row[i]) > neededlen:
-                    neededlen = len(row[i])
-            separator.append('-' * (neededlen + 1))
-            fmtstr += '{{{0}:>{1}}}|'.format(i, neededlen + 1)
-            i = i + 1
-        fmtstr = fmtstr[:-1]
-        yield fmtstr.format(*self.headers)
-        yield fmtstr.format(*separator)
-        if order is not None:
-            for row in sorted(
-                    self.rows,
-                    key=lambda x: sortutil.naturalize_string(x[order])):
-                yield fmtstr.format(*row)
-        else:
-            for row in self.rows:
-                yield fmtstr.format(*row)
-
-    def write_csv(self, output, order=None):
-        output = csv.writer(output)
-        output.writerow(self.headers)
-        i = 0
-        for head in self.headers:
-            if order and order == head:
-                order = i
-            i = i + 1
-        if order is not None:
-            for row in sorted(
-                    self.rows,
-                    key=lambda x: sortutil.naturalize_string(x[order])):
-                output.writerow(row)
-        else:
-            for row in self.rows:
-                output.writerow(row)
-
 
 def printerror(res, node=None):
     exitcode = 0
     if 'errorcode' in res:
         exitcode = res['errorcode']
-    for node in res.get('databynode', {}):
-        exitcode = res['databynode'][node].get('errorcode', exitcode)
-        if 'error' in res['databynode'][node]:
-            sys.stderr.write('{0}: {1}\n'.format(node, res['databynode'][node]['error']))
-            if exitcode == 0:
-                exitcode = 1
     if 'error' in res:
         if node:
             sys.stderr.write('{0}: {1}\n'.format(node, res['error']))
@@ -135,10 +49,7 @@ def printerror(res, node=None):
 
 
 def cprint(txt):
-    try:
-        print(txt)
-    except UnicodeEncodeError:
-        print(txt.encode('utf8'))
+    print(txt)
     sys.stdout.flush()
 
 def _parseserver(string):
@@ -161,7 +72,6 @@ class Command(object):
         self._prevkeyname = None
         self.connection = None
         self._currnoderange = None
-        self.unixdomain = False
         if server is None:
             if 'CONFLUENT_HOST' in os.environ:
                 self.serverloc = os.environ['CONFLUENT_HOST']
@@ -171,13 +81,9 @@ class Command(object):
             self.serverloc = server
         if os.path.isabs(self.serverloc) and os.path.exists(self.serverloc):
             self._connect_unix()
-            self.unixdomain = True
-        elif self.serverloc == '/var/run/confluent/api.sock':
-            raise Exception('Confluent service is not available')
         else:
             self._connect_tls()
-        self.protversion = int(tlvdata.recv(self.connection).split(
-            b'--')[1].strip()[1:])
+        tlvdata.recv(self.connection)
         authdata = tlvdata.recv(self.connection)
         if authdata['authpassed'] == 1:
             self.authenticated = True
@@ -188,13 +94,6 @@ class Command(object):
             passphrase = os.environ['CONFLUENT_PASSPHRASE']
             self.authenticate(username, passphrase)
 
-    def add_file(self, name, handle, mode):
-        if self.protversion < 3:
-            raise Exception('Not supported with connected confluent server')
-        if not self.unixdomain:
-            raise Exception('Can only add a file to a unix domain connection')
-        tlvdata.send(self.connection, {'filename': name, 'mode': mode}, handle)
-
     def authenticate(self, username, password):
         tlvdata.send(self.connection,
                      {'username': username, 'password': password})
@@ -208,7 +107,7 @@ class Command(object):
     def add_precede_dict(self, dict):
         self._prevdict = dict
 
-    def handle_results(self, ikey, rc, res, errnodes=None, outhandler=None):
+    def handle_results(self, ikey, rc, res, errnodes=None):
         if 'error' in res:
             if errnodes is not None:
                 errnodes.add(self._currnoderange)
@@ -245,12 +144,10 @@ class Command(object):
                         node, val, self._prevdict[node]))
                 else:
                     cprint('{0}: {1}'.format(node, val))
-            elif outhandler:
-                outhandler(node, res)
         return rc
 
     def simple_noderange_command(self, noderange, resource, input=None,
-                                 key=None, errnodes=None, promptover=None, outhandler=None, **kwargs):
+                                 key=None, errnodes=None, **kwargs):
         try:
             self._currnoderange = noderange
             rc = 0
@@ -264,45 +161,17 @@ class Command(object):
             if input is None:
                 for res in self.read('/noderange/{0}/{1}'.format(
                         noderange, resource)):
-                    rc = self.handle_results(ikey, rc, res, errnodes, outhandler)
+                    rc = self.handle_results(ikey, rc, res, errnodes)
             else:
-                self.stop_if_noderange_over(noderange, promptover)
                 kwargs[ikey] = input
                 for res in self.update('/noderange/{0}/{1}'.format(
                         noderange, resource), kwargs):
-                    rc = self.handle_results(ikey, rc, res, errnodes, outhandler)
+                    rc = self.handle_results(ikey, rc, res, errnodes)
             self._currnoderange = None
             return rc
         except KeyboardInterrupt:
             cprint('')
             return 0
-    
-    def stop_if_noderange_over(self, noderange, maxnodes):
-        if maxnodes is None:
-            return
-        nsize = self.get_noderange_size(noderange)
-        if nsize > maxnodes:
-            if nsize == 1:
-                nodename = list(self.read(
-                    '/noderange/{0}/nodes/'.format(noderange)))[0].get('item', {}).get('href', None)
-                nodename = nodename[:-1]
-                p = getinput('Command is about to affect node {0}, continue (y/n)? '.format(nodename))
-            else:
-                p = getinput('Command is about to affect {0} nodes, continue (y/n)? '.format(nsize))
-            if p.lower() != 'y':
-                sys.stderr.write('Aborting at user request\n')
-                sys.exit(1)
-                raise Exception("Aborting at user request")
-        
-
-    def get_noderange_size(self, noderange):
-        numnodes = 0
-        for node in self.read('/noderange/{0}/nodes/'.format(noderange)):
-            if node.get('item', {}).get('href', None):
-                numnodes += 1
-            else:
-                raise Exception("Error trying to size noderange {0}".format(noderange))
-        return numnodes
 
     def simple_nodegroups_command(self, noderange, resource, input=None, key=None, **kwargs):
         try:
@@ -396,14 +265,13 @@ class Command(object):
         if knownhosts:
             certdata = self.connection.getpeercert(binary_form=True)
             fingerprint = 'sha512$' + hashlib.sha512(certdata).hexdigest()
-            fingerprint = fingerprint.encode('utf-8')
             hostid = '@'.join((port, server))
             khf = dbm.open(os.path.join(clientcfgdir, "knownhosts"), 'c', 384)
             if hostid in khf:
                 if fingerprint == khf[hostid]:
                     return
                 else:
-                    replace = getinput(
+                    replace = raw_input(
                         "MISMATCHED CERTIFICATE DATA, ACCEPT NEW? (y/n):")
                     if replace not in ('y', 'Y'):
                         raise Exception("BAD CERTIFICATE")
@@ -436,24 +304,18 @@ def send_request(operation, path, server, parameters=None):
         result = tlvdata.recv(server)
 
 
-def attrrequested(attr, attrlist, seenattributes, node=None):
+def attrrequested(attr, attrlist, seenattributes):
     for candidate in attrlist:
         truename = candidate
         if candidate.startswith('hm'):
             candidate = candidate.replace('hm', 'hardwaremanagement', 1)
         if candidate in _attraliases:
             candidate = _attraliases[candidate]
-        if fnmatch.fnmatch(attr.lower(), candidate.lower()):
-            if node is None:
-                seenattributes.add(truename)
-            else:
-                seenattributes[node][truename] = True
+        if candidate.lower() == attr.lower():
+            seenattributes.add(truename)
             return True
         elif attr.lower().startswith(candidate.lower() + '.'):
-            if node is None:
-                seenattributes.add(truename)
-            else:
-                seenattributes[node][truename] = 1
+            seenattributes.add(truename)
             return True
     return False
 
@@ -462,45 +324,39 @@ def printattributes(session, requestargs, showtype, nodetype, noderange, options
     path = '/{0}/{1}/attributes/{2}'.format(nodetype, noderange, showtype)
     return print_attrib_path(path, session, requestargs, options)
 
-def _sort_attrib(k):
-    if isinstance(k[1], dict) and k[1].get('sortid', None) is not None:
-        return k[1]['sortid']
-    return k[0]
 
-def print_attrib_path(path, session, requestargs, options, rename=None, attrprefix=None):
+def print_attrib_path(path, session, requestargs, options, rename=None):
     exitcode = 0
-    seenattributes = NestedDict()
-    allnodes = set([])
+    seenattributes = set([])
     for res in session.read(path):
         if 'error' in res:
             sys.stderr.write(res['error'] + '\n')
             exitcode = 1
             continue
         for node in sorted(res['databynode']):
-            allnodes.add(node)
-            for attr, val in sorted(res['databynode'][node].items(), key=_sort_attrib):
+            for attr, val in sorted(
+                    res['databynode'][node].items(),
+                    key=lambda (k, v): v.get('sortid', k) if isinstance(v, dict) else k):
                 if attr == 'error':
                     sys.stderr.write('{0}: Error: {1}\n'.format(node, val))
                     continue
                 if attr == 'errorcode':
                     exitcode |= val
                     continue
-                seenattributes[node][attr] = True
+                seenattributes.add(attr)
                 if rename:
                     printattr = rename.get(attr, attr)
                 else:
                     printattr = attr
-                if attrprefix:
-                    printattr = attrprefix + printattr
                 currattr = res['databynode'][node][attr]
-                if show_attr(attr, requestargs, seenattributes, options, node):
+                if show_attr(attr, requestargs, seenattributes, options):
                     if 'value' in currattr:
                         if currattr['value'] is not None:
                             val = currattr['value']
                             if isinstance(val, list):
                                 val = ','.join(val)
                             attrout = '{0}: {1}: {2}'.format(
-                                node, printattr, val).strip()
+                                node, printattr, val)
                         else:
                             attrout = '{0}: {1}:'.format(node, printattr)
                     elif 'isset' in currattr:
@@ -509,7 +365,7 @@ def print_attrib_path(path, session, requestargs, options, rename=None, attrpref
                                                                   printattr)
                         else:
                             attrout = '{0}: {1}:'.format(node, printattr)
-                    elif isinstance(currattr, dict) and 'broken' in currattr:
+                    elif 'broken' in currattr:
                         attrout = '{0}: {1}: *ERROR* BROKEN EXPRESSION: ' \
                                   '{2}'.format(node, printattr,
                                                currattr['broken'])
@@ -526,7 +382,7 @@ def print_attrib_path(path, session, requestargs, options, rename=None, attrpref
                         blame = options.blame
                     except AttributeError:
                         blame = False
-                    if blame or (isinstance(currattr, dict) and 'broken' in currattr):
+                    if blame or 'broken' in currattr:
                         blamedata = []
                         if 'inheritedfrom' in currattr:
                             blamedata.append('inherited from group {0}'.format(
@@ -551,12 +407,9 @@ def print_attrib_path(path, session, requestargs, options, rename=None, attrpref
                                 (currattr.get('default', None) is not None and
                                 currattr.get('value', None) is not None and
                                 currattr['value'] != currattr['default'])):
-                            cval = ','.join(currattr['value']) if isinstance(
-                                currattr['value'], list) else currattr['value']
-                            dval = ','.join(currattr['default']) if isinstance(
-                                currattr['default'], list) else currattr['default']
                             cprint('{0}: {1}: {2} (Default: {3})'.format(
-                                node, printattr, cval, dval))
+                                node, printattr, currattr['value'],
+                                currattr['default']))
                     else:
 
                         try:
@@ -565,48 +418,29 @@ def print_attrib_path(path, session, requestargs, options, rename=None, attrpref
                             details = False
                         if details:
                             if currattr.get('help', None):
-                                attrout += u' (Help: {0})'.format(
-                                    currattr['help'])
+                                attrout += ' (Help: {0})'.format(
+                                    currattr['help'].encode('utf-8'))
                             if currattr.get('possible', None):
-                                try:
-                                    attrout += u' (Choices: {0})'.format(
-                                        ','.join(currattr['possible']))
-                                except TypeError:
-                                    pass
+                                attrout += ' (Choices: {0})'.format(
+                                    ','.join(currattr['possible']))
                         cprint(attrout)
-    somematched = set([])
-    printmissing = set([])
-    badnodes = NestedDict()
     if not exitcode:
         if requestargs:
             for attr in requestargs:
-                for node in allnodes:
-                    if attr in seenattributes[node]:
-                        somematched.add(attr)
-                    else:
-                        badnodes[node][attr] = True
-                        exitcode = 1
-        for node in sortutil.natural_sort(badnodes):
-            for attr in badnodes[node]:
-                if attr in somematched:
-                    sys.stderr.write(
-                        'Error: {0} matches no valid value for {1}\n'.format(
-                            attr, node))
-                else:
-                    printmissing.add(attr)
-        for missing in printmissing:
-            sys.stderr.write('Error: {0} not a valid attribute\n'.format(attr))
+                if attr not in seenattributes:
+                    sys.stderr.write('Error: {0} not a valid attribute\n'.format(attr))
+                    exitcode = 1
     return exitcode
 
 
-def show_attr(attr, requestargs, seenattributes, options, node):
+def show_attr(attr, requestargs, seenattributes, options):
     try:
         reverse = options.exclude
     except AttributeError:
         reverse = False
     if requestargs is None or requestargs == []:
         return True
-    processattr = attrrequested(attr, requestargs, seenattributes, node)
+    processattr = attrrequested(attr, requestargs, seenattributes)
     if reverse:
         processattr = not processattr
     return processattr
@@ -635,7 +469,7 @@ def printgroupattributes(session, requestargs, showtype, nodetype, noderange, op
                         attrout = '{0}: {1}: ********'.format(noderange, attr)
                     else:
                         attrout = '{0}: {1}:'.format(noderange, attr)
-                elif isinstance(currattr, dict) and 'broken' in currattr:
+                elif 'broken' in currattr:
                     attrout = '{0}: {1}: *ERROR* BROKEN EXPRESSION: ' \
                               '{2}'.format(noderange, attr,
                                            currattr['broken'])
@@ -659,7 +493,7 @@ def printgroupattributes(session, requestargs, showtype, nodetype, noderange, op
                     exitcode = 1
     return exitcode
 
-def updateattrib(session, updateargs, nodetype, noderange, options, dictassign=None):
+def updateattrib(session, updateargs, nodetype, noderange, options):
     # update attribute
     exitcode = 0
     if options.clear:
@@ -692,14 +526,6 @@ def updateattrib(session, updateargs, nodetype, noderange, options, dictassign=N
                                                             'attributes/all',
                                                             value, key)
         sys.exit(exitcode)
-    elif dictassign:
-        for key in dictassign:
-            if nodetype == 'nodegroups':
-                exitcode = session.simple_nodegroups_command(
-                    noderange, 'attributes/all', dictassign[key], key)
-            else:
-                exitcode = session.simple_noderange_command(
-                    noderange, 'attributes/all', dictassign[key], key)
     else:
         if "=" in updateargs[1]:
             try:
@@ -758,4 +584,4 @@ def check_globbing(noderange):
                 'bash or change directories such that there is no filename '
                 'that would conflict.'
                 '\n'.format(noderange))
-            sys.exit(1)
+            sys.exit(1)

confluent_client/confluent/logreader.py

@@ -1,295 +0,0 @@
-#!/usr/bin/python3
-import collections
-import os
-import struct
-import sys
-import time
-import fcntl
-import select
-import termios
-import tty
-
-def writeout(data):
-    if isinstance(data, str) and not isinstance(data, bytes):
-        data = data.encode('utf8')
-    try:
-        if hasattr(sys.stdout, 'buffer'):
-            sys.stdout.buffer.write(data)
-        else:
-            sys.stdout.write(data)
-    except IOError:
-        time.sleep(0.1)
-        pass
-
-
-class LogReplay(object):
-    def __init__(self, logfile, cblfile):
-        self.bin = open(cblfile, 'rb')
-        self.txt = open(logfile, 'rb')
-        self.cleardata = []
-        self.clearidx = 0
-        self.pendingdata = collections.deque([])
-        self.priordata = collections.deque([])
-        self.laststamp = None
-        self.needclear = False
-        self.lasttxt = ''
-
-    def _rewind(self, datasize=None):
-        curroffset = self.bin.tell() - 16
-        if self.cleardata and self.clearidx > 1:
-            self.clearidx -= 1
-            priordata = self.cleardata[self.clearidx - 1]
-            return curroffset, priordata
-        self.cleardata = []
-        self.clearidx = 0
-        newoffset = curroffset - 32
-        if newoffset < 0:  #TODO: Follow a log roll
-            newoffset = 0
-        if datasize:
-            while datasize > 0 and newoffset > 0:
-                self.bin.seek(newoffset)
-                tmprec = self.bin.read(16)
-                newoffset -= 32
-                tmprec = struct.unpack('!BBIHIBBH', tmprec)
-                if tmprec[1] == 2:
-                    datasize -= tmprec[3]
-        if newoffset >= 0:
-            self.bin.seek(newoffset)
-        return curroffset, None
-
-    def debuginfo(self):
-        return '{0}, {1}'.format(self.bin.tell(), self.clearidx)
-
-    def get_output(self, reverse=False):
-        endoffset = None
-        output = b''
-        if reverse:  # Forget the uncommited future, if present
-            output += b'\x1b[2J\x1b[H'
-            endoffset, priordata = self._rewind(4096)
-            if priordata is not None:
-                return priordata, 1
-        elif self.needclear:
-            output += b'\x1b[2J\x1b[H'
-            self.needclear = False
-        if self.cleardata and self.clearidx < len(self.cleardata):
-            datachunk = self.cleardata[self.clearidx]
-            self.clearidx += 1
-            return datachunk, 1
-        self.cleardata = []
-        self.clearidx = 0
-        while (not reverse) or (self.bin.tell() < endoffset):
-            record = self.bin.read(16)
-            if not record:
-                return b'', 0
-            record = struct.unpack('!BBIHIBBH', record)
-            if record[0] > 16:
-                # Unsupported record, skip
-                self.bin.seek(record[0] - 16, 1)
-                continue
-            type = record[1]
-            offset = record[2]
-            size = record[3]
-            evtdata = record[5]
-            auxdata = record[6]
-            if type == 3:
-                #TODO: provide data for status bar
-                continue
-            elif type == 2:
-                self.laststamp = record[4]
-                self.txt.seek(offset)
-                txtout = self.txt.read(size)
-                if reverse and self.bin.tell() < endoffset:
-                    output += txtout
-                    continue
-                self.paginate(txtout)
-                if self.cleardata:
-                    self.clearidx = 0
-                    if not self.cleardata[0]:
-                        self.cleardata = self.cleardata[1:]
-                    if self.cleardata:
-                        if reverse:
-                            output = self.cleardata[-1]
-                            self.clearidx = len(self.cleardata)
-                        else:
-                            output += self.cleardata[0]
-                            self.clearidx = 1
-                else:
-                    output += txtout
-                break
-        if endoffset is not None and endoffset >= 0:
-            self.bin.seek(endoffset)
-        self.lasttxt = output
-        return output, 1
-
-    def paginate(self, txtout):
-        cleardata = [txtout]
-        nextcleardata = []
-        for sep in (b'\x1b[2J', b'\x1b[H\x1b[J'):
-            replacementcleardata = []
-            for txtout in cleardata:
-                nextcleardata = txtout.split(sep)
-                if len(nextcleardata) > 1:
-                    for idx in range(1, len(nextcleardata)):
-                        nextcleardata[idx] = sep + nextcleardata[idx]
-                replacementcleardata.extend(nextcleardata)
-                nextcleardata = []
-            cleardata = replacementcleardata
-        if len(cleardata) > 1:
-            self.cleardata = cleardata
-        return
-
-    def begin(self):
-        self.needclear = True
-        self.bin.seek(0)
-
-    def end(self):
-        self.bin.seek(0, 2)
-
-    def search(self, searchstr, skipfirst=False):
-        overlap = len(searchstr)
-        firstoffset = self.bin.tell()
-        lastoffset = firstoffset
-        output = self.lasttxt
-        while searchstr not in output:
-            output, delay = self.get_output()
-            if not self.cleardata and lastoffset == self.bin.tell():
-                self.bin.seek(firstoffset)
-                return b'', 0
-            lastoffset = self.bin.tell()
-        if skipfirst:
-            output, delay = self.get_output()
-            while searchstr not in output:
-                output, delay = self.get_output()
-                if not self.cleardata and lastoffset == self.bin.tell():
-                    self.bin.seek(firstoffset)
-                    return b'', 0
-                lastoffset = self.bin.tell()
-        clear = b'\x1b[2J\x1b[H'
-        txtchunks = self.lasttxt.split(searchstr)
-        output = clear + txtchunks[0]
-        txtchunks = txtchunks[1:]
-        while txtchunks:
-            output += b'\x1b[7m' + searchstr + b'\x1b[27m' + txtchunks[0]
-            txtchunks = txtchunks[1:]
-        return output, 0
-
-
-def _replay_to_console(txtfile, binfile):
-    replay = LogReplay(txtfile, binfile)
-    oldtcattr = termios.tcgetattr(sys.stdin.fileno())
-    tty.setraw(sys.stdin.fileno())
-    currfl = fcntl.fcntl(sys.stdin.fileno(), fcntl.F_GETFL)
-    fcntl.fcntl(sys.stdin.fileno(), fcntl.F_SETFL, currfl | os.O_NONBLOCK)
-    reverse = False
-    skipnext = False
-    quitit = False
-    searchstr = None
-    writeout('\x1b[2J\x1b[;H')
-    prepend = ''
-    try:
-        while not quitit:
-            if not skipnext:
-                newdata, delay = replay.get_output(reverse)
-            skipnext = False
-            reverse = False
-            if newdata:
-                if prepend:
-                    newdata = prepend + newdata
-                    prepend = b''
-                writeout(newdata)
-                newdata = ''
-                writeout('\x1b]0;[Time: {0}]\x07'.format(
-                    time.strftime('%m/%d %H:%M:%S', time.localtime(replay.laststamp))))
-                try:
-                    if hasattr(sys.stdout, 'buffer'):
-                        sys.stdout.buffer.flush()
-                    else:
-                        sys.stdout.flush()
-                except IOError:
-                    pass
-            while True:
-                select.select((sys.stdin,), (), (), 86400)
-                myinput = sys.stdin.read()
-                if myinput.startswith('\x1b[C') or myinput.startswith('\x1bOC') or myinput == '\r':  # right
-                    break
-                elif myinput.startswith('\x1b[D') or myinput.startswith('\x1bOD') or myinput == 'y':  # left
-                    writeout('\x1b[2J\x1b[;H')
-                    reverse = True
-                    break
-                elif myinput == 'G' or myinput.startswith('\x1b[F'):
-                    replay.end()
-                    reverse = True
-                    break
-                elif myinput == 'g' or myinput.startswith('\x1b[H'):
-                    replay.begin()
-                    break
-                elif myinput.lower() == 'q' or myinput == '\x03':
-                    quitit = True
-                    break
-                elif myinput.lower() == 'd':
-                    writeout('\x1b];{0}\x07'.format(replay.debuginfo()))
-                    if hasattr(sys.stdout, 'buffer'):
-                        sys.stdout.buffer.flush()
-                    else:
-                        sys.stdout.flush()
-                elif myinput.lower() == '/':
-                    sys.stdout.write('\x1b7\x1b[99999;0H\x1b[2K')
-                    searchstr = ''
-                    nxtchr = '/'
-                    while '\r' not in searchstr:
-                        sys.stdout.write(nxtchr)
-                        sys.stdout.flush()
-                        select.select((sys.stdin,), (), (), 86400)
-                        nxtchr = sys.stdin.read(1)
-                        if nxtchr in ('\x08', '\x7f'):
-                            searchstr = searchstr[:-1]
-                            nxtchr = '\x08 \x08'
-                        else:
-                            searchstr += nxtchr
-                    if not isinstance(searchstr, bytes):
-                        searchstr = searchstr.encode('utf8')
-                    searchstr = searchstr[:-1]
-                    newdata, delay = replay.search(searchstr)
-                    if not newdata:
-                        sys.stdout.write('\x1b[1K\rNo match found')
-                        prepend = b'\x1b[1K\x1b8'
-                    else:
-                        sys.stdout.write('\x1b[1K\x1b8')
-                    sys.stdout.flush()
-                    skipnext = True
-                    break
-                elif myinput.lower() == 'n' and searchstr:
-                    newdata, delay = replay.search(searchstr, True)
-                    if not newdata:
-                        sys.stdout.write('\x1b7\x1b[99999;0H\x1b[2KNo more matches found')
-                        sys.stdout.flush()
-                        prepend = b'\x1b[1K\x1b8'
-                    skipnext = True
-                    break
-                else:
-                    pass # print(repr(myinput))
-    except Exception:
-        currfl = fcntl.fcntl(sys.stdin.fileno(), fcntl.F_GETFL)
-        fcntl.fcntl(sys.stdin.fileno(), fcntl.F_SETFL, currfl ^ os.O_NONBLOCK)
-        termios.tcsetattr(sys.stdin.fileno(), termios.TCSANOW, oldtcattr)
-        writeout('\x1b[m\x1b[?25h\n')
-        raise
-    currfl = fcntl.fcntl(sys.stdin.fileno(), fcntl.F_GETFL)
-    fcntl.fcntl(sys.stdin.fileno(), fcntl.F_SETFL, currfl ^ os.O_NONBLOCK)
-    termios.tcsetattr(sys.stdin.fileno(), termios.TCSANOW, oldtcattr)
-    writeout('\x1b[m\x1b[?25h\n')
-
-def replay_to_console(txtfile):
-    if os.path.exists(txtfile + '.cbl'):
-        binfile = txtfile + '.cbl'
-    else:
-        fileparts = txtfile.split('.')
-        prefix = '.'.join(fileparts[:-1])
-        binfile = prefix + '.cbl.' + fileparts[-1]
-        if not os.path.exists(binfile):
-            sys.stderr.write('Unable to locate cbl file\n')
-            sys.exit(1)
-    _replay_to_console(txtfile, binfile)
-
-if __name__ == '__main__':
-    replay_to_console(sys.argv[1])

confluent_client/confluent/screensqueeze.py

@@ -17,9 +17,9 @@ import sys
 import struct
 import termios
 
-def get_screengeom():
+def get_screenwidth():
     return struct.unpack('hh', fcntl.ioctl(sys.stdout, termios.TIOCGWINSZ,
-                                           b'....'))
+                                           b'....'))[1]
 class ScreenPrinter(object):
 
     def __init__(self, noderange, client, textlen=4):
@@ -44,8 +44,6 @@ class ScreenPrinter(object):
         self.fieldwidth = maxlen + textlen + 1  # 1 for column
 
     def set_output(self, node, text):
-        if self.nodeoutput.get(node, None) == text:
-            return
         self.nodeoutput[node] = text
         if len(text) >= self.textlen:
             self.textlen = len(text) + 1
@@ -54,31 +52,23 @@ class ScreenPrinter(object):
 
     def drawscreen(self):
         if self.squeeze:
-            currheight, currwidth = get_screengeom()
-            currheight -= 1
+            currwidth = get_screenwidth()
             numfields = currwidth // self.fieldwidth
             fieldformat = '{{0:>{0}}}:{{1:{1}}}'.format(self.nodenamelen,
                                                         self.textlen)
             sys.stdout.write('\x1b[2J\x1b[;H')  # clear screen
-            if len(self.nodelist) < (numfields * currheight):
-                numfields = len(self.nodelist) // currheight + 1
         else:
             numfields = 1
             fieldformat = '{0}: {1}'
-        if self.squeeze:
-            columns = [self.nodelist[x:x+currheight] for x in range(0, len(self.nodelist), currheight)]
-            for currow in range(0, len(columns[0])):
-                for col in columns:
-                    try:
-                        node = col[currow]
-                        sys.stdout.write(fieldformat.format(node, self.nodeoutput[node]))
-                    except IndexError:
-                        break
-                sys.stdout.write('\n')
-        else:
-            for node in self.nodelist:
-                sys.stdout.write(fieldformat.format(node, self.nodeoutput[node]))
+        currfields = 0
+        for node in self.nodelist:
+            if currfields >= numfields:
                 sys.stdout.write('\n')
+                currfields = 1
+            else:
+                currfields += 1
+            sys.stdout.write(fieldformat.format(node, self.nodeoutput[node]))
+        sys.stdout.write('\n')
         sys.stdout.flush()
 
 
@@ -88,8 +78,8 @@ class ScreenPrinter(object):
 if __name__ == '__main__':
     import confluent.client as client
     c = client.Command()
-    p = ScreenPrinter('d1-d12', c)
-    p.set_output('d3', 'Upload: 67%')
+    p = ScreenPrinter('n1-n13', c)
+    p.set_output('n3', 'Upload: 67%')
 
 
 

confluent_client/confluent/termhandler.py

@@ -53,16 +53,13 @@ class TermHandler(object):
             connection = None
             try:
                 connection, address = self.socket.accept()
-                connection.sendall(b"confetty control v1--\n")
+                connection.sendall("confetty control v1--\n")
                 cmd = connection.recv(8)
-                if b'GETWINID' == cmd:
-                    winid = os.environ['WINDOWID']
-                    if not isinstance(winid, bytes):
-                        winid = winid.encode('utf8')
-                    connection.sendall(winid)
+                if 'GETWINID' == cmd:
+                    connection.sendall(os.environ['WINDOWID'])
                 connection.close()
             except BaseException:
                 pass
             finally:
                 if connection is not None:
-                    connection.close()
+                    connection.close()

confluent_client/confluent/textgroup.py

@@ -169,18 +169,13 @@ class GroupedData(object):
         output.flush()
 
     def print_deviants(self, output=sys.stdout, skipmodal=False, reverse=False,
-                       count=False, basenode=None):
+                       count=False):
         self.generate_byoutput()
         modaloutput = None
         ismodal = True
         revoutput = []
-        if basenode:
-            for checkout in self.byoutput:
-                if basenode in self.byoutput[checkout]:
-                    modaloutput = checkout
         for outdata in sorted(
-                self.byoutput, key=lambda x: [0 if modaloutput == x else 1,
-                                              0 - len(self.byoutput[x]),
+                self.byoutput, key=lambda x: [0 - len(self.byoutput[x]),
                                               humanify_nodename(
                                                   self.get_group_text(
                                                       self.byoutput[x]

confluent_client/confluent/tlv.py

@@ -17,4 +17,4 @@
 
 
 class Types(object):
-    text, json, filehandle = range(3)
+    text, json = range(2)

confluent_client/confluent/tlvdata.py

@@ -15,19 +15,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import array
-import ctypes
-import ctypes.util
 import confluent.tlv as tlv
-try:
-    import eventlet.green.socket as socket
-    import eventlet.green.select as select
-except ImportError:
-    import socket
-    import select
 from datetime import datetime
 import json
-import os
 import struct
 
 try:
@@ -35,77 +25,6 @@ try:
 except NameError:
     unicode = str
 
-try:
-    range = xrange
-except NameError:
-    pass
-
-class iovec(ctypes.Structure):   # from uio.h
-    _fields_ = [('iov_base', ctypes.c_void_p),
-                ('iov_len', ctypes.c_size_t)]
-
-
-iovec_ptr = ctypes.POINTER(iovec)
-
-
-class cmsghdr(ctypes.Structure):  # also from bits/socket.h
-    _fields_ = [('cmsg_len', ctypes.c_size_t),
-                ('cmsg_level', ctypes.c_int),
-                ('cmsg_type', ctypes.c_int)]
-
-    @classmethod
-    def init_data(cls, cmsg_len, cmsg_level, cmsg_type, cmsg_data):
-        Data = ctypes.c_ubyte * ctypes.sizeof(cmsg_data)
-        class _flexhdr(ctypes.Structure):
-            _fields_ = cls._fields_ + [('cmsg_data', Data)]
-
-        datab = Data(*bytearray(cmsg_data))
-        return _flexhdr(cmsg_len=cmsg_len, cmsg_level=cmsg_level,
-                        cmsg_type=cmsg_type, cmsg_data=datab)
-
-
-def CMSG_LEN(length):
-    sizeof_cmshdr = ctypes.sizeof(cmsghdr)
-    return ctypes.c_size_t(CMSG_ALIGN(sizeof_cmshdr).value + length)
-
-
-SCM_RIGHTS = 1
-
-
-class msghdr(ctypes.Structure):  # from bits/socket.h
-    _fields_ = [('msg_name', ctypes.c_void_p),
-                ('msg_namelen', ctypes.c_uint),
-                ('msg_iov', ctypes.POINTER(iovec)),
-                ('msg_iovlen', ctypes.c_size_t),
-                ('msg_control', ctypes.c_void_p),
-                ('msg_controllen', ctypes.c_size_t),
-                ('msg_flags', ctypes.c_int)]
-
-
-def CMSG_ALIGN(length):  # bits/socket.h
-    ret = (length + ctypes.sizeof(ctypes.c_size_t) - 1
-           & ~(ctypes.sizeof(ctypes.c_size_t) - 1))
-    return ctypes.c_size_t(ret)
-
-
-def CMSG_SPACE(length):  # bits/socket.h
-    ret = CMSG_ALIGN(length).value + CMSG_ALIGN(ctypes.sizeof(cmsghdr)).value
-    return ctypes.c_size_t(ret)
-
-
-class ClientFile(object):
-    def __init__(self, name, mode, fd):
-        self.fileobject = os.fdopen(fd, mode)
-        self.filename = name
-
-libc = ctypes.CDLL(ctypes.util.find_library('c'))
-recvmsg = libc.recvmsg
-recvmsg.argtypes = [ctypes.c_int, ctypes.POINTER(msghdr), ctypes.c_int]
-recvmsg.restype = ctypes.c_int
-sendmsg = libc.sendmsg
-sendmsg.argtypes = [ctypes.c_int, ctypes.POINTER(msghdr), ctypes.c_int]
-sendmsg.restype = ctypes.c_size_t
-
 def decodestr(value):
     ret = None
     try:
@@ -115,13 +34,11 @@ def decodestr(value):
             ret = value.decode('cp437')
         except UnicodeDecodeError:
             ret = value
-    except AttributeError:
-        return value
     return ret
 
 def unicode_dictvalues(dictdata):
     for key in dictdata:
-        if isinstance(dictdata[key], bytes):
+        if isinstance(dictdata[key], str):
             dictdata[key] = decodestr(dictdata[key])
         elif isinstance(dictdata[key], datetime):
             dictdata[key] = dictdata[key].strftime('%Y-%m-%dT%H:%M:%S')
@@ -132,7 +49,7 @@ def unicode_dictvalues(dictdata):
 
 
 def _unicode_list(currlist):
-    for i in range(len(currlist)):
+    for i in xrange(len(currlist)):
         if isinstance(currlist[i], str):
             currlist[i] = decodestr(currlist[i])
         elif isinstance(currlist[i], dict):
@@ -141,13 +58,13 @@ def _unicode_list(currlist):
             _unicode_list(currlist[i])
 
 
-def send(handle, data, filehandle=None):
+def send(handle, data):
     if isinstance(data, unicode):
         try:
             data = data.encode('utf-8')
         except AttributeError:
             pass
-    if isinstance(data, bytes) or isinstance(data, unicode):
+    if isinstance(data, str) or isinstance(data, unicode):
         # plain text, e.g. console data
         tl = len(data)
         if tl == 0:
@@ -169,27 +86,9 @@ def send(handle, data, filehandle=None):
         if tl > 16777215:
             raise Exception("JSON data exceeds protocol limits")
         # xor in the type (0b1 << 24)
-        if filehandle is None:
-            tl |= 16777216
-            handle.sendall(struct.pack("!I", tl))
-            handle.sendall(sdata)
-        else:
-            tl |= (2 << 24)
-            handle.sendall(struct.pack("!I", tl))
-            cdtype = ctypes.c_ubyte * len(sdata)
-            cdata = cdtype.from_buffer(bytearray(sdata))
-            ciov = iovec(iov_base=ctypes.addressof(cdata),
-                         iov_len=ctypes.c_size_t(ctypes.sizeof(cdata)))
-            fd = ctypes.c_int(filehandle)
-            cmh = cmsghdr.init_data(
-                cmsg_len=CMSG_LEN(
-                    ctypes.sizeof(fd)), cmsg_level=socket.SOL_SOCKET,
-                    cmsg_type=SCM_RIGHTS, cmsg_data=fd)
-            mh = msghdr(msg_name=None, msg_len=0, msg_iov=iovec_ptr(ciov),
-                        msg_iovlen=1, msg_control=ctypes.addressof(cmh),
-                        msg_controllen=ctypes.c_size_t(ctypes.sizeof(cmh)))
-            sendmsg(handle.fileno(), mh, 0)
-
+        tl |= 16777216
+        handle.sendall(struct.pack("!I", tl))
+        handle.sendall(sdata)
 
 def recvall(handle, size):
     rd = handle.recv(size)
@@ -219,46 +118,12 @@ def recv(handle):
     datatype = (tl & 2130706432) >> 24  # grab 7 bits from near beginning
     if dlen == 0:
         return None
-    if datatype == tlv.Types.filehandle:
-        filehandles = array.array('i')
-        rawbuffer = bytearray(2048)
-        pkttype = ctypes.c_ubyte * 2048
-        data = pkttype.from_buffer(rawbuffer)
-        cmsgsize = CMSG_SPACE(ctypes.sizeof(ctypes.c_int)).value
-        cmsgarr = bytearray(cmsgsize)
-        cmtype = ctypes.c_ubyte * cmsgsize
-        cmsg = cmtype.from_buffer(cmsgarr)
-        cmsg.cmsg_level = socket.SOL_SOCKET
-        cmsg.cmsg_type = SCM_RIGHTS
-        cmsg.cmsg_len = CMSG_LEN(ctypes.sizeof(ctypes.c_int))
-        iov = iovec()
-        iov.iov_base = ctypes.addressof(data)
-        iov.iov_len = 2048
-        msg = msghdr()
-        msg.msg_iov = ctypes.pointer(iov)
-        msg.msg_iovlen = 1
-        msg.msg_control = ctypes.addressof(cmsg)
-        msg.msg_controllen = ctypes.sizeof(cmsg)
-        select.select([handle], [], [])
-        i = recvmsg(handle.fileno(), ctypes.pointer(msg), 0)
-        cdata = cmsgarr[CMSG_LEN(0).value:]
-        data = rawbuffer[:i]
-        if cmsg.cmsg_level == socket.SOL_SOCKET and cmsg.cmsg_type == SCM_RIGHTS:
-            try:
-                filehandles.fromstring(bytes(
-                    cdata[:len(cdata) - len(cdata) % filehandles.itemsize]))
-            except AttributeError:
-                filehandles.frombytes(bytes(
-                    cdata[:len(cdata) - len(cdata) % filehandles.itemsize]))
-        data = json.loads(bytes(data))
-        return ClientFile(data['filename'], data['mode'], filehandles[0])
-    else:
-        data = handle.recv(dlen)
-        while len(data) < dlen:
-            ndata = handle.recv(dlen - len(data))
-            if not ndata:
-                raise Exception("Error reading data")
-            data += ndata
+    data = handle.recv(dlen)
+    while len(data) < dlen:
+        ndata = handle.recv(dlen - len(data))
+        if not ndata:
+            raise Exception("Error reading data")
+        data += ndata
     if datatype == tlv.Types.text:
         return data
     elif datatype == tlv.Types.json:

confluent_client/confluent_client.spec.tmpl

@@ -7,7 +7,7 @@ Name: %{name}
 Version: %{version}
 Release: %{release}
 Source0: %{name}-%{version}.tar.gz
-License: Apache2
+License: UNKNOWN
 Group: Development/Libraries
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
 Prefix: %{_prefix}
@@ -24,31 +24,14 @@ a confluent server.
 %setup -n %{name}-%{version} -n %{name}-%{version}
 
 %build
-%if "%{dist}" == ".el8"
-python3 setup.py build
-%else
-%if "%{dist}" == ".el9"
-python3 setup.py build
-%else
-python2 setup.py build
-%endif
-%endif
+python setup.py build
 
 %install
-%if "%{dist}" == ".el8"
-python3 setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES --install-scripts=/opt/confluent/bin --install-purelib=/opt/confluent/lib/python
-%else
-%if "%{dist}" == ".el9"
-python3 setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES --install-scripts=/opt/confluent/bin --install-purelib=/opt/confluent/lib/python
-%else
-python2 setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES --install-scripts=/opt/confluent/bin --install-purelib=/opt/confluent/lib/python
-%endif
-%endif
+python setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES --install-scripts=/opt/confluent/bin --install-purelib=/opt/confluent/lib/python
 
 
 %clean
 rm -rf $RPM_BUILD_ROOT
 
 %files -f INSTALLED_FILES
-%license /opt/confluent/share/licenses/confluent_client/LICENSE
 %defattr(-,root,root)

confluent_client/confluent_env.sh

@@ -19,7 +19,6 @@ alias nodebmcreset='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export
 alias nodeboot='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodeboot'
 alias nodeconfig='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodeconfig'
 alias nodeconsole='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodeconsole'
-alias nodedeploy='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodedeploy'
 alias nodedefine='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodedefine'
 alias nodeeventlog='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodeeventlog'
 alias nodefirmware='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodefirmware'
@@ -37,317 +36,4 @@ alias nodereseat='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export C
 alias noderun='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; noderun'
 alias nodesensors='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodesensors'
 alias nodesetboot='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodesetboot'
-alias nodestorage='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodestorage -i'
 alias nodeshell='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodeshell'
-alias nodelicense='CURRENT_CMDLINE=$(HISTTIMEFORMAT= builtin history 1); export CURRENT_CMDLINE; nodelicense'
-# Do not continue for non-bash shells, the rest of this sets up bash completion functions
-[ -z "$BASH_VERSION" -o -z "$PS1" ] && return
-
-
-_confluent_get_args()
-{
-    CMPARGS=($COMP_LINE)
-    NUMARGS=$((COMP_CWORD+1))
-    if [ "${COMP_WORDS[COMP_CWORD]}" == '' ]; then
-        CMPARGS+=("")
-    fi
-    GENNED=""
-    for CAND in ${COMP_CANDIDATES[@]}; do
-        candarray=(${CAND//,/ })
-        matched=0
-        for c in "${candarray[@]}"; do
-            for arg in "${CMPARGS[@]}"; do
-                if [ "$arg" = "$c" ]; then
-                    matched=1
-                    break
-                fi
-            done
-        done
-        if [ 0 = $matched ]; then
-            for c in "${candarray[@]}"; do
-                GENNED+=" $c"
-            done
-        fi
-    done
-}
-
-function _confluent_generic_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS -ge 3 ] && [ ! -z "$GENNED" ]; then
-        COMPREPLY=($(compgen -W "$GENNED" -- ${COMP_WORDS[COMP_CWORD]}))
-    fi
-    if [ $NUMARGS -lt 3 ]; then
-        _confluent_nr_completion
-        return;
-    fi
-}
-_confluent_nodeidentify_completion()
-{
-    COMP_CANDIDATES=("on,off,blink -h")
-    _confluent_generic_completion
-}
-
-
-_confluent_nodesetboot_completion()
-{
-    COMP_CANDIDATES=("default,cd,network,setup,hd,floppy,usb -h -b -p")
-    _confluent_generic_completion
-}
-
-_confluent_nodepower_completion()
-{
-   COMP_CANDIDATES=("boot,off,on,status -h -p")
-   _confluent_generic_completion
-}
-
-_confluent_nodemedia_completion()
-{
-    COMP_CANDIDATES=("list,upload,attach,detachall -h")
-    _confluent_get_args
-    if [ $NUMARGS -gt 3 ] && [ ${CMPARGS[-2]} == 'upload' ]; then
-        compopt -o default
-        COMPREPLY=()
-        return
-    fi
-    if [ $NUMARGS -ge 3 ] && [ ! -z "$GENNED" ]; then
-        COMPREPLY=($(compgen -W "$GENNED" -- ${COMP_WORDS[COMP_CWORD]}))
-        return;
-    fi
-    if [ $NUMARGS -lt 3 ]; then
-        _confluent_nr_completion
-        return;
-    fi
-}
-
-_confluent_nodefirmware_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS == 3 ]; then
-        COMPREPLY=($(compgen -W "list update" -- ${COMP_WORDS[COMP_CWORD]}))
-        return;
-    fi
-    if [ $NUMARGS -gt 3 ] && [ ${CMPARGS[2]} == 'update' ]; then
-        compopt -o default
-        COMPREPLY=()
-        return
-    fi
-    if [ $NUMARGS -lt 3 ]; then
-        _confluent_nr_completion
-        return;
-    fi
-}
-
-_confluent_osimage_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS == 2 ]; then
-        COMPREPLY=($(compgen -W "initialize import updateboot" -- ${COMP_WORDS[COMP_CWORD]}))
-        return
-    elif [ ${CMPARGS[1]} == 'initialize' ]; then
-        COMPREPLY=($(compgen -W "-h -u -s -t -i" -- ${COMP_WORDS[COMP_CWORD]}))
-    elif [ ${CMPARGS[1]} == 'import' ]; then
-        compopt -o default
-        COMPREPLY=()
-        return
-    elif [ ${CMPARGS[1]} == 'updateboot' ]; then
-        COMPREPLY=($(compgen -W "-n $(confetty show /deployment/profiles|sed -e 's/\///')" -- "${COMP_WORDS[COMP_CWORD]}"))
-        return
-    fi
-}
-
-_confluent_imgutil_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS == 2 ]; then
-        COMPREPLY=($(compgen -W "build exec unpack pack capture" -- ${COMP_WORDS[COMP_CWORD]}))
-        return
-    elif [ ${CMPARGS[1]} == 'build' ]; then
-        COMPREPLY=($(compgen -W "-s $(ls /var/lib/confluent/distributions)" -- ${COMP_WORDS[COMP_CWORD]}))
-	    return
-    elif [ ${CMPARGS[1]} == 'unpack' ]; then
-        if [ $NUMARGS == 3 ]; then
-            COMPREPLY=($(compgen -W "-s $(ls /var/lib/confluent/public/os)" -- ${COMP_WORDS[COMP_CWORD]}))
-            return
-        fi
-        compopt -o dirnames
-	    return
-    elif [ ${CMPARGS[1]} == 'pack' ]; then
-        if [ $NUMARGS == 3 ]; then
-            compopt -o dirnames
-        fi
-        COMPREPLY=()
-        return
-    elif [ ${CMPARGS[1]} == 'capture' ]; then
-        if [ $NUMARGS == 3 ]; then
-            _confluent_nn_completion
-            return
-        fi
-        return
-    elif [ ${CMPARGS[1]} == 'exec' ]; then
-        compopt -o dirnames
-	    COMPREPLY=($(compgen -W "-v" -- ${COMP_WORDS[COMP_CWORD]}))
-        return
-    fi
-}
-_confluent_nodedeploy_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS -gt 2 ]; then
-        COMPREPLY=($(compgen -W "-n $(confetty show /deployment/profiles|sed -e 's/\///')" -- "${COMP_WORDS[COMP_CWORD]}"))
-        return
-    fi
-    if [ $NUMARGS -lt 3 ]; then
-        _confluent_nr_completion
-        return;
-    fi
-}
-
-_confluent_nodeshell_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS == 3 ]; then
-        COMPREPLY=($(compgen -c -- ${COMP_WORDS[COMP_CWORD]}))
-        return
-    fi
-    if [ $NUMARGS -gt 3 ]; then
-        compopt -o default
-        COMPREPLY=()
-        return
-    fi
-    if [ $NUMARGS -lt 3 ]; then
-        _confluent_nr_completion
-        return;
-    fi
-}
-
-_confluent_nodelicense_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS == 3 ]; then
-        COMPREPLY=($(compgen -W "install list save delete" -- ${COMP_WORDS[COMP_CWORD]}))
-        return;
-    fi
-    if [ $NUMARGS == 4 ] && [ ${CMPARGS[2]} == 'install' ]; then
-        compopt -o default
-        COMPREPLY=()
-        return
-    fi
-    if [ $NUMARGS == 4 ] && [ ${CMPARGS[2]} == 'save' ]; then
-        compopt -o dirnames
-        COMPREPLY=()
-        return
-    fi
-    if [ $NUMARGS -lt 3 ]; then
-         _confluent_nr_completion
-         return
-    fi
-}
-
-_confluent_nodesupport_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS == 3 ]; then
-        COMPREPLY=($(compgen -W "servicedata" -- ${COMP_WORDS[COMP_CWORD]}))
-        return;
-    fi
-    if [ $NUMARGS == 4 ] && [ ${CMPARGS[2]} == 'servicedata' ]; then
-        compopt -o  dirnames
-        COMPREPLY=()
-        return
-    fi
-    if [ $NUMARGS -lt 3 ]; then
-         _confluent_nr_completion
-         return
-    fi
-}
-
-_confluent_nodeattrib_completion()
-{
-    COMP_CANDIDATES=$(nodeattrib '~.>1' all | awk '{print $2}'|sed -e 's/://')
-    _confluent_generic_completion
-}
-
-
-_confluent_nn_completion()
-{
-    _confluent_get_args
-    INPUT=${COMP_WORDS[COMP_CWORD]}
-    INPUT=${INPUT##*,-}
-    INPUT=${INPUT##*,}
-    INPUT=${INPUT##*@}
-    PREFIX=""
-    if [ "$INPUT" != "${COMP_WORDS[COMP_CWORD]}" ]; then
-        PREFIX=${COMP_WORDS[COMP_CWORD]}
-        PREFIX=$(echo $PREFIX | sed -e 's/,[^,@-]*$/,/' -e 's/,-[^,@]*$/,-/' -e 's/@[^,@]*/@/')
-    fi
-
-    COMPREPLY=($(compgen -W "$(nodelist | sed -e s/^/$PREFIX/)" -- "${COMP_WORDS[COMP_CWORD]}"))
-}
-_confluent_nr_completion()
-{
-    CMPARGS=($COMP_LINE)
-    _confluent_get_args
-    if [ $NUMARGS -gt 2 ]; then
-        compopt -o default
-        COMPREPLY=()
-        return;
-    fi
-    INPUT=${COMP_WORDS[COMP_CWORD]}
-    INPUT=${INPUT##*,-}
-    INPUT=${INPUT##*,}
-    INPUT=${INPUT##*@}
-    PREFIX=""
-    if [ "$INPUT" != "${COMP_WORDS[COMP_CWORD]}" ]; then
-        PREFIX=${COMP_WORDS[COMP_CWORD]}
-        PREFIX=$(echo $PREFIX | sed -e 's/,[^,@-]*$/,/' -e 's/,-[^,@]*$/,-/' -e 's/@[^,@]*/@/')
-    fi
-
-    COMPREPLY=($(compgen -W "$(confetty show /nodegroups|sed -e 's/\///' -e s/^/$PREFIX/;nodelist | sed -e s/^/$PREFIX/)" -- "${COMP_WORDS[COMP_CWORD]}"))
-}
-_confluent_ng_completion()
-{
-    _confluent_get_args
-    if [ $NUMARGS -gt 2 ]; then
-        return;
-    fi
-    INPUT=${COMP_WORDS[COMP_CWORD]}
-    INPUT=${INPUT##*,-}
-    INPUT=${INPUT##*,}
-    INPUT=${INPUT##*@}
-    PREFIX=""
-    if [ "$INPUT" != "${COMP_WORDS[COMP_CWORD]}" ]; then
-        PREFIX=${COMP_WORDS[COMP_CWORD]}
-        PREFIX=$(echo $PREFIX | sed -e 's/,[^,@-]*$/,/' -e 's/,-[^,@]*$/,-/' -e 's/@[^,@]*/@/')
-    fi
-
-    COMPREPLY=($(compgen -W "$(confetty show /nodegroups|sed -e 's/\///' -e s/^/$PREFIX/)" -- "${COMP_WORDS[COMP_CWORD]}"))
-}
-complete -F _confluent_nodeattrib_completion nodeattrib
-complete -F _confluent_nodeattrib_completion nodegroupattrib
-complete -F _confluent_nr_completion nodebmcreset
-complete -F _confluent_nodesetboot_completion nodeboot
-complete -F _confluent_nr_completion nodeconfig
-complete -F _confluent_nn_completion nodeconsole
-complete -F _confluent_nr_completion nodeeventlog
-complete -F _confluent_nodefirmware_completion nodefirmware
-complete -F _confluent_nodedeploy_completion nodedeploy
-complete -F _confluent_osimage_completion osdeploy
-complete -F _confluent_imgutil_completion imgutil
-complete -F _confluent_ng_completion nodegroupattrib
-complete -F _confluent_ng_completion nodegroupremove
-complete -F _confluent_nr_completion nodehealth
-complete -F _confluent_nodeidentify_completion nodeidentify
-complete -F _confluent_nr_completion nodeinventory
-complete -F _confluent_nodeattrib_completion nodelist
-complete -F _confluent_nodemedia_completion nodemedia
-complete -F _confluent_nodepower_completion nodepower
-complete -F _confluent_nr_completion noderemove
-complete -F _confluent_nr_completion nodereseat
-complete -F _confluent_nodeshell_completion noderun
-complete -F _confluent_nr_completion nodesensors
-complete -F _confluent_nodesetboot_completion nodesetboot
-complete -F _confluent_nodeshell_completion nodeshell
-complete -F _confluent_nodesupport_completion nodesupport
-complete -F _confluent_nodelicense_completion nodelicense
-

confluent_client/doc/man/collate.ronn

@@ -3,7 +3,7 @@ collate(1) -- Organize text input by node
 
 ## SYNOPSIS
 
-`<other command> | collate [-a] [-b] [-d] [-w] [-g] [-s] [-c] [-r] [-l lognametemplate]`
+`<other command> | collate [-a] [-d] [-w] [-s] [-c] [-r]`
 
 ## DESCRIPTION
 
@@ -21,41 +21,26 @@ node and group names sorted alphanumerically.
    when output differs along a telling group boundary.  For example, if
    output suggests a large number of nodes are unreachable, abbreviate
    showing 'rack1' as being unreachable may make more obvious a possible cause.
-   
-* `-b BASE`, `--base=BASE`:
-   Use given node as reference for comparison when using
-   -d, instead of using the most common result      
 
 * `-d`, `--diff`:
    Express all but the most common result group in terms of diff from
    the most common result group
-   
+
 * `-w`, `--watch`:
    Update results dynamically as data becomes available, rather than
    waiting    for the command to fully complete.
-   
-* `-g`, `--groupcount`:
-   Show count of output groups rather than the actual
-   output
-   
+
 * `-s`, `--skipcommon`:
    Suppress printing of the most common result text group.  This is used to
    focus on stray output against a well known and expected result.
    
 * `-c`, `--count`:
    Print a count of the number of nodes in an output group under the 
-   noderange.
+  noderange.
   
-* `-r`, `--reverse`:
-   Rather than starting with most common to least common, start with
-   the least common and print the most common last.
-    
-* `-l LOG`, `--log=LOG`:
-   Save output per node to individual log files, replacing {node} in the name
-   with the nodename of each
-   
-* `-h`, `--help`:
-   Show help message and exit   
+ * `-r`, `--reverse`:
+    Rather than starting with most common to least common, start with
+    the least common and print the most common last.
    
 ## EXAMPLES
  * Organizing power state of multiple nodes:  
@@ -100,4 +85,4 @@ node and group names sorted alphanumerically.
   `  Processors.ExecuteDisableBit=Enable`  
 
    
-   
+   

confluent_client/doc/man/collective.ronn

@@ -1,59 +0,0 @@
-collective(1) -- Check and manage a confluent collective
-==============================
-
-## SYNOPSIS
-
-`collective invite <server>`  
-`collective join <server> [-i TOKEN]`  
-`collective show`  
-`collective gencert`  
-`collective delete`  
-
-
-## DESCRIPTION
-
-**collective** helps manage the collective mode of confluent, where multiple
-confluent servers are linked together to act as one.  For example, the procedure to set up
-a collective to run on three servers called mgt1, mgt2, and mgt3, first install and start
-confluent as usual on the three servers.  On mgt1, run `collective invite mgt2` and an
-invitation token will be output.  On mgt2, either run `collective join mgt1` to paste
-the token interactively, or `collective join mgt1 -i <token>`.  At this point, either
-mgt1 or mgt2 can bring in mgt3.  For example on mgt2 run `collective invite mgt3` and
-on mgt3 run `collective join mgt2 -i <token>`
-
-This can be linked together in the following manner with ssh:
-on mgt1:
-  `# ssh mgt2 collective join mgt1 -i $(collective invite mgt2)`
-
-Note that a collective is only redundant with 3 or more members.  The collective
-will function so long as more than half of the members are online.  A collective
-of two members is supported, but without redundancy.
-
-Also note that the collective leader role is dynamic, but has no impact on interacting
-with confluent.  It is merely an internal role that can dynamically change depending
-on circumstances.
-
-## OPTIONS
-
- * `-i`:
-    Provide the token as an argument rather than interactively.
-    
-* `-h`, `--help`:
-  Show help message and exit    
-   
-## EXAMPLES
- * Inviting a server called mgt2:
-  `# collective invite mgt2`  
-  `bWd0MkA+BNQ6XAxMXlqJJa+EQRlihL/k9xCXnasgSQXZr989Pa1/ln7G3e1Ncxx6BMzMqqreHJVkPr2FrzjNit/UgHlg`  
-
-* On mgt2, joining mgt1:
-  `# collective join mgt1 -i bWd0MkA+BNQ6XAxMXlqJJa+EQRlihL/k9xCXnasgSQXZr989Pa1/ln7G3e1Ncxx6BMzMqqreHJVkPr2FrzjNit/UgHlg`  
-  `Success`  
-
-* Showing the collective state:
-  `# collective show`  
-  `Quorum: True`  
-  `Leader: mgt1`  
-  `Active collective members:`  
-  `  mgt2`  
-

confluent_client/doc/man/confetty.ronn

@@ -15,21 +15,6 @@ be mostly an aid for developing client software, with
 day to day administration generally being easier with
 the various function specific commands.
 
-## OPTIONS
-
-* `-s SERVER:PORT`, `--server=SERVER:PORT`:
-  Confluent instance to connect to
-
-* `-c PATH`, `--control=PATH`:
-  Path to offer terminal control
-
-* `-m MINTIME`, `--mintime=MINTIME`:
-  Minimum time to run or else pause for input (used to
-  keep a terminal from closing quickly on error)
-  
-* `-h`, `--help`:
-  Show help message and exit  
-
 ## COMMANDS
 
 The CLI may be navigated by shell commands and some other

confluent_client/doc/man/confluentdbutil.ronn

@@ -3,7 +3,8 @@ confluentdbutil(8) -- Backup or restore confluent database
 
 ## SYNOPSIS
 
-`confluentdbutil [options] [dump|restore] <path>`
+
+`confluentdbutil [options] <dump|restore> <path>`
 
 ## DESCRIPTION
 
@@ -15,28 +16,11 @@ the json files (password protected, removed from the files, or unprotected).
 
 ## OPTIONS
 
-* `-p PASSWORD`, `--password=PASSWORD`:
+* `-p`, `--password`:
   If specified, information such as usernames and passwords will be encrypted
   using the given password.
-  
-* `-i`, `--interactivepassword`:
-  Prompt for password.  
-  
 * `-r`, `--redact`:
   Indicates to replace usernames and passwords with a dummy string rather
   than included.
-  
 * `-u`, `--unprotected`:
-  The keys.json file will include the encryption keys without any protection.
-  
-* `-s`, `--skipkeys`:
-  This specifies to dump the encrypted data without
-  dumping the keys needed to decrypt it.  This is
-  suitable for an automated incremental backup, where an
-  earlier password protected dump has a protected
-  keys.json file, and only the protected data is needed.
-  keys do not change and as such they do not require
-  incremental backup.
-  
-  * `-h`, `--help`:
-  Show help message and exit
+  The keys.json file will include the encryption keys without any protection.

confluent_client/doc/man/nodeattrib.ronn

@@ -7,7 +7,6 @@ nodeattrib(8) -- List or change confluent nodes attributes
 `nodeattrib <noderange> [<nodeattribute1=value1> <nodeattribute2=value2> ...]`  
 `nodeattrib -c <noderange> <nodeattribute1> <nodeattribute2> ...`  
 `nodeattrib -e <noderange> <nodeattribute1> <nodeattribute2> ...`  
-`nodeattrib -p <noderange> <nodeattribute1> <nodeattribute2> ...`  
 
 ## DESCRIPTION
 
@@ -23,9 +22,6 @@ For a full list of attributes, run `nodeattrib <node> all` against a node.
 If `-c` is specified, this will set the nodeattribute to a null value.
 This is different from setting the value to an empty string.
 
-Attributes may be specified by wildcard, for example `net.*switch` will report
-all attributes that begin with `net.` and end with `switch`.
-
 If the word all is specified, then all available attributes are given.
 Omitting any attribute name or the word 'all' will display only attributes
 that are currently set.
@@ -34,37 +30,16 @@ For the `groups` attribute, it is possible to add a group by doing
 `groups,=<newgroup>` and to remove by doing `groups^=<oldgroup>`
 
 Note that `nodeattrib <group>` will likely not provide the expected behavior.
-See nodegroupattrib(8) command on how to manage attributes on a group level.  Running
-nodeattrib on a group will simply set node-specific attributes on each individual
-member of the group.
-
-Additionally, if wanting to change from a node level attribute value to inherit from a
-member group, it is required to use '-c' to clear the attribute.  Conversely, assigning
-to a blank value will allow masking a group defined attribute with an empty value.
+See nodegroupattrib(8) command on how to manage attributes on a group level.
 
 ## OPTIONS
 
 * `-b`, `--blame`:
   Annotate inherited and expression based attributes to show their base value.
-  
 * `-c`, `--clear`:
-  Clear specified nodeattributes.
-  
+  Clear specified nodeattributes
 * `-e`, `--environment`:
-  Set specified attributes based on exported environment variable of matching name. 
-  Environment variable names may be lower case or all upper case. 
-  Replace . with _ as needed (e.g. info.note may be specified as either $info_note or $INFO_NOTE
-  
-* `-p`, `--prompt`:
-  Request interactive prompting to provide values rather than the command line
-  or environment variables.
-  
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Prompt if trying to set attributes on more than
-  specified number of nodes.
-
-* `-h`, `--help`:
-  Show help message and exit
+  Set specified attributes based on exported environment variable of matching name.  Environment variable names may be lower case or all upper case.  Replace . with _ as needed (e.g. info.note may be specified as either $info_note or $INFO_NOTE
 
 ## EXAMPLES
 * Listing matching nodes of a simple noderange:
@@ -110,14 +85,6 @@ to a blank value will allow masking a group defined attribute with an empty valu
     `n1: console.method: `  
     `n2: console.method: `  
 
-* List all switches that a node is described as connected to:
-    `# nodeattrib d1 net.*switch`  
-    `d1: net.mgt.switch: mgtswitch1`  
-    `d1: net.pxe.switch: pxeswitch1`  
-    `d1: net.switch:`  
-
 ## SEE ALSO
 
 nodegroupattrib(8), nodeattribexpressions(5)
-
-## ATTRIBUTES

confluent_client/doc/man/nodeattribexpressions.ronn

@@ -9,18 +9,6 @@ expression to generate the value.
 An expression will contain some directives wrapped in `{}` characters. Within
 `{}` are a number of potential substitute values and operations.
 
-Note that syntax of expressions can have overlap with the shell syntax.
-For example:
-
-`$ echo (n2)`  
-`-bash: syntax error near unexpected token `n2'`  
-
-In such a case, it helps to quote the expression to allow it to be passed:
-
-`$ echo '(n2)'`  
-`(n2)`  
-
-
 The most common operation is to extract a number from the nodename. These 
 values are available as n1, n2, etc. So for example attributes for a node named 
 b1o2r3u4 would have {n1} as 1, {n2} as 2, {n3} as 3, and {n4} as 4. 

confluent_client/doc/man/nodebmcreset.ronn

@@ -9,15 +9,6 @@ nodebmcreset(8) -- Reset management controller
 
 `nodebmcreset` allows you to reset the management controller of the specified noderange
 
-## OPTIONS
-
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Number of nodes to affect before prompting for
-  confirmation
-  
-* `-h`, `--help`:
-  Show help message and exit  
-
 ## EXAMPLES:
 
 * Reset the management controller for nodes n1 through n4:

confluent_client/doc/man/nodeboot.ronn

@@ -3,51 +3,13 @@ nodeboot(8) -- Reboot a confluent node to a specific device
 
 ## SYNOPSIS
 
-`nodeboot [options] <noderange> [default|cd|network|setup|hd]`  
+`nodeboot <noderange>`  
+`nodeboot <noderange>` [net|setup]  
 
 ## DESCRIPTION
 
 **nodeboot** reboots nodes in a noderange.  If an additional argument is given,
-it sets the node to specifically boot to that as the next boot.  This 
-performs an immediate reboot without waiting for the OS.  To set the boot
-device without inducing a reboot, see the `nodesetboot` command.
-
-## OPTIONS
-
-* `-b`, `--bios`:
-  For a system that supports both BIOS and UEFI style boot, request BIOS style
-  boot if supported (some platforms will UEFI boot with this flag anyway).
-
-* `-u`, `--uefi`:
-  This flag does nothing, it is for command compatibility with xCAT's rsetboot
-
-* `-p`, `--persist`:
-  For a system that supports it, mark the boot override to persist rather than
-  be a one time change.  Many systems do not support this functionality.
-  
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to boot, prompting
-  if over the threshold
-  
-* `-h`, `--help`:
-  Show help message and exit  
-
-* `default`:
-  Request a normal default boot with no particular device override
-
-* `cd`:
-  Request boot from media.  Note that this can include physical CD,
-  remote media mounted as CD/DVD, and detachable hard disks drives such as usb
-  key devices.
-  
-* `network`:
-  Request boot to network
-  
-* `setup`:
-  Request to enter the firmware configuration menu (e.g. F1 setup) on next boot.
-
-* `hd`:
-  Boot straight to hard disk drive
+it sets the node to specifically boot to that as the next boot.
 
 ## EXAMPLES
 * Booting n3 and n4 to the default boot behavior:

confluent_client/doc/man/nodeconfig.ronn

@@ -3,7 +3,8 @@ nodeconfig(8) -- Show or change node configuration
 
 ## SYNOPSIS
 
-`nodeconfig [options] <noderange> [setting|setting=value]`
+`nodeconfig <noderange> [options] [<configuration>..]`
+`nodeconfig <noderange> [options] [<configuration=value>..]`
 
 ## DESCRIPTION
 
@@ -13,12 +14,6 @@ running configuration on the node firmware.  Calling without '=' will show the
 current value, and '=' will change the value.  Network information can be
 given as a node expression, as documented in the man page for nodeattribexpressions(5).
 
-Note that when using nodeconfig to submit changes, it will exit when the change
-is accepted, but the endpoint may not have fully processed it. Doing a show
-immediately after doing a set may reflect older information. Also, if changing
-BIOS/UEFI settings, the change may appear in output, but generally won't
-actually be in effect until a reboot.
-
 ## OPTIONS
 
 * `-c`, `--comparedefault`:
@@ -26,38 +21,18 @@ actually be in effect until a reboot.
   no configuration values are specified, it will show only those that differ.
   If combined with `-x`, will show all differing values except those indicated
   by `-x`
-  
-* `-b settings.batch`, `--batch=settings.batch`:
-   Provide arguments as lines of a file, rather than the command line.  
-   
-* `-d`, `--detail`:
-  Provide detailed data as available.  This can include help text and valid
-  values for a setting.   
-
-* `-e`, `--extra`:
-   Read settings that are generally not needed, but may be slow to retrieve.
-   Notably this includes the IMM category of Lenovo systems.  The most popular
-   IMM settings are available through faster 'bmc' attributes.
 
 * `-x`, `--exclude`:
   Rather than listing only the specified configuration parameters, list all
   attributes except for the specified ones
 
-* `-a`, `--advanced`:
-  Include advanced settings, which are normally not intended to be used
-  without direction from the relevant server vendor.
+* `-d`, `--detail`:
+  Provide detailed data as available.  This can include help text and valid
+  values for a setting.
 
-* `-r COMPONENT`, `--restoredefault=COMPONENT`:
-  Request that the specified component of the targeted nodes will have its
-  configuration reset to default.  Currently the only component implemented
-  is uefi.
+* `-b`, '--batch':
+   Provide arguments as lines of a file, rather than the command line.
 
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to configure, prompting if over 
-  the threshold  
-  
-* `-h`, `--help`:
-  Show help message and exit  
 
 ## EXAMPLES
 * Showing the current IP configuration of noderange BMC/IMM/XCC:

confluent_client/doc/man/nodeconsole.ronn

@@ -2,7 +2,7 @@ nodeconsole(8) -- Open a console to a confluent node
 =====================================================
 
 ## SYNOPSIS
-`nodeconsole [options] <noderange>`
+`nodeconsole <node>`
 
 ## DESCRIPTION
 
@@ -16,17 +16,6 @@ will initiate an automatic retry interval that is randomized between 2 and 4 min
 The reopen escape sequence below requests an immediate retry, as does connecting
 a new session.
 
-## OPTIONS
-
-* `-t`, `--tile`:
-  Use tmux to arrange consoles of the given noderange into a tiled layout on
-  the terminal screen
-
-* `-l`, `--log`:
-  Perform a log reply on the current, local log in /var/log/confluent/consoles.
-  If in collective mode, this only makes sense to use on the current collective
-  manager at this time.
-
 ## ESCAPE SEQUENCE COMMANDS
 
 While connected to a console, a number of commands may be performed through escape

confluent_client/doc/man/nodedefine.ronn

@@ -1,5 +1,4 @@
 nodedefine(8) -- Define new confluent nodes
-===================================================================
 
 ## SYNOPSIS
 

confluent_client/doc/man/nodedeploy.ronn

@@ -1,46 +0,0 @@
-nodedeploy(8) -- Request preparation and/or initiating a node deployment
-=========================================================================
-
-## SYNOPSIS
-
-`nodedeploy [-h] [-c] [-n] [-p] [-m MAXNODES] <noderange> [profile]`  
-
-## DESCRIPTION
-
-**nodedeploy** configures attributes and interacts with BMC devices as appropriate
-to change the operating system on the noderange to that indicated by `profile`. Tab completion
-is supported under bash to help list and select a profile name. `-n` indicates that it
-will be a network based deployment (either HTTP or PXE) and `-p` suppresses any activity
-that requires the BMC (e.g. setting the next boot device and rebooting the system). Currently
-**nodedeploy** only supports `-n` style deployment flows. Without options it shows the current
-deployment status.
-
-## OPTIONS
-
-* `-c`, `--clear`:
-  Remove any pending deployment action
-
-* `-n`, `--network`:
-  Prepare for either an HTTP or PXE based deployment, setting boot device to network and rebooting unless `-p` is specified.
-
-* `-p`, `--prepareonly`:
-  Prepare the network services for deployment, but do not interact with BMCs. This is intended for scenarios where
-  the boot device control and server restart will be handled outside of confluent.
-  
-* `-m MAXNODES`, `--maxnodes=MAXNODES`: 
-  Specifiy a maximum nodes to be deployed.
-  
-* `-h`, `--help`:
-  Show help message and exit  
-
-## EXAMPLES
-* Begin the instalalation of a profile of CentOS 8.2:  
-   `# nodedeploy d4 -n centos-8.2-x86_64-default`  
-   `d4: network`  
-   `d4: reset`  
-
-* Check current deployment state of nodes:
-  `# nodedeploy d4`  
-  `d4: pending: centos-8.2-x86_64-default (node authentication armed)`  
-
-

confluent_client/doc/man/nodediscover.ronn

@@ -23,9 +23,6 @@ data may be filtered by various parameters, as denoted in the options below.
 **nodediscover assign** performs manual discovery, assigning an entry to a node
 identity or, using `-i`, using a csv file to assign nodes all at once.  For
 example, a spreadsheet of serial numbers to desired node names could be used.
-Note that if you see that the host is unreachable, it may be due to the IP
-address on the endpoint having changed since last detected. In such a case, it
-may help to **clear** and try **assign** again.
 
 **nodediscover rescan** requests the server to do an active sweep for new
 devices.  Generally every effort is made to passively detect devices as they
@@ -78,20 +75,6 @@ the nodes.
 * `-e MAC`, `--ethaddr=MAC`:
   Operate against the system with the specified MAC
   address
-* `-f FIELDS`, `--fields=FIELDS`:
-  Request a custom set of fields.  The available fields are:  
-  Node: The node name if a correlation has been identified  
-  Model: The model number  
-  Serial: The serial number  
-  UUID: The UUID as it should appear in DMI  
-  Type: Device type (e.g. lenovo-xcc, pxe-client, etc)  
-  IP: The confirmed working IP addresses associated with the record  
-  Mac: Mac address of the relevant network interface  
-  Switch: The nearest detected switch to the entry  
-  Port: Port of the switch that most closely connects to the network interface  
-  Advertised IP: IP addresses that may not have been confirmed, but are advertised  
-* `-o ORDER`, `--order=ORDER`:
-  Order output by given field.  Field names are the same as documented in the -f argument.
 * `-t TYPE`, `--type=TYPE`:
   Operate against the system of the specified type
 * `-c`, `--csv`:

confluent_client/doc/man/nodeeventlog.ronn

@@ -3,22 +3,14 @@ nodeeventlog(8) -- Pull eventlog from confluent nodes
 
 ## SYNOPSIS
 
-`nodeeventlog [options] <noderange> [clear]`  
+`nodeeventlog <noderange>`  
+`nodeeventlog <noderange> [clear]`
 
 ## DESCRIPTION
 
 `nodeeventlog` pulls and optionally clears the event log from the requested
 noderange.
 
-## OPTIONS
-
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to clear if clearing log, prompting if 
-  over the threshold 
-  
-* `-h`, `--help`:
-  Show help message and exit  
-
 ## EXAMPLES
 * Pull the event log from n2 and n3:
   `# nodeeventlog n2,n3`  

confluent_client/doc/man/nodefirmware.ronn

@@ -3,7 +3,9 @@ nodefirmware(8) -- Report firmware information on confluent nodes
 
 ## SYNOPSIS
 
-`nodefirmware <noderange> [list][update [--backup <file>]]|[<components>]`
+`nodefirmware <noderange>`  
+`nodefirmware <noderange> <components>|core`  
+`nodefirmware <noderange> update [--backup] <filename>`  
 
 ## DESCRIPTION
 
@@ -11,11 +13,7 @@ nodefirmware(8) -- Report firmware information on confluent nodes
 will retrieve all firmware, but can be directed to fetch specific firmware by
 calling out the name of the firmware (e.g. uefi or xcc) or request reading only
 core firmware firmware by using the word 'core', which is generally a quicker
-operation.  Different hardwaremanagement.method indicated plugins may have
-different capabilities available.  For example, the 'core' distinction may
-not be relevant to redfish.  Additionally, the Lenovo XCC makes certain
-information available over IPMI that is not otherwise available (for example
-the FPGA version where applicable).
+operation.
 
 In the update form, it accepts a single file and attempts to update it using
 the out of band facilities.  Firmware updates can end in one of three states:
@@ -24,18 +22,6 @@ the out of band facilities.  Firmware updates can end in one of three states:
 * `pending`:  The firmware update process has completed, but the firmware will not be active until the relevant component next resets.  Generally speaking, for UEFI update the system will need a reboot, and for BMC updates, the `nodebmcreset` command will begin the process to activate the firmware.
 * `complete`:  The firmware update process has completed and activation has proceeded.  Note that while the activation process has commenced, the component may still be in the process of rebooting when nodefirmware exits.
 
-## OPTIONS
-
-* `-b`, `--backup`:
-  Target a backup bank rather than primary
-  
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  When updating, prompt if more than the specified number of servers will 
-  be affected  
-  
-* `-h`, `--help`:
-  Show help message and exit    
-
 ## EXAMPLES
 
 * Pull firmware from a node:

confluent_client/doc/man/nodegroupattrib.ronn

@@ -7,7 +7,6 @@ nodegroupattrib(8) -- List or change confluent nodegroup attributes
 `nodegroupattrib <group> [<nodeattribute>...]`  
 `nodegroupattrib <group> [<nodeattribute1=value1> <nodeattribute2=value2> ...]`  
 `nodegroupattrib <group> [-c] [<nodeattribute1> <nodeattribute2=value2> ...]`  
-`nodeattrib -p <noderange> <nodeattribute1> <nodeattribute2> ...`  
 
 ## DESCRIPTION
 
@@ -25,20 +24,8 @@ the attributes are set on the node versus a group to which a node belongs.
 
 ## OPTIONS
 
-* `-b`, `--blame`:
-  Show information about how attributes inherited
-
-* `-e`, `--environment`:
-  Set attributes, but from environment variable of same name
-
 * `-c`, `--clear`:
   Clear specified nodeattributes.
-  
-* `-p`, `--prompt`:
-  Prompt for attribute values interactively
-  
-* `-h`, `--help`:
-  Show help message and exit  
 
 ## EXAMPLES
 
@@ -53,5 +40,3 @@ the attributes are set on the node versus a group to which a node belongs.
 ## SEE ALSO
 
 nodeattrib(8), nodeattribexpressions(5)
-
-## ATTRIBUTES

confluent_client/doc/man/nodegroupdefine.ronn

@@ -1,5 +1,4 @@
 nodegroupdefine(8) -- Define new confluent node group
-===================================================================
 
 ## SYNOPSIS
 
@@ -7,7 +6,7 @@ nodegroupdefine(8) -- Define new confluent node group
 
 ## DESCRIPTION
 
-`nodegroupdefine` allows the definition of a new nodegroup for the confluent management
+`nodegroupdefine` allows the definition of a new node for the confluent management
 service.  It may only define a single group name at a time.
 It has the same syntax as `nodegroupattrib(8)`, and the commands differ in
 that `nodegroupattrib(8)` will error if a node group does not exist.

confluent_client/doc/man/nodegrouplist.ronn

@@ -1,14 +0,0 @@
-nodegrouplist(8) -- List the defined confluent nodegroups
-===================================================================
-
-## SYNOPSIS
-
-`nodegrouplist`  
-
-## DESCRIPTION
-
-`nodegrouplist` lists the currently defined groups in confluent.
-
-## SEE ALSO
-
-nodeattrib(8), nodeattribexpressions(5), nodegroupattrib(8)

confluent_client/doc/man/nodeidentify.ronn

@@ -3,7 +3,7 @@ nodeidentify(8) -- Control the identify LED of confluent nodes
 
 ## SYNOPSIS
 
-`nodidentify <noderange> [on|off|blink]`  
+`nodidentify <noderange> [on|off]`  
 
 ## DESCRIPTION
 
@@ -13,7 +13,6 @@ options are supported:
 
 * `on`: Turn on the identify LED
 * `off`: Turn off the identify LED
-* `blink`: Set the identify LED to blink (when supported by the system)
 
 ## EXAMPLES:
 

confluent_client/doc/man/nodelicense.ronn

@@ -1,24 +0,0 @@
-nodelicense(8) -- Manage license keys on BMC
-=================================================================
-
-## SYNOPSIS
-
-`nodelicense <noderange> [list][install <license_filename>|save <directory>|delete <license_feature_name>]`
-
-## DESCRIPTION
-
-`nodelicense` manages license keys on supported BMCs. Without an argument, the command
-lists currently installed license.  Using `delete` will remove the specified license name
-from the BMC.  The `save` subcommand will take the passed directory (which may be in the form
-of /path/to/{node}/ to have the node name substituted for each node) and back up installed licenses
-to that directory. The `install` command will take the specified filename and install.  The filename
-argument may be of the form  xcc_fod_0034_7X21{id.serial}.key to have the serial number substituted
-to allow unique licenses to be specified in a single command.
-
-## OPTIONS
-
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to delete licenses from, prompting if over the threshold
-  
-* `-h`, `--help`:
-  Show help message and exit

confluent_client/doc/man/nodelist.ronn

@@ -17,9 +17,6 @@ displayed.  If `-b` is specified, it will also display information on
 how inherited and expression based attributes are defined.  There is more
 information on node attributes in nodeattributes(5) man page.
 
-Attributes may be specified by wildcard, for example `net.*switch` will report
-all attributes that begin with `net.` and end with `switch`.
-
 ## OPTIONS
 
 * `-b`, `--blame`:

confluent_client/doc/man/nodemedia.ronn

@@ -34,8 +34,8 @@ the host platform attempts.
 
 ## OPTIONS
 
-* `-h`, `--help`:
-  Show help message and exit
+* `-c`:
+  Specify the maximum number of instances to run concurrently.
 
 ## EXAMPLES
 * Listing currently mounted media:

confluent_client/doc/man/nodeping.ronn

@@ -1,47 +0,0 @@
-nodeping(8) -- Pings a node or a noderange.
-==============================
-## SYNOPSIS
-`nodeping [options] noderange`  
-
-## DESCRIPTION  
-**nodeping** is a command that pings the default NIC on a node.
-It can also be used with the `-s` flag to change the ping location to something that is 'non primary'
-
-
-## OPTIONS
-* ` -f` COUNT, `-c` COUNT, --count=COUNT  
-   Number of commands to run at a time  
-* `-h`, `--help`:  
-  Show help message and exit      
-* `-s` SUBSTITUTENAME, --substitutename=SUBSTITUTENAME  
-  Use a different name other than the nodename for ping. This may be a 
-  expression, such as {bmc} or, if no { character is present, it is treated as a suffix.  -s -eth1 would make n1 become n1-eth1, for example. 
-
-   
-## EXAMPLES
- * Pinging a node :  
-  `# nodeping <node>`  
-  `node : ping`    
-    
-* Pinging a group:  
-  `# nodeping <groupname>`    
-  `Node1 : ping  
-    Node2 : ping  
-    Node3 : ping`  
-
-* Pinging BMC on a node:  
-  `# nodeping -s {bmc} <noderange>`  
-  ` Node-bmc : ping`  
-
-* Pinging by specifying a suffix:
-  `# nodeping d1-d4 -s -eth1`  
-  `d2-eth1: no_ping`  
-  `d1-eth1: no_ping`  
-  `d3-eth1: no_ping`  
-  `d4-eth1: no_ping`  
-
-* Fail to ping node:  
-  `# nodeping <node>`  
-  `node : no_ping`  
- 
-

confluent_client/doc/man/nodepower.ronn

@@ -3,7 +3,8 @@ nodepower(8) -- Check or change power state of confluent nodes
 
 ## SYNOPSIS
 
-`nodepower [options] <noderange> ([status|on|off|shutdown|boot|reset])`
+`nodepower <noderange>`  
+`nodepower <noderange> [-p] [on|off|boot|shutdown|reset|status]`
 
 ## DESCRIPTION
 
@@ -24,21 +25,11 @@ respond.
 * `reset`:  Request immediate reset of nodes of the noderange.  Nodes that are
 off will not react to this request.
 * `status`:  Behave identically to having no argument passed at all.
-* `pdu_status`: Query state of associated PDU outlets, if configured.
-* `pdu_on`: Energize all PDU outlets associated with the noderange.
-* `pdu_off`: De-energize all PDU outlets associated with the noderange.
 
 ## OPTIONS
 
-* `-p`, `--showprevious`:
+* `-p`, '--showprevious':
    Show previous power state for all directives that may change power state.
-   
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-   Specify a maximum number of nodes to change power state, prompting if
-   over the threshold
-   
-* `-h`, `--help`:
-  Show help message and exit   
 
 ## EXAMPLES
 * Get power state of nodes n1 through n4:

confluent_client/doc/man/noderange.ronn

@@ -36,13 +36,10 @@ Also, regular expressions may be used to indicate nodes with names matching cert
 The other major noderange primitive is indicating nodes by some attribute value:
 `location.rack=7`
 
-The attribute name may use a wildcard:
-`net.*switch=switch1`
-
 Commas can be used to indicate multiple nodes, and can mix and match any of the above primitives. The following can be a valid single noderange, combining any and all members of each comma separated component
 `n1,n2,rack1,storage,location.rack=9,~s1..,n20-n30`
 
-Exclusions can be done by prepending a '-' before a portion of a noderange:
+Exclusions can be done by prepending a ‘-‘ before a portion of a noderange:
 `rack1,-n2`
 `compute,-rack1`
 `compute,-location.row=12`
@@ -54,7 +51,7 @@ To indicate nodes that match multiple selections at once (set intersection), the
 For complex expressions, () may be used to indicate order of expanding the noderange to be explicit
 `rack1,-(console.logging=full@compute)`
 
-Noderange syntax can also indicate 'pagination', or separating the nodes into well defined chunks. > is used to indicate how many nodes to display at a time, and < is used to indicate how many nodes to skip into a noderange:
+Noderange syntax can also indicate ‘pagination’, or separating the nodes into well defined chunks. > is used to indicate how many nodes to display at a time, and < is used to indicate how many nodes to skip into a noderange:
 `rack1>3<6`
 
 The above would show the seventh through ninth nodes of the rack1 group. Like all other noderange operations, this may be combined with any of the above, but must appear as the very last operation. Ordering is done with a natural sort.

confluent_client/doc/man/noderemove.ronn

@@ -9,14 +9,6 @@ noderemove(8) -- Remove nodes from the confluent management service
 
 `noderemove` simply removes the given noderange from the confluent database.
 
-## OPTIONS
-
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-    Specify a maximum number of nodes to delete, prompting if over the
-    threshold
-    
-* `-h`, `--help`:
-  Show help message and exit    
 
 ## EXAMPLES
 
@@ -30,3 +22,4 @@ noderemove(8) -- Remove nodes from the confluent management service
     `r2u3: deleted`  
     `r2u2: deleted`  
     `r2u1: deleted`  
+

confluent_client/doc/man/nodereseat.ronn

@@ -11,16 +11,9 @@ nodereseat(8) -- Request a reseat of a node
 node's slot.  This should be equivalent to removing the system entirely from
 the chassis and putting it back in, but without actually having to do so.
 
-## OPTIONS
-
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-    Specify a maximum number of nodes to reseat, prompting if over the threshold
-    
-* `-h`, `--help`:
-  Show help message and exit    
-
 ## EXAMPLES
 
 * Reseating the node `s1`:
     `# nodereseat s1`  
     `s1: Reseat successful`  
+

confluent_client/doc/man/nodersync.ronn

@@ -1,25 +0,0 @@
-nodersync(8) -- Run rsync in parallel against a noderange
-=========================================================================
-
-## SYNOPSIS
-
-`nodersync <file/directorylist> <noderange>:<destination>`  
-
-## DESCRIPTION
-
-Supervises execution of rsync to push files or a directory tree to the specified
-noderange. This will present progress as percentage for all nodes.
-
-## OPTIONS
-
-* `-f COUNT`, `-c COUNT`, `--count=COUNT`:
-  Specify how many rsync executions to do concurrently.  If noderange
-  exceeds the count, then excess nodes will wait until one of the
-  active count completes. 
-  
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to run rsync to, prompting if over the
-  threshold
-  
-* `-h`, `--help`:
-  Show help message and exit

confluent_client/doc/man/noderun.ronn

@@ -3,7 +3,7 @@ noderun(8) -- Run arbitrary commands per node in a noderange
 
 ## SYNOPSIS
 
-`noderun [options] <noderange> <command expression>`
+`noderun <noderange> <command string>`
 
 ## DESCRIPTION
 
@@ -13,21 +13,6 @@ nodeattribexpressions(5) are expanded prior to execution of the command.  For
 noderun, the commands are locally executed.  To execute commands on the nodes
 themselves, see nodeshell(8).
 
-## OPTIONS
-
-* `-f COUNT`, `-c COUNT`, `--count=COUNT`:
-  Number of commands to run at a time
-  
-* `-n`, `--nonodeprefix`:
-  Do not prefix output with node names
-  
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to run the command with, prompting if over
-  the threshold
-  
-* `-h`, `--help`:
-  Show help message and exit
-
 ## EXAMPLES
 
 * Run ping against nodes n1 through n4:

confluent_client/doc/man/nodesensors.ronn

@@ -29,10 +29,6 @@ interval of 1 second is used.
   Perform the specified number of readings, waiting `-i` indicated interval or 1 second if not
   otherwise indicated.
 
-* `-s`, `--skipnumberless`:
-  Return only sensors that provide numeric data (e.g. temperature, fanspeed),
-  ignoring sensors that do not provide numeric data.
-
 ## EXAMPLES
 * Retrieving all temperature related sensors from one system  
   `# nodesensors n1 temperature`  

confluent_client/doc/man/nodesetboot.ronn

@@ -2,8 +2,9 @@ nodesetboot(8) -- Check or set next boot device for noderange
 ====================================================
 
 ## SYNOPSIS
-  
-`nodesetboot [options] <noderange> [default|cd|network|setup|hd|usb|floppy]`
+
+`nodesetboot <noderange>`  
+`nodesetboot [options] <noderange> [default|cd|network|setup|hd]`
 
 ## DESCRIPTION
 
@@ -20,8 +21,6 @@ to use `nodesetboot <noderange> setup` and then initiate a reboot from within
 the operating system with ssh or similar rather than using the remote hardware
 control.
 
-Running the command with no target queries the current setting.
-
 ## OPTIONS
 
 * `-b`, `--bios`:
@@ -31,17 +30,7 @@ Running the command with no target queries the current setting.
 * `-p`, `--persist`:
   For a system that supports it, mark the boot override to persist rather than
   be a one time change.  Many systems do not support this functionality.
-
-* `-u`, `--uefi`:
-  This flag does nothing, it is for command compatibility with xCAT's rsetboot
   
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to modify next boot device, prompting if
-  over the threshold
-  
-* `-h`, `--help`:
-  Show help message and exit  
-
 * `default`:
   Request a normal default boot with no particular device override
 
@@ -50,14 +39,6 @@ Running the command with no target queries the current setting.
   remote media mounted as CD/DVD, and detachable hard disks drives such as usb
   key devices.
   
-* `floppy`:
-  Request boot from floppy.  Generally speaking firmware uses this to mean a USB
-  flash drive or similar (whether virtual or physical).
-
-* `usb`:
-  Request boot from usb.  Generally speaking firmware uses this to mean a USB
-  flash drive or similar (whether virtual or physical).
-
 * `network`:
   Request boot to network
   

confluent_client/doc/man/nodeshell.ronn

@@ -3,7 +3,7 @@ nodeshell(8) -- Execute command on many nodes in a noderange through ssh
 
 ## SYNOPSIS
 
-`nodeshell [options] <noderange> <command to execute on each node>`
+`nodeshell <noderange> [options] <command to execute on each node>`
 
 ## DESCRIPTION
 
@@ -13,29 +13,9 @@ nodeattribexpressions(5).  `nodeshell` provides stdout as stdout and stderr
 as stderr, unlike psh which combines all stdout and stderr into stdout.
 
 ## OPTIONS
-  
-* `-c COUNT`, `-f COUNT`, `--count=COUNT`
-  Specify the maximum number of instances to run concurrently
 
-* `-l LOGINNAME`, `--loginname=LOGINNAME`
-  Username to use when connecting, defaults to current user.
-
-* `-m MAXNODES`, `--maxnodes=MAXNODES`
-  Specify a maximum number of nodes to run remote ssh command to, prompting
-  if over the threshold
- 
-* `-n`, `--nonodeprefix`
-  Do not prefix output with node names  
-
-* `-p PORT`, `--port=PORT`
-  Specify a custom port for ssh
-
-* `-s SUBSTITUTION`, `--substitutename=SUBSTITITUTION`
-  Specify a substitution name instead of the nodename.  If no {} are in the substitution,
-  it is considered to be an append.  For example, '-s -ib' would produce 'node1-ib' from 'node1'.
-  Full expression syntax is supported, in which case the substitution is considered to be the entire
-  new name. {node}-ib would be equivalent to -ib.  For example, nodeshell -s {bmc} node1 
-  would ssh to the BMC instead of the node.
+* `-c`:
+  Specify the maximum number of instances to run concurrently.
 
 ## EXAMPLES
 

confluent_client/doc/man/nodestorage.ronn

@@ -1,77 +0,0 @@
-nodestorage(8) -- Examine/Modify storage configuration of a node
-============================================
-
-## SYNOPSIS
-
-`nodestorage <noderange> [show|create|delete|diskset] [hotspare|jbod|unconfigured] [options]`  
-
-## DESCRIPTION
-
-`nodestorage` provides access to the remote storage configuration of
-the noderange. The `show` subcommand will show current storage configuration,
-`create` can be used to create new arrays or volumes, `delete` can be used to
-remove volumes and arrays, and `diskset` can modify the usage of disks
-indicated by `-d` to either be `unconfigured`, `jbod`, or `hotspare`.
-
-## OPTIONS
-* `-r` **RAIDLEVEL**, `--raidlevel`=**RAIDLEVEL**:
-  RAID level to use when creating an array
-
-* `-d` **DISKS**, `--disks`=**DISKS**:
-   Comma separated list of disks to use, or the word "rest" to
-   indicate use of all available disks
-
-* `-s` **SIZE**, `--size`=**SIZE**:
-  Comma separated list of sizes to use when creating
-  volumes.  The sizes may be absolute size (e.g. 16gb),
-  percentage (10%) or the word "rest" to use remaining
-  capacity, default behavior is to use all capacity to
-  make a volume
-* `-n` **NAME**, `--name`=**NAME**:
-  Comma separated list of names to use when naming
-  volumes, or selecting a volume for delete.  Default
-  behavior is to use implementation provided default
-
-* `-z` **STRIPSIZES**, `--stripsizes`=**STRIPSIZES**:
-  Comma separated list of stripsizes to use when creating volumes.
-  This value is in kilobytes.  The default behavior is to allow the
-  storage controller to decide
-
-* `-m` **MAXNODES**, `--maxnodes`=**MAXNODES**:
-  Specify a maximum number of nodes to configure storage on, prompting
-  if over the threshold
-
-## EXAMPLES
-
-* Deleting the volume `somedata`:
-    `$ nodestorage d5 delete somedata`  
-    `Deleted: somedata`  
-
-* Creating a raid5 of 4 disks and a volume named `somedata`:
-    `$ nodestorage d5 create -r 5 -d drive0,drive_1,drive_2,drive_3 -n somedata`  
-    `d5: Volume somedata: Size: 1.905 TB`  
-    `d5: Volume somedata: State: Optimal`  
-    `d5: Volume somedata: Array 1-2`  
-
-* Showing current storage configuration of `d3`:
-    `$ nodestorage d3`  
-    `d3: Disk m.2-0 Description: 128GB M.2 SATA SSD`  
-    `d3: Disk m.2-0 State: online`  
-    `d3: Disk m.2-0 FRU: 00LF428`  
-    `d3: Disk m.2-0 Serial Number: H6B80054`  
-    `d3: Disk m.2-0 Array: 0-0`  
-    `d3: Disk m.2-1 Description: 128GB M.2 SATA SSD`  
-    `d3: Disk m.2-1 State: online`  
-    `d3: Disk m.2-1 FRU: 00LF428`  
-    `d3: Disk m.2-1 Serial Number: H6B80059`  
-    `d3: Disk m.2-1 Array: 0-0`  
-    `d3: Array 0-0 Available Capacity: 0.000 MB`  
-    `d3: Array 0-0 Total Capacity: 131.072 GB`  
-    `d3: Array 0-0 RAID: RAID 1`  
-    `d3: Array 0-0 Disks: m.2-0,m.2-1`  
-    `d3: Array 0-0 Volumes: new_vd`  
-    `d3: Volume new_vd: Size: 122.040 GB`  
-    `d3: Volume new_vd: State: Optimal`  
-    `d3: Volume new_vd: Array 0-0`  
-
-

confluent_client/doc/man/nodesupport.ronn

@@ -1,41 +0,0 @@
-nodesupport(8) -- Utilities for interacting with vendor support
-=================================================================
-
-## SYNOPSIS
-
-`nodesupport <noderange> servicedata <directory or filename>`  
-
-## DESCRIPTION
-
-`nodesupport` provides capabilities associated with interacting with support.
-Currently it only has the `servicedata` subcommand.  `servicedata` takes
-an argument that is either a directory name (that can be used for a single node
-or multiple nodes) or a file name (only to be used with single node noderange).
-Note that the file will be downloaded to the confluent server that actually
-connects to the managed system, so it will download to the remote system if running
-remotely and will download to the collective.manager indicated system if
-running in collective mode.
-
-Note that due to vendor filename requirements, any filename may have vendor
-specific suffixes added to any file produced.
-
-## OPTIONS
-
-* `-m MAXNODES`, `--maxnodes=MAXNODES`:
-  Specify a maximum number of nodes to download diagnostic data from, prompting
-  if over the threshold
-  
-* `-h`, `--help`:
-  Show help message and exit  
-
-## EXAMPLES
-
-* Download support data from a single node to a specific filename  
-`# nodesupport d1 servicedata svcdata.out`  
-`d1:initializing:  15%`  
-
-* Download support data from multiple nodes to a directory  
-`# nodesupport d1-d4 servicedata service/`    
-`d1:initializing:   0% d2:initializing:   0% d3:initializing:   0% d4:initializing:   0%`  
-`# ls service/`  
-`d1.svcdata d2.svcdata  d3.svcdata  d4.svcdata`  

confluent_client/doc/man/osdeploy.ronn

@@ -1,17 +0,0 @@
-osdeploy(8) --- Configure general OS deployment facilities of confluent
-==========================================================================
-
-## SYNOPSIS
-
-`osdeploy import <iso>`  
-`osdeploy updateboot <profile>`  
-`osdeploy initialize [-h] [-g] [-u] [-s] [-k] [-t] [-p] [-i] [-l] [-a]`  
-
-## DESCRIPTION
-
-**osdeploy** manages the facilities and os deployment content of a confluent server. The
-`import` subcommand will generate profiles from an iso image. `updateboot` will take any
-changes in the specified update that need to be pushed into boot configuration and/or images
-and ensure those needed changes are performed. `initialize` provides assistance in setting
-up the most commonly required facilities. Run `osdeploy initialize -h` for more detail
-on the options offered by `osdeploy initialize`

confluent_client/doc/man/stats.ronn

@@ -1,49 +0,0 @@
-stats(8) -- Common basic statistics on typical numeric data in output
-==============================
-
-## SYNOPSIS
-
-`<other command> | stats [-c N] [-d D] [-x|-g|-t|-o image.png] [-s N] [-v] [-b N]
-
-## DESCRIPTION
-
-The **stats** command helps analyze common numerical data such as performance numbers
-or temperatures or any other numerical value.
-
-By default it looks for the last numerical output on the first line to identify the numerical column
-and analyze that number. This can be overriden by **-c COLUMN** to indicate a column. By default,
-whitespace and commas are treated to delimit columns, and **-d DELIMITER** can be used to override.
-
-By default it outputs basic statistics, but a histogram is available either text or through X11 output
-or sixel or output to an image file depending on whether **-x**, **-g**, **-t*, or **-o image.png** is
-used.
-
-## OPTIONS
-
- * `-c N`:
-   Select column number. Defaults to last column that appears numeric
-
- * `-d D`:
-   Specify a custom column delimiter
-
- * `-x`:
-     Output in Sixel format (supported by mlterm and PuTTY, among others)
-
- * `-g`:
-   Try to open histogram as an X window
-
- * `-t`:
-   Output histogram as bars rendered by =
-
- * `-o image.png`:
-   Write graphical histogram to image.png.
-
- * `-s N`:
-   Ignore specified number of lines as header content before processing numbers
-
- * `-v`:
-   Treat value before : on each line as a label, and show which labels belong to which histogram buckets.
-
- * `-b N`:
-   Specify a custom number of buckets for histogram. The default is 10.
-   

confluent_client/makeman

@@ -1,6 +1,4 @@
 #!/bin/sh
-cd `dirname $0`
-python3 addattribs.py || python2 addattribs.py
 cd `dirname $0`/doc/man
 mkdir -p ../../man/man1
 mkdir -p ../../man/man5

confluent_client/samples/nodeattrib_from_switch.py

@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/env python
 
 # This is a sample python script for going through all observed mac addresses
 # and assuming they are BMC related and printing nodeattrib commands

confluent_client/setup.py.tmpl

@@ -1,9 +1,7 @@
 from setuptools import setup
 import os
 
-data_files = [('/etc/profile.d', ['confluent_env.sh', 'confluent_env.csh']),
-              ('/opt/confluent/share/licenses/confluent_client/', ['LICENSE'])
-              ]
+data_files = [('/etc/profile.d', ['confluent_env.sh', 'confluent_env.csh'])]
 try:
     scriptlist = ['bin/{0}'.format(d) for d in os.listdir('bin/')]
     data_files.append(('/opt/confluent/share/man/man1', ['man/man1/' + x for x in os.listdir('man/man1')]))

confluent_common/confluent_common.spec.tmpl

@@ -22,10 +22,10 @@ This provides the modules common for both client and server
 %setup -n %{name}-%{version} -n %{name}-%{version}
 
 %build
-python2 setup.py build
+python setup.py build
 
 %install
-python2 setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES --install-purelib=/opt/confluent/lib/python --install-scripts=/opt/confluent/bin
+python setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES --install-purelib=/opt/confluent/lib/python --install-scripts=/opt/confluent/bin
 
 %clean
 rm -rf $RPM_BUILD_ROOT

confluent_common/setup.cfg

@@ -0,0 +1,17 @@
+[metadata]
+name = confluent_common
+summary = Confluent Common Libraries
+description-file =
+    README.txt
+author = Jarrod Johnson
+author-email = jjohnson2@lenovo.com
+home-page = http://xcat.sf.net/
+classifier =
+    Intended Audience :: Information Technology
+    Intended Audience :: System Administrators
+    License :: OSI Approved :: Apache Software License
+    Operating System :: POSIX :: Linux
+    Programming Language :: Python :: 2.6
+    Programming Language :: Python :: 2.7
+
+[files]

confluent_osdeploy/buildrpm

@@ -1,23 +0,0 @@
-VERSION=`git describe|cut -d- -f 1`
-NUMCOMMITS=`git describe|cut -d- -f 2`
-if [ "$NUMCOMMITS" != "$VERSION"  ]; then
-    VERSION=$VERSION.dev$NUMCOMMITS.g`git describe|cut -d- -f 3`
-fi
-sed -e "s/#VERSION#/$VERSION/" confluent_osdeploy.spec.tmpl > confluent_osdeploy.spec
-cd ..
-cp ../LICENSE .
-tar Jcvf confluent_osdeploy.tar.xz confluent_osdeploy
-mv confluent_osdeploy.tar.xz ~/rpmbuild/SOURCES/
-cd -
-mkdir -p el9bin/opt/confluent/bin
-mkdir -p el9bin/stateless-bin
-podman run --privileged --rm -v $(pwd)/utils:/buildutils -i -t fedorabuilder make -C /buildutils
-cd utils
-mv confluent_imginfo copernicus clortho autocons ../el9bin/opt/confluent/bin
-mv start_root urlmount ../el9bin/stateless-bin/
-make clean
-cd ..
-tar Jcvf confluent_el9bin.tar.xz el9bin/
-mv confluent_el9bin.tar.xz ~/rpmbuild/SOURCES/
-rm -rf el9bin
-rpmbuild -ba confluent_osdeploy.spec

confluent_osdeploy/common/initramfs/opt/confluent/bin/apiclient

@@ -1,427 +0,0 @@
-#!/usr/bin/python
-try:
-    import http.client as client
-except ImportError:
-    import httplib as client
-import ctypes
-import ctypes.util
-import glob
-import os
-import select
-import socket
-import subprocess
-import ssl
-import sys
-import struct
-import time
-
-class InvalidApiKey(Exception):
-    pass
-
-def msg_align(len):
-    return (len + 3) & ~3
-
-cryptname = ctypes.util.find_library('crypt')
-if not cryptname:
-    if os.path.exists('/lib64/libcrypt.so.2') or os.path.exists('/usr/lib64/libcrypt.so.2'):
-        cryptname = 'libcrypt.so.2'
-    else:
-        cryptname = 'libcrypt.so.1'
-c_libcrypt = ctypes.CDLL(cryptname)
-c_crypt = c_libcrypt.crypt
-c_crypt.argtypes = (ctypes.c_char_p, ctypes.c_char_p)
-c_crypt.restype = ctypes.c_char_p
-
-
-def get_my_addresses():
-    nlhdrsz = struct.calcsize('IHHII')
-    ifaddrsz = struct.calcsize('BBBBI')
-    # RTM_GETADDR = 22
-    # nlmsghdr struct: u32 len, u16 type, u16 flags, u32 seq, u32 pid
-    nlhdr = struct.pack('IHHII', nlhdrsz + ifaddrsz, 22, 0x301, 0, 0)
-    # ifaddrmsg struct: u8 family, u8 prefixlen, u8 flags, u8 scope, u32 index
-    ifaddrmsg = struct.pack('BBBBI', 0, 0, 0, 0, 0)
-    s = socket.socket(socket.AF_NETLINK, socket.SOCK_RAW, socket.NETLINK_ROUTE)
-    s.bind((0, 0))
-    s.sendall(nlhdr + ifaddrmsg)
-    addrs = []
-    while True:
-        pdata = s.recv(65536)
-        v = memoryview(pdata)
-        if struct.unpack('H', v[4:6])[0] == 3:  # netlink done message
-            break
-        while len(v):
-            length, typ = struct.unpack('IH', v[:6])
-            if typ == 20:
-                fam, plen, _, scope, ridx = struct.unpack('BBBBI', v[nlhdrsz:nlhdrsz+ifaddrsz])
-                if scope in (253, 0):
-                    rta = v[nlhdrsz+ifaddrsz:length]
-                    while len(rta):
-                        rtalen, rtatyp = struct.unpack('HH', rta[:4])
-                        if rtalen < 4:
-                            break
-                        if rtatyp == 1:
-                            addrs.append((fam, rta[4:rtalen], plen, ridx))
-                        rta = rta[msg_align(rtalen):]
-            v = v[msg_align(length):]
-    return addrs
-
-
-def scan_confluents():
-    srvs = {}
-    s6 = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
-    s6.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 1)
-    s6.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1)
-    s6.bind(('::', 1900))
-    s4 = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
-    s4.setsockopt(socket.SOL_SOCKET, socket.SO_BROADCAST, 1)
-    s4.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1)
-    s4.bind(('0.0.0.0', 1900))
-    doneidxs = set([])
-    msg = 'M-SEARCH * HTTP/1.1\r\nST: urn:xcat.org:service:confluent:'
-    with open('/etc/confluent/confluent.deploycfg') as dcfg:
-        for line in dcfg.read().split('\n'):
-            if line.startswith('confluent_uuid:'):
-                confluentuuid = line.split(': ')[1]
-                msg += '/confluentuuid=' + confluentuuid
-                break
-    with open('/sys/devices/virtual/dmi/id/product_uuid') as uuidin:
-        msg += '/uuid=' + uuidin.read().strip()
-    for addrf in glob.glob('/sys/class/net/*/address'):
-        with open(addrf) as addrin:
-            hwaddr = addrin.read().strip()
-            msg += '/mac=' + hwaddr
-    msg = msg.encode('utf8')
-    for addr in get_my_addresses():
-        if addr[0] == socket.AF_INET6:
-            if addr[-1] in doneidxs:
-                continue
-            try:
-                s6.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_MULTICAST_IF, addr[-1])
-            except TypeError:
-                s6.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_MULTICAST_IF, addr[-1].tobytes())
-            try:
-                s6.sendto(msg, ('ff02::c', 1900))
-            except OSError:
-                pass
-            doneidxs.add(addr[-1])
-        elif addr[0] == socket.AF_INET:
-            try:
-                s4.setsockopt(socket.IPPROTO_IP, socket.IP_MULTICAST_IF, addr[1])
-            except TypeError:
-                s4.setsockopt(socket.IPPROTO_IP, socket.IP_MULTICAST_IF, addr[1].tobytes())
-            try:
-                s4.sendto(msg, ('239.255.255.250', 1900))
-            except OSError:
-                pass
-    r = select.select((s4, s6), (), (), 4)
-    srvlist = []
-    if r:
-        r = r[0]
-    while r:
-        for s in r:
-            (rsp, peer) = s.recvfrom(9000)
-            rsp = rsp.split(b'\r\n')
-            current = None
-            for line in rsp:
-                if line.startswith(b'NODENAME: '):
-                    current = {}
-                elif line.startswith(b'DEFAULTNET: 1'):
-                    current['isdefault'] = True
-                elif line.startswith(b'MGTIFACE: '):
-                    current['mgtiface'] = line.replace(b'MGTIFACE: ', b'').strip().decode('utf8')
-            if len(peer) > 2:
-                current['myidx'] = peer[-1]
-            currip = peer[0]
-            if currip.startswith('fe80::') and '%' not in currip:
-                currip = '{0}%{1}'.format(currip, peer[-1])
-            srvs[currip] = current
-            srvlist.append(currip)
-        r = select.select((s4, s6), (), (), 2)
-        if r:
-            r = r[0]
-    return srvlist, srvs
-
-
-def get_net_apikey(nodename, mgr):
-    alpha = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789./'
-    newpass = ''.join([alpha[x >> 2] for x in bytearray(os.urandom(32))])
-    salt = '$5$' + ''.join([alpha[x >> 2] for x in bytearray(os.urandom(8))])
-    newpass = newpass.encode('utf8')
-    salt = salt.encode('utf8')
-    crypted = c_crypt(newpass, salt)
-    for addrinfo in socket.getaddrinfo(mgr, 13001, 0, socket.SOCK_STREAM):
-        try:
-            clisock = socket.socket(addrinfo[0], addrinfo[1])
-            clisock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
-            if addrinfo[0] == socket.AF_INET:
-                cliaddr = ('0.0.0.0', 302)
-            else:
-                cliaddr = ('::', 302)
-            clisock.bind(cliaddr)
-            clisock.connect(addrinfo[-1])
-            rsp = clisock.recv(8)
-            if rsp != b'\xc2\xd1-\xa8\x80\xd8j\xba':
-                raise Exception('Unrecognized credential banner')
-            hellostr = bytearray([1, len(nodename)]) + bytearray(nodename.encode('utf8')) + bytearray(b'\x00\x00')
-            clisock.send(hellostr)
-            rsp = bytearray(clisock.recv(2))
-            if not rsp:
-                continue
-            if rsp[0] == 128:
-                continue
-            if rsp[0] == 2:
-                echotoken = clisock.recv(rsp[1])
-                clisock.recv(2)  # drain \x00\x00
-                clisock.send(bytes(bytearray([3, rsp[1]])))
-                clisock.send(echotoken)
-                clisock.send(bytes(bytearray([4, len(crypted)])))
-                clisock.send(crypted)
-                clisock.send(b'\x00\x00')
-            rsp = bytearray(clisock.recv(2))
-            if rsp[0] == 5:
-                return newpass.decode('utf8')
-        finally:
-            clisock.close()
-    return ''
-
-
-def get_apikey(nodename, hosts, errout=None):
-    apikey = ""
-    if os.path.exists('/etc/confluent/confluent.apikey'):
-        apikey = open('/etc/confluent/confluent.apikey').read().strip()
-        if apikey:
-            return apikey
-    while not apikey:
-        for host in hosts:
-            try:
-                apikey = get_net_apikey(nodename, host)
-            except OSError:
-                apikey = None
-            if apikey:
-                break
-        else:
-            srvlist, _ = scan_confluents()
-            for host in srvlist:
-                try:
-                    apikey = get_net_apikey(nodename, host)
-                except OSError:
-                    apikey = None
-                if apikey:
-                    break
-        if not apikey:
-            errmsg = "Failed getting API token, check deployment.apiarmed attribute on {}\n".format(nodename)
-            sys.stderr.write(errmsg)
-            if errout:
-                errout.write(errmsg)
-            time.sleep(10)
-    with open('/etc/confluent/confluent.apikey', 'w+') as apiout:
-        apiout.write(apikey)
-    apikey = apikey.strip()
-    os.chmod('/etc/confluent/confluent.apikey', 0o600)
-    return apikey
-
-class HTTPSClient(client.HTTPConnection, object):
-    def __init__(self, usejson=False, port=443, host=None, errout=None):
-        self.errout = None
-        if errout:
-            self.errout = open(errout, 'w')
-            self.errout.flush()
-        self.stdheaders = {}
-        mgtiface = None
-        if usejson:
-            self.stdheaders['ACCEPT'] = 'application/json'
-        if host:
-            self.hosts = [host]
-            with open('/etc/confluent/confluent.info') as cinfo:
-                info = cinfo.read().split('\n')
-                for line in info:
-                    if line.startswith('NODENAME:'):
-                        node = line.split(' ')[1]
-                        self.stdheaders['CONFLUENT_NODENAME'] = node
-        else:
-            self.hosts = []
-            info = open('/etc/confluent/confluent.info').read().split('\n')
-            havedefault = '0'
-            for line in info:
-                if line.startswith('NODENAME:'):
-                    node = line.split(' ')[1]
-                    self.stdheaders['CONFLUENT_NODENAME'] = node
-                if line.startswith('MANAGER:') and not host:
-                    host = line.split(' ')[1]
-                if line.startswith('EXTMGRINFO:'):
-                    extinfo = line.split(' ')[1]
-                    extinfo = extinfo.split('|')
-                    if not mgtiface:
-                        host, mgtiface, havedefault = extinfo[:3]
-                    if havedefault == '0' and extinfo[2] == '1':
-                        host, mgtiface, havedefault = extinfo[:3]
-            if '%' in host:
-                ifidx = host.split('%', 1)[1]
-                with open('/tmp/confluent.ifidx', 'w+') as ifout:
-                    ifout.write(ifidx)
-            self.hosts.append(host)
-            try:
-                info = open('/etc/confluent/confluent.deploycfg').read().split('\n')
-            except Exception:
-                info = None
-            if info:
-                for line in info:
-                    if line.startswith('deploy_server: ') or line.startswith('deploy_server_v6: '):
-                        self.hosts.append(line.split(': ', 1)[1])
-        self.stdheaders['CONFLUENT_APIKEY'] = get_apikey(node, self.hosts, errout=self.errout)
-        if mgtiface:
-            self.stdheaders['CONFLUENT_MGTIFACE'] = mgtiface
-        self.port = port
-        self.host = None
-        self.node = node
-        host = self.check_connections()
-        client.HTTPConnection.__init__(self, host, port)
-        self.connect()
-
-
-    def set_header(self, key, val):
-        self.stdheaders[key] = val
-
-    def check_connections(self):
-        foundsrv = None
-        hosts = self.hosts
-        for timeo in (0.1, 5):
-            for host in hosts:
-                try:
-                    addrinf = socket.getaddrinfo(host, self.port)[0]
-                    psock = socket.socket(addrinf[0])
-                    psock.settimeout(timeo)
-                    psock.connect(addrinf[4])
-                    foundsrv = host
-                    psock.close()
-                    break
-                except OSError:
-                    continue
-            else:
-                continue
-            break
-        if not foundsrv:
-            srvlist, srvs = scan_confluents()
-            hosts = []
-            for srv in srvlist:
-                if srvs[srv].get('isdefault', False):
-                    hosts = [srv] + hosts
-                else:
-                    hosts = hosts + [srv]
-            for host in hosts:
-                try:
-                    addrinf = socket.getaddrinfo(host, self.port)[0]
-                    psock = socket.socket(addrinf[0])
-                    psock.settimeout(timeo)
-                    psock.connect(addrinf[4])
-                    foundsrv = host
-                    psock.close()
-                    break
-                except OSError:
-                    continue
-            else:
-                raise Exception('Unable to reach any hosts')
-        return foundsrv
-
-    def connect(self):
-        addrinf = socket.getaddrinfo(self.host, self.port)[0]
-        psock = socket.socket(addrinf[0])
-        psock.connect(addrinf[4])
-        ctx = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
-        ctx.load_verify_locations('/etc/confluent/ca.pem')
-        host = self.host.split('%', 1)[0]
-        if '[' not in host and ':' in host:
-            self.stdheaders['Host'] = '[{0}]'.format(host)
-        else:
-            self.stdheaders['Host'] = '{0}'.format(host)
-        ctx.verify_mode = ssl.CERT_REQUIRED
-        ctx.check_hostname = True
-        try:
-            self.sock = ctx.wrap_socket(psock, server_hostname=host)
-        except ssl.SSLError:
-            errmsg = 'Error validating certificate on deployer (try `osdeploy initialize -t` on the deployment server {0})\n'.format(host)
-            sys.stderr.write(errmsg)
-            if self.errout:
-                self.errout.write(errmsg)
-                self.errout.flush()
-            sys.exit(1)
-
-    def grab_url(self, url, data=None, returnrsp=False):
-        return self.grab_url_with_status(url, data, returnrsp)[1]
-
-    def grab_url_with_status(self, url, data=None, returnrsp=False):
-        if data:
-            method = 'POST'
-        else:
-            method = 'GET'
-        authed = False
-        while not authed:
-            authed = True
-            self.request(method, url, data, headers=self.stdheaders)
-            rsp = self.getresponse()
-            if rsp.status >= 200 and rsp.status < 300:
-                if returnrsp:
-                    return rsp.status, rsp
-                else:
-                    return rsp.status, rsp.read()
-            if rsp.status == 401:
-                authed = False
-                rsp.read()
-                with open('/etc/confluent/confluent.apikey', 'w+') as akfile:
-                    akfile.write('')
-                self.stdheaders['CONFLUENT_APIKEY'] = get_apikey(
-                    self.node, [self.host], errout=self.errout)
-        raise Exception(rsp.read())
-
-if __name__ == '__main__':
-    data = None
-    usejson = False
-    if '-j' in sys.argv:
-        usejson = True
-    if len(sys.argv) == 1:
-        HTTPSClient()
-        sys.exit(0)
-    try:
-        outbin = sys.argv.index('-o')
-        sys.argv.pop(outbin)
-        outbin = sys.argv.pop(outbin)
-    except ValueError:
-        outbin = None
-    try:
-        waitfor = sys.argv.index('-w')
-        sys.argv.pop(waitfor)
-        waitfor = int(sys.argv.pop(waitfor))
-    except ValueError:
-        waitfor = None
-    try:
-        data = sys.argv.index('-d')
-        sys.argv.pop(data)
-        data = sys.argv.pop(data)
-    except ValueError:
-        data = None
-    try:
-        errout = sys.argv.index('-e')
-        sys.argv.pop(errout)
-        errout = sys.argv.pop(errout)
-    except ValueError:
-        errout = None
-    if len(sys.argv) > 2 and os.path.exists(sys.argv[-1]):
-        data = open(sys.argv[-1]).read()
-    if outbin:
-        with open(outbin, 'ab+') as outf:
-            reader = HTTPSClient(usejson=usejson, errout=errout).grab_url(
-                sys.argv[1], data, returnrsp=True)
-            chunk = reader.read(16384)
-            while chunk:
-                outf.write(chunk)
-                chunk = reader.read(16384)
-        sys.exit(0)
-    if waitfor:
-        client = HTTPSClient(usejson, errout=errout)
-        status = 201
-        while status != waitfor:
-            status, rsp = client.grab_url_with_status(sys.argv[1], data)
-            sys.stdout.write(rsp.decode())
-    else:
-        sys.stdout.write(HTTPSClient(usejson, errout=errout).grab_url(sys.argv[1], data).decode())

confluent_osdeploy/common/profile/scripts/confignet

@@ -1,355 +0,0 @@
-#!/usr/bin/python
-
-import glob
-import json
-import os
-import socket
-import sys
-import time
-import shlex
-import subprocess
-try:
-    from importlib.machinery import SourceFileLoader
-    def load_source(mod, path):
-        return SourceFileLoader(mod, path).load_module()
-except ImportError:
-    from imp import load_source
-
-try:
-    apiclient = load_source('apiclient', '/opt/confluent/bin/apiclient')
-except IOError:
-    apiclient = load_source('apiclient', '/etc/confluent/apiclient')
-
-def add_lla(iface, mac):
-    pieces = mac.split(':')
-    initbyte = int(pieces[0], 16) ^ 2
-    lla = 'fe80::{0:x}{1}:{2}ff:fe{3}:{4}{5}/64'.format(initbyte, pieces[1], pieces[2], pieces[3], pieces[4], pieces[5])
-    try:
-        subprocess.check_call(['ip', 'addr', 'add', 'dev', iface, lla, 'scope', 'link'])
-    except Exception:
-        return None
-    return lla
-
-#cli = apiclient.HTTPSClient(json=True)
-#c = cli.grab_url_with_status('/confluent-api/self/netcfg')
-def add_missing_llas():
-    #NetworkManager goes out of its way to suppress ipv6 lla, so will just add some
-    added = {}
-    linkinfo = subprocess.check_output(['ip', '-br', 'l']).decode('utf8')
-    ifaces = {}
-    for line in linkinfo.split('\n'):
-        line = line.strip().split()
-        if not line or 'LOOPBACK' in line[-1] or 'NO-CARRIER' in line[-1]:
-            continue
-        if 'UP' not in line[-1]:
-            subprocess.call(['ip', 'link', 'set', line[0], 'up'])
-        ifaces[line[0]] = line[2]
-    ips = {}
-    ipinfo = subprocess.check_output(['ip', '-br', '-6', 'a']).decode('utf8')
-    for line in ipinfo.split('\n'):
-        line = line.strip().split(None, 2)
-        if not line:
-            continue
-        ips[line[0]] = line[2]
-    for iface in ifaces:
-        for addr in ips.get(iface, '').split():
-            if addr.startswith('fe80::'):
-                break
-        else:
-            newlla = add_lla(iface, ifaces[iface])
-            if newlla:
-                added[iface] = newlla
-    return added
-
-def rm_tmp_llas(tmpllas):
-    for iface in tmpllas:
-        subprocess.check_call(['ip', 'addr', 'del', 'dev', iface, tmpllas[iface]])
-
-def await_tentative():
-    maxwait = 10
-    while b'tentative' in subprocess.check_output(['ip', 'a']):
-        if maxwait == 0:
-            break
-        maxwait -= 1
-        time.sleep(1)
-
-def map_idx_to_name():
-    map = {}
-    devtype = {}
-    prevdev = None
-    for line in subprocess.check_output(['ip', 'l']).decode('utf8').splitlines():
-        if line.startswith(' ') and 'link/' in line:
-            typ = line.split()[0].split('/')[1]
-            devtype[prevdev] = typ if type != 'ether' else 'ethernet'
-        if line.startswith(' '):
-            continue
-        idx, iface, rst = line.split(':', 2)
-        prevdev = iface.strip()
-        rst = rst.split()
-        try:
-            midx = rst.index('master')
-            continue
-        except ValueError:
-            pass
-        idx = int(idx)
-        iface = iface.strip()
-        map[idx] = iface
-    return map, devtype
-
-
-def get_interface_name(iname, settings):
-    explicitname = settings.get('interface_names', None)
-    if explicitname:
-        return explicitname
-    if settings.get('current_nic', False):
-        return iname
-    return None
-
-class WickedManager(object):
-    def __init__(self):
-        self.teamidx = 0
-        self.read_connections()
-
-    def read_connections(self):
-        self.cfgbydev = {}
-        for ifcfg in glob.glob('/etc/sysconfig/network/ifcfg-*'):
-            devname = ifcfg.replace('/etc/sysconfig/network/ifcfg-', '')
-            if devname == 'lo':
-                continue
-            currcfg = {}
-            self.cfgbydev[devname] = currcfg
-            for cfg in open(ifcfg).read().splitlines():
-                cfg = cfg.split('#', 1)[0]
-                kv = ' '.join(shlex.split(cfg)).split('=', 1)
-                if len(kv) != 2:
-                    continue
-                k, v = kv
-                k = k.strip()
-                v = v.strip()
-                currcfg[k] = v
-
-    def apply_configuration(self, cfg):
-        stgs = cfg['settings']
-        ipcfg = 'STARTMODE=auto\n'
-        routecfg = ''
-        bootproto4 = stgs.get('ipv4_method', 'none')
-        bootproto6 = stgs.get('ipv6_method', 'none')
-        if bootproto4 == 'dhcp' and bootproto6 == 'dhcp':
-            ipcfg += 'BOOTPROTO=dhcp\n'
-        elif bootproto4 == 'dhcp':
-            ipcfg += 'BOOTPROTO=dhcp4\n'
-        elif bootproto6 == 'dhcp':
-            ipcfg += 'BOOTPROTO=dhcp6\n'
-        else:
-            ipcfg += 'BOOTPROTO=static\n'
-        if stgs.get('ipv4_address', None):
-            ipcfg += 'IPADDR=' + stgs['ipv4_address'] + '\n'
-        v4gw = stgs.get('ipv4_gateway', None)
-        if stgs.get('ipv6_address', None):
-            ipcfg += 'IPADDR_V6=' + stgs['ipv6_address'] + '\n'
-        v6gw = stgs.get('ipv6_gateway', None)
-        cname = None
-        if len(cfg['interfaces']) > 1:  # creating new team
-            if not stgs.get('team_mode', None):
-                sys.stderr.write("Warning, multiple interfaces ({0}) without a team_mode, skipping setup\n".format(','.join(cfg['interfaces'])))
-                return
-            if not stgs.get('connection_name', None):
-                stgs['connection_name'] = 'bond{0}'.format(self.teamidx)
-                self.teamidx += 1
-            cname = stgs['connection_name']
-            with open('/etc/sysconfig/network/ifcfg-{0}'.format(cname), 'w') as teamout:
-                teamout.write(ipcfg)
-                if stgs['team_mode'] == 'lacp':
-                    stgs['team_mode'] = '802.3ad'
-                teamout.write("BONDING_MODULE_OPTS='mode={0} miimon=100'\nBONDING_MASTER=yes\n".format(stgs['team_mode']))
-                idx = 1
-                for iface in cfg['interfaces']:
-                    subprocess.call(['wicked', 'ifdown', iface])
-                    try:
-                        os.remove('/etc/sysconfig/network/ifcfg-{0}'.format(iface))
-                        os.remove('/etc/sysconfig/network/ifroute-{0}'.format(iface))
-                    except OSError:
-                        pass
-                    teamout.write('BONDING_SLAVE{0}={1}\n'.format(idx, iface))
-                    idx += 1
-        else:
-            cname = list(cfg['interfaces'])[0]
-            priorcfg = self.cfgbydev.get(cname, {})
-            for cf in priorcfg:
-                if cf.startswith('TEAM_'):
-                    ipcfg += '{0}={1}\n'.format(cf, priorcfg[cf])
-            with open('/etc/sysconfig/network/ifcfg-{0}'.format(cname), 'w') as iout:
-                iout.write(ipcfg)
-        if v4gw:
-            routecfg += 'default {0} - {1}\n'.format(v4gw, cname)
-        if v6gw:
-            routecfg += 'default {0} - {1}\n'.format(v6gw, cname)
-        if routecfg:
-            with open('/etc/sysconfig/network/ifroute-{0}'.format(cname), 'w') as routeout:
-                routeout.write(routecfg)
-        subprocess.call(['wicked', 'ifup', cname])
-
-
-class NetworkManager(object):
-    def __init__(self, devtypes):
-        self.connections = {}
-        self.uuidbyname = {}
-        self.uuidbydev = {}
-        self.connectiondetail = {}
-        self.read_connections()
-        self.teamidx = 0
-        self.devtypes = devtypes
-
-    def read_connections(self):
-        self.connections = {}
-        self.uuidbyname = {}
-        self.uuidbydev = {}
-        self.connectiondetail = {}
-        ci = subprocess.check_output(['nmcli', '-t', 'c']).decode('utf8')
-        for inf in ci.splitlines():
-            n, u, t, dev = inf.split(':')
-            if n == 'NAME':
-                continue
-            if dev == '--':
-                dev = None
-            self.uuidbyname[n] = u
-            if dev:
-                self.uuidbydev[dev] = u
-            self.connections[u] = {'name': n, 'uuid': u, 'type': t, 'dev': dev}
-            deats = {}
-            for deat in subprocess.check_output(['nmcli', 'c', 's', u]).decode('utf8').splitlines():
-                k, v = deat.split(':', 1)
-                v = v.strip()
-                if v == '--':
-                    continue
-                if '(default)' in v:
-                    continue
-                deats[k] = v
-            self.connectiondetail[u] = deats
-
-
-    def add_team_member(self, team, member):
-        bondcfg = {}
-        if member in self.uuidbydev:
-            myuuid = self.uuidbydev[member]
-            deats = self.connectiondetail[myuuid]
-            currteam = deats.get('connection.master', None)
-            if currteam == team:
-                return
-            for stg in ('ipv4.dhcp-hostname', 'ipv4.dns', 'ipv6.dns', 'ipv6.dhcp-hostname'):
-                if deats.get(stg, None):
-                    bondcfg[stg] = deats[stg]
-        if member in self.uuidbyname:
-            subprocess.check_call(['nmcli', 'c', 'del', self.uuidbyname[member]])
-        subprocess.check_call(['nmcli', 'c', 'add', 'type', 'team-slave', 'master', team, 'con-name', member, 'connection.interface-name', member])
-        if bondcfg:
-            args = []
-            for parm in bondcfg:
-                args.append(parm)
-                args.append(bondcfg[parm])
-            subprocess.check_call(['nmcli', 'c', 'm', team] + args)
-
-    def apply_configuration(self, cfg):
-        cmdargs = {}
-        stgs = cfg['settings']
-        cmdargs['ipv6.method'] = stgs.get('ipv6_method', 'link-local')
-        if stgs.get('ipv6_address', None):
-            cmdargs['ipv6.addresses'] = stgs['ipv6_address']
-        cmdargs['ipv4.method'] = stgs.get('ipv4_method', 'disabled')
-        if stgs.get('ipv4_address', None):
-            cmdargs['ipv4.addresses'] = stgs['ipv4_address']
-        if stgs.get('ipv4_gateway', None):
-            cmdargs['ipv4.gateway'] = stgs['ipv4_gateway']
-        if stgs.get('ipv6_gateway', None):
-            cmdargs['ipv6.gateway'] = stgs['ipv6_gateway']
-        if len(cfg['interfaces']) > 1:  # team time.. should be..
-            if not cfg['settings'].get('team_mode', None):
-                sys.stderr.write("Warning, multiple interfaces ({0}) without a team_mode, skipping setup\n".format(','.join(cfg['interfaces'])))
-                return
-            if not cfg['settings'].get('connection_name', None):
-                cfg['settings']['connection_name'] = 'team{0}'.format(self.teamidx)
-                self.teamidx += 1
-            cname = cfg['settings']['connection_name']
-            cargs = []
-            for arg in cmdargs:
-                cargs.append(arg)
-                cargs.append(cmdargs[arg])
-            subprocess.check_call(['nmcli', 'c', 'add', 'type', 'team', 'con-name', cname, 'connection.interface-name', cname, 'team.runner', stgs['team_mode']] + cargs)
-            for iface in cfg['interfaces']:
-                self.add_team_member(cname, iface)
-            subprocess.check_call(['nmcli', 'c', 'u', cname])
-        else:
-            cname = stgs.get('connection_name', None)
-            iname = list(cfg['interfaces'])[0]
-            if not cname:
-                cname = iname
-            u = self.uuidbyname.get(cname, None)
-            cargs = []
-            for arg in cmdargs:
-                cargs.append(arg)
-                cargs.append(cmdargs[arg])
-            if u:
-                cmdargs['connection.interface-name'] = iname
-                subprocess.check_call(['nmcli', 'c', 'm', u] + cargs)
-                subprocess.check_call(['nmcli', 'c', 'u', u])
-            else:
-                subprocess.check_call(['nmcli', 'c', 'add', 'type', self.devtypes[iname], 'con-name', cname, 'connection.interface-name', iname] + cargs)
-
-
-
-if __name__ == '__main__':
-    havefirewall = subprocess.call(['systemctl', 'status', 'firewalld'])
-    havefirewall = havefirewall == 0
-    if havefirewall:
-        subprocess.check_call(['systemctl', 'stop', 'firewalld'])
-    tmpllas = add_missing_llas()
-    await_tentative()
-    idxmap, devtypes = map_idx_to_name()
-    netname_to_interfaces = {}
-    myaddrs = apiclient.get_my_addresses()
-    srvs, _ = apiclient.scan_confluents()
-    doneidxs = set([])
-    for srv in srvs:
-        s = socket.create_connection((srv, 443))
-        myname = s.getsockname()
-        s.close()
-        if len(myname) == 4:
-            curridx = myname[-1]
-        else:
-            myname = myname[0]
-            myname = socket.inet_pton(socket.AF_INET, myname)
-            for addr in myaddrs:
-                if myname == addr[1].tobytes():
-                    curridx = addr[-1]
-        if curridx in doneidxs:
-            continue
-        status, nc = apiclient.HTTPSClient(usejson=True, host=srv).grab_url_with_status('/confluent-api/self/netcfg')
-        nc = json.loads(nc)
-        iname = get_interface_name(idxmap[curridx], nc.get('default', {}))
-        if iname:
-            for iname in iname.split(','):
-                if 'default' in netname_to_interfaces:
-                    netname_to_interfaces['default']['interfaces'].add(iname)
-                else:
-                    netname_to_interfaces['default'] = {'interfaces': set([iname]), 'settings': nc['default']}
-        for netname in nc.get('extranets', {}):
-            uname = '_' + netname
-            iname = get_interface_name(idxmap[curridx], nc['extranets'][netname])
-            if iname:
-                for iname in iname.split(','):
-                    if uname in netname_to_interfaces:
-                        netname_to_interfaces[uname]['interfaces'].add(iname)
-                    else:
-                        netname_to_interfaces[uname] = {'interfaces': set([iname]), 'settings': nc['extranets'][netname]}
-        doneidxs.add(curridx)
-    rm_tmp_llas(tmpllas)
-    if os.path.exists('/usr/bin/nmcli'):
-        nm = NetworkManager(devtypes)
-    elif os.path.exists('/usr/sbin/wicked'):
-        nm = WickedManager()
-    for netn in netname_to_interfaces:
-        nm.apply_configuration(netname_to_interfaces[netn])
-    if havefirewall:
-        subprocess.check_call(['systemctl', 'start', 'firewalld'])
-    await_tentative()
-

confluent_osdeploy/confluent_osdeploy.spec.tmpl

@@ -1,102 +0,0 @@
-Name: confluent_osdeploy-x86_64
-Version: #VERSION#
-Release: 1
-Summary: OS Deployment support for confluent
-
-License: Apache2
-URL: https://hpc.lenovo.com/
-Source0: confluent_osdeploy.tar.xz
-Source1: confluent_el9bin.tar.xz
-BuildArch: noarch
-Requires: confluent_ipxe mtools tar
-BuildRoot: /tmp
-
-%description
-This contains support utilities for enabling deployment of x86_64 architecture systems
-
-
-%define debug_package %{nil}
-
-%prep
-%setup -n confluent_osdeploy -a 1
-
-%build
-mkdir -p opt/confluent/bin
-mkdir -p stateless-bin
-cd utils
-make all
-cp confluent_imginfo copernicus clortho autocons ../opt/confluent/bin
-cp start_root urlmount ../stateless-bin/
-cd ..
-ln -s el8 el9
-for os in rhvh4 el7 genesis el8 suse15 ubuntu20.04 ubuntu22.04 coreos el9; do
-    mkdir ${os}out
-    cd ${os}out
-    if [ -d ../${os}bin ]; then 
-        cp -a ../${os}bin/opt .
-    else
-        cp -a ../opt .
-    fi
-    cp -a ../${os}/initramfs/* .
-    cp -a ../common/initramfs/* .
-    find . | cpio -H newc -o > ../addons.cpio
-    mv ../addons.cpio .
-    cd ..
-done
-for os in el7 el8 suse15 el9 ubuntu20.04; do
-    mkdir ${os}disklessout
-    cd ${os}disklessout
-    if [ -d ../${os}bin ]; then
-        cp -a ../${os}bin/opt .
-    else
-        cp -a ../opt .
-    fi
-    cp -a ../${os}-diskless/initramfs/* .
-    cp -a ../common/initramfs/* .
-    if [ -d ../${os}bin ]; then 
-        cp -a ../${os}bin/stateless-bin/* opt/confluent/bin
-    else
-        cp -a ../stateless-bin/* opt/confluent/bin
-    fi
-    find . | cpio -H newc -o > ../addons.cpio
-    mv ../addons.cpio .
-    cd ..
-done
-mkdir esxi7out
-cd esxi7out
-cp -a ../opt .
-cp -a ../esxi7/initramfs/* .
-cp -a ../common/initramfs/* .
-chmod +x bin/* opt/confluent/bin/*
-tar zcvf ../addons.tgz *
-mv ../addons.tgz .
-cd ..
-cp -a esxi7out esxi6out
-cp -a esxi7 esxi6
-
-%install
-mkdir -p %{buildroot}/opt/confluent/share/licenses/confluent_osdeploy/
-cp LICENSE %{buildroot}/opt/confluent/share/licenses/confluent_osdeploy/
-for os in rhvh4 el7 el8 el9 genesis suse15 ubuntu20.04 ubuntu22.04 esxi6 esxi7 coreos; do
-    mkdir -p %{buildroot}/opt/confluent/lib/osdeploy/$os/initramfs
-    mkdir -p %{buildroot}/opt/confluent/lib/osdeploy/$os/profiles
-    cp ${os}out/addons.* %{buildroot}/opt/confluent/lib/osdeploy/$os/initramfs
-    cp -a $os/profiles/* %{buildroot}/opt/confluent/lib/osdeploy/$os/profiles
-    for targ in %{buildroot}/opt/confluent/lib/osdeploy/$os/profiles/*; do
-        cp -a common/profile/* $targ
-    done
-    if [ -d ${os}disklessout ]; then
-        mkdir -p %{buildroot}/opt/confluent/lib/osdeploy/${os}-diskless/initramfs
-        mkdir -p %{buildroot}/opt/confluent/lib/osdeploy/${os}-diskless/profiles
-        cp ${os}disklessout/addons.* %{buildroot}/opt/confluent/lib/osdeploy/${os}-diskless/initramfs
-        cp -a ${os}-diskless/profiles/* %{buildroot}/opt/confluent/lib/osdeploy/$os-diskless/profiles
-        for targ in %{buildroot}/opt/confluent/lib/osdeploy/$os-diskless/profiles/*; do
-            cp -a common/profile/* $targ
-        done
-    fi
-done
-find %{buildroot}/opt/confluent/lib/osdeploy/ -name .gitignore -exec rm -f {} +
-
-%files
-/opt/confluent/lib/osdeploy
-%license /opt/confluent/share/licenses/confluent_osdeploy/LICENSE

confluent_osdeploy/coreos/initramfs/etc/systemd/system/initrd-root-fs.target.requires/confluent-rootfs.service

@@ -1 +0,0 @@
-/usr/lib/systemd/system/confluent-rootfs.service