2
0
mirror of https://github.com/xcat2/confluent.git synced 2026-11-19 08:52:20 +00:00
Commit Graph

7237 Commits

Author SHA1 Message Date
Markus Hilger cf98bf1ef9 Refresh the HTTP boot iPXE shim when confluent_ipxe is updated
A package update replaced only the copies in /opt/confluent/lib/ipxe,
so an upgraded server kept serving no shim, or an old one, until
osdeploy initialize ran again. A fresh install still gets the shim from
osdeploy initialize, before which the public tree may not exist.
2026-11-17 23:20:33 +01:00
Markus Hilger aaaf4e3ea8 Install the HTTP boot iPXE shim on every osdeploy initialize run
The shim copy ran after the early exit of initialize, so -p, -k, -l
or -g on their own did not install it. It also checked for the aarch64
shim as ipxe-aarch64-shim.efi, a name it never writes, so it copied
that one on every run instead of only when it was missing.
2026-11-17 23:20:28 +01:00
Jarrod Johnson c7ce6caae8 Merge pull request #393 from Obihoernchen/fix/httpboot-aarch64-shim
Check the iPXE shim of the booting architecture for HTTP boot
nightly
2026-11-17 15:11:30 -05:00
Markus Hilger 2ba8db30ef Check the iPXE shim of the booting architecture for HTTP boot
UEFI HTTP boot chainloads the iPXE shim only when it is installed, but
the check always looked for the x86_64 shim. An aarch64 node on a
server with only the x86_64 shim was offered the missing aarch64 one
and failed to boot, and on a server with only the aarch64 shim it got
the static boot.img instead.
2026-11-17 21:05:33 +01:00
Jarrod Johnson f72ce3f98a Fix import of Ubuntu 26.04.1 arm media 2026-11-17 14:08:25 -05:00
Jarrod Johnson 7662955a98 Merge pull request #390 from Obihoernchen/fix/profile-installedargs
Fix profile installedargs on Debian, Ubuntu and SUSE 16
2026-11-17 13:43:20 -05:00
Jarrod Johnson 7d27b13f16 Merge pull request #389 from Obihoernchen/fix/image2disk-grub-lvm-names
Name the created volumes in the grub defaults of an image install
2026-11-17 13:42:07 -05:00
Jarrod Johnson 8470f1d155 Merge pull request #388 from Obihoernchen/fix/suse16-profile-label
Label the SUSE 16 profile as the default profile
2026-11-17 13:41:27 -05:00
Jarrod Johnson 360d3d5fe2 Merge pull request #387 from Obihoernchen/fix/capture-unsupported-root
Refuse capture when / cannot be captured
2026-11-17 13:41:15 -05:00
Jarrod Johnson 0c517104ab Merge pull request #386 from Obihoernchen/fix/log-noise-4.0.2
Fix log noise in 4.0.2
2026-11-17 13:40:41 -05:00
Jarrod Johnson a47d9ecbba Merge pull request #385 from robertcaliman/fix/SLES16-multi-nic
Add support for SLES 16 deployed from a multi NIC confluent server
2026-11-17 13:37:34 -05:00
Markus Hilger 52ae9c9e16 Fix profile installedargs on Debian, Ubuntu and SUSE
On Debian and Ubuntu 18.04 the installedargs line of profile.yaml was
added to GRUB_CMDLINE_LINUX with its "installedargs:" key still in
front, and update-grub was not run for it, so the arguments only took
effect with a later grub update, as a broken first argument.

All Debian and Ubuntu profiles also put the arguments into a sed
replacement unescaped, so an argument containing a slash, such as
rd.lvm.lv=vg/root, made sed fail and left the grub defaults unchanged.

SUSE 16 put the arguments into a JSON string unescaped, so an argument
containing a double quote or backslash produced an invalid
autoinstall.json, and one containing "!" or "&" broke the sed command
that fills it in.

SUSE 15 put them into the AutoYaST XML unescaped, so an argument
containing "&" or "<" made the whole profile invalid and stopped the
install.
2026-11-17 19:03:50 +01:00
Markus Hilger fb017b7392 Refuse capture when / cannot be captured 2026-11-17 17:00:40 +01:00
Markus Hilger e9e83635ee Name the created volumes in the grub defaults of an image install
When the image has no /etc/default/grub, as images built by imgutil do
not, installing it to disk on EL9 and EL10 wrote one with
rd.lvm.lv=vg/root rd.lvm.lv=vg/swap, volumes that do not exist. A
missing /etc/kernel/cmdline likewise got root=/dev/mapper/localstorage-root,
which is wrong for an install without LVM or with a volume group named
after the node. The boot loader entries were rewritten correctly, so
the first boot worked, but grub2-mkconfig --update-bls-cmdline or a new
kernel would take the wrong names from these files.

Both defaults now name the root device and the logical volumes for root
and swap that the install created.
2026-11-17 16:53:10 +01:00
Markus Hilger d7a4af65b1 Tolerate a null system UUID in Redfish inventory
A Giga Computing BMC reports the system UUID as null, which made
nodeinventory fail with 'NoneType' object has no attribute 'lower'.
Treat a null UUID like a missing one.
2026-11-17 16:41:50 +01:00
Markus Hilger aa250bb91b Handle IPMI sessions torn down while a response is pending
A SOL keepalive reply arriving after the console was closed failed with
an AttributeError on the released session. A privilege level request on
a session that was logged out or given up on during login raised
IpmiException out of the packet handler into the event loop shared by
all sessions. Ignore the late keepalive reply, and report the failed
login to its waiters instead.
2026-11-17 16:27:52 +01:00
Markus Hilger 75a5e75063 Log IPMI plugin stack traces to the trace log
traceback.print_exc() went to stderr, where the log redirect tags every
line with its caller, traceback.py, which made the traces unreadable.
2026-11-17 16:27:52 +01:00
Markus Hilger e73a42ca5e Report request errors from console sessions like other requests
A request sent from within a console session, such as the power state
check confetty makes, went through a handler that logged every failure
as an unexpected 500 with a stack trace. A node with an unreachable BMC
filled the trace log with TargetEndpointUnreachable. Share the error
reporting of the main request loop, so the client gets the real error
code and only unexpected failures are traced.
2026-11-17 16:27:52 +01:00
Markus Hilger cb729147e7 Tolerate credserver clients that disconnect early
A client that reset the connection or closed it before finishing the
exchange left a stack trace in the trace log (ConnectionResetError, or
an IndexError on an empty read). Read each field in full, and treat a
client going away as the end of that exchange rather than a server fault.
2026-11-17 16:27:52 +01:00
Robert Caliman 1e8c4a88c3 Add support for SLES 16 deployed from a multi NIC server 2026-11-17 17:14:12 +02:00
Markus Hilger f05ef810c1 Label the SUSE 16 profile as the default profile
Every other OS labels its stock profile "(Default Profile)", including
SUSE 15, whose server profile also has the directory name server. SUSE
16 said "(Server Profile)" instead.
2026-11-17 16:05:04 +01:00
Jarrod Johnson 209d6ef2ed Fix undefined nodeinfo in the get_chassis_info flow. 2026-11-16 16:47:19 -05:00
Jarrod Johnson 246aae08fe Change secure http to ipxe as well
It is verified that iPXE leverages the UEFI CA and does not let untrusted connections.

So let it do https as well as http, relegating boot.img for virtual media instead.

This like the plain http boot works nicely with a broader set of UEFI.
2026-11-16 16:43:11 -05:00
Jarrod Johnson 17e6319f75 Leverage the askpass facility from sshutil in nodeshell
This allows a user to pass a password by environment variable.
2026-11-14 10:08:27 -05:00
Jarrod Johnson bd647ebfa4 Implement chassis information separate from system
Some implementations claim to have a system, but have useless data.

We can't tell programattically that the data is useless, so provide chassis for the user to decide.
2026-11-14 08:01:31 -05:00
Jarrod Johnson 334815e9a5 Catch the target url from a 403 extended message, if required 2026-11-13 10:00:38 -05:00
Jarrod Johnson d4c2072e3f Have nvos discovery handle LLA based onboarding 2026-11-13 09:36:31 -05:00
Jarrod Johnson dd700ad1a5 Add mac address to registered address, when possible 2026-11-13 09:04:07 -05:00
Jarrod Johnson 85ff47e684 Add singleton IPv6 support to nodediscover register
This allows otherwise queried ipv6 addresses to be checked one at a time.
2026-11-13 08:13:26 -05:00
Jarrod Johnson 4862c9f734 Implement blacklist of module init functions
Since we have a Seccomp cBPF going anyway, add insmod/modprobe operations to block.

Also reframe things to be a bit more readable using enum and less magical numbers.
2026-11-12 11:15:43 -05:00
Jarrod Johnson ad2de237bc Implement management of UEFI HTTPS certificates
On supported platforms, manage the UEFI HTTPS certificate store.  This can make it easier to manage HTTPS boot.
2026-11-12 10:17:48 -05:00
Jarrod Johnson 9d78d42071 Merge remote-tracking branch 'xcat/master' 2026-11-12 10:06:02 -05:00
Jarrod Johnson bdfe5d9b32 Merge pull request #381 from Obihoernchen/feat/imgutil-image-kernel
imgutil: report the image kernel in exec and build
2026-11-12 10:02:01 -05:00
Markus Hilger 7108cdd3d9 imgutil: derive the seccomp filter length from the filter 2026-11-12 15:42:18 +01:00
Jarrod Johnson aedb093c22 Merge pull request #384 from Obihoernchen/fix/image2disk-no-boot-partition
Use the root filesystem for grub when an image has no /boot
2026-11-12 09:41:42 -05:00
Markus Hilger 973a340ed7 Use the root filesystem for grub when an image has no /boot
image2disk only took the boot UUID from a /boot volume. Images captured
from a system without a separate /boot left it unset, and rewriting the
EFI stub grub.cfg failed with "TypeError: sequence item 5: expected str
instance, NoneType found". Fall back to the UUID of the / filesystem,
which holds /boot in that case.
2026-11-12 15:17:36 +01:00
Jarrod Johnson bec1ed1498 Merge pull request #383 from Obihoernchen/feat/confluent-attrib-helper
Add confluent_attrib helper for profile scripts
2026-11-12 07:40:14 -05:00
Markus Hilger 9d8cb97fb3 Add confluent_attrib helper to profile functions
Profile scripts had to call apiclient and parse /self/myattribs to read
a node attribute. confluent_attrib prints one attribute, comma joining
lists, and returns 1 when it is unset. Non-shell scripts can run it as
'bash /etc/confluent/functions confluent_attrib <name>'.
2026-11-11 23:02:02 +01:00
Markus Hilger c949359199 Return node groups from /self/myattribs
groups is stored as a plain list rather than a value dict, so the
value check skipped it and a node could not see its own groups. Return
it as a list, the same way ansible plays get it as host vars.
2026-11-11 23:02:02 +01:00
Jarrod Johnson 5523abc435 Merge pull request #382 from Obihoernchen/fix/nodedefine-shared-groups
Copy per-node attribute data in set_node_attributes
2026-11-11 13:02:08 -05:00
Markus Hilger 69a872c208 Copy per-node attribute data in set_node_attributes
nodedefine with a noderange passed one dict for all nodes, so they
shared one stored groups list. Later group membership changes then
updated inheritance for only the first node, leaving the others with
values inherited from groups they no longer belong to.
2026-11-11 18:51:56 +01:00
Jarrod Johnson 20a5065d06 Merge remote-tracking branch 'xcat/master' 2026-11-11 07:39:21 -05:00
Jarrod Johnson 218f245b50 Merge pull request #380 from Obihoernchen/fix/confignet-firewalld-quiet
Do not print the firewalld check of confignet
2026-11-11 07:09:09 -05:00
Jarrod Johnson fac29990c0 Merge pull request #379 from Obihoernchen/fix/imgutil-dosfstools
Add dosfstools to the EL imgutil package lists
2026-11-11 07:08:46 -05:00
Jarrod Johnson 316107db60 Merge pull request #378 from Obihoernchen/fix/diskless-post-custom
Add post.custom to EL diskless profiles, drop firstboot tls copy
2026-11-11 07:08:25 -05:00
Markus Hilger dade8ea706 imgutil: report the image kernel in exec and build 2026-11-11 00:10:36 +01:00
Markus Hilger 823f2e57e6 Do not print the firewalld check of confignet
systemctl status firewalld printed the unit status, or 'Unit
firewalld.service could not be found.' on images without firewalld.
2026-11-10 22:25:29 +01:00
Markus Hilger e9e284986f Add post.custom to EL diskless profiles, drop firstboot tls copy
post.sh runs post.custom, which the profiles lacked, so every install
to disk logged a failed download. firstboot.sh copied
/etc/confluent/tls/*.pem, which diskless nodes never have: installimage
already adds the confluent CA to the ca-trust anchors.
2026-11-10 22:25:09 +01:00
Markus Hilger 82ecc69bc9 Add dosfstools to the EL imgutil package lists
image2disk formats /boot/efi with mkfs.vfat, which minimal built EL
images lack, so installtodisk failed. The Ubuntu lists have it.
2026-11-10 22:04:57 +01:00
Jarrod Johnson 5990303661 Fix ARM/x86 UEFI HTTP boot
Make http location tree consistent with tftp
2026-11-10 14:09:37 -05:00