The installedargs of profile.yaml only reached systems installed by an
OS installer. A diskless image written to disk with installtodisk got
none of them, and keeps from the network boot only console=,
net.ifnames=, biosdevname= and quiet, so arguments meant for the
installed system had to be baked into the image.
image2disk.py now fetches the profile.yaml of the deployment and adds
its installedargs before deployment.installedargs, in the same places.
An argument the image already has, as when it was captured from a node
installed this way, is kept once, in its last position, so the node
arguments still come last, and a profile.yaml that cannot be read only
skips the profile arguments instead of failing the install.
Kernel arguments for the installed OS could only be set per profile,
with installedargs in profile.yaml. deployment.installedargs sets them
per node or group, appended after the ones of the profile.
The deploycfg served to the node carries the value as installedargs,
and the installers add it wherever they add the profile installedargs:
the kickstart bootloader line on EL and RHVH, the AutoYaST and Agama
bootloader settings on SUSE, and GRUB_CMDLINE_LINUX on Debian and
Ubuntu. Diskless images installed to disk add it to GRUB_CMDLINE_LINUX,
and on EL9 and EL10 also to /etc/kernel/cmdline and the boot loader
entries.
deploycfg is no longer wrapped at 80 columns, since the scripts read
each value from its single line.
Some systems during startup especially may take a hit that crosses the threshold.
Also, some IO hangs in select environments during certain activity can pause a while.
Heartbeat 4 times per interval instead of 2.
UEFI HTTP boot goes through the iPXE shim once osdeploy initialize has
installed it, so the boot.img fallback warning points to that, for IPv4
and IPv6.
Kernel arguments could only be set per profile, baked into the static
boot files of the profile. Nodes or groups that need extra arguments,
such as a different console or driver options, required a copy of the
whole profile.
When deployment.kernelargs is set, the iPXE boot offer now points at the
existing /confluent-api/boot/by-node endpoint, which serves the profile
boot.ipxe or boot.ipxe.shim with the node arguments appended to the
kernel line and the paths made absolute. UEFI HTTP boot takes the same
path, as it chainloads the iPXE shim when that is installed. A UEFI
HTTP boot that loads the static boot.img instead logs that the node
arguments are not applied.
Nodes without the attribute keep receiving the static profile files.
A client sends its Request to the server whose Advertise it picked,
named by the server identifier. confluent answered every Request, so
with several DHCPv6 servers on the segment, such as the members of a
collective, all of them replied to it.
get_my_addresses only looked at the first netlink message of each
datagram for NLMSG_DONE. When the kernel sends the last addresses and
the done message in one datagram, as EL10 does for an IPv6 dump, the
loop waited for another datagram that never came. reply_dhcp6 asks for
the IPv6 addresses of the interface, so every DHCPv6 boot request went
unanswered.
A failed dump ends with an error message and no done message, so stop
at an error message too.
IPv6 UEFI HTTP boot always served boot.img. Offer the iPXE shim when
the profile has boot.ipxe.shim and the shim of the booting
architecture is installed, as the IPv4 path does.
iPXE then sends its own DHCPv6 request with user class iPXE and a
PXEClient vendor class, which was refused as IPv6 PXE. Answer it with
the boot.ipxe.shim URL, or boot.ipxe when the profile has no shim
script. With only the other configuration flag in the router
advertisement, iPXE sends an Information-request, which was not
handled at all and carries no IA_NA. Handle it and only assign an
address when the request asks for one.
Before it starts the shim, the firmware releases the address and
retransmits the Release while it is unanswered, which delayed the
handoff by over a minute. Answer a Release sent to this server.
A package update replaced only the copies in /opt/confluent/lib/ipxe,
so an upgraded server kept serving no shim, or an old one, until
osdeploy initialize ran again. A fresh install still gets the shim from
osdeploy initialize, before which the public tree may not exist.
The shim copy ran after the early exit of initialize, so -p, -k, -l
or -g on their own did not install it. It also checked for the aarch64
shim as ipxe-aarch64-shim.efi, a name it never writes, so it copied
that one on every run instead of only when it was missing.
UEFI HTTP boot chainloads the iPXE shim only when it is installed, but
the check always looked for the x86_64 shim. An aarch64 node on a
server with only the x86_64 shim was offered the missing aarch64 one
and failed to boot, and on a server with only the aarch64 shim it got
the static boot.img instead.
On Debian and Ubuntu 18.04 the installedargs line of profile.yaml was
added to GRUB_CMDLINE_LINUX with its "installedargs:" key still in
front, and update-grub was not run for it, so the arguments only took
effect with a later grub update, as a broken first argument.
All Debian and Ubuntu profiles also put the arguments into a sed
replacement unescaped, so an argument containing a slash, such as
rd.lvm.lv=vg/root, made sed fail and left the grub defaults unchanged.
SUSE 16 put the arguments into a JSON string unescaped, so an argument
containing a double quote or backslash produced an invalid
autoinstall.json, and one containing "!" or "&" broke the sed command
that fills it in.
SUSE 15 put them into the AutoYaST XML unescaped, so an argument
containing "&" or "<" made the whole profile invalid and stopped the
install.
When the image has no /etc/default/grub, as images built by imgutil do
not, installing it to disk on EL9 and EL10 wrote one with
rd.lvm.lv=vg/root rd.lvm.lv=vg/swap, volumes that do not exist. A
missing /etc/kernel/cmdline likewise got root=/dev/mapper/localstorage-root,
which is wrong for an install without LVM or with a volume group named
after the node. The boot loader entries were rewritten correctly, so
the first boot worked, but grub2-mkconfig --update-bls-cmdline or a new
kernel would take the wrong names from these files.
Both defaults now name the root device and the logical volumes for root
and swap that the install created.
A Giga Computing BMC reports the system UUID as null, which made
nodeinventory fail with 'NoneType' object has no attribute 'lower'.
Treat a null UUID like a missing one.
A SOL keepalive reply arriving after the console was closed failed with
an AttributeError on the released session. A privilege level request on
a session that was logged out or given up on during login raised
IpmiException out of the packet handler into the event loop shared by
all sessions. Ignore the late keepalive reply, and report the failed
login to its waiters instead.
A request sent from within a console session, such as the power state
check confetty makes, went through a handler that logged every failure
as an unexpected 500 with a stack trace. A node with an unreachable BMC
filled the trace log with TargetEndpointUnreachable. Share the error
reporting of the main request loop, so the client gets the real error
code and only unexpected failures are traced.
A client that reset the connection or closed it before finishing the
exchange left a stack trace in the trace log (ConnectionResetError, or
an IndexError on an empty read). Read each field in full, and treat a
client going away as the end of that exchange rather than a server fault.
Every other OS labels its stock profile "(Default Profile)", including
SUSE 15, whose server profile also has the directory name server. SUSE
16 said "(Server Profile)" instead.
It is verified that iPXE leverages the UEFI CA and does not let untrusted connections.
So let it do https as well as http, relegating boot.img for virtual media instead.
This like the plain http boot works nicely with a broader set of UEFI.
Some implementations claim to have a system, but have useless data.
We can't tell programattically that the data is useless, so provide chassis for the user to decide.
Since we have a Seccomp cBPF going anyway, add insmod/modprobe operations to block.
Also reframe things to be a bit more readable using enum and less magical numbers.