2
0
mirror of https://github.com/xcat2/confluent.git synced 2026-11-19 08:52:20 +00:00
Commit Graph

7252 Commits

Author SHA1 Message Date
Jarrod Johnson 2e958becaf Merge pull request #392 from Obihoernchen/feat/node-installedargs
Per-node kernel arguments for the installed OS
2026-11-18 17:47:18 -05:00
Markus Hilger d4bea73868 Apply profile installedargs when installing a diskless image to disk
The installedargs of profile.yaml only reached systems installed by an
OS installer. A diskless image written to disk with installtodisk got
none of them, and keeps from the network boot only console=,
net.ifnames=, biosdevname= and quiet, so arguments meant for the
installed system had to be baked into the image.

image2disk.py now fetches the profile.yaml of the deployment and adds
its installedargs before deployment.installedargs, in the same places.
An argument the image already has, as when it was captured from a node
installed this way, is kept once, in its last position, so the node
arguments still come last, and a profile.yaml that cannot be read only
skips the profile arguments instead of failing the install.
2026-11-18 23:44:04 +01:00
Markus Hilger 903a9f2c9a Add deployment.installedargs for per-node installed kernel arguments
Kernel arguments for the installed OS could only be set per profile,
with installedargs in profile.yaml. deployment.installedargs sets them
per node or group, appended after the ones of the profile.

The deploycfg served to the node carries the value as installedargs,
and the installers add it wherever they add the profile installedargs:
the kickstart bootloader line on EL and RHVH, the AutoYaST and Agama
bootloader settings on SUSE, and GRUB_CMDLINE_LINUX on Debian and
Ubuntu. Diskless images installed to disk add it to GRUB_CMDLINE_LINUX,
and on EL9 and EL10 also to /etc/kernel/cmdline and the boot loader
entries.

deploycfg is no longer wrapped at 80 columns, since the scripts read
each value from its single line.
2026-11-18 23:44:04 +01:00
Jarrod Johnson 86f6c5f1f5 Merge pull request #391 from Obihoernchen/feat/node-kernelargs
Per-node kernel arguments at network boot
2026-11-18 16:17:47 -05:00
Jarrod Johnson 447d86739e Merge pull request #396 from Obihoernchen/feat/httpboot6-ipxe-shim
Use the iPXE shim for IPv6 UEFI HTTP boot
2026-11-18 16:09:47 -05:00
Jarrod Johnson 192eda00a5 Merge pull request #394 from Obihoernchen/fix/ipxe-shim-refresh
Fix ipxe shim refresh
2026-11-18 16:06:08 -05:00
Jarrod Johnson ba45554de1 Merge pull request #395 from Obihoernchen/fix/neighutil-addr-done
Stop the address dump at a done message anywhere in the datagram
2026-11-18 16:04:52 -05:00
Jarrod Johnson 631d7fa680 Relax watchdog timing
Some systems during startup especially may take a hit that crosses the threshold.

Also, some IO hangs in select environments during certain activity can pause a while.

Heartbeat 4 times per interval instead of 2.
2026-11-18 15:33:53 -05:00
Jarrod Johnson be48cb28ce Merge remote-tracking branch 'xcat/master' 2026-11-18 12:18:13 -05:00
Jarrod Johnson 00f62d4506 Fix some functions with chassis-only bmcs
Some infrastructure equipment models as a chassis with no system, handle this case better more generically.
2026-11-18 12:17:48 -05:00
Markus Hilger e6c5210699 Name the cause in the kernelargs HTTP boot warnings
UEFI HTTP boot goes through the iPXE shim once osdeploy initialize has
installed it, so the boot.img fallback warning points to that, for IPv4
and IPv6.
2026-11-18 13:30:05 +01:00
Markus Hilger 8d09bb5b0d Add deployment.kernelargs for per-node kernel arguments
Kernel arguments could only be set per profile, baked into the static
boot files of the profile. Nodes or groups that need extra arguments,
such as a different console or driver options, required a copy of the
whole profile.

When deployment.kernelargs is set, the iPXE boot offer now points at the
existing /confluent-api/boot/by-node endpoint, which serves the profile
boot.ipxe or boot.ipxe.shim with the node arguments appended to the
kernel line and the paths made absolute. UEFI HTTP boot takes the same
path, as it chainloads the iPXE shim when that is installed. A UEFI
HTTP boot that loads the static boot.img instead logs that the node
arguments are not applied.

Nodes without the attribute keep receiving the static profile files.
2026-11-18 13:30:01 +01:00
Markus Hilger a328123357 Ignore DHCPv6 requests sent to another server
A client sends its Request to the server whose Advertise it picked,
named by the server identifier. confluent answered every Request, so
with several DHCPv6 servers on the segment, such as the members of a
collective, all of them replied to it.
2026-11-18 13:06:14 +01:00
Markus Hilger a8f18b6955 Stop the address dump at a done message anywhere in the datagram
get_my_addresses only looked at the first netlink message of each
datagram for NLMSG_DONE. When the kernel sends the last addresses and
the done message in one datagram, as EL10 does for an IPv6 dump, the
loop waited for another datagram that never came. reply_dhcp6 asks for
the IPv6 addresses of the interface, so every DHCPv6 boot request went
unanswered.

A failed dump ends with an error message and no done message, so stop
at an error message too.
2026-11-18 13:06:00 +01:00
Markus Hilger be3623c551 Use the iPXE shim for IPv6 UEFI HTTP boot
IPv6 UEFI HTTP boot always served boot.img. Offer the iPXE shim when
the profile has boot.ipxe.shim and the shim of the booting
architecture is installed, as the IPv4 path does.

iPXE then sends its own DHCPv6 request with user class iPXE and a
PXEClient vendor class, which was refused as IPv6 PXE. Answer it with
the boot.ipxe.shim URL, or boot.ipxe when the profile has no shim
script. With only the other configuration flag in the router
advertisement, iPXE sends an Information-request, which was not
handled at all and carries no IA_NA. Handle it and only assign an
address when the request asks for one.

Before it starts the shim, the firmware releases the address and
retransmits the Release while it is unanswered, which delayed the
handoff by over a minute. Answer a Release sent to this server.
2026-11-18 11:22:22 +01:00
Markus Hilger cf98bf1ef9 Refresh the HTTP boot iPXE shim when confluent_ipxe is updated
A package update replaced only the copies in /opt/confluent/lib/ipxe,
so an upgraded server kept serving no shim, or an old one, until
osdeploy initialize ran again. A fresh install still gets the shim from
osdeploy initialize, before which the public tree may not exist.
2026-11-17 23:20:33 +01:00
Markus Hilger aaaf4e3ea8 Install the HTTP boot iPXE shim on every osdeploy initialize run
The shim copy ran after the early exit of initialize, so -p, -k, -l
or -g on their own did not install it. It also checked for the aarch64
shim as ipxe-aarch64-shim.efi, a name it never writes, so it copied
that one on every run instead of only when it was missing.
2026-11-17 23:20:28 +01:00
Jarrod Johnson c7ce6caae8 Merge pull request #393 from Obihoernchen/fix/httpboot-aarch64-shim
Check the iPXE shim of the booting architecture for HTTP boot
nightly
2026-11-17 15:11:30 -05:00
Markus Hilger 2ba8db30ef Check the iPXE shim of the booting architecture for HTTP boot
UEFI HTTP boot chainloads the iPXE shim only when it is installed, but
the check always looked for the x86_64 shim. An aarch64 node on a
server with only the x86_64 shim was offered the missing aarch64 one
and failed to boot, and on a server with only the aarch64 shim it got
the static boot.img instead.
2026-11-17 21:05:33 +01:00
Jarrod Johnson f72ce3f98a Fix import of Ubuntu 26.04.1 arm media 2026-11-17 14:08:25 -05:00
Jarrod Johnson 7662955a98 Merge pull request #390 from Obihoernchen/fix/profile-installedargs
Fix profile installedargs on Debian, Ubuntu and SUSE 16
2026-11-17 13:43:20 -05:00
Jarrod Johnson 7d27b13f16 Merge pull request #389 from Obihoernchen/fix/image2disk-grub-lvm-names
Name the created volumes in the grub defaults of an image install
2026-11-17 13:42:07 -05:00
Jarrod Johnson 8470f1d155 Merge pull request #388 from Obihoernchen/fix/suse16-profile-label
Label the SUSE 16 profile as the default profile
2026-11-17 13:41:27 -05:00
Jarrod Johnson 360d3d5fe2 Merge pull request #387 from Obihoernchen/fix/capture-unsupported-root
Refuse capture when / cannot be captured
2026-11-17 13:41:15 -05:00
Jarrod Johnson 0c517104ab Merge pull request #386 from Obihoernchen/fix/log-noise-4.0.2
Fix log noise in 4.0.2
2026-11-17 13:40:41 -05:00
Jarrod Johnson a47d9ecbba Merge pull request #385 from robertcaliman/fix/SLES16-multi-nic
Add support for SLES 16 deployed from a multi NIC confluent server
2026-11-17 13:37:34 -05:00
Markus Hilger 52ae9c9e16 Fix profile installedargs on Debian, Ubuntu and SUSE
On Debian and Ubuntu 18.04 the installedargs line of profile.yaml was
added to GRUB_CMDLINE_LINUX with its "installedargs:" key still in
front, and update-grub was not run for it, so the arguments only took
effect with a later grub update, as a broken first argument.

All Debian and Ubuntu profiles also put the arguments into a sed
replacement unescaped, so an argument containing a slash, such as
rd.lvm.lv=vg/root, made sed fail and left the grub defaults unchanged.

SUSE 16 put the arguments into a JSON string unescaped, so an argument
containing a double quote or backslash produced an invalid
autoinstall.json, and one containing "!" or "&" broke the sed command
that fills it in.

SUSE 15 put them into the AutoYaST XML unescaped, so an argument
containing "&" or "<" made the whole profile invalid and stopped the
install.
2026-11-17 19:03:50 +01:00
Markus Hilger fb017b7392 Refuse capture when / cannot be captured 2026-11-17 17:00:40 +01:00
Markus Hilger e9e83635ee Name the created volumes in the grub defaults of an image install
When the image has no /etc/default/grub, as images built by imgutil do
not, installing it to disk on EL9 and EL10 wrote one with
rd.lvm.lv=vg/root rd.lvm.lv=vg/swap, volumes that do not exist. A
missing /etc/kernel/cmdline likewise got root=/dev/mapper/localstorage-root,
which is wrong for an install without LVM or with a volume group named
after the node. The boot loader entries were rewritten correctly, so
the first boot worked, but grub2-mkconfig --update-bls-cmdline or a new
kernel would take the wrong names from these files.

Both defaults now name the root device and the logical volumes for root
and swap that the install created.
2026-11-17 16:53:10 +01:00
Markus Hilger d7a4af65b1 Tolerate a null system UUID in Redfish inventory
A Giga Computing BMC reports the system UUID as null, which made
nodeinventory fail with 'NoneType' object has no attribute 'lower'.
Treat a null UUID like a missing one.
2026-11-17 16:41:50 +01:00
Markus Hilger aa250bb91b Handle IPMI sessions torn down while a response is pending
A SOL keepalive reply arriving after the console was closed failed with
an AttributeError on the released session. A privilege level request on
a session that was logged out or given up on during login raised
IpmiException out of the packet handler into the event loop shared by
all sessions. Ignore the late keepalive reply, and report the failed
login to its waiters instead.
2026-11-17 16:27:52 +01:00
Markus Hilger 75a5e75063 Log IPMI plugin stack traces to the trace log
traceback.print_exc() went to stderr, where the log redirect tags every
line with its caller, traceback.py, which made the traces unreadable.
2026-11-17 16:27:52 +01:00
Markus Hilger e73a42ca5e Report request errors from console sessions like other requests
A request sent from within a console session, such as the power state
check confetty makes, went through a handler that logged every failure
as an unexpected 500 with a stack trace. A node with an unreachable BMC
filled the trace log with TargetEndpointUnreachable. Share the error
reporting of the main request loop, so the client gets the real error
code and only unexpected failures are traced.
2026-11-17 16:27:52 +01:00
Markus Hilger cb729147e7 Tolerate credserver clients that disconnect early
A client that reset the connection or closed it before finishing the
exchange left a stack trace in the trace log (ConnectionResetError, or
an IndexError on an empty read). Read each field in full, and treat a
client going away as the end of that exchange rather than a server fault.
2026-11-17 16:27:52 +01:00
Robert Caliman 1e8c4a88c3 Add support for SLES 16 deployed from a multi NIC server 2026-11-17 17:14:12 +02:00
Markus Hilger f05ef810c1 Label the SUSE 16 profile as the default profile
Every other OS labels its stock profile "(Default Profile)", including
SUSE 15, whose server profile also has the directory name server. SUSE
16 said "(Server Profile)" instead.
2026-11-17 16:05:04 +01:00
Jarrod Johnson 209d6ef2ed Fix undefined nodeinfo in the get_chassis_info flow. 2026-11-16 16:47:19 -05:00
Jarrod Johnson 246aae08fe Change secure http to ipxe as well
It is verified that iPXE leverages the UEFI CA and does not let untrusted connections.

So let it do https as well as http, relegating boot.img for virtual media instead.

This like the plain http boot works nicely with a broader set of UEFI.
2026-11-16 16:43:11 -05:00
Jarrod Johnson 17e6319f75 Leverage the askpass facility from sshutil in nodeshell
This allows a user to pass a password by environment variable.
2026-11-14 10:08:27 -05:00
Jarrod Johnson bd647ebfa4 Implement chassis information separate from system
Some implementations claim to have a system, but have useless data.

We can't tell programattically that the data is useless, so provide chassis for the user to decide.
2026-11-14 08:01:31 -05:00
Jarrod Johnson 334815e9a5 Catch the target url from a 403 extended message, if required 2026-11-13 10:00:38 -05:00
Jarrod Johnson d4c2072e3f Have nvos discovery handle LLA based onboarding 2026-11-13 09:36:31 -05:00
Jarrod Johnson dd700ad1a5 Add mac address to registered address, when possible 2026-11-13 09:04:07 -05:00
Jarrod Johnson 85ff47e684 Add singleton IPv6 support to nodediscover register
This allows otherwise queried ipv6 addresses to be checked one at a time.
2026-11-13 08:13:26 -05:00
Jarrod Johnson 4862c9f734 Implement blacklist of module init functions
Since we have a Seccomp cBPF going anyway, add insmod/modprobe operations to block.

Also reframe things to be a bit more readable using enum and less magical numbers.
2026-11-12 11:15:43 -05:00
Jarrod Johnson ad2de237bc Implement management of UEFI HTTPS certificates
On supported platforms, manage the UEFI HTTPS certificate store.  This can make it easier to manage HTTPS boot.
2026-11-12 10:17:48 -05:00
Jarrod Johnson 9d78d42071 Merge remote-tracking branch 'xcat/master' 2026-11-12 10:06:02 -05:00
Jarrod Johnson bdfe5d9b32 Merge pull request #381 from Obihoernchen/feat/imgutil-image-kernel
imgutil: report the image kernel in exec and build
2026-11-12 10:02:01 -05:00
Markus Hilger 7108cdd3d9 imgutil: derive the seccomp filter length from the filter 2026-11-12 15:42:18 +01:00
Jarrod Johnson aedb093c22 Merge pull request #384 from Obihoernchen/fix/image2disk-no-boot-partition
Use the root filesystem for grub when an image has no /boot
2026-11-12 09:41:42 -05:00