arif/zaza-openstack-tests
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use UTC when calculating certificate validity

Browse Source 
The current usage of ``datetime.today()`` is at the grace of the
locale settings of the test executor and the instances spun up.

The ``cryptography.x509.CertificateBuilder`` ``not_valud_before``
and ``not_valid_after`` attributes do expect [0] a UTC datetime.

0: https://cryptography.io/en/latest/x509/reference/#cryptography.x509.CertificateBuilder
This commit is contained in:
Frode Nordahl
2019-09-10 12:14:52 +02:00
parent 4a5f72ad05
commit caed1ceeb3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zaza/openstack/utilities/cert.py
View File

@@ -94,10 +94,10 @@ def generate_cert(common_name,
cryptography.x509.oid.NameOID.COMMON_NAME, issuer_name),
]))
builder = builder.not_valid_before(
datetime.datetime.today() - datetime.timedelta(0, 1, 0),
datetime.datetime.utcnow() - datetime.timedelta(0, 1, 0),
)
builder = builder.not_valid_after(
datetime.datetime.today() + datetime.timedelta(30, 0, 0),
datetime.datetime.utcnow() + datetime.timedelta(30, 0, 0),
)
builder = builder.serial_number(cryptography.x509.random_serial_number())
builder = builder.public_key(public_key)