arif/zaza-openstack-tests
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tempest: Refactor _add_application_ips.

Browse Source 
Perform repetitive task in loop on input data rather than
repeating the same call three times in the code.

Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
This commit is contained in:
Frode Nordahl
2024-10-11 12:02:35 +02:00
parent 115c4e7e6c
commit a9f7794b15
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
zaza/openstack/charm_tests/tempest/utils.py
View File

@@ -217,9 +217,10 @@ def _add_application_ips(ctxt):
:returns: None
:rtype: None
"""
ctxt['keystone'] = juju_utils.get_application_ip('keystone')
ctxt['dashboard'] = juju_utils.get_application_ip('openstack-dashboard')
ctxt['ncc'] = juju_utils.get_application_ip('nova-cloud-controller')
for ctxt_key, application_name in (('keystone', 'keystone'),
('dashboard', 'openstack-dashboard'),
('ncc', 'nova-cloud-controller')):
ctxt[ctxt_key] = zaza_juju_utils.get_application_ip(application_name)
def _add_nova_config(ctxt, keystone_session, missing_fatal=True):