Merge pull request #141 from thedac/iteration-handling

py3.7+ StopIteration handling

unit_tests/utilities/test_zaza_utilities_openstack.py

@@ -15,7 +15,6 @@
 import copy
 import datetime
 import io
-import itertools
 import mock
 import tenacity
 
@@ -814,14 +813,16 @@ class TestOpenStackUtils(ut_utils.BaseTestCase):
             name='_get_machine_series'
         )
 
+        _machine = mock.MagicMock()
+
         # No machine returned
-        self._get_machines.side_effect = StopIteration
+        self._get_machines.return_value = []
         with self.assertRaises(exceptions.ApplicationNotFound):
             openstack_utils.get_current_os_release_pair()
         self._get_machines.side_effect = None
 
         # No series returned
-        self._get_machines.return_value = itertools.repeat('6')
+        self._get_machines.return_value = [_machine]
         self._get_machine_series.return_value = None
         with self.assertRaises(exceptions.SeriesNotFound):
             openstack_utils.get_current_os_release_pair()

zaza/openstack/utilities/juju.py

@@ -92,7 +92,7 @@ def get_machines_for_application(application, model_name=None):
     """
     status = get_application_status(application, model_name=model_name)
     if not status:
-        raise StopIteration
+        return
 
     # libjuju juju status no longer has units for subordinate charms
     # Use the application it is subordinate-to to find machines

zaza/openstack/utilities/openstack.py

@@ -649,9 +649,9 @@ def configure_gateway_ext_port(novaclient, neutronclient, net_id=None,
         application_names = ['neutron-openvswitch']
         try:
             ngw = 'neutron-gateway'
-            next(juju_utils.get_machine_uuids_for_application(ngw))
+            model.get_application(ngw)
             application_names.append(ngw)
-        except StopIteration:
+        except KeyError:
             # neutron-gateway not in deployment
             pass
     elif ovn_present():
@@ -659,9 +659,9 @@ def configure_gateway_ext_port(novaclient, neutronclient, net_id=None,
         application_names = ['ovn-chassis']
         try:
             ovn_dc_name = 'ovn-dedicated-chassis'
-            next(juju_utils.get_machine_uuids_for_application(ovn_dc_name))
+            model.get_application(ovn_dc_name)
             application_names.append(ovn_dc_name)
-        except StopIteration:
+        except KeyError:
             # ovn-dedicated-chassis not in deployment
             pass
         port_config_key = 'interface-bridge-mappings'
@@ -679,7 +679,8 @@ def configure_gateway_ext_port(novaclient, neutronclient, net_id=None,
         ext_port_name = "{}_ext-port".format(server.name)
         for port in neutronclient.list_ports(device_id=server.id)['ports']:
             if port['name'] == ext_port_name:
-                logging.warning('Neutron Gateway already has additional port')
+                logging.warning(
+                    'Neutron Gateway already has additional port')
                 break
         else:
             logging.info('Attaching additional port to instance, '
@@ -1446,8 +1447,8 @@ def get_current_os_release_pair(application='keystone'):
     :raises: exceptions.OSVersionNotFound
     """
     try:
-        machine = next(juju_utils.get_machines_for_application(application))
-    except StopIteration:
+        machine = list(juju_utils.get_machines_for_application(application))[0]
+    except IndexError:
         raise exceptions.ApplicationNotFound(application)
 
     series = juju_utils.get_machine_series(machine)