From 3d92fa97371d78c49aa36d04cc92277a3640f815 Mon Sep 17 00:00:00 2001
From: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Date: Tue, 28 Jul 2026 11:34:24 -0300
Subject: [PATCH] fix(xcat-dep): manifest -- build conserver-xcat everywhere;
 document per-EL perl set

conserver-xcat is not pulled by `dnf install xCAT` (goconserver superseded
it), but some users still deploy conserver, so build+ship it on every target.

Document why the variable perl modules are scoped per EL: each is required from
xcat-dep only where neither the base OS nor EPEL provides it. In particular
perl-Sys-Virt is omitted on el8 because EPEL provides it on AlmaLinux 8 (not a
build issue); likewise perl-HTML-Form (el9/el10), perl-Crypt-SSLeay and
perl-Net-Telnet (el8/el9) come from the OS/EPEL on the releases where they are
omitted.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
---
 packages-manifest.conf | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/packages-manifest.conf b/packages-manifest.conf
index 924c088..9fe17fc 100644
--- a/packages-manifest.conf
+++ b/packages-manifest.conf
@@ -11,11 +11,19 @@
 # package that fails to build fails the whole run (no tolerated failures).
 #
 #
-# Notable results: conserver-xcat is never required (goconserver supersedes it);
-# the variable perl modules differ per EL because the OS/EPEL already provides
-# the others there (so xcat-dep is not required for them on that EL).
+# Per-EL perl set: a perl module is required from xcat-dep only on the releases
+# where neither the base OS nor EPEL provides it; on the other releases EPEL/OS
+# supplies it (so `dnf install xCAT` pulls the OS/EPEL copy, not xcat-dep's).
+#   perl-Sys-Virt     omitted on el8   -- provided by EPEL on AlmaLinux 8.
+#   perl-HTML-Form    only on el8      -- provided by the OS/EPEL on el9/el10.
+#   perl-Crypt-SSLeay only on el10     -- provided by the OS/EPEL on el8/el9.
+#   perl-Net-Telnet   only on el10     -- provided by the OS/EPEL on el8/el9.
+#
+# conserver-xcat is NOT pulled by `dnf install xCAT` (goconserver superseded it),
+# but it is built for every target anyway because some users still deploy it.
 
 [alma+epel-8-x86_64]
+conserver-xcat=*
 elilo-xcat=*
 goconserver=*
 grub2-xcat=*
@@ -29,6 +37,7 @@ perl-Net-HTTPS-NB=*
 xCAT-genesis-base=*
 
 [alma+epel-8-ppc64le]
+conserver-xcat=*
 elilo-xcat=*
 goconserver=*
 grub2-xcat=*
@@ -42,6 +51,7 @@ perl-Net-HTTPS-NB=*
 xCAT-genesis-base=*
 
 [alma+epel-9-x86_64]
+conserver-xcat=*
 elilo-xcat=*
 goconserver=*
 grub2-xcat=*
@@ -55,6 +65,7 @@ perl-Sys-Virt=*
 xCAT-genesis-base=*
 
 [alma+epel-9-ppc64le]
+conserver-xcat=*
 elilo-xcat=*
 goconserver=*
 grub2-xcat=*
@@ -68,6 +79,7 @@ perl-Sys-Virt=*
 xCAT-genesis-base=*
 
 [alma+epel-10-x86_64]
+conserver-xcat=*
 elilo-xcat=*
 goconserver=*
 grub2-xcat=*
@@ -83,6 +95,7 @@ perl-Sys-Virt=*
 xCAT-genesis-base=*
 
 [alma+epel-10-ppc64le]
+conserver-xcat=*
 elilo-xcat=*
 goconserver=*
 grub2-xcat=*