From 0266df91f33640f317b718b73617629622a62100 Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Thu, 13 Aug 2026 12:25:56 -0300 Subject: [PATCH] docs(build): name conserver-xcat in BUILD.md; test control_binary_arch multi-arch return Landing-review nits: the Packages note said 'conserver' where the shipped package is 'conserver-xcat'; and add a test asserting control_binary_arch returns the full multi-token Architecture value (documents the commit's intent; behaviorally inert). Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> --- BUILD.md | 8 ++++---- t/sbuild-all.t | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/BUILD.md b/BUILD.md index 0d265b5..0f205bc 100644 --- a/BUILD.md +++ b/BUILD.md @@ -397,10 +397,10 @@ single source of truth and is layered so the decision logic is pure and unit-tes - **`pyodbc`** is intentionally not built or listed: modern Ubuntu provides `python3-pyodbc` from apt (and EL from appstream/EPEL), so xcat-dep no longer ships its own. The legacy `pyodbc/` directory (an old `pyodbc-3.0.7` RPM spec, no `debian/`) is kept for historical reference only. -- **`conserver`** was replaced by `goconserver` but is provided for completeness and backward - compatibility. Core packages depend on `goconserver`; to use `conserver` you must install it - explicitly (it is **not** pulled in as a dependency), disable the `goconserver` service and enable - the `conserver` service. +- **`conserver-xcat`** was replaced by `goconserver` but is provided for completeness and backward + compatibility. Core packages depend on `goconserver`; to use conserver you must install + `conserver-xcat` explicitly (it is **not** pulled in as a dependency), disable the `goconserver` + service and enable the `conserver` service. # References diff --git a/t/sbuild-all.t b/t/sbuild-all.t index a618207..f26471f 100644 --- a/t/sbuild-all.t +++ b/t/sbuild-all.t @@ -364,6 +364,8 @@ SKIP: { is(control_binary_arch(undef,'x'), undef, 'undef control -> undef (no crash)'); is(control_binary_arch("Package: ipmitool-xcat\nArchitecture: ppc64el\n", 'ipmitool-xcat'), 'ppc64el', 'native per-arch value returned verbatim'); + is(control_binary_arch("Package: ipmitool-xcat\nArchitecture: i386 amd64 ia64 ppc64el\n", 'ipmitool-xcat'), + 'i386 amd64 ia64 ppc64el', 'multi-arch Architecture returned in FULL, not just the first token'); } # ---- skip_arch_all_on: the SHARED build/validate skip rule -----------------------------------------