mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-11-21 01:42:15 +00:00
f38c6cd33d
rinstall prints "Failed to run 'nodeset' against the node: <node>" and returns 1, while nodeset against the same node exits 0 and reports no error. rinstall returns before rnetboot and rpower, so the node is never powered on and every provisioning case waits for a machine that nobody booted. xCAT::Utils::runxcmd returns $::RUNCMD_RC. runxcmd_output ORs the errorcode of each response into that global, and xCAT::Utils::runcmd and the service helpers assign their own exit status to it, so the last command of any plugin in the subrequest replaces the result. makedhcp supplies that command: its ISC branch restarts dhcpd6 whenever /etc/dhcp/dhcpd6.conf is absent or written by another program, which is every run of a cluster with no IPv6 network, and the restart fails with no subnet to serve. A Kea cell restarts kea-dhcp6 only for a run that has DHCPv6 work, so only ISC cells fail. runxcmd now collects the errorcodes in $::xcmd_errorcode and assigns that to $::RUNCMD_RC after the subrequest, so a command of the subrequest can neither set nor clear the result. dhcp6_restart_needed restarts dhcpd6 only for a run that serves an IPv6 network. runxcmd_subrequest_errorcode.t and dhcp_isc_dhcp6_restart.t fail on the parent commit. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT is a toolkit for the deployment and administration of clusters. xCAT documentation is available at: http://xcat-docs.readthedocs.org/ xCAT is made available as open source software under the EPL license: http://www.opensource.org/licenses/eclipse-1.0.php