mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-08-26 16:46:41 +00:00
Vinícius Ferrão
d5f882291d
The manual page and the usage message of nodestat give the option -f|--usefping. The preprocessor of the request knows no option f, and the handler of the request spells the long name useping, so --usefping does nothing. An administrator who follows the manual page gets the nmap path, and gets no message that says why. The two places also read different specifications, so an option that one place accepts can reach the other place and take a different meaning. Put the specification in one routine, and let both places read that routine. Give the name usefping to the option, and keep useping as a second name. That spelling has worked since 2.14.2, so a site can have it in a script. The long name of the fping option starts with the same letters as usemon, so --use and --us become names that Getopt::Long cannot decide. Those two abbreviations select usemon today. Keep them with usemon, or an administrator who monitors with them loses the monitoring and gets no message. The change has two other effects. The abbreviations --use and --us no longer select fping as well, which they did only because the two places read different specifications. The bundles -mf and -fm now select both options, which they did not do before. Recovered from the lenovobuild branch.